Commits · bb8c4ed22abc40a93a31ef4c3c59841773d75e88 · go / golang

19 Oct, 2011 8 commits
- exp/types: fix crash in parseBasicType on unknown type · bb8c4ed2
  Russ Cox authored Oct 19, 2011
```
R=gri
CC=golang-dev
https://golang.org/cl/5302044
```
  bb8c4ed2
- crypto/x509: fix names in certificate generation. · ec0b5533
  Adam Langley authored Oct 19, 2011
```
I had a brain fart in af84b15fbae2 and messed up the names in
generated certificates.

R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/5315046
```
  ec0b5533
- http: comment tweaks · 314afb41
  Brad Fitzpatrick authored Oct 19, 2011
```
It hasn't been primitive in a while.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5287041
```
  314afb41
- syscall: update ztypes_linux_386 for terminal changes · cf0952d3
  Brad Fitzpatrick authored Oct 19, 2011
```
R=golang-dev, dave, iant
CC=golang-dev
https://golang.org/cl/5299045
```
  cf0952d3
- syscall: update ztypes_linux_arm for terminal changes · ec80beb9
  Dave Cheney authored Oct 19, 2011
```
regenerated on a debian sid arm5 host.

R=bradfitz, iant
CC=golang-dev
https://golang.org/cl/5298046
```
  ec80beb9
- os/inotify: move to exp/inotify · e13635c1
  Mikio Hara authored Oct 19, 2011
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5295044
```
  e13635c1
- tag weekly.2011-10-18 · da356dc3
  Andrew Gerrand authored Oct 19, 2011
```
R=golang-dev
CC=golang-dev
https://golang.org/cl/5292045
```
  da356dc3
- weekly.2011-10-18 · ac21766c
  Andrew Gerrand authored Oct 19, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5302041
```
  ac21766c
18 Oct, 2011 32 commits

html: fix escape_test.go for CSS escaper change 5306042. · 98e723ed
Nigel Tao authored Oct 18, 2011
```
R=mikesamuel
CC=golang-dev
https://golang.org/cl/5313044
```
98e723ed

fmt: clean up after reflect.Interface change. · 811d334a

Rob Pike authored Oct 18, 2011

Store the reflect.Value in the internal print state. Code is simpler, cleaner,
and a little faster - back to what it was before the change.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5299046

811d334a

rpc: don't panic on write error. · 4c56c30b

Rob Pike authored Oct 18, 2011

The mechanism to record the error in the call is already in place.
Fixes #2382.

R=golang-dev, dsymonds, bradfitz, r
CC=golang-dev
https://golang.org/cl/5307043

4c56c30b

exp/template/html: fix bug in cssEscaper · fc3ce349

Mike Samuel authored Oct 18, 2011

cssEscaper escapes using the CSS convention: `\` + hex + optional-space

It outputs the space when the escape could be followed by
a hex digit to distinguish a "\na" from "\u00aa".

It did not output a space when the escape is followed by a space
character so did not distinguish "\n " from "\n".

Currently when doing lookahead, it does not distinguish spaces that
will be escaped later by the same function from ones that will not.
This is correct but suboptimal.

R=nigeltao
CC=golang-dev
https://golang.org/cl/5306042

fc3ce349

http: add test for panic inside hijacked request · aa42881e
Andrew Gerrand authored Oct 18, 2011
```
R=golang-dev, rsc, rsc
CC=golang-dev
https://golang.org/cl/5283052
```
aa42881e

html: parse raw text and RCDATA elements, such as <script> and <title>. · b1fd528d

Nigel Tao authored Oct 18, 2011

Pass tests1.dat, test 26:
#data
<script><div></script></div><title><p></title><p><p>
#document
| <html>
|   <head>
|     <script>
|       "<div>"
|     <title>
|       "<p>"
|   <body>
|     <p>
|     <p>

Thanks to Andy Balholm for driving this change.

R=andybalholm
CC=golang-dev
https://golang.org/cl/5301042

b1fd528d

ld: modify macho linkedit segment to enable OS X code signing · 78ad19f2

Mikkel Krautz authored Oct 18, 2011

Move string table to the end of the __LINKEDIT segment.

This change allows Apple's codesign(1) utility to successfully sign
Go binaries, as long as they don't contain DWARF data (-w flag to
8l/6l).  This is because codesign(1) expects the string table to be
the last part of the file.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5271050

78ad19f2

godoc: generate package toc in template, not in JavaScript · cb2f6cb0

Russ Cox authored Oct 18, 2011

1. Generate TOC for package pages using template,
instead of using JavaScript magic.  This makes the
pages generated by godoc -html easier to export
to other systems.

2. Make TOC one column.  It's hard to do two columns
portably without invoking JavaScript.

3. Since the TOC is only one column, show full type
signatures for functions and methods.  Many times
that's all you need to see anyway.

4. Name the section after the TOC "Overview".
Naming it something is important, to set it off
from the TOC and so that there's a quick link to
it in the TOC.

For now, some illustrative examples:

http://swtch.com:6060/pkg/io/
http://swtch.com:6060/pkg/strings/
http://swtch.com:6060/pkg/tabwriter/
http://swtch.com:6060/pkg/unicode/

Fixes #1982.

R=gri, bradfitz, r
CC=golang-dev
https://golang.org/cl/5303044

cb2f6cb0

exp/winfsnotify: filesystem watcher for Windows · 7ecf6c99

Hector Chu authored Oct 18, 2011

R=rsc, alex.brainman, bradfitz
CC=bsiegert, go.peter.90, golang-dev
https://golang.org/cl/4188047

7ecf6c99

5l, 6l, 8l: correct ELFRESERVE diagnostic · 033585d6

Anthony Martin authored Oct 18, 2011

If the length of the interpreter string
pushes us over the ELFRESERVE limit, the
resulting error message will be comical.

I was doing some ELF tinkering with a
modified version of 8l when I hit this.

To be clear, the stock linkers wouldn't
hit this without adding about forty more
section headers.  We're safe for now. ;)

Also, remove a redundant call to cflush.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5268044

033585d6

6l, 8l: emit macho dwarf info before linkedit section · 4566868b
Mikkel Krautz authored Oct 18, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5272050
```
4566868b
big: handle aliasing correctly for Rat.SetFrac. · c7cf56be
Robert Griesemer authored Oct 18, 2011
```
Fixes #2379.

R=r, rsc
CC=golang-dev
https://golang.org/cl/5305043
```
c7cf56be

gc: preserve uint8 and byte distinction in errors, import data · 862179b0

Russ Cox authored Oct 18, 2011

There is no semantic change here, just better errors.
If a function says it takes a byte, and you pass it an int,
the compiler error now says that you need a byte, not
that you need a uint8.

Groundwork for rune.

R=ken2
CC=golang-dev
https://golang.org/cl/5300042

862179b0

5g, 6g: comment out uses of -r · d604cf78
Russ Cox authored Oct 18, 2011
```
R=ken2
CC=golang-dev
https://golang.org/cl/5299043
```
d604cf78

build: pass $GCFLAGS to compiler · 389d55fa

Russ Cox authored Oct 18, 2011

For example, if you are debugging an optimization
problem you can now run

        GCFLAGS=-N gotest

This is a convention for make, not for the general build,
so it may go away or be done differently in the eventual
'go' command.

The plan is that people will be able to test their code for
rune safety by doing GCFLAGS=-r.

R=golang-dev, bradfitz, lvd
CC=golang-dev
https://golang.org/cl/5294042

389d55fa

net: remove duplicate error information in Dial · 56579399
Andrey Mirtchovski authored Oct 18, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5293045
```
56579399
net: allow LookupSRV on non-standard DNS names · 48bb3e8f
Russ Cox authored Oct 18, 2011
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5313043
```
48bb3e8f
A+C: Jani Monoses (individual CLA) · 835dcb71
Russ Cox authored Oct 18, 2011
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5297043
```
835dcb71

godoc: fix ToAbsolute mapping · 0e4d1c3e

Robert Griesemer authored Oct 18, 2011

The implementation of splitFirst was broken;
splitFirst("foo/") must be the same as splitFirst("foo").
As a result, ToAbsolute could be simplified, and as a side
effect this fixes a long-standing bug.

Thanks to Luca Greco <luca.greco@alcacoop.it> for doing
the investigation.

Fixes #1157.

R=rsc
CC=golang-dev
https://golang.org/cl/5278050

0e4d1c3e

http, crypto/tls: fix read timeouts and closing. · 9d99d52f

Adam Langley authored Oct 18, 2011

tls.Conn.Close() didn't close the underlying connection and tried to
do a handshake in order to send the close notify alert.

http didn't look for errors from the TLS handshake.

Fixes #2281.

R=bradfitz
CC=golang-dev
https://golang.org/cl/5283045

9d99d52f

exp/terminal: split terminal handling from exp/ssh · 7bc4f8de

Adam Langley authored Oct 18, 2011

This change splits terminal handling from exp/ssh, as suggested
several times in the ssh code review.

shell.go and shell_test.go are copies from exp/ssh with minimal
changes, so don't need another full review. A future CL will remove
that code from exp/ssh.

R=bradfitz, r, dave, rsc
CC=golang-dev
https://golang.org/cl/5278049

7bc4f8de

exp/ssh: general cleanups for client support · ec158f77

Dave Cheney authored Oct 18, 2011

common.go:
* simplify findAgreedAlgorithms.
* add channelExtendedData support.

messages.go:
* add clientExtendedData.

server.go:
*  use simplified findAgreedAlgorithms.

server_shell.go:
* fix shadowed err return value.

transport.go:
* introduce separate cipher, mac and compression for each direction.
* added filteredConn and packetWriter interfaces.
* newTransport requires a source of randomness.

R=golang-dev, agl, rsc
CC=golang-dev
https://golang.org/cl/5285044

ec158f77

big: more explicit documentation for div/mod/quo/rem · 1db31f89
Robert Griesemer authored Oct 18, 2011
```
Fixes #2380.

R=rsc, rogpeppe
CC=golang-dev
https://golang.org/cl/5313041
```
1db31f89

reflect: make unsafe use of SliceHeader gc-friendly · 4e7aac54

Russ Cox authored Oct 18, 2011

Revert workaround in compiler and
revert test for compiler workaround.

Tested that the 386 build continues to fail if
the gc change is made without the reflect change.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5312041

4e7aac54

gofix -r mapdelete · 313c8224

Russ Cox authored Oct 18, 2011

R=golang-dev, r, adg, r, cw
CC=golang-dev
https://golang.org/cl/5266045

313c8224

gofix: add mapdelete · 7242052b
Russ Cox authored Oct 18, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5286043
```
7242052b

gc: add delete(m, x) but leave in m[x] = 0, false. · 1d687c74

Russ Cox authored Oct 18, 2011

The old m[x] = 0, false syntax will be deleted
in a month or so, once people have had time to
change their code (there is a gofix in a separate CL).

R=ken2
CC=golang-dev
https://golang.org/cl/5265048

1d687c74

misc/windows: automated toolchain packager · 10953052

Joe Poirier authored Oct 18, 2011

A first run at fully automating the process.
This CL supersedes https://golang.org/cl/4634114/
which I seemed to have lost.

R=golang-dev, alex.brainman, adg
CC=golang-dev
https://golang.org/cl/5273041

10953052

ld: bump pe linker version to 3.0 to allow code signing · c9bf0483

Mikkel Krautz authored Oct 18, 2011

The Windows signtool.exe thinks our binaries are 'invalid
Win32 programs' unless the PE linker version field is 3.0
or greater.

This minor change makes it possible to successfully sign
gc-built binaries on Windows.

R=golang-dev, alex.brainman, rsc
CC=golang-dev
https://golang.org/cl/5268045

c9bf0483

tag release.r58.2 · 82704f04
Andrew Gerrand authored Oct 18, 2011
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5299041
```
82704f04
reflect: make map test independent of map iteration order. · 9049abbd
David Symonds authored Oct 18, 2011
```
This should fix the 386 builds.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5298042
```
9049abbd

reflect: fix test failure reporting. · fdc6376c

David Symonds authored Oct 18, 2011

There's a problem that is manifesting on the 386 builders,
but this test bug is masking it.

R=adg
CC=golang-dev
https://golang.org/cl/5295042

fdc6376c