- 06 Oct, 2012 8 commits
-
-
Rob Pike authored
Fixes #3872. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6612060
-
Rob Pike authored
Protects the package a little against undesirable clients. R=golang-dev, bradfitz, rsc CC=golang-dev https://golang.org/cl/6624054
-
Dave Cheney authored
func add() int { var a int a += 10 a += 20 a += 30 a -= 10 a -= 20 a -= 30 return a } before --- prog list "add" --- 0000 (/home/dfc/src/add.go:5) TEXT add+0(SB),$0-4 0001 (/home/dfc/src/add.go:6) MOVW $0,R2 0002 (/home/dfc/src/add.go:7) MOVW $10,R0 0003 (/home/dfc/src/add.go:7) ADD R0,R2,R1 0004 (/home/dfc/src/add.go:8) MOVW $20,R0 0005 (/home/dfc/src/add.go:8) ADD R0,R1 0006 (/home/dfc/src/add.go:9) MOVW $30,R0 0007 (/home/dfc/src/add.go:9) ADD R0,R1 0008 (/home/dfc/src/add.go:10) MOVW $10,R0 0009 (/home/dfc/src/add.go:10) SUB R0,R1 0010 (/home/dfc/src/add.go:11) MOVW $20,R0 0011 (/home/dfc/src/add.go:11) SUB R0,R1 0012 (/home/dfc/src/add.go:12) MOVW $30,R0 0013 (/home/dfc/src/add.go:12) SUB R0,R1,R2 0014 (/home/dfc/src/add.go:12) MOVW R2,R0 0015 (/home/dfc/src/add.go:13) MOVW R2,R1 0016 (/home/dfc/src/add.go:13) MOVW R2,.noname+0(FP) 0017 (/home/dfc/src/add.go:13) RET , after --- prog list "add" --- 0000 (/home/dfc/src/add.go:5) TEXT add+0(SB),$0-4 0001 (/home/dfc/src/add.go:6) MOVW $0,R0 0002 (/home/dfc/src/add.go:7) ADD $10,R0 0003 (/home/dfc/src/add.go:8) ADD $20,R0 0004 (/home/dfc/src/add.go:9) ADD $30,R0 0005 (/home/dfc/src/add.go:10) SUB $10,R0 0006 (/home/dfc/src/add.go:11) SUB $20,R0 0007 (/home/dfc/src/add.go:12) SUB $30,R0,R2 0008 (/home/dfc/src/add.go:13) MOVW R2,R0 0009 (/home/dfc/src/add.go:13) MOVW R2,.noname+0(FP) 0010 (/home/dfc/src/add.go:13) RET , R=rsc, minux.ma, remyoudompheng CC=golang-dev https://golang.org/cl/6584056 -
Rémy Oudompheng authored
Fixes #4197. R=golang-dev, r CC=golang-dev https://golang.org/cl/6611056
-
Dmitriy Vyukov authored
The profiler collects goroutine blocking information similar to Google Perf Tools. You may see an example of the profile (converted to svg) attached to http://code.google.com/p/go/issues/detail?id=3946 The public API changes are: +pkg runtime, func BlockProfile([]BlockProfileRecord) (int, bool) +pkg runtime, func SetBlockProfileRate(int) +pkg runtime, method (*BlockProfileRecord) Stack() []uintptr +pkg runtime, type BlockProfileRecord struct +pkg runtime, type BlockProfileRecord struct, Count int64 +pkg runtime, type BlockProfileRecord struct, Cycles int64 +pkg runtime, type BlockProfileRecord struct, embedded StackRecord R=rsc, dave, minux.ma, r CC=gobot, golang-dev, r, remyoudompheng https://golang.org/cl/6443115
-
Daniel Morsing authored
rundir will compile each file in the directory in lexicographic order, link the last file as the main package and run the resulting program. rundircmpout is an related command, that will compare the output of the program to an corresponding .out file errorcheckdir will compile each file in a directory in lexicographic order, running errorcheck on each file as it compiles. All compilations are assumed to be successful except for the last file. However, If a -0 flag is present on the command, the last compilation will also be assumed successful This CL also includes a small refactoring of run.go. It was getting unwieldy and the meaning of the run commands was hidden behind argument line formatting. Fixes #4058. R=rsc, minux.ma, remyoudompheng, iant CC=golang-dev https://golang.org/cl/6554071
-
Jan Ziak authored
R=golang-dev, minux.ma, rsc CC=golang-dev https://golang.org/cl/6621052
-
Dave Cheney authored
func addr(s[]int) *int { return &s[2] } --- prog list "addr" --- 0000 (/home/dfc/src/addr.go:5) TEXT addr+0(SB),$0-16 0001 (/home/dfc/src/addr.go:6) MOVW $s+0(FP),R0 0002 (/home/dfc/src/addr.go:6) MOVW 4(R0),R1 0003 (/home/dfc/src/addr.go:6) MOVW $2,R2 0004 (/home/dfc/src/addr.go:6) CMP R2,R1, 0005 (/home/dfc/src/addr.go:6) BHI ,7(APC) 0006 (/home/dfc/src/addr.go:6) BL ,runtime.panicindex+0(SB) 0007 (/home/dfc/src/addr.go:6) MOVW 0(R0),R0 0008 (/home/dfc/src/addr.go:6) MOVW $8,R1 0009 (/home/dfc/src/addr.go:6) ADD R1,R0 0010 (/home/dfc/src/addr.go:6) MOVW R0,.noname+12(FP) 0011 (/home/dfc/src/addr.go:6) RET , becomes --- prog list "addr" --- 0000 (/home/dfc/src/addr.go:5) TEXT addr+0(SB),$0-16 0001 (/home/dfc/src/addr.go:6) MOVW $s+0(FP),R0 0002 (/home/dfc/src/addr.go:6) MOVW 4(R0),R1 0003 (/home/dfc/src/addr.go:6) MOVW $2,R2 0004 (/home/dfc/src/addr.go:6) CMP R2,R1, 0005 (/home/dfc/src/addr.go:6) BHI ,7(APC) 0006 (/home/dfc/src/addr.go:6) BL ,runtime.panicindex+0(SB) 0007 (/home/dfc/src/addr.go:6) MOVW 0(R0),R0 0008 (/home/dfc/src/addr.go:6) ADD $8,R0 0009 (/home/dfc/src/addr.go:6) MOVW R0,.noname+12(FP) 0010 (/home/dfc/src/addr.go:6) RET , R=rsc, remyoudompheng, minux.ma CC=golang-dev https://golang.org/cl/6590056
-
- 05 Oct, 2012 8 commits
-
-
Rémy Oudompheng authored
R=golang-dev, dave, daniel.morsing, rsc CC=golang-dev, remy https://golang.org/cl/6586072
-
Dmitry Chestnykh authored
SHA-256: benchmark old ns/op new ns/op delta BenchmarkHash1K 21686 16912 -22.01% BenchmarkHash8K 173216 135020 -22.05% benchmark old MB/s new MB/s speedup BenchmarkHash1K 47.22 60.55 1.28x BenchmarkHash8K 47.29 60.67 1.28x SHA-512: benchmark old ns/op new ns/op delta BenchmarkHash1K 14323 11163 -22.06% BenchmarkHash8K 114120 88693 -22.28% benchmark old MB/s new MB/s speedup BenchmarkHash1K 71.49 91.73 1.28x BenchmarkHash8K 71.78 92.36 1.29x R=golang-dev, agl CC=golang-dev https://golang.org/cl/6584071
-
Akshat Kumar authored
The Go run-time assumes that all SSE floating-point exceptions are masked so that Go programs are not broken by such invalid operations. By default, the 64-bit version of the Plan 9 kernel masks only some SSE floating-point exceptions. Here, we mask them all on a per-thread basis. R=rsc, rminnich, minux.ma CC=golang-dev https://golang.org/cl/6592056
-
Shenghou Ma authored
so that it could work with the bundled jQuery. R=adg CC=golang-dev https://golang.org/cl/6592073
-
Robert Griesemer authored
(use floating-point rather then integer constant division) gofmt -w src misc Fixes #3965. R=r, bsiegert, 0xjnml CC=bradfitz, golang-dev https://golang.org/cl/6610051
-
Robert Griesemer authored
Also: gofmt -w src misc R=r CC=golang-dev, iant https://golang.org/cl/6591071
-
Robert Griesemer authored
The AST representation is already identical. Making the code (nearly) identical in the parser reduces code size and ensures that the ast.ValueSpec nodes have the same values (specifically, iota). This in turn permits the sharing of much of the respective code in the typechecker. While at it: type functions work now, so use them. R=r CC=golang-dev https://golang.org/cl/6624047
-
Graham Miller authored
Code for parsing email addresses was already partially part of the public API with "func (Header) AddressList". This CL adds a trivial implementation for two public methods to parse address and lists from a string. With tests. R=dsymonds CC=golang-dev https://golang.org/cl/5676067
-
- 04 Oct, 2012 8 commits
-
-
Jeff Wendling authored
Adds a DecryptBlock function which takes a password and a *pem.Block and returns the decrypted DER bytes suitable for passing into other crypto/x509 functions. R=golang-dev, agl, leterip CC=golang-dev https://golang.org/cl/6555052
-
Shenghou Ma authored
R=golang-dev, adg CC=golang-dev https://golang.org/cl/6593078
-
Andrew Gerrand authored
R=dsymonds CC=golang-dev https://golang.org/cl/6523045
-
Andrew Gerrand authored
For golang.org I intend to rewrite the jquery link in godoc.html to point to the Google-hosted jquery.js. R=dsymonds, minux.ma CC=golang-dev https://golang.org/cl/6589071
-
Shenghou Ma authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/6587074
-
Rob Pike authored
Fixes build. Makes me annoyed. R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/6591074
-
Rob Pike authored
Fixes build. R=golang-dev, adg, bradfitz, dsymonds, dave CC=golang-dev https://golang.org/cl/6586074
-
Andrew Gerrand authored
R=dsymonds CC=gobot, golang-dev https://golang.org/cl/6588079
-
- 03 Oct, 2012 9 commits
-
-
Andrew Gerrand authored
R=gri CC=gobot, golang-dev https://golang.org/cl/6601054
-
Andrew Gerrand authored
R=gri CC=gobot, golang-dev https://golang.org/cl/6592061
-
Robert Griesemer authored
Also: Be explicit what operator means with respect to conversion types. The parenthesis requirement is a language change. At the moment, literal function types in conversions that cannot possibly be followed by a '(' don't need parentheses. For instance: func(int)int(x) -> same as (func(int)int)(x) func()()(x) -> same as (func())(x) but: func(int)(x) -> could be func(int)x {...} Fixes #4109. R=rsc, r, iant, ken, iant CC=golang-dev https://golang.org/cl/6584065 -
Brad Fitzpatrick authored
Fixes #4187 R=golang-dev, dave, minux.ma CC=golang-dev https://golang.org/cl/6587071
-
Andrew Gerrand authored
R=golang-dev, dsymonds, bradfitz, r CC=golang-dev https://golang.org/cl/6591066
-
Shenghou Ma authored
R=golang-dev, rsc, r CC=golang-dev https://golang.org/cl/6591051
-
Rob Pike authored
They now show the correct name, the byte offset on the line, and context for the failed evaluation. Before: template: three:7: error calling index: index out of range: 5 After: template: top:7:20: executing "three" at <index "hi" $>: error calling index: index out of range: 5 Here top is the template that was parsed to create the set, and the error appears with the action starting at byte 20 of line 7 of "top", inside the template called "three", evaluating the expression <index "hi" $>. Also fix a bug in index: it didn't work on strings. Ouch. Also fix bug in error for index: was showing type of index not slice. The real previous error was: template: three:7: error calling index: can't index item of type int The html/template package's errors can be improved by building on this; I'll do that in a separate pass. Extends the API for text/template/parse but only by addition of a field and method. The old API still works. Fixes #3188. R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/6576058 -
Robert Griesemer authored
This is a backward-compatible API change. Without the correct <- position information, certain channel types have incorrect position information. R=iant, iant CC=golang-dev https://golang.org/cl/6585063
-
Shivakumar GN authored
Fixes #4113. R=golang-dev, alex.brainman CC=golang-dev https://golang.org/cl/6545054
-
- 02 Oct, 2012 4 commits
-
-
Robert Griesemer authored
Fixes #4110. R=iant CC=golang-dev https://golang.org/cl/6597069
-
Robert Hencke authored
Continuation of https://golang.org/cl/6499053/ R=golang-dev, minux.ma CC=golang-dev https://golang.org/cl/6584059
-
Rémy Oudompheng authored
A similar change was made in 6g recently. LEALs in cmd/go: 31440 before, 27867 after. benchmark old ns/op new ns/op delta BenchmarkBinaryTree17 7065794000 6723617000 -4.84% BenchmarkFannkuch11 7767395000 7477945000 -3.73% BenchmarkGobDecode 34708140 34857820 +0.43% BenchmarkGobEncode 10998780 10960060 -0.35% BenchmarkGzip 1603630000 1471052000 -8.27% BenchmarkGunzip 242573900 240650400 -0.79% BenchmarkJSONEncode 120842200 117966100 -2.38% BenchmarkJSONDecode 247254900 249103100 +0.75% BenchmarkMandelbrot200 29237330 29241790 +0.02% BenchmarkParse 8111320 8096865 -0.18% BenchmarkRevcomp 2595780000 2694153000 +3.79% BenchmarkTemplate 276679600 264497000 -4.40% benchmark old ns/op new ns/op delta BenchmarkAppendFloatDecimal 429 416 -3.03% BenchmarkAppendFloat 780 740 -5.13% BenchmarkAppendFloatExp 746 700 -6.17% BenchmarkAppendFloatNegExp 752 694 -7.71% BenchmarkAppendFloatBig 1228 1108 -9.77% BenchmarkAppendFloat32Integer 457 416 -8.97% BenchmarkAppendFloat32ExactFraction 662 631 -4.68% BenchmarkAppendFloat32Point 771 735 -4.67% BenchmarkAppendFloat32Exp 722 672 -6.93% BenchmarkAppendFloat32NegExp 724 659 -8.98% BenchmarkAppendFloat64Fixed1 429 400 -6.76% BenchmarkAppendFloat64Fixed2 463 442 -4.54% Update #1914. R=golang-dev, daniel.morsing, rsc CC=golang-dev https://golang.org/cl/6574043
-
Dmitriy Vyukov authored
This is the first part of a bigger change that adds data race detection feature: https://golang.org/cl/6456044 This change makes gc compiler instrument memory accesses when supplied with -b flag. R=rsc, nigeltao, lvd CC=golang-dev https://golang.org/cl/6497074
-
- 01 Oct, 2012 3 commits
-
-
Andrew Gerrand authored
R=gri CC=gobot, golang-dev https://golang.org/cl/6524047
-
Dave Cheney authored
This CL is an attempt to backport the abop code generation from 6g. This improves the generation of the range offset if the increment can be encoded directly via Operand2 shift encoding. 0023 (/home/dfc/src/range.go:7) BGE ,29(APC) 0024 (/home/dfc/src/range.go:7) MOVW 0(R3),R5 0025 (/home/dfc/src/range.go:7) MOVW $4,R1 0026 (/home/dfc/src/range.go:7) ADD R1,R3,R3 0027 (/home/dfc/src/range.go:8) ADD R5,R4,R4 0028 (/home/dfc/src/range.go:7) B ,17(APC) becomes 0023 (/home/dfc/src/range.go:7) BGE ,28(APC) 0024 (/home/dfc/src/range.go:7) MOVW 0(R3),R0 0025 (/home/dfc/src/range.go:7) ADD $4,R3,R3 0026 (/home/dfc/src/range.go:8) ADD R0,R4,R4 0027 (/home/dfc/src/range.go:7) B ,17(APC) Benchmarks are unimpressive dfc@qnap:~/go/test/bench/go1$ ~/go/misc/benchcmp {old,new}.txt benchmark old ns/op new ns/op delta BenchmarkBinaryTree17 2147483647 2147483647 +0.93% BenchmarkFannkuch11 2147483647 2147483647 -2.52% BenchmarkGobDecode 196135200 195842000 -0.15% BenchmarkGobEncode 78581650 76734450 -2.35% BenchmarkGzip 2147483647 2147483647 -0.47% BenchmarkGunzip 1087243000 1070254000 -1.56% BenchmarkJSONEncode 1107558000 1146077000 +3.48% BenchmarkJSONDecode 2147483647 2147483647 -0.07% BenchmarkMandelbrot200 2147483647 2147483647 -0.77% BenchmarkParse 74328550 71653400 -3.60% BenchmarkRevcomp 111123900 109325950 -1.62% BenchmarkTemplate 2147483647 2147483647 -0.82% benchmark old MB/s new MB/s speedup BenchmarkGobDecode 3.91 3.92 1.00x BenchmarkGobEncode 9.77 10.00 1.02x BenchmarkGzip 3.65 3.66 1.00x BenchmarkGunzip 17.85 18.13 1.02x BenchmarkJSONEncode 1.75 1.69 0.97x BenchmarkJSONDecode 0.83 0.83 1.00x BenchmarkParse 0.78 0.81 1.04x BenchmarkRevcomp 22.87 23.25 1.02x BenchmarkTemplate 0.84 0.85 1.01x R=remyoudompheng, minux.ma, rsc CC=golang-dev https://golang.org/cl/6564067 -
Jeremy Jackins authored
This fixes some example code in the tar package documentation, which first refers to tar.NewWriter and then to Header, which is inconsistent because NewWriter and Header are both in the tar namespace. R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/6595050
-
