Commits · bcf88de5ffa1119e8b56a765a076d6a302ae3ecc · go / golang

16 Oct, 2012 3 commits

pprof: filter out runtime.settype and fix --svg mode to produce valid XML · bcf88de5
Brad Fitzpatrick authored Oct 16, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6642043
```
bcf88de5
builder: label the race builder as "race" · 08d66439
Brad Fitzpatrick authored Oct 16, 2012
```
R=golang-dev, adg, dave, rsc, minux.ma, dvyukov
CC=golang-dev
https://golang.org/cl/6648043
```
08d66439

spec: more clarification about deferred functions · 15970c8d

Rob Pike authored Oct 16, 2012

Proposed new text to make matters clearer. The existing text was
unclear about the state of result parameters when panicking.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/6653047

15970c8d

15 Oct, 2012 3 commits

runtime: add missing if(raceenabled) · 6273c732
Dmitriy Vyukov authored Oct 15, 2012
```
R=0xe2.0x9a.0x9b, minux.ma, iant, dave
CC=golang-dev
https://golang.org/cl/6654052
```
6273c732

image/jpeg: re-organize the processSOS code. · 1f31598e

Nigel Tao authored Oct 15, 2012

This is a straight copy/paste, and the deletion of a TODO. There are
no other changes.

R=r
CC=golang-dev
https://golang.org/cl/6687049

1f31598e

image/jpeg: decode progressive JPEGs. · 8b624f60

Nigel Tao authored Oct 15, 2012

To be clear, this supports decoding the bytes on the wire into an
in-memory image. There is no API change: jpeg.Decode will still not
return until the entire image is decoded.

The code is obviously more complicated, and costs around 10% in
performance on baseline JPEGs. The processSOS code could be cleaned up a
bit, and maybe some of that loss can be reclaimed, but I'll leave that
for follow-up CLs, to keep the diff for this one as small as possible.

Before:
BenchmarkDecode	    1000	   2855637 ns/op	  21.64 MB/s
After:
BenchmarkDecodeBaseline	     500	   3178960 ns/op	  19.44 MB/s
BenchmarkDecodeProgressive	     500	   4082640 ns/op	  15.14 MB/s

Fixes #3976.

The test data was generated by:
# Create intermediate files; cjpeg on Ubuntu 10.04 can't read PNG.
convert video-001.png video-001.bmp
convert video-005.gray.png video-005.gray.pgm
# Create new test files.
cjpeg -quality 100 -sample 1x1,1x1,1x1 -progressive video-001.bmp > video-001.progressive.jpeg
cjpeg -quality 50 -sample 2x2,1x1,1x1 video-001.bmp > video-001.q50.420.jpeg
cjpeg -quality 50 -sample 2x1,1x1,1x1 video-001.bmp > video-001.q50.422.jpeg
cjpeg -quality 50 -sample 1x1,1x1,1x1 video-001.bmp > video-001.q50.444.jpeg
cjpeg -quality 50 -sample 2x2,1x1,1x1 -progressive video-001.bmp > video-001.q50.420.progressive.jpeg
cjpeg -quality 50 -sample 2x1,1x1,1x1 -progressive video-001.bmp > video-001.q50.422.progressive.jpeg
cjpeg -quality 50 -sample 1x1,1x1,1x1 -progressive video-001.bmp > video-001.q50.444.progressive.jpeg
cjpeg -quality 50 video-005.gray.pgm > video-005.gray.q50.jpeg
cjpeg -quality 50 -progressive video-005.gray.pgm > video-005.gray.q50.progressive.jpeg
# Delete intermediate files.
rm video-001.bmp video-005.gray.pgm

R=r
CC=golang-dev
https://golang.org/cl/6684046

8b624f60

14 Oct, 2012 1 commit
- time: accept numbers larger than 2^32 in ParseDuration. · f2045aad
  David Symonds authored Oct 14, 2012
```
Fixes #3374.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6683047
```
  f2045aad
13 Oct, 2012 1 commit

io/ioutil: use pathname instead of name in docs to avoid confusion · 24083437

Shenghou Ma authored Oct 13, 2012

caller of ioutil.TempFile() can use f.Name() to get "pathname"
of the temporary file, instead of just the "name" of the file.

Also remove an out-of-date comment about random number state.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6649054

24083437

12 Oct, 2012 9 commits

compress/bzip2: use io.ByteReader instead of internal interface · 422da762
Anthony Martin authored Oct 12, 2012
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6663044
```
422da762
runtime: FreeBSD/ARM support · 366268aa
Shenghou Ma authored Oct 12, 2012
```
R=rsc
CC=golang-dev
https://golang.org/cl/6625071
```
366268aa

doc: remove ExpressivenessOfGo.pdf · ef2ee452

Shenghou Ma authored Oct 12, 2012

        It has been moved to go.talks/2010/ExpressivenessOfGo-2010.pdf
        URL: http://talks.golang.org/2010/ExpressivenessOfGo-2010.pdf

R=r
CC=golang-dev
https://golang.org/cl/6660046

ef2ee452

syscall: FreeBSD/ARM support · 378d7ef5
Shenghou Ma authored Oct 12, 2012
```
R=rsc, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/6657048
```
378d7ef5

cmd/5l: reorder some struct fields to reduce memory consumption · 1e9f3085

Shenghou Ma authored Oct 12, 2012

Valgrind Massif result when linking godoc:
On amd64:
                    old          new         -/+
mem_heap_B       185844612    175358047    -5.7%
mem_heap_extra_B    773404       773137    -0.0%

On 386/ARM:
                    old          new         -/+
mem_heap_B       141775701    131289941    -7.4%
mem_heap_extra_B    737011       736955    -0.0%

R=golang-dev, r, dave
CC=golang-dev
https://golang.org/cl/6655045

1e9f3085

cmd/dist: fix superfluous and confusing "binaries ... to be copied or moved" message · 19dc7bb1

Shenghou Ma authored Oct 12, 2012

Also, to aid debugging cmd/dist, make make.bat support --dist-tool flag.

Fixes #3100.

R=alex.brainman
CC=golang-dev
https://golang.org/cl/6637061

19dc7bb1

fmt: document some undocumented details · e171b97e

Rob Pike authored Oct 12, 2012

Better explanation of width for floating-point values.
Explain that scanning does not handle %#q etc.

Fixes #4202.
Fixes #4206.

R=golang-dev, adg, rsc, iant
CC=golang-dev
https://golang.org/cl/6620074

e171b97e

bytes, strings: add (*Reader).WriteTo · eae25d43

Evan Shaw authored Oct 12, 2012

Fixes #4031.

R=golang-dev, bradfitz, remyoudompheng, r, dave
CC=golang-dev
https://golang.org/cl/6632046

eae25d43

time: delete erroneous word from documentation. · 06d42690
Rob Pike authored Oct 12, 2012
```
Fixes #4236.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6658051
```
06d42690

11 Oct, 2012 11 commits

os/signal: add Notify example · bd6601f4
Andrew Gerrand authored Oct 11, 2012
```
R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/6615078
```
bd6601f4

math/big: more conservative use of lock for divisor table · 4bee88d4

Robert Griesemer authored Oct 11, 2012

Minor performance impact running sequentially:

benchmark                      old ns/op    new ns/op    delta
BenchmarkString10Base2               389          391   +0.51%
BenchmarkString100Base2             1530         1534   +0.26%
BenchmarkString1000Base2           11789        11787   -0.02%
BenchmarkString10000Base2         111443       112030   +0.53%
BenchmarkString100000Base2       1017483      1015347   -0.21%
BenchmarkString10Base8               339          344   +1.47%
BenchmarkString100Base8              753          756   +0.40%
BenchmarkString1000Base8            4618         4641   +0.50%
BenchmarkString10000Base8          43217        43534   +0.73%
BenchmarkString100000Base8        397518       400602   +0.78%
BenchmarkString10Base10              630          630   +0.00%
BenchmarkString100Base10            1975         1960   -0.76%
BenchmarkString1000Base10          10179        10174   -0.05%
BenchmarkString10000Base10         44527        44416   -0.25%
BenchmarkString100000Base10     14404694     14425308   +0.14%
BenchmarkString10Base16              283          288   +1.77%
BenchmarkString100Base16             597          598   +0.17%
BenchmarkString1000Base16           3189         3186   -0.09%
BenchmarkString10000Base16         29403        29364   -0.13%
BenchmarkString100000Base16       265657       265587   -0.03%

Note that due to other improvements (faster assembly routines,
better code generation by compiler), these benchmarks now run
up to 37% faster than they used to at the last time measured (1/9/2012).

Minor performance impact for StringPiParallel running in parallel:

Current CL but with Lock/Unlock commented out (removed):

BenchmarkStringPiParallel	    5000	    343581 ns/op
BenchmarkStringPiParallel-2	   10000	    184511 ns/op
BenchmarkStringPiParallel-3	   10000	    129768 ns/op
BenchmarkStringPiParallel-4	   10000	    102326 ns/op

Current CL:

BenchmarkStringPiParallel	    5000	    345169 ns/op
BenchmarkStringPiParallel-2	   10000	    185827 ns/op
BenchmarkStringPiParallel-3	   10000	    131168 ns/op
BenchmarkStringPiParallel-4	   10000	    102353 ns/op

Fixes #4218.

R=dvyukov, michael.jones, dave
CC=golang-dev
https://golang.org/cl/6643053

4bee88d4

crypto/rsa: fix decryption benchmark. · 3acce59b

Adam Langley authored Oct 11, 2012

I was an idiot and was thinking that a small base didn't matter
because the exponentiation would quickly make the number the same size
as the modulus. But, of course, the small base continues to make
multiplications unrealistically cheap throughout the computation.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6649048

3acce59b

net/http: fix data race on countReader.n · a14f87ca
Dave Cheney authored Oct 11, 2012
```
Fixes #4220.

R=dvyukov, bradfitz
CC=golang-dev
https://golang.org/cl/6638053
```
a14f87ca

net/http: fix race on bodyEOFSignal.isClosed · f1b17536

Dave Cheney authored Oct 11, 2012

Update #4191.

Fixes unreported race failure at
http://build.golang.org/log/61e43a328fb220801d3d5c88cd91916cfc5dc43c

R=dvyukov, bradfitz
CC=golang-dev
https://golang.org/cl/6640057

f1b17536

crypto/hmac: add Equal function. · 6720997f

Adam Langley authored Oct 11, 2012

It was suggested that it's too easy to use crypto/hmac insecurely and
I think that has some merit. This change adds a Equal function to
make it obvious that MAC values should be compared in constant time.

R=rsc, max
CC=golang-dev
https://golang.org/cl/6632044

6720997f

doc/contribute.html: assorted fixes · 4c473c02

Shenghou Ma authored Oct 11, 2012

0. windows uses all.bat instead of ./all.bash
1. correct expected all.bash output
2. mention you need to use an application specific password
if you're using 2-step verification
3. note you can edit files included in CL by 'hg change NNNN'
or 'hg file'

R=golang-dev, adg, r
CC=golang-dev
https://golang.org/cl/6615060

4c473c02

godoc: update favicon · b13c7eec
Andrew Gerrand authored Oct 11, 2012
```
R=golang-dev
CC=golang-dev
https://golang.org/cl/6641058
```
b13c7eec
doc/faq: discuss virtual memory use by go processes · 2100947d
Andrew Gerrand authored Oct 11, 2012
```
Fixes #3948.

R=golang-dev, r, dave, dsymonds
CC=golang-dev
https://golang.org/cl/6639064
```
2100947d

doc/articles/wiki: numerous fixes · dad1228c

Jimmy Zelinskie authored Oct 11, 2012

Fixes #3733
Fixes #2149
Updated Syntax
Added part3.go example program
Added part3-errorhandling.go example program
Improved wording in some places

R=golang-dev, adg, minux.ma
CC=golang-dev
https://golang.org/cl/6636048

dad1228c

A+C: add Jimmy Zelinskie (Individual CLA) · a3d116cf
Andrew Gerrand authored Oct 11, 2012
```
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/6642068
```
a3d116cf

10 Oct, 2012 12 commits

godoc: restore toy selection to playground widget · bd31e629
Andrew Gerrand authored Oct 10, 2012
```
Fixes #4225.

R=golang-dev
CC=golang-dev
https://golang.org/cl/6640054
```
bd31e629
doc/godoc.js: assign tmp. id to nodes without id in generateTOC() · 6572c7ee
Shenghou Ma authored Oct 10, 2012
```
R=adg
CC=golang-dev
https://golang.org/cl/6604062
```
6572c7ee
godoc: fix site for large displays · 7e196d08
Andrew Gerrand authored Oct 10, 2012
```
R=golang-dev, skybrian
CC=golang-dev
https://golang.org/cl/6643062
```
7e196d08

test: convert tests to run.go whenever possible. · dda1b560

Rémy Oudompheng authored Oct 10, 2012

The other tests either need a complex procedure
or are architecture- or OS-dependent.

Update #4139.

R=golang-dev, daniel.morsing, iant
CC=golang-dev
https://golang.org/cl/6618062

dda1b560

container/heap: optimization in case heap has many duplicates · c12dab2a

Taj Khattra authored Oct 10, 2012

benchmark       old ns/op    new ns/op    delta
BenchmarkDup      3075682       609448  -80.18%

R=gri
CC=golang-dev
https://golang.org/cl/6613064

c12dab2a

C+A: added Taj Khattra (individual CLA) · 4c9c36e6
Robert Griesemer authored Oct 10, 2012
```
R=golang-dev, r, bradfitz
CC=golang-dev
https://golang.org/cl/6635061
```
4c9c36e6

cmd/go: don't ignore error when 'go clean' · bf7d229e

Shenghou Ma authored Oct 10, 2012

        Fixes #4208.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/6635064

bf7d229e

runtime/debug: fix the test · be2b95fe

Dmitriy Vyukov authored Oct 10, 2012

If source are not available, then the stack looks like:
stack_test.go:40: /tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/runtime/debug/bla-bla-bla/src/pkg/runtime/debug/stack_test.go:15 (0x43fb11)
stack_test.go:40: /tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/runtime/debug/bla-bla-bla/src/pkg/runtime/debug/stack_test.go:18 (0x43fb7a)
stack_test.go:40: /tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/runtime/debug/bla-bla-bla/src/pkg/runtime/debug/stack_test.go:37 (0x43fbf4)
stack_test.go:40: /tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/testing/bla-bla-bla/src/pkg/testing/testing.go:301 (0x43b5ba)
stack_test.go:40: /tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/runtime/bla-bla-bla/src/pkg/runtime/proc.c:276 (0x410670)
stack_test.go:40:
which is 6 lines.

R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/6637060

be2b95fe

codereview.py: Fix crash on auth error handling. · df7b7207

Uriel Mangado authored Oct 10, 2012

In recent Python versions .reason is a read-only property that simply gives you the msg value.

Fixes #4024

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/6545052

df7b7207

cmd/gc: fix compiler crash during race instrumentation · 21b2ce72

Dmitriy Vyukov authored Oct 10, 2012

The compiler is crashing on the following code:

type TypeID int
func (t *TypeID) encodeType(x int) (tt TypeID, err error) {
        switch x {
        case 0:
                return t.encodeType(x * x)
        }
        return 0, nil
}
The pass marks "return struct" {tt TypeID, err error} as used,
and this causes internal check failure.
I've added the test to:
https://golang.org/cl/6525052/diff/7020/src/pkg/runtime/race/regression_test.go

R=golang-dev, minux.ma, rsc
CC=golang-dev
https://golang.org/cl/6611049

21b2ce72

runtime: fix race detector handling of stackalloc() · 27e93fbd
Dmitriy Vyukov authored Oct 10, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6632051
```
27e93fbd

spec: clarify defer semantics · f04ae137

Rob Pike authored Oct 10, 2012

It's already there but only in the "for instance" and so not
clear enough: deferred functions run after
the result parameters are updated.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6631058

f04ae137