Commits · c02294344943db0e93d24d37526961b3fe851a66 · go / golang

17 Jan, 2013 12 commits

html/template: remove noescape support · c0229434

Andrew Gerrand authored Jan 17, 2013

This was never documented or properly implemented.

Fixes #3528.

R=mikesamuel, rsc
CC=golang-dev
https://golang.org/cl/7142048

c0229434

testing: catch panicking example and report, just like tests · 5bd5ed2b
Andrew Gerrand authored Jan 17, 2013
```
Fixes #4670.

R=rsc
CC=golang-dev
https://golang.org/cl/7148043
```
5bd5ed2b
C: add Carl Shapiro (Google CLA). · 07dfd8b1
David Symonds authored Jan 17, 2013
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/7132049
```
07dfd8b1
all: remove exec bit on files · d46d0f15
Shenghou Ma authored Jan 17, 2013
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/7128048
```
d46d0f15
cmd/vet: don't complain about Error() · e487ea84
Shenghou Ma authored Jan 17, 2013
```
Fixes #4598.

R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/7102050
```
e487ea84
doc/go_spec.html: clarification about insertion during map iteration · ced57153
Shenghou Ma authored Jan 17, 2013
```
R=mdempsky, iant, r, gri, rsc, ken
CC=golang-dev
https://golang.org/cl/7100046
```
ced57153

cmd/godoc: when redirecting don't clear query string · c2aee3c0

Shenghou Ma authored Jan 17, 2013

so that http://golang.org/pkg/runtime?m=all works.

R=bradfitz
CC=golang-dev
https://golang.org/cl/7094046

c2aee3c0

os: use SameFile in TestStartProcess · 40b37588

Shenghou Ma authored Jan 17, 2013

Fixes #4650.

R=golang-dev, bradfitz, alex.brainman
CC=golang-dev
https://golang.org/cl/7085048

40b37588

testing: introduce (*B).ReportAllocs() · 1e095b76

Shenghou Ma authored Jan 17, 2013

Calling it will show memory allocation statistics for that
single benchmark (if -test.benchmem is not provided)

R=golang-dev, rsc, kevlar, bradfitz
CC=golang-dev
https://golang.org/cl/7027046

1e095b76

doc/articles/json_and_go: fix some format. · f5958c61
Oling Cat authored Jan 17, 2013
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/7131045
```
f5958c61

time: add Timer.Reset · 44ff17e6

Volker Dobler authored Jan 17, 2013

Fixes #4412.

R=adg, rsc, rogpeppe, andrewdg, bradfitz
CC=golang-dev
https://golang.org/cl/7086050

44ff17e6

exp/html: remove "INCOMPLETE" comment · 55740f76

Andrew Balholm authored Jan 17, 2013

I think that the parser is complete enough to take that warning out.
It passes the test suite.
There may be incompatible API changes, but being in the exp directory
is warning enough for that.

R=nigeltao
CC=golang-dev
https://golang.org/cl/7131050

55740f76

16 Jan, 2013 2 commits
- go/types: correct result type for append (bug fix) · 5a4a197d
  Robert Griesemer authored Jan 16, 2013
```
Rewrote existing code to prevent similar mistakes.

R=adonovan
CC=golang-dev
https://golang.org/cl/7129046
```
  5a4a197d
- net/http: Serve creates service goroutines, not service threads · 1a03580e
  Matthew Dempsky authored Jan 16, 2013
```
R=bradfitz
CC=golang-dev
https://golang.org/cl/7132045
```
  1a03580e
15 Jan, 2013 2 commits

net/http: fix racy test · 3b73aaaf

Brad Fitzpatrick authored Jan 15, 2013

We need to wait for the handler to actually finish running,
not almost be done running.

This was always a bug, but now that handler output is buffered
it shows up easily on GOMAXPROCS >1 systems.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/7109043

3b73aaaf

doc: fix various fragment links · 399a36a6
Andrew Gerrand authored Jan 15, 2013
```
R=dsymonds
CC=golang-dev
https://golang.org/cl/7094058
```
399a36a6

14 Jan, 2013 12 commits
- net: simplify ListenMulticastUDP · 6d725e97
  Mikio Hara authored Jan 14, 2013
```
R=rsc, iant, dave
CC=golang-dev
https://golang.org/cl/6999053
```
  6d725e97
- syscall: simplify socket control messages · c241f696
  Mikio Hara authored Jan 14, 2013
```
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/7016044
```
  c241f696
- go/types: set type of lhs ident in type switch guards · 0822a62c
  Robert Griesemer authored Jan 14, 2013
```
(bug fix)

R=adonovan
CC=golang-dev
https://golang.org/cl/7098059
```
  0822a62c
- go/types: various minor fixes · 5e5c0a9f
  Robert Griesemer authored Jan 14, 2013
```
- always set the Pkg field in QualifiedIdents
- call Context.Ident for all identifiers in the AST that denote
  a types.Object (bug fix)
- added test that Context.Ident is called for all such identifiers

R=adonovan
CC=golang-dev
https://golang.org/cl/7101054
```
  5e5c0a9f
- time: fix race · fd1abac7
  Brad Fitzpatrick authored Jan 14, 2013
```
Fixes #4622

R=golang-dev, dave, dvyukov
CC=golang-dev
https://golang.org/cl/7103046
```
  fd1abac7
- go/types: mark completely imported packages as such · 6c3736a5
  Robert Griesemer authored Jan 14, 2013
```
R=adonovan
CC=golang-dev
https://golang.org/cl/7103055
```
  6c3736a5
- go/types: callback for *ast.Ident -> Object mapping · 7f18f811
  Robert Griesemer authored Jan 14, 2013
```
Also re-enabled resolver test.

R=adonovan
CC=golang-dev
https://golang.org/cl/7107043
```
  7f18f811
- html/template: Clarifying references to "text/template" in the documentation. · 1590be9e
  Francesc Campoy authored Jan 14, 2013
```
Fixes #4634.

R=adg, kevlar
CC=golang-dev
https://golang.org/cl/7066053
```
  1590be9e
- syscall: simplify netlink sockets · a0509d85
  Mikio Hara authored Jan 14, 2013
```
R=dave, rsc
CC=golang-dev
https://golang.org/cl/7039044
```
  a0509d85
- encoding/json: fix panics on type mismatches. · 406ca3c2
  Rémy Oudompheng authored Jan 14, 2013
```
Fixes #4222.
Fixes #4628.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/7100049
```
  406ca3c2
- encoding/gob: fix broken test (fix build) · 06af0ea3
  Alex Brainman authored Jan 14, 2013
```
R=golang-dev, kevlar
CC=adg, golang-dev
https://golang.org/cl/7093056
```
  06af0ea3
- encoding/gob: handle encoding of different indirects of GobEncoder · bc1152a3
  Kyle Lemons authored Jan 14, 2013
```
Fixes #4647.

R=r, golang-dev
CC=golang-dev
https://golang.org/cl/7085051
```
  bc1152a3
13 Jan, 2013 3 commits

misc/dashboard/codereview: add campoy to list of gophers · f31f9a61
Andrew Gerrand authored Jan 13, 2013
```
R=dsymonds
CC=golang-dev
https://golang.org/cl/7106044
```
f31f9a61

cmd/godoc: support m=text parameter for text files · be259647

Andrew Gerrand authored Jan 13, 2013

It's possible to view the package docs in plain text, eg:
        http://golang.org/pkg/time/?m=text
and this CL introduces the ability to do the same for files:
        http://golang.org/src/pkg/time/time.go?m=text

R=golang-dev, dave, minux.ma
CC=golang-dev
https://golang.org/cl/7085054

be259647

go/types: Moving from *ast.Objects to types.Objects (step 2). · 94878070

Robert Griesemer authored Jan 13, 2013

Completely removed *ast.Objects from being exposed by the
types API. *ast.Objects are still required internally for
resolution, but now the door is open for an internal-only
rewrite of identifier resolution entirely at type-check
time. Once that is done, ASTs can be type-checked whether
they have been created via the go/parser or otherwise,
and type-checking does not require *ast.Object or scope
invariants to be maintained externally.

R=adonovan
CC=golang-dev
https://golang.org/cl/7096048

94878070

12 Jan, 2013 7 commits

cmd/5l: fix invalid executable header on Plan 9 · 1a9a6396
Anthony Martin authored Jan 12, 2013
```
R=minux.ma, lucio.dere
CC=golang-dev
https://golang.org/cl/7094048
```
1a9a6396

cmd/5c: fix handling of side effects when assigning a struct literal. · c13866db

Rémy Oudompheng authored Jan 12, 2013

Also undo revision a5b96b602690 used to workaround the bug.

Fixes #4643.

R=rsc, golang-dev, dave, minux.ma, lucio.dere, bradfitz
CC=golang-dev
https://golang.org/cl/7090043

c13866db

test: limit runoutput tests on arm platforms · dc75670a

Dave Cheney authored Jan 12, 2013

runoutput styles tests generally consume a lot of memory. On arm platforms rotate?.go consume around 200mb each to compile, and as tests are sorted alphabetically, they all tend to run at once.

This change limits the number of runoutput jobs to 2 on arm platforms.

R=minux.ma, remyoudompheng, bradfitz, lucio.dere
CC=golang-dev
https://golang.org/cl/7099047

dc75670a

build: add missing function declarations for Plan 9 · 39ffa83f
Lucio De Re authored Jan 12, 2013
```
R=golang-dev, minux.ma, rsc, ality, seed
CC=golang-dev
https://golang.org/cl/7034052
```
39ffa83f
testing: document whitespace trimming of example expected/actual output. · b78f5f0e
Caleb Spare authored Jan 12, 2013
```
Fixes #4642.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/7090044
```
b78f5f0e
text/template: Document that range can be used on chan types. · ad63c7e5
Kamil Kisiel authored Jan 12, 2013
```
Fixes #4640.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/7082044
```
ad63c7e5
testing: in example, empty output not distinguished from missing output · 3073a02b
Ryan Slade authored Jan 12, 2013
```
Fixes #4485.

R=golang-dev, rsc, adg
CC=golang-dev
https://golang.org/cl/7071050
```
3073a02b

11 Jan, 2013 2 commits
- net/http/cgi: fix test case sensitivity on Windows · 05bf9a45
  Brad Fitzpatrick authored Jan 11, 2013
```
Fixes #4645

R=golang-dev, alex.brainman, minux.ma
CC=golang-dev
https://golang.org/cl/7105047
```
  05bf9a45
- go/types: export QualifiedName.IsSame and NamedType.AstObj · 8b62f54e
  Robert Griesemer authored Jan 11, 2013
```
R=adonovan
CC=golang-dev
https://golang.org/cl/7103047
```
  8b62f54e