R=rsc
https://golang.org/cl/164085

in favor of tempname.
allows optimizer to do more.
unfortunately, optimizer seems to be broken; disable it.

R=ken2
https://golang.org/cl/163091

	drop check in range over array.
	drop check in [256]array indexed by byte.

R=ken2
https://golang.org/cl/163088

tabs for indentation even if -spaces is set.

Changes to gofmt:
- added -tabindent flag
- don't recompute parser and printer mode repeatedly

Changes to go/printer:
- provide new printing mode TabIndent

Changes to tabwriter:
- implement new mode TabIndent to use tabs independent
  of the actual padding character for leading empty columns
- distinguish between minimal cell width and tab width
  (tabwidth is only used if the output contains tabs,
  minwidth and padding are always considered)
- fixed and added more comments
- some additional factoring

By default, -tabindent is disabled and the default gofmt
behavior is unchanged. By setting -spaces and -tabindent,
gofmt will use tabs for indentation but do any other
alignment with spaces. This permits a user to change the
visible indentation by simply changing the editor's tab
width and the code will remain properly aligned without
the need to rerun gofmt.

R=rsc
https://golang.org/cl/163068

Fixes #274.

R=r
CC=jonathan.r.hudson
https://golang.org/cl/163072

R=rsc
CC=golang-dev
https://golang.org/cl/164082

R=gri
https://golang.org/cl/164081

How to reproduce:

	$ mkdir /tmp/foo
	$ cp /dev/null /tmp/foo/bar.go
	$ chmod -r /tmp/foo/bar.go
	$ gofmt /tmp/foo
	open /tmp/foo/bar.go: permission denied
	$ echo $?		# should echo 2
	0
	$

Maybe you need to put a call to time.Sleep at the beginning of report().

R=gri
CC=golang-dev
https://golang.org/cl/164073

R=rsc
https://golang.org/cl/164071

Fixes #338.

R=rsc
CC=golang-dev
https://golang.org/cl/163083

can't mix slices and arrays now; perhaps that should be a TODO

R=rsc
https://golang.org/cl/164079

  so that the issue stops showing up on the
  per-reviewer dashboard page.

R=r
https://golang.org/cl/164075

added random test to look for more.

Fixes #363.

R=r, cw
https://golang.org/cl/163071

Submitting as a TBR to fix the build.

R=dho, rsc
https://golang.org/cl/164078

  on my linux machine this is the correct one. lxml.etree
  exists with an ElementTree class, but does not contain
  an .XML method.

R=rsc
https://golang.org/cl/163082

R=rsc
CC=golang-dev
https://golang.org/cl/164053

R=r
CC=hurtonm
https://golang.org/cl/164074

Fixes #271.
Fixes #321.

R=rsc, agl, cw
CC=golang-dev
https://golang.org/cl/163052

R=rsc
https://golang.org/cl/163070

R=rsc
CC=golang-dev
https://golang.org/cl/163069

Necessary for 163052

R=rsc
CC=golang-dev
https://golang.org/cl/164068

R=rsc
CC=golang-dev
https://golang.org/cl/164069

R=gri
https://golang.org/cl/163067

R=dho
CC=golang-dev
https://golang.org/cl/163061

R=rsc
https://golang.org/cl/163049

R=rsc
CC=golang-dev
https://golang.org/cl/163062

TBR=r
https://golang.org/cl/163064

Easy stuff in this round, more to come.

R=iant, rsc, r, ken2
https://golang.org/cl/163058

Bad returns noticed by "Devon H. O'Dell" <devon.odell@gmail.com>.

Resolves Issue 360.

R=rsc, dho, agl, agl1
CC=ukai
https://golang.org/cl/163055

Also fixes issue 310 comment 5 error.
Fixes #310.

R=rsc
https://golang.org/cl/163042

1) need to send slice and array types (was only sending element types)
2) compatibleType needs to use decoder's type map

R=rsc
CC=golang-dev
https://golang.org/cl/164062

R=rsc
https://golang.org/cl/164059

R=r
https://golang.org/cl/164060

R=rsc
https://golang.org/cl/163053

R=rsc
https://golang.org/cl/161050

Opening /dev/stdin can sometimes fail. For example, in the acme editor,
executing "Edit ,|gofmt" fails with:

	open /dev/stdin: no such device or address

Executing "Edit ,|ls -l /dev/stdin /proc/self/fd/0" gives:

	lrwxrwxrwx 1 root root  15 2009-09-07 02:17 /dev/stdin -> /proc/self/fd/0
	lrwx------ 1 fhs  users 64 2009-11-26 22:05 /proc/self/fd/0 -> socket:[5528230]

(This is my first change, and I've signed the individual contributor license agreement.)

R=rsc, gri
CC=golang-dev
https://golang.org/cl/162041

- simplified dealing with parse errors: no need to intersperse them in the source
- improve visibility of highlighted identifiers by showing them in bold

R=rsc
https://golang.org/cl/163051

R=golang-dev, rsc
https://golang.org/cl/164052

R=rsc
CC=agl1
https://golang.org/cl/154123

R=rsc
https://golang.org/cl/163050