- 19 Jul, 2018 2 commits
-
-
Brad Fitzpatrick authored
It was flaky on slower machines. Per report at https://github.com/golang/go/issues/23399#issuecomment-405792381 Change-Id: I7cab02821f78b5ce02ea51089d7eb51723f9705f Reviewed-on: https://go-review.googlesource.com/124835 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Rob Pike authored
Completely replace the opener, which had become not only stale but bad, expand the discussion of the gopher, and generally provide prose more connected to the present than to the programming world of 2007. Fixes #26107 Change-Id: I5e72f0c81e71d1237fe142dc26114991329a6996 Reviewed-on: https://go-review.googlesource.com/124616Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
- 18 Jul, 2018 32 commits
-
-
Ian Lance Taylor authored
Change-Id: Ic1ff580573711a6c91c1d5e3eb019a298a2fec49 Reviewed-on: https://go-review.googlesource.com/124837Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Brad Fitzpatrick authored
Change-Id: I9008afdc8c38c440ea083a4f2bed0d2253e112f0 Reviewed-on: https://go-review.googlesource.com/124836Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Andrew Bonventre authored
Change-Id: I3e2a19fe90334f0c1ed1593c7a9a3a458f15d8e8 Reviewed-on: https://go-review.googlesource.com/124799Reviewed-by: Andrew Bonventre <andybons@golang.org>
-
Andrew Bonventre authored
Change-Id: Ib488a78802ad730e7c6b3618eab24c259f4bebd1 Reviewed-on: https://go-review.googlesource.com/124798Reviewed-by: Andrew Bonventre <andybons@golang.org>
-
Brad Fitzpatrick authored
Change-Id: I30d2b4b94f26300f2cf7b4ecd328a4875d69db51 Reviewed-on: https://go-review.googlesource.com/124777Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Hana (Hyang-Ah) Kim authored
The final API uses 'region' instead of 'span' from the proposal. Change-Id: I305da891a360596fff89b10bc6de3090289b5396 Reviewed-on: https://go-review.googlesource.com/124815Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Ian Lance Taylor authored
Change-Id: Ie4e81b88cc8035fddf9c074363a1b35bcae3d470 Reviewed-on: https://go-review.googlesource.com/124778Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Daniel Martí authored
If one tries to use promoted fields in a struct literal, the compiler errors correctly. However, if the embedded fields are of struct pointer type, the field.Type.Sym.Name expression below panics. This is because field.Type.Sym is nil in that case. We can simply use field.Sym.Name in this piece of code though, as it only concerns embedded fields, in which case what we are after is the field name. Added a test mirroring fixedbugs/issue23609.go, but with pointer types. Fixes #26416. Change-Id: Ia46ce62995c9e1653f315accb99d592aff2f285e Reviewed-on: https://go-review.googlesource.com/124395 Run-TryBot: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
-
Ian Lance Taylor authored
Change-Id: I806d411c075cdc66322112b6ee5e50f58462bc6b Reviewed-on: https://go-review.googlesource.com/124776Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Austin Clements authored
Text based on CL 124655. Change-Id: I7c4866ce829cb28a4c60cd8ced3ef99047a38c54 Reviewed-on: https://go-review.googlesource.com/124711Reviewed-by: Austin Clements <austin@google.com>
-
Jack authored
If a filepath.WalkFunc is called with an non-nil err argument, it's possible that the info argument will be nil. The comment above filepath.WalkFunc now reflects this. Fixes #26425 Change-Id: Ib9963b3344587d2993f1698c5a801f2d1286856b GitHub-Last-Rev: 553fc266b570d0c47efe12b3b670f88112e3b334 GitHub-Pull-Request: golang/go#26435 Reviewed-on: https://go-review.googlesource.com/124635Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Austin Clements authored
Change-Id: I25b93a84996ab1c17d64089b4c2ffabdff3365ec Reviewed-on: https://go-review.googlesource.com/124710Reviewed-by: Austin Clements <austin@google.com>
-
Andrew Bonventre authored
Change-Id: Id06e5139f16cd7a85c59a3dcf2020cf647fcdea0 Reviewed-on: https://go-review.googlesource.com/124709Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Andrew Bonventre <andybons@golang.org>
-
Andrew Bonventre authored
Change-Id: I357eea0efb04392e1a4671d20190a2052bf548de Reviewed-on: https://go-review.googlesource.com/124706Reviewed-by: Andrew Bonventre <andybons@golang.org>
-
Andrew Bonventre authored
Update text/scanner and text/template sections. Change-Id: I1a273e99ff400870053cca63cea68fb7a9b56764 Reviewed-on: https://go-review.googlesource.com/124705Reviewed-by: Andrew Bonventre <andybons@golang.org>
-
Brad Fitzpatrick authored
This doesn't auto-deploy to golang.org, only tip.golang.org. Change-Id: I112743ada2c1393e21edcc9075127f40da9e6270 Reviewed-on: https://go-review.googlesource.com/124755Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Russ Cox authored
Change-Id: Id381ee73e678ff4b025c1c35512a755ba49d6f81 Reviewed-on: https://go-review.googlesource.com/124702 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: Andrew Bonventre <andybons@golang.org>
-
Brad Fitzpatrick authored
Change-Id: Ic5b9ccb2772534cee77ffcaeee617c7d5edfb6fd Reviewed-on: https://go-review.googlesource.com/124715Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Hana (Hyang-Ah) Kim authored
Mention the change in the behavior of go test -memprofile. Change-Id: I0384f058298bd8fcfd2d97996464d46b4e419938 Reviewed-on: https://go-review.googlesource.com/124656Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Alberto Donizetti authored
Missed in CL 124516. Change-Id: I6488196c8392987d69eca832ab4969aaafe1a26c Reviewed-on: https://go-review.googlesource.com/124658Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Elias Naur authored
The change to make the runtime use libSystem.so macOS instead of direct kernel calls applies to iOS as well. Change-Id: I97ea86452ac5f7433aea58bbd3ff53a2eb2835e0 Reviewed-on: https://go-review.googlesource.com/124657Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Ben Shi authored
The arm64 backend generates "TST" for "if uint32(a)&uint32(b) == 0", which should be "TSTW". fixes #26438 Change-Id: I7d64c30e3a840b43486bcd10eea2e3e75aaa4857 Reviewed-on: https://go-review.googlesource.com/124637 Run-TryBot: Ben Shi <powerman1st@163.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>
-
Alberto Donizetti authored
Change-Id: I6f8d9cc8997128d0076a3a3e82fe5155d53db40d Reviewed-on: https://go-review.googlesource.com/124659Reviewed-by: Rob Pike <r@golang.org>
-
Ian Lance Taylor authored
In CLs 122575 and 123177 the cgo tool started explicitly looking up typedefs. When there are two Go files using import "C", and the first one has an incomplete typedef and the second one has a complete version of the same typedef, then we will now record a version of the first typedef which will not match the recorded version of the second typedef, producing an "inconsistent definitions" error. Fix this by silently merging incomplete typedefs with complete ones. Fixes #26430 Change-Id: I9e629228783b866dd29b5c3a31acd48f6e410a2d Reviewed-on: https://go-review.googlesource.com/124575 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Keith Randall <khr@golang.org>
-
Rob Pike authored
This should have been added to the repo after Renee's Gophercon keynote. I will link to it from the FAQ. Change-Id: I0e5b88690e288827591d27b99420d3a449f7f662 Reviewed-on: https://go-review.googlesource.com/124615Reviewed-by: Andrew Gerrand <adg@golang.org>
-
Russ Cox authored
It worked once. It needs to keep working. Change-Id: Iaa43726e1c78f0c4a20b5805c7c2bfa76fab2489 Reviewed-on: https://go-review.googlesource.com/124383 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
-
Russ Cox authored
We need an easy way to remove $GOPATH/src/mod, especially since all the directories are marked read-only. Change-Id: Ib9e8e47e50048f55ecc4de0229b06c4a416ac114 Reviewed-on: https://go-review.googlesource.com/124382 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
-
Russ Cox authored
The top-level directory in a module was marked unwritable but not the subdirectories. Fix that. Change-Id: Ia57e5343624753851d9fe1ddfe496b870b67f924 Reviewed-on: https://go-review.googlesource.com/124381 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
-
Russ Cox authored
Within the zip file for a given module, disallow names that are invalid on various operating systems (mostly Windows), and disallow having two different paths that are case-fold-equivalent. Disallowing different case-fold-equivalent paths means the zip file content is safe for case-insensitive file systems. There is more we could do to relax the rules later, but I think this should be enough to avoid digging a hole in the early days of modules that's hard to climb out of later. In tests on my repo test corpus, the repos now rejected are: github.com/vjeantet/goldap v0.0.0-20160521203625-ea702ca12a40 "doc/RFC 4511 - LDAP: The Protocol.txt": invalid char ':' github.com/ChimeraCoder/anaconda v0.0.0-20160509014622-91bfbf5de08d "json/statuses/show.json?id=404409873170841600": invalid char '?' github.com/bmatcuk/doublestar "test/a
☺ b": invalid char '☺ ' github.com/kubernetes-incubator/service-catalog v0.1.10 "cmd/svcat/testdata/responses/clusterserviceclasses?fieldSelector=spec.externalName=user-provided-service.json": invalid char '?' The : and ? are reserved on Windows, and the : is half-reserved (and quite confusing) on macOS. The☺ is perhaps an overreach, but I am not convinced that allowing all of category So is safe; certainly Sk is not. Change-Id: I83b6ac47ce6c442f726f1036bccccdb15553c0af Reviewed-on: https://go-review.googlesource.com/124380 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com> -
Russ Cox authored
Over time there may exist two modules with names that differ only in case. On systems with case-insensitive file systems, we need to make sure those modules do not collide in the download cache. Do this by using the new "safe encoding" for file system paths as well as proxy paths. Fixes #25992. Change-Id: I717a9987a87ad5c6927d063bf30d10d9229498c9 Reviewed-on: https://go-review.googlesource.com/124379 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
-
Russ Cox authored
Module paths, like import paths, are case-sensitive, for better or worse. But not all file systems distinguish file paths with different cases. If we are going to use module paths to construct file system paths, we must apply an encoding that distinguishes case without relying upon the file system to do it. This CL defines that encoding, the "safe module path encoding". Module paths today are ASCII-only with limited punctuation, so the safe module path encoding is to convert the whole path to lower case and insert an ! before every formerly upper-case letter: github.com/Sirupsen/logrus is stored as github.com/!sirupsen/logrus. Although this CL defines the encoding, it does not change the rest of the go command to use the encoding. That will be done in follow-up CLs. Change-Id: I06e6188dcfcbbc1d88674f7c95e1cb45cb476238 Reviewed-on: https://go-review.googlesource.com/124378 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
-
EduRam authored
Fixes #26385 Change-Id: I5594564f42898a71d30531e5132bddb3a6915247 GitHub-Last-Rev: fbd7b38b0419e21ecd22fe802ede5c0ee3f14a9a GitHub-Pull-Request: golang/go#26427 Reviewed-on: https://go-review.googlesource.com/124555Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
- 17 Jul, 2018 6 commits
-
-
Ian Lance Taylor authored
Fixes #25093 Change-Id: If283275e2b73621ade56d014e60c2d18199b366c Reviewed-on: https://go-review.googlesource.com/122555 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
-
Rob Pike authored
Bring it up to date with recent terminology, mention new approaches such as in Rust, and link to the new blog post. Change-Id: I1d0b121e6f8347c3cf2c8ca0d8adc8285ce59ef1 Reviewed-on: https://go-review.googlesource.com/124475Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Austin Clements authored
Change-Id: I487bdf0c828d28b2122bd93934dc5a9a5dbc6a00 Reviewed-on: https://go-review.googlesource.com/124517Reviewed-by: Austin Clements <austin@google.com>
-
Austin Clements authored
Change-Id: I3c0cb9b56776d8cc78a96ef012385c31f9f0e146 Reviewed-on: https://go-review.googlesource.com/124516Reviewed-by: Austin Clements <austin@google.com>
-
Mostyn Bramley-Moore authored
Relates to #9679 Change-Id: I68951f664d2a03812dae309c580c181869d8af21 Reviewed-on: https://go-review.googlesource.com/122237 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Filippo Valsorda authored
CL 124135 follow-ups. Change-Id: Ib7e2066bd2d18851561e03386709a1b42b50fcef Reviewed-on: https://go-review.googlesource.com/124136Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Andrew Bonventre <andybons@golang.org>
-