- 09 Dec, 2016 9 commits
-
-
Joe Tsai authored
Made many minor changes so that the document is consistent with itself. Some more noticeable changes: * CL/34141: Revert "testing: add T.Context method" * CL/33630: net/http: document restrictions on ETag as expected by ServeContent Change-Id: I39ae5e55c56e374895c115e6852998c940beae35 Reviewed-on: https://go-review.googlesource.com/34243Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Raul Silvera authored
Must add locations to the profile when generating a profile.proto. This fixes #18229 Change-Id: I49cd63a30759d3fe8960d7b7c8bd5a554907f8d1 Reviewed-on: https://go-review.googlesource.com/34028Reviewed-by: Michael Matloob <matloob@golang.org> Run-TryBot: Michael Matloob <matloob@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Brad Fitzpatrick authored
Fixes the build. Updates #18199 Change-Id: Ibf029ba9f9293d1f3d49c1c8773fc262159a5d5b Reviewed-on: https://go-review.googlesource.com/34242Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
-
Brad Fitzpatrick authored
Fixes #17888 Change-Id: I7490b95a03b810a0f7ed1f07f37d7c7b3ac036be Reviewed-on: https://go-review.googlesource.com/34240Reviewed-by: Dmitri Shuralyov <shurcool@gmail.com> Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
-
Austin Clements authored
Fixes #18234. Change-Id: I0f18992ea14e13f283873ac295f0b49d6b7dd8b2 Reviewed-on: https://go-review.googlesource.com/34191Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
-
Joe Tsai authored
This reverts commit 26827bc2. Fixes #18199 Change-Id: I42e292cb4e3d740a4fbb5d0380c6ee15ac742092 Reviewed-on: https://go-review.googlesource.com/34141Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Daniel Theophanes authored
Fixes #18168 Change-Id: Idbfe3d4daedd93c7caf6f1770ecd988e9af39949 Reviewed-on: https://go-review.googlesource.com/34144Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Brad Fitzpatrick authored
Fixes #18257 Change-Id: Iafba5aa0a0641cfe36351bb0e4b57f20257fdc4e Reviewed-on: https://go-review.googlesource.com/34210Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Robert Griesemer authored
Change-Id: I395625dca9b719290c52d2c46f60b53e8fb3abc4 Reviewed-on: https://go-review.googlesource.com/34139 TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
- 08 Dec, 2016 6 commits
-
-
Brad Fitzpatrick authored
Fixes #17938 Change-Id: Iad12155f4976846bd4a9a53869f89e40e5b3deb3 Reviewed-on: https://go-review.googlesource.com/34147 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
-
Brad Fitzpatrick authored
There is nothing notable to mention as far as users are concerned. Fixes #17929 (another bug tracks the remaining TODO item) Change-Id: Id39f787581ed9d2ecd493126bb7ca27836816d4b Reviewed-on: https://go-review.googlesource.com/34145Reviewed-by: Michael Matloob <matloob@golang.org>
-
Brad Fitzpatrick authored
This rolls back https://golang.org/cl/27117 partly, softening it so it only retries POST/PUT/DELETE etc requests where there's no Body (nil or NoBody). This is a little useless, since most idempotent requests have a body (except maybe DELETE), but it's late in the Go 1.8 release cycle and I want to do the proper fix. The proper fix will look like what we did for http2 and only retrying the request if Request.GetBody is defined, and then creating a new request for the next attempt. See https://golang.org/cl/33971 for the http2 fix. Updates #15723 Fixes #18239 Updates #18241 Change-Id: I6ebaa1fd9b19b5ccb23c8d9e7b3b236e71cf57f3 Reviewed-on: https://go-review.googlesource.com/34134 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Tom Bergan <tombergan@google.com>
-
Michael Hudson-Doyle authored
Fixes #18250 Change-Id: I4f61591356ddb4a906c206ad8456d1839daf7b91 Reviewed-on: https://go-review.googlesource.com/34170 Run-TryBot: Michael Hudson-Doyle <michael.hudson@canonical.com> Reviewed-by: David Crawshaw <crawshaw@golang.org>
-
Joe Tsai authored
The combination of two prior CLs can cause panics: * CL/17873: make chained multiReader Read more efficient * CL/28533: make MultiReader nil exhausted Readers for earlier GC The first CL allows MultiReader to "inherit" another MultiReader's list of Readers for efficiency reasons. This is problematic when combined with the later CL since that can set prior Readers in that list to nil for GC reasons. This causes panics when two MultiReaders are used together (even synchronously). To fix this, rather than setting consumed Readers as nil, we set them with a special eofReader that always returns EOF. Fixes #18232 Change-Id: I2a9357ab217e3d54d38ea9022d18e4d14f4182d3 Reviewed-on: https://go-review.googlesource.com/34140Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Ian Lance Taylor authored
Fixes #18240. Change-Id: Ife951e2c1320b3f1362c85642615b24fd4291189 Reviewed-on: https://go-review.googlesource.com/34135Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
- 07 Dec, 2016 13 commits
-
-
Brad Fitzpatrick authored
Change-Id: I929f66b713525f5273cf0fe09579835603279b58 Reviewed-on: https://go-review.googlesource.com/34023Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Ian Lance Taylor authored
Change-Id: I271707dee03fd97cd37bfb116eb00a5532034b57 Reviewed-on: https://go-review.googlesource.com/34020 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Austin Clements authored
This adds a counter for the number of times the application forced a GC by, e.g., calling runtime.GC(). This is useful for detecting applications that are overusing/abusing runtime.GC() or debug.FreeOSMemory(). Fixes #18217. Change-Id: I990ab7a313c1b3b7a50a3d44535c460d7c54f47d Reviewed-on: https://go-review.googlesource.com/34067Reviewed-by: Russ Cox <rsc@golang.org>
-
David Crawshaw authored
Change-Id: Ib9ba8f0b8785f1b0ddb29214beb8674dc06f7422 Reviewed-on: https://go-review.googlesource.com/34111Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: David Crawshaw <crawshaw@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Lynn Boger authored
While processing a symbol for a function, if it is determined that a function would make the text section too large then a new text section is created and the address of the function is in the new text section. But the symbol for the function is marked as being in the previous text section, causing incorrect codegen for the function and leading to a segv if that function is called. This adds code to set the sym.Sect field to the new section if a new one is created. Note that this problem only happens at the point where a new section is created. Fixes #18218 Change-Id: Ic21ae11368d9d88ff6d5d3977f9ea72fe6477ed1 Reviewed-on: https://go-review.googlesource.com/34069 Run-TryBot: Lynn Boger <laboger@linux.vnet.ibm.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Carlos Eduardo Seo <cseo@linux.vnet.ibm.com> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Brad Fitzpatrick authored
150 is too high for some people. Reports of 132, 145, 149 on OS X. Fixes #18203 Change-Id: I559639aba7e87e07d1a1249f8b212b3f34a078ab Reviewed-on: https://go-review.googlesource.com/34019Reviewed-by: Russ Cox <rsc@golang.org>
-
Keith Randall authored
When we copy the stack, we need to adjust all BPs. We correctly adjust the ones on the stack, but we also need to adjust the one that is in g.sched.bp. Like CL 33754, no test as only kernel-gathered profiles will notice. Tests will come (in 1.9) with the implementation of #16638. The invariant should hold that every frame pointer points to somewhere within its stack. After this CL, it is mostly true, but something about cgo breaks it. The runtime checks are disabled until I figure that out. Update #16638 Fixes #18174 Change-Id: I6023ee64adc80574ee3e76491d4f0fa5ede3dbdb Reviewed-on: https://go-review.googlesource.com/33895Reviewed-by: Austin Clements <austin@google.com>
-
Odin Ugedal authored
Change-Id: If30ccfcf56d56fb40102ad567a980793bd39f320 Reviewed-on: https://go-review.googlesource.com/34071Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Russ Cox authored
Fixes #16821. Change-Id: I63d5f3d7cfba1c76259912d754025c5f3cbe4a56 Reviewed-on: https://go-review.googlesource.com/31573 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Adam Langley authored
Previously it was possible to craft a DSA private key that would cause Sign() to loop forever because no signature could be valid. This change does some basic sanity checks and ensures that Sign will always terminate. Thanks to Yolan Romailler for highing this. Be aware, however, that it's still possible for an attacker to simply craft a private key with enormous values and thus cause Sign to take an arbitrary amount of time. Change-Id: Icd53939e511eef513a4977305dd9015d9436d0ce Reviewed-on: https://go-review.googlesource.com/33725Reviewed-by: Yolan Romailler <y@romailler.ch> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
-
Brad Fitzpatrick authored
Fixes TestLookupPort_Minimal on android. Fixes #18213 Change-Id: I1b65e790525d339a4cb7f17afe7e3a02c4587302 Reviewed-on: https://go-review.googlesource.com/34014Reviewed-by: Russ Cox <rsc@golang.org>
-
Ian Lance Taylor authored
It is reported as failing for two people (issues #18202 and #18212). The failure mode is that the system gets overloaded and other programs fail to run. Fixes #18202. Change-Id: I1f1ca1f5d8eed6cc3a9dffac3289851e09fa662b Reviewed-on: https://go-review.googlesource.com/34017 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Brad Fitzpatrick authored
Fixes #18153 Change-Id: Ie8a32dd6fe306f00e51cde77dd4ea353f7109940 Reviewed-on: https://go-review.googlesource.com/34010Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
- 06 Dec, 2016 10 commits
-
-
Brad Fitzpatrick authored
Fixes #18207 Change-Id: Ibe85ab0acba7553b93603a31140b31bd9e4802cf Reviewed-on: https://go-review.googlesource.com/34015Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Keith Randall authored
Mention that the best-effort race detector on maps was upgraded to detect write/iterate races. Fixes #18137 Change-Id: Ib6e0adde47e965126771ea712386031a2a55eba3 Reviewed-on: https://go-review.googlesource.com/33768Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Sebastien Binet authored
This CL adds a simple example for StructOf. The example shows how StructOf can be used in a JSON roundtrip. Change-Id: I9ff1ea9cb8c0cf297c5fae74e68b89931076adfd Reviewed-on: https://go-review.googlesource.com/33953 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: David Crawshaw <crawshaw@golang.org>
-
Brad Fitzpatrick authored
Updates bundled x/net/http2 to git rev 8dab9293 for: http2: make Transport retry on server's GOAWAY graceful shutdown https://golang.org/cl/33971 Fixes #18083 Change-Id: I676f5eb4b490a4d86356778bb17296c451f16d90 Reviewed-on: https://go-review.googlesource.com/34011 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Tom Bergan <tombergan@google.com>
-
David Crawshaw authored
Conditioning on the plugin.Open symbol existing before loading all symbols means sometimes some packages don't have a hash value. Fixes #17928 Change-Id: I2722449aa58eca08a25117d3ce976f11f805b5ac Reviewed-on: https://go-review.googlesource.com/33925 Run-TryBot: David Crawshaw <crawshaw@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Shenghou Ma authored
Change-Id: I811e76c9f42505e974bea634d4ded2499e4893db Reviewed-on: https://go-review.googlesource.com/33926Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Matthew Dempsky authored
Fixes #13263. Change-Id: Ie1cafc62b6bfe6c5381c35d9a95563267b4cc9b0 Reviewed-on: https://go-review.googlesource.com/33970Reviewed-by: Robert Griesemer <gri@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Shenghou Ma authored
While we're at it, also mention OpenBSD/ARM support. Change-Id: I4df4a158b67d11720146d05a235099d452295170 Reviewed-on: https://go-review.googlesource.com/33854Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Ian Lance Taylor authored
Seen on the OpenBSD/AMD64 builder: https://build.golang.org/log/fa34df1bcd3af12d4fc0fb0e60e3c6197a2a6f75 Update #18146. Change-Id: I2646621488be84d50f47c312baa0817c72e3c058 Reviewed-on: https://go-review.googlesource.com/33907 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Chris Broadfoot authored
Change-Id: I84043b6fe4b20a2514d47217e07e44f26bec52ab Reviewed-on: https://go-review.googlesource.com/33973Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
- 05 Dec, 2016 2 commits
-
-
Ian Lance Taylor authored
For reasons that I do not know, OpenBSD does not call pthread_create directly, but instead looks it up in libpthread.so. That means that we can't use the code used on other systems to retry pthread_create on EAGAIN, since that code simply calls pthread_create. This patch copies that code to an OpenBSD-specific version. Also, check for an EAGAIN failure in the test, as that seems to be the underlying cause of the test failure on several systems including OpenBSD. Fixes #18146. Change-Id: I3bceaa1e03a7eaebc2da19c9cc146b25b59243ef Reviewed-on: https://go-review.googlesource.com/33905 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Ian Lance Taylor authored
Fails on builder for unknown reasons. Fixes #18198. Update #18146. Change-Id: Iaa85826655eee57d86e0c73d06c930ef3f4647ec Reviewed-on: https://go-review.googlesource.com/33906 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-