Commits · c705701c69a0ae18ec690cd6a34481f52c52f65b · go / golang

17 Jul, 2011 2 commits

exp/templates: variable scope persists until "end". · c705701c

Rob Pike authored Jul 17, 2011

The previous CL doicumented and diagnosed the old situation.
This one changes it to something more traditional: any action
may declare a variable, and the block structure of scopes
applies only to control seequences.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4748047

c705701c

exp/template: allow declaration of variables only inside control structures. · 331840f5

Rob Pike authored Jul 17, 2011

In simple pipelines the declaration has no scope.
Also document the scope.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4761044

331840f5

15 Jul, 2011 10 commits

http: fixes for sniffing · e07c6e6e
Russ Cox authored Jul 15, 2011
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4753044
```
e07c6e6e

6a, 6c, 6l: fix for Plan 9 build · 4c6280b0

Lucio De Re authored Jul 15, 2011

6a/a.h:
. Dropped <u.h> and <libc.h>.
. Made definition of EOF conditional.

6a/a.y:
. Added <u.h> and <libc.h>.

6a/lex.c:
. Added <u.h> and <libc.h>.
. Dropped <ctype.h> (now in <u.h>).

6c/gc.h:
. Added varargck pragma for "lD".

6c/swt.c:
. Dropped unused "thestring" argument in Bprint() calls.

6l/Makefile:
. Dropped unneeded directory prefix.

6l/l.h:
. Dropped unneeded directory prefix.
. Added varargck pragma for "I" and "i".

6l/obj.c:
. Dropped unneeded assignment.
. Dropped unreachable goto statement.

6l/pass.c:
. Dropped assignments flagged as unused.

6l/prof.c:
. Replaced "#if 0" with "#ifdef NOTDEF".

6l/span.c:
. Dropped unused incrementation.
. Added USED() as required.
. Dropped unreachable "return" statement.

R=golang-dev
CC=golang-dev, rsc
https://golang.org/cl/4747044

4c6280b0

5a, 5c, 5l: fix for Plan 9 build · 5ea4d73b

Lucio De Re authored Jul 15, 2011

5a/a.h:
. Removed <u.h> and <lib.h>.
. Made definition of EOF conditional.

5a/a.y:
. Added <u.h> and <lib.h>.

5a/lex.c:
. Added <u.h> and <lib.h>.
. Dropped <ctype.h> (now in <u.h>).

5c/peep.c:
. Removed unnecessary "return 0" statement.

5c/reg.c:
. Added compilation condition around unused code.

5c/swt.c:
. Removed unused "thestring" argument from Bprint() calls.

5l/asm.c:
. Added USED() statements as required.
. Adjusted a few format specifications.
. Added compilation condition around unused code.

5l/l.h:
. Dropped directory prefix from <../5l/5.out.h>.
. Added varargck pragma for "I" and "i".

5l/obj.c:
. Cascaded consecutive "if" statements.
. Dropped unnecessary incrementation and assignments.

5l/pass.c:
. Dropped unnecessary assignment.

5l/prof.c:
. #if 0 converted to #ifdef NOTDEF.

5l/span.c:
. Dropped unnecessary incrementation and assignments.

R=golang-dev
CC=golang-dev, rsc
https://golang.org/cl/4752041

5ea4d73b

8l: nits · 0490eb60

Lucio De Re authored Jul 15, 2011

8l/Makefile:
. Dropped unnecessary prefix from "../8l/8.out.h"

8l/l.h:
. Dropped unnecessary prefix from "../8l/8.out.h"
. Dropped unused and inconsistent "I" vararg pragma.

R=golang-dev
CC=golang-dev, rsc
https://golang.org/cl/4754041

0490eb60

runtime: native xadd for 386/amd64 · 491aa157

Dmitriy Vyukov authored Jul 15, 2011

benchmark                          old ns/op    new ns/op    delta
BenchmarkSemaUncontended               37.40        34.10   -8.82%
BenchmarkSemaUncontended-2             18.90        17.70   -6.35%
BenchmarkSemaUncontended-4             11.90        10.90   -8.40%
BenchmarkSemaUncontended-8              6.26         5.19  -17.09%
BenchmarkSemaUncontended-16             4.39         3.91  -10.93%
BenchmarkSemaSyntNonblock              38.00        35.30   -7.11%
BenchmarkSemaSyntNonblock-2            83.00        46.70  -43.73%
BenchmarkSemaSyntNonblock-4           124.00       101.00  -18.55%
BenchmarkSemaSyntNonblock-8           124.00       116.00   -6.45%
BenchmarkSemaSyntNonblock-16          148.00       114.00  -22.97%

(on HP Z600 2 x Xeon E5620, 8 HT cores, 2.40GHz)

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4755041

491aa157

gc: some enhancements to printing debug info. · 8cf8806d
Luuk van Dijk authored Jul 15, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4710046
```
8cf8806d
http: sniffing placeholder · e1b2e202
Russ Cox authored Jul 15, 2011
```
R=dsymonds
CC=golang-dev
https://golang.org/cl/4746041
```
e1b2e202
go/build: less aggressive failure when GOROOT not found · 5d929a9c
Andrew Gerrand authored Jul 15, 2011
```
R=golang-dev, rsc, dsymonds
CC=golang-dev
https://golang.org/cl/4743041
```
5d929a9c
runtime: make TestSideEffectOrder work twice · 29125be5
Russ Cox authored Jul 15, 2011
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4714045
```
29125be5

cgi: make test less flaky · fc7b4232

Brad Fitzpatrick authored Jul 15, 2011

Previously, during the anti-zombie test, a
CGI process had to finish within ~625ms.
Now it gets ~5.6 seconds.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4741041

fc7b4232

14 Jul, 2011 16 commits

go/printer: simplify internal state · 48f598a3
Robert Griesemer authored Jul 14, 2011
```
No formatting changes.

R=rsc
CC=golang-dev
https://golang.org/cl/4735042
```
48f598a3
go spec: (up-)date · 38a53c7e
Robert Griesemer authored Jul 14, 2011
```
R=rsc, bradfitz, r
CC=golang-dev
https://golang.org/cl/4738042
```
38a53c7e

go/printer: changed max. number of newlines from 3 to 2 · 90564a92

Robert Griesemer authored Jul 14, 2011

manual changes in src/pkg/go/printer, src/cmd/gofix/signal_test.go
(cd src/cmd/gofix/testdata; gofmt -w *.in *.out)
(cd src/pkg/go/printer; gotest -update)
gofmt -w misc src

runs all tests

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4715041

90564a92

go: require { } around else block · 58e19aa4
Russ Cox authored Jul 14, 2011
```
R=gri, ken, r
CC=golang-dev
https://golang.org/cl/4721044
```
58e19aa4
json: add omitempty struct tag option · 3f53475c
Brad Fitzpatrick authored Jul 14, 2011
```
Fixes #2032

R=rsc, dsymonds, r, r
CC=golang-dev
https://golang.org/cl/4709044
```
3f53475c
godoc: fix build (add Makefile change) · 8d73781f
Robert Griesemer authored Jul 14, 2011
```
R=bradfitz
CC=golang-dev
https://golang.org/cl/4733041
```
8d73781f

godoc: support for file systems stored in .zip files · df68a61c

Robert Griesemer authored Jul 14, 2011

Instead of serving files of the underlying OS file system,
a .zip file may be provided to godoc containing the files
to serve; for instance:

   godoc -http=:6060 -zip=go.zip

using a .zip file created from a clean tree as follows:

   zip -r go.zip $GOROOT

R=rsc
CC=golang-dev
https://golang.org/cl/4670053

df68a61c

gc: fix closure bug · e8ff9a62
Luuk van Dijk authored Jul 14, 2011
```
Fixes #2056.

R=rsc
CC=golang-dev
https://golang.org/cl/4709042
```
e8ff9a62

json: escape < and > in any JSON string. · cbad580e

David Symonds authored Jul 14, 2011

Angle brackets can trigger some browser sniffers, causing
some forms of JSON output to be interpreted as HTML.
Escaping angle brackets closes that security hole.

R=rsc
CC=golang-dev
https://golang.org/cl/4701047

cbad580e

exp/template: allow range actions to declare a key and element variable. · fc1f0bd5

Rob Pike authored Jul 14, 2011

        {{range $key, $element := pipeline}}
This CL is smaller than it looks due to some rearrangement and renaming.

R=rsc, r
CC=golang-dev
https://golang.org/cl/4709047

fc1f0bd5

mime: fix build · aec89c4c
Russ Cox authored Jul 14, 2011
```
R=bradfitz
CC=golang-dev
https://golang.org/cl/4695060
```
aec89c4c

exp/template: escape < and > in JS escaper. · a16ad6fe

David Symonds authored Jul 14, 2011

Angle brackets can trigger some browser sniffers,
causing some output to be interpreted as HTML.
Escaping angle brackets closes that security hole.

R=r
CC=golang-dev
https://golang.org/cl/4714044

a16ad6fe

exp/template: include function name in error returned by function or method call. · dfffc7a5
Rob Pike authored Jul 14, 2011
```
R=golang-dev, rsc, r
CC=golang-dev
https://golang.org/cl/4711049
```
dfffc7a5

exp/template: simplify method and function calls by using the value's Method · 19e207d2

Rob Pike authored Jul 14, 2011

rather than the type's, so a method's invocation works the same as a function's.

R=golang-dev, rsc, r
CC=golang-dev
https://golang.org/cl/4704049

19e207d2

json: allow using '$' and '-' as the struct field's tag · 689a2ec8
Mikio Hara authored Jul 14, 2011
```
R=adg, rsc, bradfitz, mattn.jp, gustavo
CC=golang-dev
https://golang.org/cl/4625081
```
689a2ec8

reflect: trivial addition: Value.NumMethod. · 125e8277

Rob Pike authored Jul 14, 2011

Just an oversight it was missing.

R=rsc, dsymonds, bradfitz, r
CC=golang-dev
https://golang.org/cl/4695059

125e8277

13 Jul, 2011 12 commits

os: Plan 9: add Process.Signal as a way to send notes. · 0bf36ce8

Yuval Pavel Zholkover authored Jul 13, 2011

Move the Signal interface from exec_posix.go to exec.go.
Remove some unsused code from file_plan9.go.

R=fshahriar, rsc
CC=golang-dev
https://golang.org/cl/4683044

0bf36ce8

runtime: correct FixedStack value (fixes windows build) · dde43558
Alex Brainman authored Jul 13, 2011
```
Fixes #2068.

R=rsc
CC=golang-dev
https://golang.org/cl/4705046
```
dde43558

cc: fixes for Plan 9 build · 3f2cc8ba

Lucio De Re authored Jul 13, 2011

<ctype.h> has been moved into <u.h>, specifically to be able to
drop it from these modules.

Will someone check platforms other than UBUNTU/386, please?

R=bsiegert, rsc
CC=golang-dev
https://golang.org/cl/4648078

3f2cc8ba

fix build from e904b6784768 breakage · 8ba48fb5
Brad Fitzpatrick authored Jul 13, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4696047
```
8ba48fb5

syscall: add Flock on Linux · aebfd63c

Russ Cox authored Jul 13, 2011

Fixes #2069.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4703048

aebfd63c

syscall: change missing from windows net fixes · a16baf07
Russ Cox authored Jul 13, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4701045
```
a16baf07
filepath/path: fix a comment · f4acaa8e
Robert Griesemer authored Jul 13, 2011
```
R=bradfitz
CC=golang-dev
https://golang.org/cl/4704047
```
f4acaa8e

exp/template: tweak behavior of booleans. · 469e3331

Rob Pike authored Jul 13, 2011

Russ suggested this technique, making the "and" and "or" functions handier.
But it's hacky, and I can be talked out of it.

R=dsymonds, rsc
CC=golang-dev
https://golang.org/cl/4698044

469e3331

exp/template: allow niladic methods inside chained field references. · c3344d61
Rob Pike authored Jul 13, 2011
```
Also really fix the bug about dot vs. receivers.

R=rsc, r
CC=golang-dev
https://golang.org/cl/4705047
```
c3344d61

http: fix Content-Type of file extension. · 2012290c

Yasuhiro Matsumoto authored Jul 13, 2011

ServeFile() pass empty string to serveFile(). serveFile() should get
file extension via joining root and filename.

R=bradfitz, rsc
CC=golang-dev
https://golang.org/cl/4654089

2012290c

net: windows/amd64 port · 35050455
Wei Guangjing authored Jul 13, 2011
```
R=rsc, alex.brainman
CC=golang-dev
https://golang.org/cl/3790044
```
35050455

debug/elf: Read ELF Program headers. · 932db13e

Matthew Horsnell authored Jul 13, 2011

NewFile has been fixed to read ELF Program headers into the structs.
Added test coverage.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4628062

932db13e