- 19 Sep, 2013 4 commits
-
-
Shenghou Ma authored
Was causing "invalid symbol binding" and thus "malformed pe file" error. R=golang-dev, alex.brainman, adg CC=golang-dev https://golang.org/cl/13722050
-
Shenghou Ma authored
Fixes #5986. R=golang-dev, rsc, alex.brainman CC=golang-dev https://golang.org/cl/13261055
-
Shenghou Ma authored
Fixes #5740. R=iant, rsc, luisbebop CC=gobot, golang-dev https://golang.org/cl/10345046
-
Rob Pike authored
Unlike the other output from the -x flag, it was going to stdout. Fixes #6362. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/13746044
-
- 18 Sep, 2013 8 commits
-
-
Ian Lance Taylor authored
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/13632057
-
Ian Lance Taylor authored
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/13451045
-
Alan Donovan authored
R=gri CC=golang-dev https://golang.org/cl/13471045
-
Ian Lance Taylor authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/13683046
-
-
Andrew Gerrand authored
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/13501050
-
Dave Cheney authored
R=rsc, r CC=golang-dev https://golang.org/cl/13749044
-
Ian Lance Taylor authored
This is a framework for docs on the subject more than it is actual docs. The section header in go/doc.go just says "C", not "C/C++," because otherwise godoc doesn't recognize the line as a section header. Fixes #5473. R=golang-dev, r CC=golang-dev https://golang.org/cl/13280050
-
- 17 Sep, 2013 12 commits
-
-
Robert Griesemer authored
See also issue 6414. R=r CC=golang-dev https://golang.org/cl/13683044
-
Robert Griesemer authored
Avoid future 'declared and not used error'. See also issue 6414. R=r CC=golang-dev https://golang.org/cl/13242058
-
Ian Lance Taylor authored
Gccgo got this wrong, and evidently nothing else tests it. R=golang-dev, r CC=golang-dev https://golang.org/cl/13709045
-
Russ Cox authored
This eliminates ~75% of the nil checks being emitted, on all architectures. We can do better, but we need a bit more general support from the compiler, and I don't want to do that so close to Go 1.2. What's here is simple but effective and safe. A few small code generation cleanups were required to make the analysis consistent on all systems about which nil checks are omitted, at least in the test. Fixes #6019. R=ken2 CC=golang-dev https://golang.org/cl/13334052
-
Adam Langley authored
47ec7a68b1a2 added support for ECDSA ciphersuites but didn't alter the cipher suite selection to take that into account. Thus Go servers could try and select an ECDSA cipher suite while only having an RSA certificate, leading to connection failures. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/13239053
-
Ian Lance Taylor authored
In particular document that the Go tool will look for certain file extensions and compile with them with either the C or the C++ compiler. Fixes #6393. R=golang-dev, r CC=golang-dev https://golang.org/cl/13733043
-
Josh Bleecher Snyder authored
The root cause of the panic reported in https://code.google.com/p/go/issues/detail?id=5980 is that parse's Tree.Text wasn't being copied during the clone. Fix this by adding and using a Copy method for parse.Tree. Fixes #5980. R=golang-dev, r CC=golang-dev https://golang.org/cl/12420044
-
Dave Cheney authored
Update #5764 Like Tribbles, the more you kill, the more spring up in their place. R=rsc CC=golang-dev https://golang.org/cl/13324049
-
Carl Shapiro authored
This interface is required to use the PCDATA interface implemented in Go 1.2. While initially entirely private, the FUNCDATA side of the interface has been made public. This change completes the FUNCDATA/PCDATA interface. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/13735043
-
Rémy Oudompheng authored
A new transformation during walk turns append calls into a combination of growslice and memmove. benchmark old ns/op new ns/op delta BenchmarkAppend 141 141 +0.00% BenchmarkAppend1Byte 18 11 -39.56% BenchmarkAppend4Bytes 19 10 -42.63% BenchmarkAppend7Bytes 18 10 -42.16% BenchmarkAppend8Bytes 18 10 -40.44% BenchmarkAppend15Bytes 19 11 -41.67% BenchmarkAppend16Bytes 19 11 -41.97% BenchmarkAppend32Bytes 23 14 -38.82% BenchmarkAppendStr1Byte 14 10 -23.78% BenchmarkAppendStr4Bytes 14 11 -21.13% BenchmarkAppendStr8Bytes 14 10 -25.17% BenchmarkAppendStr16Bytes 19 11 -41.45% BenchmarkAppendStr32Bytes 18 14 -19.44% BenchmarkAppendSpecialCase 62 63 +1.77% R=golang-dev, khr, cshapiro, rsc, dave CC=golang-dev https://golang.org/cl/12815046
-
Russ Cox authored
Hide container symbols like text and etext so that the individual pieces inside are shown instead. For example, if text and main.init have the same address, it was a toss-up which name was printed. R=golang-dev, iant CC=golang-dev https://golang.org/cl/13722046
-
Russ Cox authored
The code for call site-specific pointer bitmaps was not ready in time, but the zeroing required without it is too expensive to use by default. We will have to wait for precise collection of stack frames until Go 1.3. The precise collection can be re-enabled by GOEXPERIMENT=precisestack ./all.bash but that will not be the default for a Go 1.2 build. Fixes #6087. R=golang-dev, jeremyjackins, dan.kortschak, r CC=golang-dev https://golang.org/cl/13677045
-
- 16 Sep, 2013 16 commits
-
-
Rob Pike authored
Fixes #5725. R=golang-dev, iant CC=golang-dev https://golang.org/cl/13705044
-
Rob Pike authored
Make the break example slightly more interesting Update #5725 Effective Go will be updated in a separate CL. R=golang-dev, iant CC=golang-dev https://golang.org/cl/13368054
-
Adam Langley authored
With TLS 1.2, when sending client certificates the code was omitting the new (in TLS 1.2) signature and hash fields. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/13413050
-
Ian Lance Taylor authored
All these features have in fact been implemented. R=rsc CC=golang-dev https://golang.org/cl/13419049
-
Russ Cox authored
Fixes #6395. R=ken2 CC=golang-dev https://golang.org/cl/13470046
-
Russ Cox authored
The uint64 divide function calls _mul64x32 to do a 64x32-bit multiply and then compares the result against the 64-bit numerator. If the result is bigger than the numerator, must use the slow path. Unfortunately, the 64x32 produces a 96-bit product, and only the low 64 bits were being used in the comparison. Return all 96 bits, the bottom 64 via the original uint64* pointer, and the top 32 as the function's return value. Fixes 386 build (broken by ARM division tests). R=golang-dev, iant CC=golang-dev https://golang.org/cl/13722044
-
Russ Cox authored
Fixes #6399. R=ken2 CC=golang-dev https://golang.org/cl/13253055
-
Russ Cox authored
TBR=golang-dev CC=golang-dev https://golang.org/cl/13720044
-
Russ Cox authored
TBR=golang-dev CC=golang-dev https://golang.org/cl/13700045
-
Russ Cox authored
This CL is required for all.bat to work out of the box on my Windows 8 laptop. These tests either require the firewall to be turned off or require the user to be in the Administrators group. I don't know which. Alex may follow up with a refinement of the test to allow them to run if the user is in the Administrators group. Fixes #6392. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/13421049
-
Russ Cox authored
Because we can, and because it otherwise might crash the program if we think we're out of memory. Fixes #6390. R=golang-dev, iant, minux.ma CC=golang-dev https://golang.org/cl/13345048
-
Russ Cox authored
The implementation of division in the 5 toolchain is a bit too magical. Hide the magic from the traceback routines. Also add a test for the results of the software divide routine. Fixes #5805. R=golang-dev, minux.ma CC=golang-dev https://golang.org/cl/13239052
-
Russ Cox authored
The kernel implementation of the fast system call path, the one invoked by the SYSCALL instruction, is broken for restarting system calls. A C program demonstrating this is below. Change the system calls to use INT $0x80 instead, because that (perhaps slightly slower) system call path actually works. I filed http://www.freebsd.org/cgi/query-pr.cgi?pr=182161. The C program demonstrating that it is FreeBSD's fault is below. It reports the same "Bad address" failures from wait. #include <sys/time.h> #include <sys/signal.h> #include <pthread.h> #include <unistd.h> #include <stdlib.h> #include <stdio.h> #include <string.h> static void handler(int); static void* looper(void*); int main(void) { int i; struct sigaction sa; pthread_cond_t cond; pthread_mutex_t mu; memset(&sa, 0, sizeof sa); sa.sa_handler = handler; sa.sa_flags = SA_RESTART; memset(&sa.sa_mask, 0xff, sizeof sa.sa_mask); sigaction(SIGCHLD, &sa, 0); for(i=0; i<2; i++) pthread_create(0, 0, looper, 0); pthread_mutex_init(&mu, 0); pthread_mutex_lock(&mu); pthread_cond_init(&cond, 0); for(;;) pthread_cond_wait(&cond, &mu); return 0; } static void handler(int sig) { } int mywait4(int pid, int *stat, int options, struct rusage *rusage) { int result; asm("movq %%rcx, %%r10; syscall" : "=a" (result) : "a" (7), "D" (pid), "S" (stat), "d" (options), "c" (rusage)); } static void* looper(void *v) { int pid, stat, out; struct rusage rusage; for(;;) { if((pid = fork()) == 0) _exit(0); out = mywait4(pid, &stat, 0, &rusage); if(out != pid) { printf("wait4 returned %d\n", out); } } } Fixes #6372. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/13582047
-
Rob Pike authored
Fixes #6312. R=golang-dev, dave CC=golang-dev https://golang.org/cl/13391049
-
Han-Wen Nienhuys authored
Fixes #6367. R=rsc, r CC=golang-dev https://golang.org/cl/13395047
-
Nigel Tao authored
http://golang.org/doc/go1.1#new_packages R=r CC=golang-dev https://golang.org/cl/13368053
-