- 23 Mar, 2013 2 commits
-
-
Ian Lance Taylor authored
R=golang-dev, gri CC=golang-dev https://golang.org/cl/7577049
-
Ian Lance Taylor authored
I'm not sure how to write a test for this. The change in behaviour is that if you somehow get a SIGBUS signal for an address >= 0x1000, the program will now crash rather than calling panic. As far as I know, on x86 GNU/Linux, the only way to get a SIGBUS (rather than a SIGSEGV) is to set the stack pointer to an invalid value. R=golang-dev, r CC=golang-dev https://golang.org/cl/7906045
-
- 22 Mar, 2013 27 commits
-
-
Robert Griesemer authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/7834049
-
Rob Pike authored
R=golang-dev, gri CC=golang-dev https://golang.org/cl/7496051
-
Mikio Hara authored
Also simplifies ResolveUnixAddr. R=golang-dev, dave, rsc, bradfitz CC=golang-dev https://golang.org/cl/7510047
-
Robert Griesemer authored
Also: - more consistenly use "xxx" statement rather than <code>xxx</code> statement - fix/remove unnecessary links R=golang-dev, r CC=golang-dev https://golang.org/cl/7821050
-
Rob Pike authored
R=golang-dev, rsc, jeremyjackins, gri CC=golang-dev https://golang.org/cl/7838045
-
Russ Cox authored
R=ken2 CC=golang-dev https://golang.org/cl/7838048
-
Russ Cox authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/7493048
-
Russ Cox authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/7877045
-
Rob Pike authored
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/7834047
-
Shenghou Ma authored
R=dave, rsc CC=golang-dev https://golang.org/cl/7970043
-
Julien Schmidt authored
E.g conversions from numeric types to RawBytes are missing, what makes RawBytes unusable in some cases. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/7783046
-
Russ Cox authored
Fixes #5036. R=golang-dev, r CC=golang-dev https://golang.org/cl/7531045
-
Rob Pike authored
Will help people find the rules by searching the spec by having a comment saying "missing return"; "terminating statement" does not evoke the rule to the uninitiated. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/7838044
-
Russ Cox authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/7834046
-
Russ Cox authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/7973043
-
Adam Langley authored
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/7879044
-
Jeff R. Allen authored
The GIF89a spec says: "Each image must fit within the boundaries of the Logical Screen, as defined in the Logical Screen Descriptor." Also, do not accept GIFs which have too much data for the image size. R=nigeltao, jra, r CC=bradfitz, golang-dev https://golang.org/cl/7602045
-
Joel Sing authored
On Darwin and FreeBSD, the mmap syscall return value is returned unmodified. This means that the return value will either be a valid address or a positive error number. Also check return value from mmap in SysReserve - the callers of SysReserve expect nil to be returned if the allocation failed. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/7871043
-
Joel Sing authored
Rather than just checking for ENOMEM, check for a return value of less than 4096, so that we catch other errors such as EACCES and EINVAL. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/7942043
-
Rob Pike authored
R=golang-dev, adg CC=golang-dev https://golang.org/cl/7958043
-
Oling Cat authored
R=golang-dev, nigeltao CC=golang-dev https://golang.org/cl/7835046
-
Nigel Tao authored
data does not agree with its bounds. R=r, jeff.allen CC=golang-dev https://golang.org/cl/7938043
-
Miki Tebeka authored
Change from atoi to strtol since atoi does not set errno. R=golang-dev, minux.ma, rsc, bradfitz CC=golang-dev https://golang.org/cl/7888047
-
Dominik Honnef authored
R=adonovan, cw, patrick.allen.higgins, bradfitz CC=golang-dev https://golang.org/cl/7844045
-
Brad Fitzpatrick authored
Saves over 8KB of allocations per new connection. benchmark old ns/op new ns/op delta BenchmarkServerFakeConnNoKeepAlive 28777 24927 -13.38% benchmark old allocs new allocs delta BenchmarkServerFakeConnNoKeepAlive 52 46 -11.54% benchmark old bytes new bytes delta BenchmarkServerFakeConnNoKeepAlive 13716 5286 -61.46% R=golang-dev, adg CC=golang-dev https://golang.org/cl/7799047
-
Brad Fitzpatrick authored
R=golang-dev, adg CC=golang-dev https://golang.org/cl/7927044
-
Rémy Oudompheng authored
After the revert of revision 9ea9e7e6e0c8 the related revision 76ff7da868c6 must be reverted too. Fixes #5102. R=golang-dev, r CC=golang-dev https://golang.org/cl/7961044
-
- 21 Mar, 2013 11 commits
-
-
Robert Griesemer authored
To be submitted once gc agrees. R=rsc, iant, remyoudompheng CC=golang-dev https://golang.org/cl/7861045
-
Rémy Oudompheng authored
Fixes #4813. R=golang-dev, daniel.morsing, rsc CC=golang-dev https://golang.org/cl/7625050
-
Robert Griesemer authored
-notes="BUG|TODO" instead of -notes="BUG,TODO". Permits -notes=".*" to see all notes. R=cnicolaou CC=golang-dev https://golang.org/cl/7951043
-
Rob Pike authored
Also fix the examples to use stderr for errors. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/7716052
-
Brad Fitzpatrick authored
If a handler didn't consume all its Request.Body, child.go was closing the socket while the host was still writing to it, causing the child to send a RST and the host (at least nginx) to send an empty response body. Now, we tell the host we're done with the request/response first, and then close our input pipe after consuming a bit of it. Consuming the body fixes the problem, and flushing to the host first to tell it that we're done increases the chance that the host cuts off further data to us, meaning we won't have much to consume. No new tests, because this package is lacking in tests. Tested by hand with nginx. See issue for testing details. Fixes #4183 R=golang-dev, rsc CC=golang-dev https://golang.org/cl/7939045
-
Russ Cox authored
Also adjust the implementation of applyRelocationsAMD64 so that the test added in CL 6848044 still passes. R=golang-dev, minux.ma CC=golang-dev https://golang.org/cl/7686049
-
Russ Cox authored
Fixes #1517. R=golang-dev, r CC=golang-dev https://golang.org/cl/7906043
-
Rob Pike authored
Only the net stuff remains as significant work in the "minor changes" section. R=golang-dev, dave, elias.naur, rsc CC=golang-dev https://golang.org/cl/7933044
-
Russ Cox authored
XOR key into data 128 bits at a time instead of 64 bits and pipeline half of state loads. Rotate loop to allow single-register indexing for state[i]. On a MacBookPro10,2 (Core i5): benchmark old ns/op new ns/op delta BenchmarkRC4_128 412 224 -45.63% BenchmarkRC4_1K 3179 1613 -49.26% BenchmarkRC4_8K 25223 12545 -50.26% benchmark old MB/s new MB/s speedup BenchmarkRC4_128 310.51 570.42 1.84x BenchmarkRC4_1K 322.09 634.48 1.97x BenchmarkRC4_8K 320.97 645.32 2.01x For comparison, on the same machine, openssl 0.9.8r reports its rc4 speed as somewhat under 350 MB/s for both 1K and 8K (it is operating 64 bits at a time). On an Intel Xeon E5520: benchmark old ns/op new ns/op delta BenchmarkRC4_128 418 259 -38.04% BenchmarkRC4_1K 3200 1884 -41.12% BenchmarkRC4_8K 25173 14529 -42.28% benchmark old MB/s new MB/s speedup BenchmarkRC4_128 306.04 492.48 1.61x BenchmarkRC4_1K 319.93 543.26 1.70x BenchmarkRC4_8K 321.61 557.20 1.73x For comparison, on the same machine, openssl 1.0.1 reports its rc4 speed as 587 MB/s for 1K and 601 MB/s for 8K. R=agl CC=golang-dev https://golang.org/cl/7865046
-
Shenghou Ma authored
fix code that implicitly assumes little-endian machines. R=golang-dev, bradfitz, rsc, alex.brainman CC=golang-dev https://golang.org/cl/6792043
-
Shenghou Ma authored
gcc generates only attr DW_AT_byte_size for DW_TAG_pointer_type of "void *", but we used to also generate DW_AT_type pointing to imaginary unspecified type "void", which confuses some gdb. This change makes old Apple gdb 6.x (specifically, Apple version gdb-1515) accepts our binary without issue like this: (gdb) b 'main.main' Die: DW_TAG_unspecified_type (abbrev = 10, offset = 47079) has children: FALSE attributes: DW_AT_name (DW_FORM_string) string: "void" Dwarf Error: Cannot find type of die [in module /Users/minux/go/go2.hg/bin/go] Special thanks to Russ Cox for pointing out the problem in comment #6 of CL 7891044. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/7744051
-