Commits · c9152a8568fd49b2e7a5dd689005098487a6178d · go / golang

12 Jul, 2011 19 commits

runtime: eliminate contention during stack allocation · c9152a85

Dmitriy Vyukov authored Jul 12, 2011

Standard-sized stack frames use plain malloc/free
instead of centralized lock-protected FixAlloc.
Benchmark results on HP Z600 (2 x Xeon E5620, 8 HT cores, 2.40GHz)
are as follows:
benchmark                                        old ns/op    new ns/op    delta
BenchmarkStackGrowth                               1045.00       949.00   -9.19%
BenchmarkStackGrowth-2                             3450.00       800.00  -76.81%
BenchmarkStackGrowth-4                             5076.00       513.00  -89.89%
BenchmarkStackGrowth-8                             7805.00       471.00  -93.97%
BenchmarkStackGrowth-16                           11751.00       321.00  -97.27%

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4657091

c9152a85

sync: improve RWMutex performance · daaf29cf

Dmitriy Vyukov authored Jul 12, 2011

The new implementation features wait-free
fast path for readers which significantly improves
performance/scalability on read-mostly workloads.
Benchmark results on HP Z600 (2 x Xeon E5620, 8 HT cores, 2.40GHz)
are as follows:
benchmark old ns/op new ns/op delta
BenchmarkRWMutexUncontended 179.00 96.60 -46.03%
BenchmarkRWMutexUncontended-2 89.10 49.10 -44.89%
BenchmarkRWMutexUncontended-4 44.70 24.70 -44.74%
BenchmarkRWMutexUncontended-8 23.30 12.90 -44.64%
BenchmarkRWMutexUncontended-16 16.80 8.75 -47.92%
BenchmarkRWMutexWrite100 79.60 26.80 -66.33%
BenchmarkRWMutexWrite100-2 305.00 33.00 -89.18%
BenchmarkRWMutexWrite100-4 245.00 113.00 -53.88%
BenchmarkRWMutexWrite100-8 330.00 147.00 -55.45%
BenchmarkRWMutexWrite100-16 371.00 152.00 -59.03%
BenchmarkRWMutexWrite10 78.30 29.80 -61.94%
BenchmarkRWMutexWrite10-2 348.00 165.00 -52.59%
BenchmarkRWMutexWrite10-4 447.00 199.00 -55.48%
BenchmarkRWMutexWrite10-8 564.00 180.00 -68.09%
BenchmarkRWMutexWrite10-16 492.00 192.00 -60.98%
BenchmarkRWMutexWorkWrite100 1077.00 1037.00 -3.71%
BenchmarkRWMutexWorkWrite100-2 659.00 596.00 -9.56%
BenchmarkRWMutexWorkWrite100-4 509.00 361.00 -29.08%
BenchmarkRWMutexWorkWrite100-8 603.00 351.00 -41.79%
BenchmarkRWMutexWorkWrite100-16 750.00 607.00 -19.07%
BenchmarkRWMutexWorkWrite10 990.00 951.00 -3.94%
BenchmarkRWMutexWorkWrite10-2 1119.00 1070.00 -4.38%
BenchmarkRWMutexWorkWrite10-4 1300.00 1199.00 -7.77%
BenchmarkRWMutexWorkWrite10-8 1424.00 1291.00 -9.34%
BenchmarkRWMutexWorkWrite10-16 1981.00 1786.00 -9.84%

R=rsc
CC=golang-dev
https://golang.org/cl/4671051

daaf29cf

effective go: tweak the words about semicolons, parens in control structures, · 4c631295
Rob Pike authored Jul 12, 2011
```
and make and new.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4699043
```
4c631295

hash/crc32: add SSE4.2 support · 9f4c288c

Adam Langley authored Jul 12, 2011

Using the CRC32 instruction speeds up the Castagnoli computation by
about 20x on a modern Intel CPU.

R=rsc
CC=golang-dev
https://golang.org/cl/4650072

9f4c288c

go/build: include processing of .c files for cgo packages · 0f8678a7
Alex Brainman authored Jul 12, 2011
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4696041
```
0f8678a7

image: remove superfluous if condition. · 851ded96

Nigel Tao authored Jul 12, 2011

DrawMask already returns early if r.Empty().

R=r
CC=golang-dev
https://golang.org/cl/4703041

851ded96

image: re-organize draw.go. · caaa6764

Nigel Tao authored Jul 12, 2011

There are no behavioral changes, only some copy-and-pastes.

Before, drawFillOver was next to drawCopyOver.

After, drawFillOver is next to drawFillSrc, which is more similar to
drawFillOver than drawCopyOver is.

Similarly, drawCopyOver is now next to drawCopySrc, etc.

R=r
CC=golang-dev
https://golang.org/cl/4695045

caaa6764

image: change Pix from []FooColor to []uint8. · 8bd50895

Nigel Tao authored Jul 12, 2011

Some benchmark numbers below. The image/draw fast-paths show dramatic
improvement, the generic slow-paths show a smaller slow-down.

BEFORE
png.BenchmarkEncodePaletted      200       8203800 ns/op      37.45 MB/s
png.BenchmarkEncodeRGBOpaque         100      26940440 ns/op      45.61 MB/s
png.BenchmarkEncodeRGBA       20      73821000 ns/op      16.65 MB/s
jpeg.BenchmarkEncodeRGBOpaque         50      35598640 ns/op      34.52 MB/s
draw.BenchmarkFillOver	     500	   4024226 ns/op
draw.BenchmarkFillSrc	   10000	    152736 ns/op
draw.BenchmarkCopyOver	     500	   3452824 ns/op
draw.BenchmarkCopySrc	   50000	     73218 ns/op
draw.BenchmarkNRGBAOver	     500	   3941234 ns/op
draw.BenchmarkNRGBASrc	    1000	   2484400 ns/op
draw.BenchmarkYCbCr	    1000	   2609005 ns/op
draw.BenchmarkGlyphOver	    2000	   1169575 ns/op
draw.BenchmarkRGBA	     200	   9031390 ns/op
draw.BenchmarkGenericOver	      50	  34636620 ns/op
draw.BenchmarkGenericMaskOver	     100	  16561150 ns/op
draw.BenchmarkGenericSrc	     100	  13873760 ns/op
draw.BenchmarkGenericMaskSrc	     100	  25198860 ns/op

AFTER
png.BenchmarkEncodePaletted      200       8206600 ns/op      37.43 MB/s
png.BenchmarkEncodeRGBOpaque         100      26129530 ns/op      47.03 MB/s
png.BenchmarkEncodeRGBA       20      75776750 ns/op      16.22 MB/s
jpeg.BenchmarkEncodeRGBOpaque         50      37192940 ns/op      33.04 MB/s
draw.BenchmarkFillOver	     500	   3008134 ns/op
draw.BenchmarkFillSrc	   10000	    154214 ns/op
draw.BenchmarkCopyOver	    1000	   2169988 ns/op
draw.BenchmarkCopySrc	   50000	     73095 ns/op
draw.BenchmarkNRGBAOver	    1000	   2491079 ns/op
draw.BenchmarkNRGBASrc	    2000	   1361244 ns/op
draw.BenchmarkYCbCr	    1000	   2554269 ns/op
draw.BenchmarkGlyphOver	    2000	   1042225 ns/op
draw.BenchmarkRGBA	     100	  10233340 ns/op
draw.BenchmarkGenericOver	      50	  38421560 ns/op
draw.BenchmarkGenericMaskOver	     100	  17521190 ns/op
draw.BenchmarkGenericSrc	     100	  16351200 ns/op
draw.BenchmarkGenericMaskSrc	     100	  26538190 ns/op

R=r
CC=golang-dev
https://golang.org/cl/4675076

8bd50895

image/draw: add benchmarks. · 6ec6f1ef
Nigel Tao authored Jul 12, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4695043
```
6ec6f1ef
doc: document r58.1 · 1002e82f
Russ Cox authored Jul 12, 2011
```
R=adg, dsymonds
CC=golang-dev
https://golang.org/cl/4700041
```
1002e82f

runtime: eliminate false sharing on runtime.goidgen · 013ad89c

Dmitriy Vyukov authored Jul 12, 2011

runtime.goidgen can be quite frequently modified and
shares cache line with the following variables,
it leads to false sharing.
50c6b0 b nfname
50c6b4 b nfunc
50c6b8 b nfunc$17
50c6bc b nhist$17
50c6c0 B runtime.checking
50c6c4 B runtime.gcwaiting
50c6c8 B runtime.goidgen
50c6cc B runtime.gomaxprocs
50c6d0 B runtime.panicking
50c6d4 B strconv.IntSize
50c6d8 B src/pkg/runtime/_xtest_.ss
50c6e0 B src/pkg/runtime/_xtest_.stop
50c6e8 b addrfree
50c6f0 b addrmem
50c6f8 b argv

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4673054

013ad89c

runtime: eliminate false sharing on random number generators · 909f3187

Dmitriy Vyukov authored Jul 12, 2011

Use machine-local random number generator instead of
racy global ones.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4674049

909f3187

runtime: fix data race on runtime·maxstring · f9f21aa1

Dmitriy Vyukov authored Jul 12, 2011

The data race can lead to erroneous output of
"[invalid string]" instead of a string.

R=golang-dev
CC=golang-dev
https://golang.org/cl/4678049

f9f21aa1

6l: change default output name to 6.out.exe on windows · 8ed9fc60
Alex Brainman authored Jul 12, 2011
```
R=golang-dev, vcc.163
CC=golang-dev
https://golang.org/cl/4670049
```
8ed9fc60
http: support for periodic flushing in ReverseProxy · ce3c3953
Brad Fitzpatrick authored Jul 12, 2011
```
Fixes #2012

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4662091
```
ce3c3953

exp/template: make numbers adhere to Go's rules for ideal constants. · 7c477418

Rob Pike authored Jul 12, 2011

Without further type informatnion, 1.0 is a float and an integer
must fit in an int.

R=rsc
CC=golang-dev
https://golang.org/cl/4696042

7c477418

go/build: make Nuke comment say what it does · 05c89edc
Alex Brainman authored Jul 12, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4697041
```
05c89edc
codereview: fix for Mercurial 1.9 · 87d71a38
Andrew Gerrand authored Jul 12, 2011
```
R=golang-dev, mirtchovski, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/4686049
```
87d71a38
doc: don't specify make target for working on windwos. · 34bac8bc
Yasuhiro Matsumoto authored Jul 12, 2011
```
makehtml does not work on windows.

R=golang-dev, adg, rsc
CC=golang-dev
https://golang.org/cl/4675041
```
34bac8bc

11 Jul, 2011 14 commits

undo CL 4675045 / 0e11e08951f7 · b4f0e8ff

Andrew Gerrand authored Jul 11, 2011

Breaks Mercurial 1.8.3.

««« original CL description
codereview: fix for Mercurial 1.9

Fixes #2038.

R=rsc, bobbypowers
CC=golang-dev
https://golang.org/cl/4675045
»»»

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4685055

b4f0e8ff

codereview: fix for Mercurial 1.9 · 762ea790
Andrew Gerrand authored Jul 11, 2011
```
Fixes #2038.

R=rsc, bobbypowers
CC=golang-dev
https://golang.org/cl/4675045
```
762ea790

cgi: close stdout reader pipe when finished · 1722ec22

Brad Fitzpatrick authored Jul 11, 2011

This causes the child, if still writing, to get an error or
SIGPIPE and most likely exit so our subsequent wait can
finish.

A more guaranteed fix would be putting a time limit on the
child's overall execution, but this fixes the problem
I was having.

Fixes #2059

R=rsc
CC=golang-dev
https://golang.org/cl/4675081

1722ec22

os: don't permit Process.Signal after a successful Wait · d53385fd
Brad Fitzpatrick authored Jul 11, 2011
```
R=dsymonds, rsc
CC=golang-dev
https://golang.org/cl/4689043
```
d53385fd

exec: closeAfterWait append bug · d1f4e0d1

Brad Fitzpatrick authored Jul 11, 2011

Wasn't actually eager closing the fds as a result of the
copy/paste bug. (GC was doing it instead)

R=rsc
CC=golang-dev
https://golang.org/cl/4671057

d1f4e0d1

json: encode \r and \n in strings as e.g. "\n", not "\u000A" · 2f69a735

Evan Martin authored Jul 11, 2011

This is allowed by the JSON spec and is shorter/easier to read.

R=golang-dev, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/4678046

2f69a735

strconv: handle [-+]Infinity in atof · f19b24a1

Brad Fitzpatrick authored Jul 11, 2011

This is the form as returned by Postgres, as well
as JavaScript.

I've tried and failed to find authorative docs online
about the proper string serialization, if any.

R=golang-dev, gri, r, r, rsc
CC=golang-dev
https://golang.org/cl/4650077

f19b24a1

exp/template: fix bug in argument evaluation. · d366c369

Rob Pike authored Jul 11, 2011

Must keep dot and the receiver separate - variables broke that symmetry.
Also clean up function invocation and rename "data" to "dot" for clarity.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4678048

d366c369

go/build: use os.MkdirAll to create directories · 3c6a7b3f

Alex Brainman authored Jul 11, 2011

Replaces "mkdir -p ..." command, as Windows mkdir command
does not support -p flag. Also, is simpler and faster then
launching new process.

R=golang-dev, mattn.jp, adg, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/4626087

3c6a7b3f

exp/template: fields and methods on variables. · 7b79b3b2

Rob Pike authored Jul 11, 2011

Not strictly necessary (you could achieve the same, clumsily,
via with blocks) but great to have: $x.Field, $y.Method.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4678047

7b79b3b2

exp/template: documentation glitches and typos. · 96bbcc42

Rob Pike authored Jul 11, 2011

Also explain that len(v)==0 makes v a 'zero value'
in template execution.

R=golang-dev, dsymonds, adg, r
CC=golang-dev
https://golang.org/cl/4691041

96bbcc42

exp/template: simpler parse of char constants. · 0027dc91

Rob Pike authored Jul 11, 2011

We can avoid the check against empty constants (''),
which UnquoteChar doesn't handle well, by leaving on
the trailing quote and seeing that's all we have left at the end.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4657090

0027dc91

exp/template: character constants. · bf9531f8

Rob Pike authored Jul 11, 2011

Easier to implement than to justify leaving them out.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4662089

bf9531f8

exp/template: static check for defined variables. · e7030e7f

Rob Pike authored Jul 11, 2011

Worth catching at parse time rather than execution. Plus it's really easy.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4641100

e7030e7f

10 Jul, 2011 6 commits

exp/eval: delete binary · 1fe9c9a7

Rob Pike authored Jul 10, 2011

Mistakenly checked in.
Fixes #2058.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4670057

1fe9c9a7

flag: make -help nicer. · e44853c9

Rob Pike authored Jul 10, 2011

- suppress the print that -help is not defined.
- return a special error code if -help is set
- do not change behavior if an explict "help" flag is defined.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4641099

e44853c9

exp/template: add functions print and println. · abae8471
Rob Pike authored Jul 10, 2011
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4687041
```
abae8471
exp/template: package documentation · 4acddca4
Rob Pike authored Jul 10, 2011
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4675072
```
4acddca4

image: change Pix[0] to mean top-left corner of an image's Rect instead · 87d9e7e1

Nigel Tao authored Jul 10, 2011

of the origin.

image/png and image/jpeg benchmarks show no significant changes.

The image/draw changes suggest to me that making a gofix for this is not
feasible. People are just going to have to make manual fixes.

R=r
CC=golang-dev
https://golang.org/cl/4681044

87d9e7e1

archive/zip: add Writer · 4d47600f
Andrew Gerrand authored Jul 10, 2011
```
R=bradfitz, dchest, r, rsc
CC=golang-dev
https://golang.org/cl/4523077
```
4d47600f

09 Jul, 2011 1 commit
- multipart: use textproto to handle multiline header · e45b3213
  Evan Martin authored Jul 09, 2011
```
R=bradfitz
CC=golang-dev
https://golang.org/cl/4686044
```
  e45b3213