- 12 Dec, 2013 1 commit
-
-
Josh Bleecher Snyder authored
If the return was reached, then hostsPath would not be properly restored to its original value. See the (lengthy) discussion at https://golang.org/cl/15960047/ I assume that this is not for Go 1.2; mailing now since I promised to do so. I will plan to ping once Go 1.2 is out. R=rsc, bradfitz CC=golang-dev https://golang.org/cl/16200043
-
- 11 Dec, 2013 6 commits
-
-
Adam Langley authored
Fixes #6633. R=golang-dev, r CC=golang-dev https://golang.org/cl/40720046
-
Han-Wen Nienhuys authored
and GCM on 386 and amd64 Intel(R) Core(TM) i5-2540M CPU @ 2.60GHz: benchmark old MB/s new MB/s speedup BenchmarkAESGCMSeal1K 82.39 92.05 1.12x BenchmarkAESGCMOpen1K 82.28 91.88 1.12x BenchmarkAESCFBEncrypt1K 141.54 277.59 1.96x BenchmarkAESCFBDecrypt1K 133.06 278.07 2.09x BenchmarkAESOFB1K 160.51 380.24 2.37x BenchmarkAESCTR1K 164.07 429.25 2.62x BenchmarkAESCBCEncrypt1K 170.99 263.74 1.54x BenchmarkAESCBCDecrypt1K 124.96 249.14 1.99x Fixes #6741. R=agl, dave, agl CC=golang-dev https://golang.org/cl/24250044
-
Russ Cox authored
When I renamed LAddr back to Addr (before sending the original linker CLs), I missed the .y files in my global substitute. Since the .y files are only processed when running make in one of those directories (not during all.bash), they were behind the generated files. R=golang-dev, iant CC=golang-dev https://golang.org/cl/40770044
-
Joel Sing authored
Benchmark on Intel(R) Xeon(R) CPU X5650 @ 2.67GHz benchmark old ns/op new ns/op delta BenchmarkHash8Bytes 1259 677 -46.23% BenchmarkHash1K 14387 6749 -53.09% BenchmarkHash8K 106006 50107 -52.73% benchmark old MB/s new MB/s speedup BenchmarkHash8Bytes 6.35 11.81 1.86x BenchmarkHash1K 71.17 151.72 2.13x BenchmarkHash8K 77.28 163.49 2.12x R=agl CC=golang-dev https://golang.org/cl/28460043
-
Shenghou Ma authored
Fixes #6911. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/38690043
-
Andrew Gerrand authored
The ambiguity has gone on too long. R=golang-dev, minux.ma, r, dsymonds CC=golang-dev https://golang.org/cl/39920043
-
- 10 Dec, 2013 19 commits
-
-
Oling Cat authored
R=golang-dev, minux.ma CC=golang-dev https://golang.org/cl/37700043
-
Ian Lance Taylor authored
There is no necessary relationship between the imports of the packages a and b, and gccgo happens to import them in a different order, leading to different output. This ordering is not the purpose of the test in any case. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/40400043
-
Carl Shapiro authored
R=golang-dev, iant CC=golang-dev https://golang.org/cl/39810043
-
Adam Langley authored
(Reporter wasn't able to provide a certificate chain that uses this feature for testing.) Fixes #6831 R=golang-dev, bradfitz, r CC=golang-dev https://golang.org/cl/40340043
-
Russ Cox authored
Among other things, it makes it easier to scan to see what is slow. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/40040044
-
Ian Lance Taylor authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/40310043
-
David du Colombier authored
R=ality, golang-dev, r, rsc CC=golang-dev https://golang.org/cl/39640043
-
Joel Sing authored
Skip routing messages with a mismatched version, rather than failing and returning EINVAL. Only return EINVAL if we were unable to parse any of the routing messages (presumably due to a version mismatch). R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/30340043
-
Alberto García Hierro authored
The final condition (db.maxIdleConnsLocked() > db.freeConn.Len()) can only be true iff db.maxIdleConnsLocked() is greater than 0, so previously checking if it's greater than 0 is a waste, specially when that involves a method call which (ATM) can't be inlined and includes a switch. Dissasembly follows (test for err == nil has been omitted for clarity): Before: 43c357: cmp $0x0,%bl 43c35a: jne 43c3ce <database/sql.(*DB).putConnDBLocked+0x1ce> 43c35c: mov %rax,(%rsp) 43c360: callq 43aec0 <database/sql.(*DB).maxIdleConnsLocked> 43c365: mov 0x8(%rsp),%rbx 43c36a: cmp $0x0,%rbx 43c36e: jle 43c3ce <database/sql.(*DB).putConnDBLocked+0x1ce> 43c370: mov 0x30(%rsp),%rbx 43c375: mov %rbx,(%rsp) 43c379: callq 43aec0 <database/sql.(*DB).maxIdleConnsLocked> 43c37e: mov 0x30(%rsp),%rdx 43c383: mov 0x8(%rsp),%rcx 43c388: mov 0x28(%rdx),%rbp 43c38c: mov 0x28(%rbp),%rbx 43c390: cmp %rcx,%rbx 43c393: jge 43c3ce <database/sql.(*DB).putConnDBLocked+0x1ce> 43c395: mov 0x28(%rdx),%rbp 43c399: mov %rbp,(%rsp) 43c39d: mov 0x38(%rsp),%rcx 43c3a2: mov $0x556c60,%eax 43c3a7: mov %rax,0x8(%rsp) 43c3ac: mov %rcx,0x10(%rsp) 43c3b1: callq 4db5b0 <container/list.(*List).PushFront> After: 43c357: cmp $0x0,%bl 43c35a: jne 43c3b5 <database/sql.(*DB).putConnDBLocked+0x1b5> 43c35c: mov %rax,(%rsp) 43c360: callq 43aec0 <database/sql.(*DB).maxIdleConnsLocked> 43c365: mov 0x30(%rsp),%rdx 43c36a: mov 0x8(%rsp),%rcx 43c36f: mov 0x28(%rdx),%rbp 43c373: mov 0x28(%rbp),%rbx 43c377: cmp %rcx,%rbx 43c37a: jge 43c3b5 <database/sql.(*DB).putConnDBLocked+0x1b5> 43c37c: mov 0x28(%rdx),%rbp 43c380: mov %rbp,(%rsp) 43c384: mov 0x38(%rsp),%rcx 43c389: mov $0x556c60,%eax 43c38e: mov %rax,0x8(%rsp) 43c393: mov %rcx,0x10(%rsp) 43c398: callq 4db590 <container/list.(*List).PushFront> R=golang-dev, bradfitz, iant CC=golang-dev https://golang.org/cl/14656044
-
Mikio Hara authored
R=golang-dev, dave, adg CC=golang-dev https://golang.org/cl/27430043
-
Shenghou Ma authored
CL 36800043 and CL 36930044 have a merge conflict that I overlooked. R=golang-dev CC=golang-dev https://golang.org/cl/39850043
-
Shenghou Ma authored
Fixes #6849. Fixes #6867. R=golang-dev, agl CC=golang-dev https://golang.org/cl/35870043
-
Shenghou Ma authored
Three changes: 1. mention "move" to clarify things up. 2. use {old,new}path instead of {old,new}name, which makes it clear what relative path would do here. 3. mention "OS-specific restrictions might apply". Fixes #6887. R=golang-dev, alex.brainman, iant, r CC=golang-dev https://golang.org/cl/36930044
-
Shenghou Ma authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/38920043
-
Carl Shapiro authored
Fixes #6899 R=golang-dev, r, cshapiro, iant, rsc CC=golang-dev https://golang.org/cl/38120043
-
Alex Brainman authored
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/39780043
-
Russ Cox authored
Nothing looks at __.SYMDEF, and the object file format is changing. R=golang-dev, r CC=golang-dev https://golang.org/cl/39580044
-
Russ Cox authored
The linker is in charge of providing the one true declaration. R=golang-dev, dave, r CC=golang-dev https://golang.org/cl/39560043
-
Alex Brainman authored
Fixes #6833 R=minux.ma, iant CC=golang-dev https://golang.org/cl/35790045
-
- 09 Dec, 2013 14 commits
-
-
Anthony Martin authored
R=golang-dev, 0intro, rsc CC=golang-dev https://golang.org/cl/39680044
-
David du Colombier authored
warning: src/cmd/8c/list.c:124 format mismatch d VLONG, arg 3 warning: src/cmd/8c/list.c:134 format mismatch d VLONG, arg 3 warning: src/cmd/8c/list.c:142 format mismatch d VLONG, arg 3 warning: src/cmd/8c/list.c:152 format mismatch d VLONG, arg 3 warning: src/cmd/8c/list.c:156 format mismatch d VLONG, arg 4 warning: src/cmd/8c/list.c:160 format mismatch d VLONG, arg 4 warning: src/cmd/8c/list.c:165 format mismatch d VLONG, arg 4 warning: src/cmd/8c/list.c:167 format mismatch d VLONG, arg 3 warning: src/cmd/8c/list.c:172 format mismatch d VLONG, arg 4 warning: src/cmd/8c/list.c:174 format mismatch d VLONG, arg 3 warning: src/cmd/8c/list.c:178 format mismatch d VLONG, arg 3 warning: src/cmd/8c/list.c:184 format mismatch d VLONG, arg 3 warning: src/cmd/8g/list.c:91 format mismatch d VLONG, arg 4 warning: src/cmd/8g/list.c:100 format mismatch d VLONG, arg 4 warning: src/cmd/8g/list.c:114 format mismatch d VLONG, arg 5 warning: src/cmd/8g/list.c:118 format mismatch d VLONG, arg 5 warning: src/cmd/8g/list.c:122 format mismatch d VLONG, arg 5 warning: src/cmd/8g/list.c:126 format mismatch d VLONG, arg 5 warning: src/cmd/8g/list.c:136 format mismatch d VLONG, arg 4 warning: src/cmd/8l/list.c:107 format mismatch d VLONG, arg 4 warning: src/cmd/8l/list.c:125 format mismatch ux VLONG, arg 4 warning: src/cmd/8l/list.c:128 format mismatch ux VLONG, arg 4 warning: src/cmd/8l/list.c:130 format mismatch d VLONG, arg 4 warning: src/cmd/8l/list.c:134 format mismatch d VLONG, arg 5 warning: src/cmd/8l/list.c:138 format mismatch d VLONG, arg 6 warning: src/cmd/8l/list.c:143 format mismatch d VLONG, arg 5 warning: src/cmd/8l/list.c:148 format mismatch d VLONG, arg 5 warning: src/cmd/8l/list.c:150 format mismatch d VLONG, arg 4 warning: src/cmd/8l/list.c:154 format mismatch d VLONG, arg 4 warning: src/cmd/8l/list.c:158 format mismatch d VLONG, arg 4 warning: src/cmd/8l/obj.c:132 format mismatch ux VLONG, arg 2 R=golang-dev, rsc CC=golang-dev https://golang.org/cl/39710043
-
Anthony Martin authored
Fixes a regression introduced in revision 4cb93e2900d0. That revision changed runtime·memmove to use SSE MOVOU instructions for sizes between 17 and 256 bytes. We were using memmove to save a copy of the note string during the note handler. The Plan 9 kernel does not allow the use of floating point in note handlers (which includes MOVOU since it touches the XMM registers). Arguably, runtime·memmove should not be using MOVOU when GO386=387 but that wouldn't help us on amd64. It's very important that we guard against any future changes so we use a simple copy loop instead. This change is extracted from CL 9796043 (since that CL is still being ironed out). R=rsc CC=golang-dev https://golang.org/cl/34640045
-
Russ Cox authored
R=golang-dev, minux.ma, iant CC=golang-dev https://golang.org/cl/36300045
-
Anthony Martin authored
R=jas, lucio.dere, rsc CC=golang-dev https://golang.org/cl/14604047
-
Carl Shapiro authored
The funcdata symbol incorrectly named the dead value map the dead pointer map. The dead value map identifies all dead values, including pointers and non-pointers, in a stack frame. The purpose of this map is to allow the runtime to poison locations of dead data to catch lost invariants. R=golang-dev, iant CC=golang-dev https://golang.org/cl/38670043
-
Russ Cox authored
TBR=iant CC=golang-dev https://golang.org/cl/39540043
-
Russ Cox authored
TBR=iant CC=golang-dev https://golang.org/cl/39530043
-
Russ Cox authored
R=golang-dev, iant CC=golang-dev https://golang.org/cl/36300044
-
Russ Cox authored
TBR=iant CC=golang-dev https://golang.org/cl/39510043
-
Russ Cox authored
TBR=iant CC=golang-dev https://golang.org/cl/39400044
-
Russ Cox authored
That option turns off word wrapping of individual error messages generated by clang. The wrapping makes the errors harder to read and conflicts with the idea of a terminal window that can be resized. R=golang-dev, r CC=golang-dev https://golang.org/cl/35810043
-
David du Colombier authored
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/39280043
-
Russ Cox authored
The new linker will disallow this on arm (it is already disallowed on amd64 and 386) in order to be able to lay out each function separately. The restriction is only for jumps into the middle of a function; jumps to the beginning of a function remain fine. Prereq for linker cleanup (golang.org/s/go13linker). R=iant, r, minux.ma CC=golang-dev https://golang.org/cl/35800043
-