Commits · d03611f628c65321b572ab0d4ce85cc61b759fc6 · go / golang

15 Nov, 2011 10 commits

allow copy of struct containing unexported fields · d03611f6

Russ Cox authored Nov 15, 2011

An experiment: allow structs to be copied even if they
contain unexported fields.  This gives packages the
ability to return opaque values in their APIs, like reflect
does for reflect.Value but without the kludgy hacks reflect
resorts to.

In general, we trust programmers not to do silly things
like *x = *y on a package's struct pointers, just as we trust
programmers not to do unicode.Letter = unicode.Digit,
but packages that want a harder guarantee can introduce
an extra level of indirection, like in the changes to os.File
in this CL or by using an interface type.

All in one CL so that it can be rolled back more easily if
we decide this is a bad idea.

Originally discussed in March 2011.
https://groups.google.com/group/golang-dev/t/3f5d30938c7c45ef

R=golang-dev, adg, dvyukov, r, bradfitz, jan.mercl, gri
CC=golang-dev
https://golang.org/cl/5372095

d03611f6

strconv: make Ftoa faster · 0ed5e6a2

Russ Cox authored Nov 15, 2011

Make code amenable to escape analysis
so that the decimal values do not escape.

benchmark old ns/op new ns/op delta
strconv_test.BenchmarkAtof64Decimal 229 233 +1.75%
strconv_test.BenchmarkAtof64Float 261 263 +0.77%
strconv_test.BenchmarkAtof64FloatExp 7760 7757 -0.04%
strconv_test.BenchmarkAtof64Big 3086 3053 -1.07%
strconv_test.BenchmarkFtoa64Decimal 6866 2629 -61.71%
strconv_test.BenchmarkFtoa64Float 7211 3064 -57.51%
strconv_test.BenchmarkFtoa64FloatExp 12587 8263 -34.35%
strconv_test.BenchmarkFtoa64Big 7058 2825 -59.97%
json.BenchmarkCodeEncoder 357355200 276528200 -22.62%
json.BenchmarkCodeMarshal 360735200 279646400 -22.48%
json.BenchmarkCodeDecoder 731528600 709460600 -3.02%
json.BenchmarkCodeUnmarshal 754774400 731051200 -3.14%
json.BenchmarkCodeUnmarshalReuse 713379000 704218000 -1.28%
json.BenchmarkSkipValue 51594300 51682600 +0.17%

benchmark old MB/s new MB/s speedup
json.BenchmarkCodeEncoder 5.43 7.02 1.29x
json.BenchmarkCodeMarshal 5.38 6.94 1.29x
json.BenchmarkCodeDecoder 2.65 2.74 1.03x
json.BenchmarkCodeUnmarshal 2.57 2.65 1.03x
json.BenchmarkCodeUnmarshalReuse 2.72 2.76 1.01x
json.BenchmarkSkipValue 38.61 38.55 1.00x

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5369111

0ed5e6a2

runtime: avoid allocation for make([]T, 0) · 94c2536e
Russ Cox authored Nov 15, 2011
```
R=gri, iant, iant
CC=golang-dev
https://golang.org/cl/5375093
```
94c2536e
strconv: add Ftoa benchmarks · 276473cd
Russ Cox authored Nov 15, 2011
```
R=bradfitz
CC=golang-dev
https://golang.org/cl/5373096
```
276473cd
encoding/json: add marshal/unmarshal benchmark · 552a556a
Russ Cox authored Nov 15, 2011
```
R=bradfitz
CC=golang-dev
https://golang.org/cl/5387041
```
552a556a

net/http: fix build · 8998673c

Mikio Hara authored Nov 15, 2011

empty is already not a nil.

R=golang-dev, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/5376099

8998673c

html: auto-close <p> elements when starting <form> element. · b91d8225

Andrew Balholm authored Nov 15, 2011

Pass tests2.dat, test 26:
<!doctypehtml><p><form>

| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     <p>
|     <form>

Also pass tests through test 32:
<!DOCTYPE html><!-- X

R=nigeltao
CC=golang-dev
https://golang.org/cl/5369114

b91d8225

xml: fix build · a619da9f

Mikio Hara authored Nov 15, 2011

empty is already not a nil.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5376098

a619da9f

go/build: fix build · 301701d8

Mikio Hara authored Nov 15, 2011

empty is already not a nil.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5375097

301701d8

html: parse and render <plaintext> elements · 3bd5082f

Andrew Balholm authored Nov 15, 2011

Pass tests2.dat, test 10:
<table><plaintext><td>

| <html>
|   <head>
|   <body>
|     <plaintext>
|       "<td>"
|     <table>

Also pass tests through test 25:
<!doctypehtml><p><dd>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5369109

3bd5082f

14 Nov, 2011 30 commits

math/big: replace nat{} -> nat(nil) · f5cf0a48

Robert Griesemer authored Nov 14, 2011

No need for creating a new nat each time.
Per Roger Peppe's suggestion; assuming
nat(nil) produces better code than nat{}.

R=rsc
CC=golang-dev
https://golang.org/cl/5375092

f5cf0a48

cgi: make test code more readable · 4bd15ae1
Brad Fitzpatrick authored Nov 14, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5375089
```
4bd15ae1
reflect: empty slice/map is not DeepEqual to nil · 4e65478c
Russ Cox authored Nov 14, 2011
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5373095
```
4e65478c

fmt: distinguish empty vs nil slice/map in %#v · a7f1e10d

Russ Cox authored Nov 14, 2011

Also update Scanf tests to cope with DeepEqual
distinguishing empty vs nil slice.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5375091

a7f1e10d

encoding/json: decode [] as empty slice, not nil slice · 53523f6a

Russ Cox authored Nov 14, 2011

Test was already present, but bug in reflect.DeepEqual hid this bug.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5375090

53523f6a

6l, 8l: add missing space in error message · 11fe7cd6
Lucio De Re authored Nov 14, 2011
```
R=golang-dev
CC=golang-dev, rsc
https://golang.org/cl/5374085
```
11fe7cd6

crypto/tls: fix handshake message test · 1df62ca6

Russ Cox authored Nov 14, 2011

This test breaks when I make reflect.DeepEqual
distinguish empty slices from nil slices.

R=agl
CC=golang-dev
https://golang.org/cl/5369110

1df62ca6

time: fix test hang · ba98a7ee
Dmitriy Vyukov authored Nov 14, 2011
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5374083
```
ba98a7ee
misc/notepadplus: error and rune support · 3811a441
Anthony Starks authored Nov 14, 2011
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5376048
```
3811a441
misc/bbedit: error and rune support · 23f541aa
Anthony Starks authored Nov 14, 2011
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5369057
```
23f541aa
kate: add error and rune · 39b25576
Evan Shaw authored Nov 14, 2011
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5370078
```
39b25576

syscall: take over env implementation · 0acd879c

Russ Cox authored Nov 14, 2011

The environment is needed by package time, which
we want not to depend on os (so that os can use
time.Time), so push down into syscall.

Delete syscall.Sleep, now unnecessary.

The package os environment API is preserved;
it is only the implementation that is moving to syscall.

Delete os.Envs, which was undocumented,
uninitialized on Windows and Plan 9, and
not maintained by Setenv and Clearenv.
Code can call os.Environ instead.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5370091

0acd879c

runtime: fix timers crash · dc6726b3

Dmitriy Vyukov authored Nov 14, 2011

Timer callbacks occasionally crash
with "sched while holding locks" message.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5381043

dc6726b3

sql: add DB.Close, fix bugs, remove Execer on Driver (only Conn) · 0a8005c7
Brad Fitzpatrick authored Nov 14, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5372099
```
0a8005c7

syscall: more linux arm build fixes · 869aabbd

Russ Cox authored Nov 14, 2011

Don't know if it runs, but at least it builds.

R=bradfitz
TBR=bradfitz
CC=golang-dev
https://golang.org/cl/5373093

869aabbd

doc/install: add openbsd · 6687e52a

Joel Sing authored Nov 14, 2011

Add openbsd to the $GOOS list.

R=golang-dev, r, rsc
CC=golang-dev
https://golang.org/cl/4964053

6687e52a

runtime: fix syscall test to satisfy new error · 946647fb
Alex Brainman authored Nov 14, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5369103
```
946647fb
doc/progs: fix windows version to satisfy new error · 36494b0a
Alex Brainman authored Nov 14, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5376089
```
36494b0a
gc: fix newlines in %+N · 40afe586
Luuk van Dijk authored Nov 14, 2011
```
fixes #2442

R=rsc
CC=golang-dev
https://golang.org/cl/5370066
```
40afe586

syscall: fix linux arm build · 45eef04e

Russ Cox authored Nov 14, 2011

Regenerate system call file.

TBR=bradfitz
CC=golang-dev
https://golang.org/cl/5371087

45eef04e

syscall: make windows Errno implement net.Error (fix build) · 6677d295
Russ Cox authored Nov 14, 2011
```
TBR=brainman
CC=golang-dev
https://golang.org/cl/5371086
```
6677d295
syscall: regenerate z-files for freebsd · f19aef53
Mikio Hara authored Nov 14, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5369102
```
f19aef53
gc: remove func, map compare · 5bb54b8e
Russ Cox authored Nov 14, 2011
```
R=ken, ken
CC=golang-dev
https://golang.org/cl/5373079
```
5bb54b8e
spec: disallow general func, map comparisons · efb74460
Russ Cox authored Nov 14, 2011
```
R=golang-dev, gri, r, r
CC=golang-dev
https://golang.org/cl/5369090
```
efb74460
various: avoid func compare · 558e7fc3
Russ Cox authored Nov 14, 2011
```
R=gri, r, bradfitz
CC=golang-dev
https://golang.org/cl/5371074
```
558e7fc3

syscall: use error · c017a829

Russ Cox authored Nov 14, 2011

- syscall (not os) now defines the Errno type.
- the low-level assembly functions Syscall, Syscall6, and so on
  return Errno, not uintptr
- syscall wrappers all return error, not uintptr.

R=golang-dev, mikioh.mikioh, r, alex.brainman
CC=golang-dev
https://golang.org/cl/5372080

c017a829

time: remove unused sysSleep · b126902e
Russ Cox authored Nov 14, 2011
```
R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/5369094
```
b126902e
various: reduce overuse of os.EINVAL + others · fd34e78b
Russ Cox authored Nov 14, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5372081
```
fd34e78b

exp/ssh: add direct-tcpip client support · 7af553ab

Dave Cheney authored Nov 14, 2011

This CL adds experimental support for making proxied
net.Conn connections via the remote server.

nb. Functional tests exist for this feature but CL
5320053 or similar needs to be committed to support them.

R=rsc, agl, n13m3y3r
CC=cw, golang-dev, huin
https://golang.org/cl/5371081

7af553ab

exp/ssh: add client functional tests · 34466a14

Dave Cheney authored Nov 14, 2011

Requires CL 5373055

R=rsc, agl, n13m3y3r
CC=golang-dev
https://golang.org/cl/5320053

34466a14