- 11 Apr, 2013 3 commits
-
-
Andrew Wilkins authored
This change removes processing of #cgo directives from cmd/cgo, pushing the onus back on cmd/go to pass all necessary flags. Fixes #5224. See comments for rationale. R=golang-dev, iant, r CC=golang-dev https://golang.org/cl/8610044
-
Rob Pike authored
Fixes #5268. R=golang-dev, dsymonds, bradfitz CC=golang-dev https://golang.org/cl/8646045
-
Anthony Martin authored
All symbols are currently marked with global scope. The correct behavior was lost when the symbol table format was changed. R=golang-dev, iant, r CC=golang-dev https://golang.org/cl/8625043
-
- 10 Apr, 2013 5 commits
-
-
Rob Pike authored
The String method is called whenever the printing operation wants a string, not just for %s and %v. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/8638043
-
Robert Griesemer authored
Go1.1 harmless, but not critical. Fixes #5249. R=golang-dev, r CC=golang-dev https://golang.org/cl/8609043
-
Rob Pike authored
If there are no tags, the rules are the same as before. If there is a tagged field, choose it if there is exactly one at the top level of all fields. More tests. The old tests were clearly inadequate, since they all pass as is. The new tests only work with the new code. R=golang-dev, iant CC=golang-dev https://golang.org/cl/8617044
-
Shenghou Ma authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/8622043
-
Rémy Oudompheng authored
Some variables declared in C could end up as undefined symbols in the final binary and have null address. Fixes #5114. Fixes #5227. R=golang-dev, iant, ajstarks, dave, r CC=golang-dev https://golang.org/cl/8602044
-
- 09 Apr, 2013 11 commits
-
-
Rob Pike authored
The old code was incorrect and also broken. It passed the tests by accident. The new algorithm is: 1) Sort the fields in order of names. 2) For all fields with the same name, sort in increasing depth. 3) Choose the single field with shortest depth. If any of the fields of a given name has a tag, do the above using tagged fields of that name only. Fixes #5245. R=iant CC=golang-dev https://golang.org/cl/8583044
-
Brad Fitzpatrick authored
R=r, golang-dev CC=golang-dev https://golang.org/cl/8575043
-
Ian Lance Taylor authored
R=golang-dev, bradfitz, r CC=golang-dev https://golang.org/cl/8573043
-
Andrew Gerrand authored
Fixes #5246. R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/8558044
-
Andrew Gerrand authored
R=campoy, dsymonds CC=golang-dev https://golang.org/cl/8564043
-
Mikio Hara authored
Makes it possible to return the spent runtime.PollDesc to runtime.pollcache descriptor pool when netFD.connect or syscall.Listen fails. Fixes #5219. R=dvyukov, dave, bradfitz, adg CC=golang-dev https://golang.org/cl/8318044
-
Andrew Gerrand authored
Generated by addca. R=gobot CC=golang-dev https://golang.org/cl/8556044
-
Alex Brainman authored
R=golang-dev, dave CC=golang-dev https://golang.org/cl/8551043
-
Dave Cheney authored
If the build key contains -race, the builder will invoke to the race.{bat,bash} build command. This allows {darwin,linux,windows}-amd64 builders to do race and non race builds in sequence. R=adg, dvyukov, fullung CC=golang-dev https://golang.org/cl/8266046
-
Dmitriy Vyukov authored
The test is problematic, because it requires 8GB+ of RAM. Fixes #5239. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/8550043
-
Dave Cheney authored
See 8318044 R=bradfitz CC=golang-dev https://golang.org/cl/8547043
-
- 08 Apr, 2013 13 commits
-
-
Andrew Wilkins authored
cgo stores cgo LDFLAGS in _cgo_flags and _cgo_defun.c. The _cgo_defun.c records the flags via "#pragma cgo_ldflag <flag>", which external linking relies upon for passing libraries (and search paths) to the host linker. The go command will allow LDFLAGS for cgo to be passed through the environment (CGO_LDFLAGS); cgo ignores this environment variable, and so its value doesn't make it into the above mentioned files. This CL changes cgo to record CGO_LDFLAGS also. Fixes #5205. R=iant, minux.ma CC=golang-dev https://golang.org/cl/8465043
-
Rémy Oudompheng authored
The race detector uses a global lock to analyze atomic operations. A panic in the middle of the code leaves the lock acquired. Similarly, the sync package may leave the race detectro inconsistent when methods are called on nil pointers. R=golang-dev, r, minux.ma, dvyukov, rsc, adg CC=golang-dev https://golang.org/cl/7981043
-
Dmitriy Vyukov authored
It's not trivial to make a comprehensive check due to inferior pointers, reflect, gob, etc. But this is essentially what I've used to debug the GC issues. Update #5193. R=golang-dev, iant, 0xe2.0x9a.0x9b, r CC=golang-dev https://golang.org/cl/8455043
-
Brad Fitzpatrick authored
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/8491044
-
Rémy Oudompheng authored
Fixes #5231. R=golang-dev, daniel.morsing, adg CC=golang-dev https://golang.org/cl/8275044
-
Rob Pike authored
Apologies for not reviewing the previous CL; I was on the road. The text was misleading; execution is no more separate than with any other test. Rewritten. Dropped the odd adverb. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/8439045
-
Andrew Gerrand authored
Fixes #5230. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/8507043
-
Andrew Gerrand authored
The spec doesn't explicitly say that trailing data is okay, but a lot of people do this and most unzippers will handle it just fine. In any case, this makes the package more useful, and led me to make the directory parsing code marginally more robust. Fixes #5228. R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/8504044
-
Kamil Kisiel authored
Fixes #5144 R=golang-dev, r, dave, adg CC=golang-dev https://golang.org/cl/8171044
-
Jonathan Rudenberg authored
R=golang-dev, adg, adg CC=golang-dev https://golang.org/cl/8488047
-
Rob Pike authored
R=golang-dev, adg, dvyukov CC=golang-dev https://golang.org/cl/8494045
-
Andrew Gerrand authored
Fixes #5235. R=golang-dev, r CC=golang-dev https://golang.org/cl/8426048
-
Dmitriy Vyukov authored
Use atomic operations on flags field to make sure we aren't losing a flag update during parallel map operations. R=golang-dev, dave, r CC=golang-dev https://golang.org/cl/8377046
-
- 07 Apr, 2013 8 commits
-
-
Alexei Sholik authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/8499043
-
David Symonds authored
It changes an exported API, and breaks the build. ««« original CL description reflect: use unsafe.Pointer in StringHeader and SliceHeader Relates to issue 5193. R=r CC=golang-dev https://golang.org/cl/8363045 »»» R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/8357051
-
Jan Ziak authored
Relates to issue 5193. R=r CC=golang-dev https://golang.org/cl/8363045
-
Brad Fitzpatrick authored
Don't measure wall time in map.go. Keep it portable and only test NaN, but not time. Move time tests to mapnan.go and only measure user CPU time, not wall time. It builds on Darwin and Linux, the primary platforms where people hack on the runtime & in particular maps. The runtime is shared, though, so we don't need it to run on all of the platforms. Fixes flaky build failures like: http://build.golang.org/log/ba67eceefdeaa1142cb6c990a62fa3ffd8fd73f8 R=golang-dev, r CC=golang-dev https://golang.org/cl/8479043
-
Albert Strasheim authored
R=golang-dev, dvyukov, bradfitz CC=golang-dev https://golang.org/cl/8366044
-
Albert Strasheim authored
Before, an empty TMPDIR would lead to: cannot create <nil>/go.o: No such file or directory R=golang-dev, iant, dave, bradfitz CC=golang-dev https://golang.org/cl/8355045
-
Albert Strasheim authored
R=golang-dev, iant, dave CC=golang-dev https://golang.org/cl/8253045
-
Dmitriy Vyukov authored
The invariant is that there must be at least one running P or a thread polling network. It was broken. Fixes #5216. R=golang-dev, bradfitz, r CC=golang-dev https://golang.org/cl/8459043
-