Commits · d2933e99021f9d1048cc25e0d0b0724f5bfc6ed6 · go / golang

19 Dec, 2011 21 commits

syscall: regenerate z-files for linux/arm · d2933e99
Mikio Hara authored Dec 19, 2011
```
R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/5496062
```
d2933e99
exec: disable new test to fix build · 355ed5da
Ian Lance Taylor authored Dec 19, 2011
```
TBR=bradfitz
CC=golang-dev
https://golang.org/cl/5494075
```
355ed5da

strconv: implement faster parsing of decimal numbers. · 2368b003

Rémy Oudompheng authored Dec 19, 2011

The algorithm is the same as in the double-conversion library
which also implements Florian Loitsch's fast printing algorithm.
It uses extended floats with a 64-bit mantissa, but cannot give
an answer for all cases.

                           old ns/op  new ns/op  speedup
BenchmarkAtof64Decimal         332        322      1.0x
BenchmarkAtof64Float           385        373      1.0x
BenchmarkAtof64FloatExp       9777        419     23.3x
BenchmarkAtof64Big            3934        691      5.7x
BenchmarkAtof64RandomBits    34060        899     37.9x
BenchmarkAtof64RandomFloats   1329        680      2.0x

See F. Loitsch, ``Printing Floating-Point Numbers Quickly and
Accurately with Integers'', Proceedings of the ACM, 2010.

R=ality, rsc
CC=golang-dev, remy
https://golang.org/cl/5494068

2368b003

doc: delete go course notes · c99f4f5b

Rob Pike authored Dec 19, 2011

They're out of date, a pain to maintain, and most of the material
is better served by the Go Tour.

Fixes #2101.

R=golang-dev, rsc, r, adg
CC=golang-dev
https://golang.org/cl/5489053

c99f4f5b

net, syscall, os: set CLOEXEC flag on epoll/kqueue descriptor · 38432959
Ian Lance Taylor authored Dec 19, 2011
```
Enable new test in os.

R=dave, iant, rsc
CC=golang-dev
https://golang.org/cl/5494061
```
38432959
gc: avoid unsafe in defn of package runtime · 1d0f93b4
Russ Cox authored Dec 19, 2011
```
Keeps -u tracking simple.

R=ken2
CC=golang-dev
https://golang.org/cl/5495094
```
1d0f93b4

runtime: separate out auto-generated files, take 2 · 55889409

Russ Cox authored Dec 19, 2011

This is like the ill-fated CL 5493063 except that
I have written a shell script (autogen.sh) instead of
thinking I could possibly write a correct Makefile.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5496075

55889409

encoding/json: cleanup leftover variables in array decoding. · 4a4c39e7

Rémy Oudompheng authored Dec 19, 2011

An old update for API changes in reflect package left several
helper variables that do not have a meaning anymore, and
the type checking of arrays vs slices was broken.
Fixes #2513.

R=ultrotter, rsc
CC=golang-dev, remy
https://golang.org/cl/5488094

4a4c39e7

strconv: reduce buffer size for multi-precision decimals. · 3a2dec02

Rémy Oudompheng authored Dec 19, 2011

The longest numbers we have to represent are the smallest denormals.
Their decimal mantissa is not longer than 5^1100. Taking into
account some extra size for in-place operations, 800 digits are
enough. This saves time used for zero intiialization of extra
bytes.

                                        old ns/op  new ns/op    delta
strconv_test.BenchmarkAtof64Decimal           521        334   -35.9%
strconv_test.BenchmarkAtof64Float             572        391   -31.6%
strconv_test.BenchmarkAtof64FloatExp        10242      10036    -2.0%
strconv_test.BenchmarkAtof64Big              4229       4029    -4.7%
strconv_test.BenchmarkFormatFloatDecimal     1396        934   -33.1%
strconv_test.BenchmarkFormatFloat            4295       3341   -22.2%
strconv_test.BenchmarkFormatFloatExp        12035      11181    -7.1%
strconv_test.BenchmarkFormatFloatBig         4213       3229   -23.4%
strconv_test.BenchmarkAppendFloatDecimal     1031        600   -41.8%
strconv_test.BenchmarkAppendFloat            3971       3044   -23.3%
strconv_test.BenchmarkAppendFloatExp        11699      11003    -5.9%
strconv_test.BenchmarkAppendFloatBig         3836       2915   -24.0%

R=golang-dev, bradfitz, rsc
CC=golang-dev, remy
https://golang.org/cl/5491064

3a2dec02

exec: add test to verify net package's epoll fd doesn't go to child · 178be83e
Brad Fitzpatrick authored Dec 19, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5490075
```
178be83e

syscall: Changes to the syscall package to support NetBSD. · 5425db8f

Christopher Nielsen authored Dec 19, 2011

Not all syscalls are implemented, but many are. On the suggestion
of Joel Sing <jsing@google.com>, the generated files were added
with hg add instead of hg cp, since they are generated on an OS
dependant basis.

R=golang-dev, jsing, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/5491050

5425db8f

crypto/tls: don't assume an RSA private key in the API. · 2ca4a616

Adam Langley authored Dec 19, 2011

We still very much assume it in the code, but with this change in
place we can implement other things later without changing and users
of the package.

Fixes #2319.

R=golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/5489073

2ca4a616

net/http: test both texta and textb values, not texta twice · 10e43384
Alex Brainman authored Dec 19, 2011
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5489082
```
10e43384
io/ioutil: close file in TestWriteFile before deleting it · c4227f5b
Alex Brainman authored Dec 19, 2011
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5495086
```
c4227f5b
dashboard: improve formatting of build status page · 35755b9c
Andrew Gerrand authored Dec 19, 2011
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5493077
```
35755b9c
builder: send commit time to dashboard · 9b3799aa
Andrew Gerrand authored Dec 19, 2011
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5489084
```
9b3799aa
archive/zip: add SetModTime method to FileHeader · 0b28de9a
Andrew Gerrand authored Dec 19, 2011
```
Fixes #2574.

R=golang-dev, bradfitz, adg, bradfitz
CC=golang-dev
https://golang.org/cl/5494072
```
0b28de9a
dashboard: hide build status column (package builder is out of action) · 3f216c1b
Andrew Gerrand authored Dec 19, 2011
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5489080
```
3f216c1b

html: handle text nodes in foreign content. · 18e84414

Nigel Tao authored Dec 19, 2011

Passes tests10.dat, test 6:
<!DOCTYPE html><body><table><svg><g>foo</g></svg></table>

| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     <svg svg>
|       <svg g>
|         "foo"
|     <table>

Also pass tests through test 12:
<!DOCTYPE html><body><table><caption><svg><g>foo</g><g>bar</g></svg><p>baz</caption></table>

R=andybalholm
CC=golang-dev
https://golang.org/cl/5495061

18e84414

encoding/json: examples for Marshal and Unmarshal · 5ede9df5
Andrew Gerrand authored Dec 19, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5493075
```
5ede9df5
text/template: fix handing of nil arguments to functions · 12f473f8
Gustavo Niemeyer authored Dec 19, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5494070
```
12f473f8

18 Dec, 2011 2 commits

vim: fix go filetype detection · 41f4ba3a

Paul Sbarra authored Dec 18, 2011

The filetype needs to be set during BufRead in order for the did_filetype() check to prevent the file being detected as a conf file. One example where this can occur is if a cgo file has a #include at the top of the file. The # is detected in vim's generic configuration (conf file) toward the bottom of filetype.vim

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5496066

41f4ba3a

doc: suggest code.google.com/p/go instead of go.googlecode.com/hg · 31cc66bc
Andrew Gerrand authored Dec 18, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5491069
```
31cc66bc

17 Dec, 2011 4 commits

os: Add NetBSD support for recent signal changes. · 5030177e

Christopher Nielsen authored Dec 17, 2011

Add NetBSD to mksignals.sh and generate files.
While we're here, also add netbsd to the +build list where appropriate.

R=golang-dev, jsing
CC=golang-dev
https://golang.org/cl/5492064

5030177e

runtime: use correct traceback file on arm · 13b26cb3

Rob Pike authored Dec 17, 2011

reported by fred richter

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5494062

13b26cb3

goinstall: only suggest -fix for bad imports when appropriate · 76a07833
Andrew Gerrand authored Dec 17, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5495073
```
76a07833

go/build: remove 'go/build' from error messages · 96a5780d

Andrew Gerrand authored Dec 17, 2011

This leads to really confusing messages in goinstall.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5495074

96a5780d

16 Dec, 2011 13 commits

runtime: hg revert -r 6ec0a5c12d75 · 86dcc431

Russ Cox authored Dec 16, 2011

That was the last build that was close to working.
I will try that change again next week.
Make is being very subtle today.

At the reverted-to CL, the ARM traceback appears
to be broken.  I'll look into that next week too.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5492063

86dcc431

go/printer, gofmt: fine tuning of line spacing · 541b67d0

Robert Griesemer authored Dec 16, 2011

- no empty lines inside empty structs and interfaces
- top-level declarations are separated by a blank line if
  a) they are of different kind (e.g. const vs type); or
  b) there are documentation comments associated with a
     declaration (this is new)
- applied gofmt -w misc src

The actual changes are in go/printer/nodes.go:397-400 (empty structs/interfaces),
and go/printer/printer.go:307-309 (extra line break). The remaining
changes are cleanups w/o changing the existing functionality.

Fixes issue  2570.

R=rsc
CC=golang-dev
https://golang.org/cl/5493057

541b67d0

runtime: fix build on gri's machine · 72bdd868

Russ Cox authored Dec 16, 2011

Why it was not failing anywhere else I don't know,
but the Makefile was definitely wrong.  The rules
must not run in parallel.

TBR=r
CC=golang-dev
https://golang.org/cl/5489069

72bdd868

runtime: fix build · cfd17a1b

Russ Cox authored Dec 16, 2011

I am looking forward to not supporting two build
systems simultaneously.  Make complains about
a circular dependency still, but I don't understand it
and it's probably not worth the time to figure out.

TBR=r
CC=golang-dev
https://golang.org/cl/5496058

cfd17a1b

websocket: fix a trivial example server · 32734f46
Olivier Duperray authored Dec 16, 2011
```
R=golang-dev, rsc, r
CC=golang-dev
https://golang.org/cl/5491063
```
32734f46
runtime: separate out auto-generated files · bd9243da
Russ Cox authored Dec 16, 2011
```
R=golang-dev, r, r
CC=golang-dev
https://golang.org/cl/5493063
```
bd9243da
runtime: fix build · 95907c47
Russ Cox authored Dec 16, 2011
```
TBR=r
CC=golang-dev
https://golang.org/cl/5493061
```
95907c47

runtime: make more build-friendly · 851f3013

Russ Cox authored Dec 16, 2011

Collapse the arch,os-specific directories into the main directory
by renaming xxx/foo.c to foo_xxx.c, and so on.

There are no substantial edits here, except to the Makefile.
The assumption is that the Go tool will #define GOOS_darwin
and GOARCH_amd64 and will make any file named something
like signals_darwin.h available as signals_GOOS.h during the
build.  This replaces what used to be done with -I$(GOOS).

There is still work to be done to make runtime build with
standard tools, but this is a big step.  After this we will have
to write a script to generate all the generated files so they
can be checked in (instead of generated during the build).

R=r, iant, r, lucio.dere
CC=golang-dev
https://golang.org/cl/5490053

851f3013

encoding/gob: arrays are zero only if their elements are zero · 474d64d2
Rob Pike authored Dec 16, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5494059
```
474d64d2

gob: isZero for struct values · 4fb5f544

Rob Pike authored Dec 16, 2011

Fixes #2577.

R=golang-dev, r, gri
CC=golang-dev
https://golang.org/cl/5492058

4fb5f544

various: use $GCFLAGS and $GCIMPORTS like Make does · bf6dd2db
Maxim Pimenov authored Dec 16, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5489065
```
bf6dd2db

net/http: Added interface for a cookie jar. · dd694fb1

Volker Dobler authored Dec 16, 2011

Types implementing CookieJar may be used in a Client
to persist cookies.

R=bradfitz, rsc
CC=golang-dev
https://golang.org/cl/5399043

dd694fb1

codereview: Initialize "found" in codereview.py. · a3008e23

Miki Tebeka authored Dec 16, 2011

Fixes #2569 (hg undo crashes when CL not found).

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5489052

a3008e23