Commits · d3d08e1e3a5dfd5b3a7a3112e503f7bcc76bf343 · go / golang

08 Jul, 2011 11 commits
- exp/template: forgot to allow . as a function argument · d3d08e1e
  Rob Pike authored Jul 08, 2011
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4671053
```
  d3d08e1e
- exp/template: parse variables and declarations · b8c66429
  Rob Pike authored Jul 08, 2011
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4631099
```
  b8c66429
- exp/template: lex variables · ee14989e
  Rob Pike authored Jul 08, 2011
```
Variables start with'$' and are declared with ':='.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4662084
```
  ee14989e
- exp/template: add a tree-walking example to the test. · 02039b63
  Rob Pike authored Jul 08, 2011
```
Also fix a comment formatting glitch.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4672054
```
  02039b63
- exp/template: the must-have MustParse functions · ad58dc9d
  Andrew Gerrand authored Jul 08, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4641096
```
  ad58dc9d
- exp/template: allow fields and methods to be found in parent structs. · a852981d
  Rob Pike authored Jul 08, 2011
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4657085
```
  a852981d
- tag weekly.2011-07-07 · 6f4cf399
  Andrew Gerrand authored Jul 08, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4664066
```
  6f4cf399
- weekly.2011-07-07 · 4f03ef79
  Andrew Gerrand authored Jul 08, 2011
```
R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/4668061
```
  4f03ef79
- sort: rename helpers: s/Sort// in sort.Sort[Float64s|Ints|Strings] · 5bcbcab3
  Andrew Gerrand authored Jul 08, 2011
```
Includes 'sorthelpers' gofix and updates to tree.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/4631098
```
  5bcbcab3
- gob: export fields in structs in the package documentation. · e67a2504
  David Symonds authored Jul 08, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4648075
```
  e67a2504
- cgi: don't depend on CGI.pm for tests · 3236097a
  Brad Fitzpatrick authored Jul 08, 2011
```
CGI.pm used to be part of the Perl core,
but some distros now bundle perl-core
and perl-modules separately.

It's not worth depending on.

R=golang-dev, mattn.jp
CC=golang-dev
https://golang.org/cl/4675063
```
  3236097a
07 Jul, 2011 11 commits

image/draw: add draw tests where the destination image doesn't start · b39afde8

Nigel Tao authored Jul 07, 2011

at (0, 0).

Also refactor the test to use the SubImage method rather than monkeying
with an image's Pix and Rect fields.

R=r
CC=golang-dev
https://golang.org/cl/4678045

b39afde8

crypto/x509: prevent chain cycles in Verify · d1d466f6

Adam Langley authored Jul 07, 2011

It's possible to include a self-signed root certificate as an
intermediate and push Verify into a loop.

I already had a test for this so I thought that it was ok, but it
turns out that the test was void because the Verisign root certificate
doesn't contain the "IsCA" flag and so it wasn't an acceptable
intermediate certificate for that reason.

R=bradfitz
CC=golang-dev
https://golang.org/cl/4657080

d1d466f6

doc: remove ed from apt-get package list · 141f676b
Brad Fitzpatrick authored Jul 07, 2011
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/4672052
```
141f676b
image: tighten Paletted.Opaque to check only those palette entries · 03f987c8
Nigel Tao authored Jul 07, 2011
```
in the image, not all palette entries.

R=r
CC=golang-dev
https://golang.org/cl/4672049
```
03f987c8

os: fix documentation for FileInfo.Name. · 07c9a925

Rob Pike authored Jul 07, 2011

It's the base name, not the full name.
Fixes #2047.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4680041

07c9a925

exp/template: handle pointers and values in empty interfaces. · 238274ed
Rob Pike authored Jul 07, 2011
```
R=golang-dev, r, mattn.jp
CC=golang-dev
https://golang.org/cl/4664064
```
238274ed

exp/template: change the name from 'metacharacter' to 'delimiter', · 8d538c6d

Rob Pike authored Jul 07, 2011

because that's what they are.
No semantic change.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4675060

8d538c6d

crypto/openpgp: fixed dangerous use of for loop variable · 582d6e58

Gideon Jan-Wessel Redelinghuys authored Jul 07, 2011

In function readSignedMessage a pointer to for loop variable 'key' was incorrectly being assigned
to md.SignedBy. Changed so that md.SignedBy is pointing to the 'more correct' memory position.

R=golang-dev, r, agl
CC=golang-dev
https://golang.org/cl/4631088

582d6e58

C+A: Gideon Jan-Wessel Redelinghuys · 7875ecb4

Rob Pike authored Jul 07, 2011

R=golang-dev, dsymonds
CC=gjredelinghuys, golang-dev
https://golang.org/cl/4675059

7875ecb4

syscall: rearrange windows code so 386 and amd64 can share files · e71fc0c1
Alex Brainman authored Jul 07, 2011
```
R=golang-dev, r
CC=golang-dev, vcc.163
https://golang.org/cl/4641093
```
e71fc0c1
CONTRIBUTORS: add Google contributor mpvl@golang.org · ae19943e
Rob Pike authored Jul 07, 2011
```
R=golang-dev, dsymonds
CC=golang-dev, mpvl
https://golang.org/cl/4643075
```
ae19943e

06 Jul, 2011 16 commits

exp/template: index: forgot the always last-to-arrive uintptr. · 46ecd6f1
Rob Pike authored Jul 06, 2011
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/4636087
```
46ecd6f1

asn1: support T61 and UTF8 string. · 1aa571d3

Adam Langley authored Jul 06, 2011

There is no end to the kitchen sink of string types in ASN.1.

Fixes #1953.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/4672045

1aa571d3

crypto/tls: fix generate_cert.go · 502589e0
Adam Langley authored Jul 06, 2011
```
Fixes #2030.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/4635092
```
502589e0

json: fix test if rand returns 0. · 7b0bb480

Ian Lance Taylor authored Jul 06, 2011

Fixes test when run with gccgo using optimization, which
changes the order of the calls to rand.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/4639101

7b0bb480

exp/template: index function for arrays, slices, and maps. · 6732bd35
Rob Pike authored Jul 06, 2011
```
R=golang-dev, adg, r
CC=golang-dev
https://golang.org/cl/4643072
```
6732bd35

exp/template: silence test noise (but add a flag to put it back) · 64228e36

Rob Pike authored Jul 06, 2011

Also delete a TODO and clean up a little evaluation code.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4643071

64228e36

exp/template: add a JavaScript escaper. · 33705dde
David Symonds authored Jul 06, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4671048
```
33705dde
exp/template: allow an empty interface value to be the target of range, etc. · a33cc423
Rob Pike authored Jul 06, 2011
```
We extract the concrete value inside.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4677041
```
a33cc423
exp/template: improve error message for non-exported field. · 381a555f
Rob Pike authored Jul 06, 2011
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4636086
```
381a555f

maketables: update debugging data. · a8e5db94

Rob Pike authored Jul 06, 2011

This is unused in the generation of the tables, but was incorrect if we ever needed it.
Also update the reference to the document.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4626097

a8e5db94

exp/template: add missing dotNode case. · 9d5ed174
David Symonds authored Jul 06, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4672044
```
9d5ed174

exp/template: fixes and updates. · 9495dd31

Rob Pike authored Jul 06, 2011

- fix line numbers - forgot to update state.line during execution
- add a comment convention {{/* comment */}}
- set.Template returns the named template in the set
- set.Execute executes the named template in the set
- use a local methodByName so this package can be used with earlier release of reflect.
- use initial cap to detect exported names

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4668054

9495dd31

exp/template: remove debugging dreg. · d45ba2c1
David Symonds authored Jul 06, 2011
```
R=r, gri
TBR=r
CC=golang-dev
https://golang.org/cl/4671047
```
d45ba2c1
html: parse start tags that aren't explicitly otherwise dealt with. · 1e6d9465
Yasuhiro Matsumoto authored Jul 06, 2011
```
R=golang-dev, nigeltao
CC=golang-dev
https://golang.org/cl/4626080
```
1e6d9465
exp/template: remove the need for a goroutine. · 329990d5
Rob Pike authored Jul 06, 2011
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4626095
```
329990d5
exp/template: remove the visibility of the token channel from the parser. · 4657d7d7
Rob Pike authored Jul 06, 2011
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4675053
```
4657d7d7

05 Jul, 2011 2 commits

gc: fix %N for OGOTO nodes. · 13d048a2

Luuk van Dijk authored Jul 05, 2011

6g -W crashed on any source with a goto. this fixes that.

R=rsc, r
CC=golang-dev
https://golang.org/cl/4675052

13d048a2

exp/template: add templates to sets; boolean logic. · eea54435
Rob Pike authored Jul 05, 2011
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4670045
```
eea54435