Commits · d608b15db7f1e55e612f23cb9039379087a1f287 · go / golang

11 Jun, 2012 1 commit

misc/emacs: Fix the automatic gofmt when creating a new file. · d608b15d

Jean-Marc Eurin authored Jun 11, 2012

Patching the buffer with the output from gofmt -d only works if
the file already exists. If it doesn't, replace the content with
the output of gofmt.

R=sameer
CC=golang-dev
https://golang.org/cl/6302063

d608b15d

10 Jun, 2012 1 commit
- encoding/gob: fix doc typo · 1d609f9b
  Brad Fitzpatrick authored Jun 10, 2012
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6300078
```
  1d609f9b
08 Jun, 2012 9 commits

runtime: use uintptr where possible in malloc stats · 0b09425b

Dave Cheney authored Jun 08, 2012

linux/arm OMAP4 pandaboard

benchmark                 old ns/op    new ns/op    delta
BenchmarkBinaryTree17   68723297000  37026214000  -46.12%
BenchmarkFannkuch11     34962402000  35958435000   +2.85%
BenchmarkGobDecode        137298600    124182150   -9.55%
BenchmarkGobEncode         60717160     60006700   -1.17%
BenchmarkGzip            5647156000   5550873000   -1.70%
BenchmarkGunzip          1196350000   1198670000   +0.19%
BenchmarkJSONEncode       863012800    782898000   -9.28%
BenchmarkJSONDecode      3312989000   2781800000  -16.03%
BenchmarkMandelbrot200     45727540     45703120   -0.05%
BenchmarkParse             74781800     59990840  -19.78%
BenchmarkRevcomp          140043650    139462300   -0.42%
BenchmarkTemplate        6467682000   5832153000   -9.83%

benchmark                  old MB/s     new MB/s  speedup
BenchmarkGobDecode             5.59         6.18    1.11x
BenchmarkGobEncode            12.64        12.79    1.01x
BenchmarkGzip                  3.44         3.50    1.02x
BenchmarkGunzip               16.22        16.19    1.00x
BenchmarkJSONEncode            2.25         2.48    1.10x
BenchmarkJSONDecode            0.59         0.70    1.19x
BenchmarkParse                 0.77         0.97    1.26x
BenchmarkRevcomp              18.15        18.23    1.00x
BenchmarkTemplate              0.30         0.33    1.10x

darwin/386 core duo

benchmark                 old ns/op    new ns/op    delta
BenchmarkBinaryTree17   10591616577   9678245733   -8.62%
BenchmarkFannkuch11     10758473315  10749303846   -0.09%
BenchmarkGobDecode         34379785     34121250   -0.75%
BenchmarkGobEncode         23523721     23475750   -0.20%
BenchmarkGzip            2486191492   2446539568   -1.59%
BenchmarkGunzip           444179328    444250293   +0.02%
BenchmarkJSONEncode       221138507    219757826   -0.62%
BenchmarkJSONDecode      1056034428   1048975133   -0.67%
BenchmarkMandelbrot200     19862516     19868346   +0.03%
BenchmarkRevcomp         3742610872   3724821662   -0.48%
BenchmarkTemplate         960283112    944791517   -1.61%

benchmark                  old MB/s     new MB/s  speedup
BenchmarkGobDecode            22.33        22.49    1.01x
BenchmarkGobEncode            32.63        32.69    1.00x
BenchmarkGzip                  7.80         7.93    1.02x
BenchmarkGunzip               43.69        43.68    1.00x
BenchmarkJSONEncode            8.77         8.83    1.01x
BenchmarkJSONDecode            1.84         1.85    1.01x
BenchmarkRevcomp              67.91        68.24    1.00x
BenchmarkTemplate              2.02         2.05    1.01x

R=rsc, 0xe2.0x9a.0x9b, mirtchovski
CC=golang-dev, minux.ma
https://golang.org/cl/6297047

0b09425b

math/big: added nat.trailingZeroBits, simplified some code · 014d036d
Robert Griesemer authored Jun 08, 2012
```
Will simplify implementation of binaryGCD.

R=rsc, cswenson
CC=golang-dev
https://golang.org/cl/6299064
```
014d036d

syscall: unexport GetCurrentProcessId on Windows · 7762a9dc

Russ Cox authored Jun 08, 2012

This slipped in with the implementation of Getpid in CL 5909043.
I'd exclude that CL entirely but it is tangled up in the Win32finddata changes.

R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/6297065

7762a9dc

syscall: fix windows build · 56f5e6d8
Russ Cox authored Jun 08, 2012
```
TBR=bradfitz
CC=golang-dev
https://golang.org/cl/6303061
```
56f5e6d8

syscall: revert API changes in Windows Win32finddata fix. · 7ad37673

Russ Cox authored Jun 08, 2012

Preserve old API by using correct struct in system call
and then copying the results, as we did for SetsockoptLinger.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6307065

7ad37673

cmd/api: handle empty API file, ignore -next in release · 0c2f0cca
Russ Cox authored Jun 08, 2012
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6298063
```
0c2f0cca

regexp/syntax: unexport ErrUnexpectedParen · 50452720

Russ Cox authored Jun 08, 2012

This new error is the only API change in the current draft of
Go 1.0.2 CLs. I'd like to include the CL that introduced it,
because it replaces a mysterious 'internal error' with a
useful error message, but I don't want any API changes,
so unexport the error constant for now. It can be
re-exported for Go 1.1.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6294055

50452720

exp/html: check the context node for consistency when parsing fragments. · 6c204982
Nigel Tao authored Jun 08, 2012
```
R=rsc
CC=golang-dev
https://golang.org/cl/6303053
```
6c204982

cmd/5c, cmd/5g, cmd/5l: fix cross compilation failure on darwin · 072e36d5

Dave Cheney authored Jun 08, 2012

Fixes #3708.

The fix to allow 5{c,g,l} to compile under clang 3.1 broke cross
compilation on darwin using the Apple default compiler on 10.7.3.

This failure was introduced in 9b455eb64690.

This has been tested by cross compiling on darwin/amd64 to linux/arm using

* gcc version 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2336.1.00)
* clang version 3.1 (branches/release_31)

As well as on linux/arm using

* gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5)
* Ubuntu clang version 3.0-6ubuntu3 (tags/RELEASE_30/final) (based on LLVM 3.0)
* Debian clang version 3.1-4 (branches/release_31) (based on LLVM 3.1)

R=consalus, rsc
CC=golang-dev
https://golang.org/cl/6307058

072e36d5

07 Jun, 2012 15 commits

test/bench/shoutout: fix compliation · 97300640

Shenghou Ma authored Jun 07, 2012

-lm must come after the source file, versions of gcc insist this strict order.
On standard compliant systems, we no longer need malloc.h for malloc.
Use pkg-config(1) to get correct glib cflags and libs.
Fix compiler warning in threadring.c and k-nucleotide.c.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6198076

97300640

cmd/5a, cmd/5l: add MULW{T,B} and MULAW{T,B} support for ARM · a0084b34

Shenghou Ma authored Jun 07, 2012

        Supported in ARMv5TE and above.
        Also corrected MULA disassembly listing.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6265045

a0084b34

cmd/cgo: make Go code order deterministic · f51390b2

Russ Cox authored Jun 07, 2012

The type declarations were being generated using
a range over a map, which meant that successive
runs produced different orders. This will make sure
successive runs produce the same files.

Fixes #3707.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6300062

f51390b2

cmd/gc: limit data disassembly to -SS · b185de82
Russ Cox authored Jun 07, 2012
```
This makes -S useful again.

R=ken2
CC=golang-dev
https://golang.org/cl/6302054
```
b185de82

cmd/gc: fix LEAQ $0, SI bug · 2a9410c1

Russ Cox authored Jun 07, 2012

Cannot take effective address of constant.

Fixes #3670.

R=ken2
CC=golang-dev
https://golang.org/cl/6299055

2a9410c1

cmd/gc: run escape analysis in call graph dependency order · 9fe42473

Russ Cox authored Jun 07, 2012

If there are mutually recursive functions, there is a cycle in
the dependency graph, so the order is actually dependency order
among the strongly connected components: mutually recursive
functions get put into the same batch and analyzed together.
(Until now the entire package was put in one batch.)

The non-recursive case (single function, maybe with some
closures inside) will be able to be more precise about inputs
that escape only back to outputs, but that is not implemented yet.

R=ken2
CC=golang-dev, lvd
https://golang.org/cl/6304050

9fe42473

cmd/gc: fix type checking loop · 6363fc5a

Russ Cox authored Jun 07, 2012

CL 4313064 fixed its test case but did not address a
general enough problem:

type T1 struct { F *T2 }
type T2 T1
type T3 T2

could still end up copying the definition of T1 for T2
before T1 was done being evaluated, or T3 before T2
was done.

In order to propagate the updates correctly,
record a copy of an incomplete type for re-execution
once the type is completed. Roll back CL 4313064.

Fixes #3709.

R=ken2
CC=golang-dev, lstoakes
https://golang.org/cl/6301059

6363fc5a

cmd/gc: delete dead code · f18ced3f
Russ Cox authored Jun 07, 2012
```
R=ken2
CC=golang-dev
https://golang.org/cl/6307050
```
f18ced3f
cmd/gc: do not crash on struct with _ field · 744b23fe
Russ Cox authored Jun 07, 2012
```
Fixes #3607.

R=ken2
CC=golang-dev
https://golang.org/cl/6296052
```
744b23fe
cmd/gc: preserve side effects during inlining of function with _ argument · ee5f59ab
Russ Cox authored Jun 07, 2012
```
Fixes #3593.

R=ken2
CC=golang-dev, lvd
https://golang.org/cl/6305061
```
ee5f59ab
encoding/json: fix panic unmarshaling into non-nil interface value · 09b736a2
Russ Cox authored Jun 07, 2012
```
Fixes #3614.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/6306051
```
09b736a2
cmd/gc: mark output of typename as type-checked · 8022a1a5
Russ Cox authored Jun 07, 2012
```
R=ken2
CC=golang-dev
https://golang.org/cl/6302051
```
8022a1a5

exp/html: when parsing, compare atoms (ints) instead of strings. · c8fac7b9

Nigel Tao authored Jun 07, 2012

This is the mechanical part of the 2-part change that started with
https://golang.org/cl/6305053/

R=rsc
CC=andybalholm, golang-dev, r
https://golang.org/cl/6295055

c8fac7b9

exp/html: make the tokenizer return atoms for tag tokens. · cd21eff7

Nigel Tao authored Jun 07, 2012

This is part 1 of a 2 part changelist. Part 2 contains the mechanical
change to parse.go to compare atoms (ints) instead of strings.

The overall effect of the two changes are:
benchmark                      old ns/op    new ns/op    delta
BenchmarkParser                  4462274      4058254   -9.05%
BenchmarkRawLevelTokenizer        913202       912917   -0.03%
BenchmarkLowLevelTokenizer       1268626      1267836   -0.06%
BenchmarkHighLevelTokenizer      1947305      1968944   +1.11%

R=rsc
CC=andybalholm, golang-dev, r
https://golang.org/cl/6305053

cd21eff7

test/bench/go1: add go/parser benchmark · 64236820

Dave Cheney authored Jun 07, 2012

As discussed in

https://groups.google.com/d/msg/golang-dev/Na9XE6mcQyY/zbeBI7R-vnoJ

Here is a static copy of the go/parser benchmark. I ended up using
fancy encodings because the original parser.go had a number of `s
scattered throughout which made it hard to embed the source directly.

Curiously on my laptop this benchmark always scores roughly 10% higher
than the standalone benchmark. This may be down to the generation of
the fasta data set triggering the cpu governor to raise the cpu speed.
However the benchmark is consistent with itself across multiple runs.

R=golang-dev, minux.ma, rsc
CC=golang-dev
https://golang.org/cl/6305055

64236820

06 Jun, 2012 13 commits

runtime: include "typekind.h" to fix windows build · f54d6106
Alex Brainman authored Jun 06, 2012
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6305059
```
f54d6106

exp/html/atom: add more atoms. · 90fa13d2

Nigel Tao authored Jun 06, 2012

This completely covers the tags used by exp/html's parser.

Before:
295 atoms; 1406 string bytes + 2048 tables = 3454 total data
BenchmarkLookup    50000         59841 ns/op

After:
322 atoms; 1508 string bytes + 2048 tables = 3556 total data
BenchmarkLookup    50000         60159 ns/op

R=r
CC=golang-dev
https://golang.org/cl/6296045

90fa13d2

misc/dashboard/app: fix build failure notifications · 55282111

Andrew Gerrand authored Jun 06, 2012

The datastore.Query methods once mutated the Query value, but now they return
a derivative query, so the Hash= and ParentHash= filters were not being
applied.

R=golang-dev, bradfitz, dsymonds
CC=golang-dev
https://golang.org/cl/6300058

55282111

net: pass tests on Plan 9 again · 42a76efc
Fazlul Shahriar authored Jun 06, 2012
```
R=golang-dev
CC=golang-dev
https://golang.org/cl/6280045
```
42a76efc
runtime: move type kinds into a separate file · ede6718c
Jan Ziak authored Jun 06, 2012
```
R=rsc
CC=golang-dev
https://golang.org/cl/6285047
```
ede6718c
fmt: fix doc typo · c8cbbd31
Daniel Morsing authored Jun 06, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6308046
```
c8cbbd31
A+C: Daniel Morsing (individual CLA) · c53450a0
Russ Cox authored Jun 06, 2012
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6307048
```
c53450a0
crypto/rand: enable rand.Reader on plan9 · 3476c231
Markus Sonderegger authored Jun 06, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6297044
```
3476c231
A+C: Markus Sonderegger (individual CLA) · fe80cf0f
Russ Cox authored Jun 06, 2012
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6303047
```
fe80cf0f

fmt: fix inadvertent change to %#v · ee3c2726

Russ Cox authored Jun 06, 2012

The reordering speedup in CL 6245068 changed the semantics
of %#v by delaying the clearing of some flags.  Restore the old
semantics and add a test.

Fixes #3706.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6302048

ee3c2726

net: fix cgoAddrInfoFlags() on FreeBSD · 58993e51

Shenghou Ma authored Jun 06, 2012

        CL 6250075 removed AI_MASK mask on all BSD variants,
        however FreeBSD's AI_MASK does not include AI_V4MAPPED
        and AI_ALL, and its libc is strict about the ai_flags.

        This will fix the FreeBSD builder.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6305054

58993e51

build: restore PATH before "dist banner" · 81368d9b

Shenghou Ma authored Jun 06, 2012

        Fixes #3699.

R=golang-dev, r, rsc
CC=golang-dev
https://golang.org/cl/6272048

81368d9b

runtime: fix tv_sec handling for netbsd/386 · 2cb74984

Joel Sing authored Jun 06, 2012

On netbsd/386, tv_sec is a 64-bit integer for both timeval and timespec.
Fix the time handling code so that it works correctly.

R=golang-dev, rsc, m4dh4tt3r
CC=golang-dev
https://golang.org/cl/6256056

2cb74984

05 Jun, 2012 1 commit
- cmd/5c, cmd/5g, cmd/5l: fix array indexing warning under Clang 3.1 · d2d990cc
  Dave Cheney authored Jun 05, 2012
```
This should be the last of them.

R=golang-dev, minux.ma, rsc
CC=golang-dev
https://golang.org/cl/6297043
```
  d2d990cc