Commits · d7b4851586a912e0166bc405cf8aace5f77d96d7 · go / golang

21 Apr, 2010 9 commits

strings: add ReadRune to Reader · d7b48515
Kyle Consalus authored Apr 21, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/940041
```
d7b48515

big: eliminate redundant array lookups · e4136fe9

Evan Shaw authored Apr 21, 2010

This gives about a 6% performance improvement to pidigits.
Thanks to Russ for the suggestion.

R=rsc, gri
CC=golang-dev
https://golang.org/cl/957041

e4136fe9

big: reduce the number of allocations · 4f445d27

Evan Shaw authored Apr 21, 2010

There was a bug in makeN that caused lots of unnecessary
allocations.  Fixing this exposed a few bugs in other
functions which worked when makeN allocated a new slice, but
failed when it simply resized an existing slice.  The result
is a pretty big performance improvement.  When running
pidigits, here were the numbers I got on amd64:

Before this change:
pidigits 10000
        gcc -O2 pidigits.c -lgmp        2.09u 0.02s 2.11r
        gc pidigits     12.68u 0.04s 12.72r
        gc_B pidigits   12.71u 0.03s 12.75r

After:
pidigits 10000
        gcc -O2 pidigits.c -lgmp        2.09u 0.00s 2.10r
        gc pidigits     6.82u 0.00s 6.85r
        gc_B pidigits   6.55u 0.01s 6.59r

R=rsc, gri
CC=golang-dev
https://golang.org/cl/953042

4f445d27

go_faq: add question: Why does Go perform badly on benchmark X? · 0857573a
Andrew Gerrand authored Apr 21, 2010
```
R=r, cw
CC=golang-dev
https://golang.org/cl/895043
```
0857573a

6l, 8l: include ELF header in PT_LOAD mapping for text segment · 1c0c2528

Russ Cox authored Apr 21, 2010

Due to page boundary rounding, the header would have
been loaded as part of the text segment already, but this
change placates the "paxctl" tool on so-called hardened
Linux distributions (as if normal distributions weren't already
hard enough to use).

R=r
CC=golang-dev
https://golang.org/cl/954041

1c0c2528

big: Add Lsh and Value; convert pidigits to use big · 76cbbc8a

Evan Shaw authored Apr 21, 2010

This yields a pretty significant performance boost to pidigits and there are still some improvements to be made. Here are my numbers:

amd64 w/ bignum:
pidigits 10000
        gcc -O2 pidigits.c -lgmp        2.10u 0.00s 2.10r
        gc pidigits     22.92u 0.02s 22.97r
        gc_B pidigits   22.62u 0.00s 22.65r

amd64 w/ big:
pidigits 10000
        gcc -O2 pidigits.c -lgmp        2.09u 0.02s 2.11r
        gc pidigits     12.68u 0.04s 12.72r
        gc_B pidigits   12.71u 0.03s 12.75r

386 w/ bignum:
pidigits 10000
        gcc -O2 pidigits.c -lgmp        2.09u 0.00s 2.09r
        gc pidigits     44.30u 0.01s 44.35r
        gc_B pidigits   44.29u 0.03s 44.35r

386 w/ big:
pidigits 10000
        gcc -O2 pidigits.c -lgmp        2.10u 0.00s 2.10r
        gc pidigits     22.70u 0.06s 22.79r
        gc_B pidigits   22.80u 0.09s 22.91r

R=rsc, gri
CC=golang-dev
https://golang.org/cl/881050

76cbbc8a

gc: print x[y:] correctly · 4ba177ae
Russ Cox authored Apr 21, 2010
```
R=ken2
CC=golang-dev
https://golang.org/cl/955041
```
4ba177ae
runtime: rename cgo2c, *.cgo to goc2c, *.goc · 20c50cf0
Russ Cox authored Apr 21, 2010
```
to avoid confusion with real cgo

R=r
CC=golang-dev
https://golang.org/cl/904046
```
20c50cf0
reflect: implement Set(nil), SetValue(nil) for PtrValue and MapValue · 7295b61c
Russ Cox authored Apr 21, 2010
```
R=r
CC=golang-dev
https://golang.org/cl/823048
```
7295b61c

20 Apr, 2010 2 commits
- big: Get rid of function pointers and init function · 73374c93
  Evan Shaw authored Apr 20, 2010
```
R=rsc, gri
CC=golang-dev
https://golang.org/cl/929041
```
  73374c93
- godashboard: remove obselete data models and conversion code · 8df31213
  Andrew Gerrand authored Apr 20, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/919045
```
  8df31213
19 Apr, 2010 5 commits

Added strings.FieldsFunc, a generalization of strings.Fields in style of the… · ad2c5a49

Kyle Consalus authored Apr 19, 2010

Added strings.FieldsFunc, a generalization of strings.Fields in style of the strings.Trim*Func functions.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/824051

ad2c5a49

godashboard: bz2 compress logs in data store · 47c4416b

Andrew Gerrand authored Apr 19, 2010

This results in a 10-20x size reduction per record.
(from ~150kb to ~10kb)

This revision has been pushed live, as I'm in the process of
converting Log records to bz2-compresed CompressedLog records.
I would have waited but we're running seriously low on space
and it seemed like a sane (and reversible) move.

R=rsc
CC=golang-dev
https://golang.org/cl/872048

47c4416b

gc benchmark: Update package list · 93c750d8

Evan Shaw authored Apr 19, 2010

Some old packages on the list were preventing this benchmark from working.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/820045

93c750d8

gc: cmplx typecheck bug fix · d97bbabb
Russ Cox authored Apr 19, 2010
```
Fixes #729.

R=ken2
CC=golang-dev
https://golang.org/cl/875048
```
d97bbabb

syscall: match linux Setsid function signature to darwin · 3ffbd57b

Andrew Gerrand authored Apr 19, 2010

SETSID does return an errno - any reason why it has been done this
way in zsyscall_linux_* ? Otherwise it should be the same as darwin.

From SETSID(2) on my Linux box:

ERRORS
       On error, -1 is returned, and errno is set.

Fixes #730

R=rsc
CC=golang-dev
https://golang.org/cl/878047

3ffbd57b

18 Apr, 2010 3 commits

reflect: add FieldByNameFunc · 57e76417

Raif S. Naffah authored Apr 18, 2010

xml: add support for XML marshalling embedded structs.

R=rsc
CC=golang-dev
https://golang.org/cl/837042

57e76417

net: fix bugs in packStructValue · 13f81feb

Michael Hoisie authored Apr 18, 2010

packStructValue was cutting off last byte of uint32
in _Dns_msg.Unpack, use packRR for rr types

R=rsc
CC=golang-dev
https://golang.org/cl/844048

13f81feb

json: scanner, Compact, Indent, and tests · 3cfa2c3d

Russ Cox authored Apr 18, 2010

This is the first of probably four separate CLs
for the new implementation of the json package.

The scanner is the core of the new implementation.
The other CLs would be the new decoder,
the new encoder, and support for JSON streams.

R=r
CC=golang-dev
https://golang.org/cl/802051

3cfa2c3d

16 Apr, 2010 6 commits

rpc: Add Close() method to rpc.Client to allow graceful connection teardown. · 3f7da4f8
Rob Pike authored Apr 16, 2010
```
Fixes #675.

R=rsc, msolo
CC=golang-dev
https://golang.org/cl/882049
```
3f7da4f8

the android runner script · 0b2e0265

Kai Backman authored Apr 16, 2010

	this is a version synthesized from rsc's, dean's and my
	versions. changes and updates:

	- embeds the retval script and pushes a new version to the
          device if needed
	- passes arguments correctly to the program on the device
	- export GOARCH, GOTRACEBACK and GOGC from the local
          environment to the device.
	- added times.out support to run-arm

	enabled a few tests that are now passing and moved the
	GOGC=off workaround to run-arm.

R=dpx
CC=golang-dev, rsc
https://golang.org/cl/880046

0b2e0265

add Sam Thorogood (of Google Inc.) to CONTRIBUTORS · a8c18e14
Andrew Gerrand authored Apr 16, 2010
```
R=r
CC=golang-dev
https://golang.org/cl/890048
```
a8c18e14

exp/eval: Always read float literals as base 10 · 9ca10b0a

Evan Shaw authored Apr 16, 2010

We were letting bignum decide, which caused problems with float literals with a leading 0.

R=gri
CC=golang-dev
https://golang.org/cl/816047

9ca10b0a

go/ast: Update comment to mention imaginary literals · ff922fe1
Evan Shaw authored Apr 16, 2010
```
R=gri
CC=golang-dev
https://golang.org/cl/846050
```
ff922fe1
exp/eval: Implement x[lo:] · 39a2e82e
Evan Shaw authored Apr 16, 2010
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/908044
```
39a2e82e

15 Apr, 2010 5 commits

flag: eliminate unnecessary structs · a318f9d3
Russ Cox authored Apr 15, 2010
```
R=r
CC=golang-dev
https://golang.org/cl/872045
```
a318f9d3

"godoc -src pkg_name" excludes duplicates entries · fffac807

Andrei Vieru authored Apr 15, 2010

$ godoc xml | grep Copy\(\)
func (c CharData) Copy() CharData
func (c Comment) Copy() Comment
func (d Directive) Copy() Directive
func (p ProcInst) Copy() ProcInst
func (e StartElement) Copy() StartElement
--------------------------------------------
$ godoc -src xml | grep Copy\(\)
func (c CharData) Copy() CharData
--------------------------------------------
$ godoc -src xml Copy
func (c CharData) Copy() CharData { return CharData(makeCopy(c)) }
--------------------------------------------
The command "godoc -src pkg_name" should output the interface of the named package, but it excludes all duplicate entries. Also the command "godoc -src pkg_name method_name" will output the source code only for one method even if there are more of them with the same name in the same package. This patch set fixes this issue.

R=gri
CC=golang-dev
https://golang.org/cl/883051

fffac807

synchronize ARM runner environment variable with run-arm · df3a5440
Kai Backman authored Apr 15, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/912041
```
df3a5440

support for printing floats: · 26e84642

Kai Backman authored Apr 15, 2010

fmt.Printf("float32 %f\n", float32(1234.56789))
fmt.Printf("float64 %f\n", float64(1234.56789))
->
float32 1234.567871
float64 1234.567890

this is a snapshot. extended instruction support, corner cases
and fixes coming in subseuent cls.

R=rsc
CC=dpx, golang-dev
https://golang.org/cl/876045

26e84642

scanner: implement Peek() to look at the next char w/o advancing · 0fd00c8b
Robert Griesemer authored Apr 15, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/840045
```
0fd00c8b

14 Apr, 2010 6 commits
- bytes: shuffle implementation, making WriteByte 50% faster · 1baf35e4
  Russ Cox authored Apr 14, 2010
```
R=r
CC=golang-dev
https://golang.org/cl/920041
```
  1baf35e4
- release.2010-04-13 part two · ba1e025f
  Andrew Gerrand authored Apr 14, 2010
```
R=rsc, r
CC=golang-dev
https://golang.org/cl/896045
```
  ba1e025f
- runtime: better trace for fault due to nil pointer call · c3e54f09
  Russ Cox authored Apr 14, 2010
```
R=r
CC=golang-dev
https://golang.org/cl/854048
```
  c3e54f09
- os, syscall: mingw bug fixes · 03526597
  Alex Brainman authored Apr 14, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/815044
```
  03526597
- go_spec updates · 6aad4191
  Russ Cox authored Apr 14, 2010
```
R=r, iant
CC=golang-dev
https://golang.org/cl/921041
```
  6aad4191
- release.2010-04-13 · 93efe475
  Andrew Gerrand authored Apr 14, 2010
```
R=rsc, r
CC=golang-dev
https://golang.org/cl/902045
```
  93efe475
13 Apr, 2010 4 commits
- os: mingw version of Readdir() and Stat() implemented · b07e4d95
  Alex Brainman authored Apr 13, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/851045
```
  b07e4d95
- 8l: add DOS stub to PE binaries · 30f981d9
  Evan Shaw authored Apr 13, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/915041
```
  30f981d9
- netchan: allow client to send as well as receive. · 1b56947f
  Rob Pike authored Apr 13, 2010
```
much rewriting and improving, but it's still experimental.

R=rsc
CC=golang-dev
https://golang.org/cl/875045
```
  1b56947f
- template: use panic/recover to simplify internal error handling. · effddcad
  Rob Pike authored Apr 13, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/824049
```
  effddcad