Commits · d8626ef128bb5e9e13a8f8659481067f12dd23cc · go / golang

18 Jan, 2013 15 commits

runtime: faster mcentral alloc. · d8626ef1

Sébastien Paolacci authored Jan 18, 2013

Reduce individual object handling by anticipating how much of them are servable.

Not a chunked transfer cache, but decent enough to make sure the bottleneck is not here.

Mac OSX, median of 10 runs:

benchmark                 old ns/op    new ns/op    delta
BenchmarkBinaryTree17    5358937333   4892813012   -8.70%
BenchmarkFannkuch11      3257752475   3315436116   +1.77%
BenchmarkGobDecode         23277349     23001114   -1.19%
BenchmarkGobEncode         14367327     14262925   -0.73%
BenchmarkGzip             441045541    440451719   -0.13%
BenchmarkGunzip           139117663    139622494   +0.36%
BenchmarkJSONEncode        45715854     45687802   -0.06%
BenchmarkJSONDecode       103949570    106530032   +2.48%
BenchmarkMandelbrot200      4542462      4548290   +0.13%
BenchmarkParse              7790558      7557540   -2.99%
BenchmarkRevcomp          831436684    832510381   +0.13%
BenchmarkTemplate         133789824    133007337   -0.58%

benchmark                  old MB/s     new MB/s  speedup
BenchmarkGobDecode            32.82        33.33    1.02x
BenchmarkGobEncode            53.42        53.86    1.01x
BenchmarkGzip                 43.70        44.01    1.01x
BenchmarkGunzip              139.09       139.14    1.00x
BenchmarkJSONEncode           42.69        42.56    1.00x
BenchmarkJSONDecode           18.78        17.91    0.95x
BenchmarkParse                 7.37         7.67    1.04x
BenchmarkRevcomp             306.83       305.70    1.00x
BenchmarkTemplate             14.57        14.56    1.00x

R=rsc, dvyukov
CC=golang-dev
https://golang.org/cl/7005055

d8626ef1

cmd/gc, cmd/6g: fix error on large stacks. · d127ed53
Rémy Oudompheng authored Jan 18, 2013
```
Fixes #4666.

R=golang-dev, daniel.morsing, rsc
CC=golang-dev
https://golang.org/cl/7141047
```
d127ed53

cmd/6c: Improve peep hole optimization of rotate and shift instructions. · 41ec481a

Matthew Dempsky authored Jan 18, 2013

Update #4629.

$ cat shift2.c
unsigned int
shift(unsigned int x, unsigned int y)
{
        x = (x << 3);
        y = (y << 5);
        x = (x << 7);
        y = (y << 9);
        return x ^ y;
}

## BEFORE
$ go tool 6c -S shift2.c
(shift2.c:2)	TEXT	shift+0(SB),$0-8
(shift2.c:4)	MOVL	x+0(FP),!!AX
(shift2.c:4)	SALL	$3,!!AX
(shift2.c:4)	MOVL	AX,!!DX
(shift2.c:5)	MOVL	y+4(FP),!!AX
(shift2.c:5)	SALL	$5,!!AX
(shift2.c:5)	MOVL	AX,!!CX
(shift2.c:6)	MOVL	DX,!!AX
(shift2.c:6)	SALL	$7,!!AX
(shift2.c:6)	MOVL	AX,!!DX
(shift2.c:7)	MOVL	CX,!!AX
(shift2.c:7)	SALL	$9,!!AX
(shift2.c:7)	MOVL	AX,!!CX
(shift2.c:8)	MOVL	DX,!!AX
(shift2.c:8)	XORL	CX,!!AX
(shift2.c:8)	RET	,!!
(shift2.c:8)	RET	,!!
(shift2.c:8)	END	,!!

## AFTER
$ go tool 6c -S shift2.c
(shift2.c:2)	TEXT	shift+0(SB),$0-8
(shift2.c:4)	MOVL	x+0(FP),!!AX
(shift2.c:4)	SALL	$3,!!AX
(shift2.c:5)	MOVL	y+4(FP),!!CX
(shift2.c:5)	SALL	$5,!!CX
(shift2.c:6)	SALL	$7,!!AX
(shift2.c:7)	SALL	$9,!!CX
(shift2.c:8)	XORL	CX,!!AX
(shift2.c:8)	RET	,!!
(shift2.c:8)	RET	,!!
(shift2.c:8)	END	,!!

R=rsc, minux.ma, dave, nigeltao
CC=golang-dev
https://golang.org/cl/7066055

41ec481a

cmd/gc: allow registerization of temporaries created by inlining. · dfdfba14

Rémy Oudompheng authored Jan 18, 2013

Names beginning with a dot are ignored by optimizers.

R=rsc, lvd, golang-dev, dave
CC=golang-dev
https://golang.org/cl/7098049

dfdfba14

cmd/go: diagnose un-bootstrapped runtime · f579faa6
Russ Cox authored Jan 18, 2013
```
Fixes #4665.

R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/7132057
```
f579faa6
time: add note about Parse()'s choice of default year · e985d546
Shenghou Ma authored Jan 18, 2013
```
R=rsc
CC=golang-dev
https://golang.org/cl/7101046
```
e985d546
cmd/dist: update for new flag parsing on Plan 9 · 0c026c45
Anthony Martin authored Jan 18, 2013
```
R=golang-dev, seed, rsc
CC=golang-dev
https://golang.org/cl/7069053
```
0c026c45

build: change GO386=sse to GO386=sse2 · d795f077

Russ Cox authored Jan 18, 2013

sse2 is a more precise description of the requirement,
and it matches what people will see in, for example
        grep sse2 /proc/cpuinfo # linux
        sysctl hw.optional.sse2 # os x

R=golang-dev, dsymonds, iant
CC=golang-dev
https://golang.org/cl/7057050

d795f077

compress/flate: Performance improvement for inflate · ebf35167

Raph Levien authored Jan 18, 2013

Decode as much as possible of a Huffman symbol in a single table
lookup (much like the zlib implementation), filling more bits
(conservatively, so we don't consume past the end of the stream)
when the code prefix indicates more bits are needed. This
results in about a 50% performance gain in speed benchmarks.
The following set is benchcmp done on a retina MacBook Pro:

benchmark old MB/s new MB/s speedup
BenchmarkDecodeDigitsSpeed1e4 28.41 42.79 1.51x
BenchmarkDecodeDigitsSpeed1e5 30.18 47.62 1.58x
BenchmarkDecodeDigitsSpeed1e6 30.81 48.14 1.56x
BenchmarkDecodeDigitsDefault1e4 30.28 44.61 1.47x
BenchmarkDecodeDigitsDefault1e5 32.18 51.94 1.61x
BenchmarkDecodeDigitsDefault1e6 35.57 53.28 1.50x
BenchmarkDecodeDigitsCompress1e4 30.39 44.83 1.48x
BenchmarkDecodeDigitsCompress1e5 33.05 51.64 1.56x
BenchmarkDecodeDigitsCompress1e6 35.69 53.04 1.49x
BenchmarkDecodeTwainSpeed1e4 25.90 43.04 1.66x
BenchmarkDecodeTwainSpeed1e5 29.97 48.19 1.61x
BenchmarkDecodeTwainSpeed1e6 31.36 49.43 1.58x
BenchmarkDecodeTwainDefault1e4 28.79 45.02 1.56x
BenchmarkDecodeTwainDefault1e5 37.12 55.65 1.50x
BenchmarkDecodeTwainDefault1e6 39.28 58.16 1.48x
BenchmarkDecodeTwainCompress1e4 28.64 44.90 1.57x
BenchmarkDecodeTwainCompress1e5 37.40 55.98 1.50x
BenchmarkDecodeTwainCompress1e6 39.35 58.06 1.48x

R=rsc, dave, minux.ma, bradfitz, nigeltao
CC=golang-dev
https://golang.org/cl/6872063

ebf35167

doc/contribute.html: mention hg mail during hg change discussion · c64469f8

Russ Cox authored Jan 18, 2013

People keep not reading all the way to the bottom of the doc
and not running hg mail.

R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/7137057

c64469f8

cmd/gc: don't hash nor compare struct padding or blank fields. · 2ad57b45
Rémy Oudompheng authored Jan 18, 2013
```
Fixes #4585.

R=rsc, golang-dev
CC=golang-dev
https://golang.org/cl/7142052
```
2ad57b45
lib/godoc: link to Projects wiki page instead of dashboard · 2ee06a51
Andrew Gerrand authored Jan 18, 2013
```
R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/7139057
```
2ee06a51
time: Sleep does better job then runtime.Gosched in TestAfterStress · e0aa26a4
Alex Brainman authored Jan 18, 2013
```
for slow windows-386 builder

R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/7128053
```
e0aa26a4

misc/dashboard/godashboard: delete · 60b9cd53

Andrew Gerrand authored Jan 18, 2013

This code is obsolete and unmaintained.

R=bradfitz
CC=golang-dev
https://golang.org/cl/7135056

60b9cd53

testing: allow examples to pass (fix build) · e19cdc65
Andrew Gerrand authored Jan 18, 2013
```
R=golang-dev
CC=golang-dev
https://golang.org/cl/7132050
```
e19cdc65

17 Jan, 2013 12 commits

html/template: remove noescape support · c0229434

Andrew Gerrand authored Jan 17, 2013

This was never documented or properly implemented.

Fixes #3528.

R=mikesamuel, rsc
CC=golang-dev
https://golang.org/cl/7142048

c0229434

testing: catch panicking example and report, just like tests · 5bd5ed2b
Andrew Gerrand authored Jan 17, 2013
```
Fixes #4670.

R=rsc
CC=golang-dev
https://golang.org/cl/7148043
```
5bd5ed2b
C: add Carl Shapiro (Google CLA). · 07dfd8b1
David Symonds authored Jan 17, 2013
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/7132049
```
07dfd8b1
all: remove exec bit on files · d46d0f15
Shenghou Ma authored Jan 17, 2013
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/7128048
```
d46d0f15
cmd/vet: don't complain about Error() · e487ea84
Shenghou Ma authored Jan 17, 2013
```
Fixes #4598.

R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/7102050
```
e487ea84
doc/go_spec.html: clarification about insertion during map iteration · ced57153
Shenghou Ma authored Jan 17, 2013
```
R=mdempsky, iant, r, gri, rsc, ken
CC=golang-dev
https://golang.org/cl/7100046
```
ced57153

cmd/godoc: when redirecting don't clear query string · c2aee3c0

Shenghou Ma authored Jan 17, 2013

so that http://golang.org/pkg/runtime?m=all works.

R=bradfitz
CC=golang-dev
https://golang.org/cl/7094046

c2aee3c0

os: use SameFile in TestStartProcess · 40b37588

Shenghou Ma authored Jan 17, 2013

Fixes #4650.

R=golang-dev, bradfitz, alex.brainman
CC=golang-dev
https://golang.org/cl/7085048

40b37588

testing: introduce (*B).ReportAllocs() · 1e095b76

Shenghou Ma authored Jan 17, 2013

Calling it will show memory allocation statistics for that
single benchmark (if -test.benchmem is not provided)

R=golang-dev, rsc, kevlar, bradfitz
CC=golang-dev
https://golang.org/cl/7027046

1e095b76

doc/articles/json_and_go: fix some format. · f5958c61
Oling Cat authored Jan 17, 2013
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/7131045
```
f5958c61

time: add Timer.Reset · 44ff17e6

Volker Dobler authored Jan 17, 2013

Fixes #4412.

R=adg, rsc, rogpeppe, andrewdg, bradfitz
CC=golang-dev
https://golang.org/cl/7086050

44ff17e6

exp/html: remove "INCOMPLETE" comment · 55740f76

Andrew Balholm authored Jan 17, 2013

I think that the parser is complete enough to take that warning out.
It passes the test suite.
There may be incompatible API changes, but being in the exp directory
is warning enough for that.

R=nigeltao
CC=golang-dev
https://golang.org/cl/7131050

55740f76

16 Jan, 2013 2 commits
- go/types: correct result type for append (bug fix) · 5a4a197d
  Robert Griesemer authored Jan 16, 2013
```
Rewrote existing code to prevent similar mistakes.

R=adonovan
CC=golang-dev
https://golang.org/cl/7129046
```
  5a4a197d
- net/http: Serve creates service goroutines, not service threads · 1a03580e
  Matthew Dempsky authored Jan 16, 2013
```
R=bradfitz
CC=golang-dev
https://golang.org/cl/7132045
```
  1a03580e
15 Jan, 2013 2 commits

net/http: fix racy test · 3b73aaaf

Brad Fitzpatrick authored Jan 15, 2013

We need to wait for the handler to actually finish running,
not almost be done running.

This was always a bug, but now that handler output is buffered
it shows up easily on GOMAXPROCS >1 systems.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/7109043

3b73aaaf

doc: fix various fragment links · 399a36a6
Andrew Gerrand authored Jan 15, 2013
```
R=dsymonds
CC=golang-dev
https://golang.org/cl/7094058
```
399a36a6

14 Jan, 2013 9 commits
- net: simplify ListenMulticastUDP · 6d725e97
  Mikio Hara authored Jan 14, 2013
```
R=rsc, iant, dave
CC=golang-dev
https://golang.org/cl/6999053
```
  6d725e97
- syscall: simplify socket control messages · c241f696
  Mikio Hara authored Jan 14, 2013
```
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/7016044
```
  c241f696
- go/types: set type of lhs ident in type switch guards · 0822a62c
  Robert Griesemer authored Jan 14, 2013
```
(bug fix)

R=adonovan
CC=golang-dev
https://golang.org/cl/7098059
```
  0822a62c
- go/types: various minor fixes · 5e5c0a9f
  Robert Griesemer authored Jan 14, 2013
```
- always set the Pkg field in QualifiedIdents
- call Context.Ident for all identifiers in the AST that denote
  a types.Object (bug fix)
- added test that Context.Ident is called for all such identifiers

R=adonovan
CC=golang-dev
https://golang.org/cl/7101054
```
  5e5c0a9f
- time: fix race · fd1abac7
  Brad Fitzpatrick authored Jan 14, 2013
```
Fixes #4622

R=golang-dev, dave, dvyukov
CC=golang-dev
https://golang.org/cl/7103046
```
  fd1abac7
- go/types: mark completely imported packages as such · 6c3736a5
  Robert Griesemer authored Jan 14, 2013
```
R=adonovan
CC=golang-dev
https://golang.org/cl/7103055
```
  6c3736a5
- go/types: callback for *ast.Ident -> Object mapping · 7f18f811
  Robert Griesemer authored Jan 14, 2013
```
Also re-enabled resolver test.

R=adonovan
CC=golang-dev
https://golang.org/cl/7107043
```
  7f18f811
- html/template: Clarifying references to "text/template" in the documentation. · 1590be9e
  Francesc Campoy authored Jan 14, 2013
```
Fixes #4634.

R=adg, kevlar
CC=golang-dev
https://golang.org/cl/7066053
```
  1590be9e
- syscall: simplify netlink sockets · a0509d85
  Mikio Hara authored Jan 14, 2013
```
R=dave, rsc
CC=golang-dev
https://golang.org/cl/7039044
```
  a0509d85