Commits · d9b82baac1f25fce52d1a392fb39711fa9462f40 · go / golang

11 Jan, 2012 24 commits

doc: update "How to Write Go Code" to use the go tool · d9b82baa
Andrew Gerrand authored Jan 11, 2012
```
R=golang-dev, r, kevlar, rsc
CC=golang-dev
https://golang.org/cl/5534045
```
d9b82baa
misc/dashboard/builder: fix comment in http.go · 014c342b
Olivier Duperray authored Jan 11, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5534074
```
014c342b
gc: fix inlining bug · 836a517f
Russ Cox authored Jan 11, 2012
```
Fixes #2682.

R=lvd
CC=golang-dev
https://golang.org/cl/5538043
```
836a517f

cmd/go: change deadline to 10 minutes · f2b51f56

Russ Cox authored Jan 11, 2012

1 minute is not enough for the slower builders.

R=adg
CC=golang-dev
https://golang.org/cl/5533068

f2b51f56

gc: export nil literals without inferred type. · feaa9ed1
Luuk van Dijk authored Jan 11, 2012
```
Fixes #2678

R=rsc
CC=golang-dev
https://golang.org/cl/5529066
```
feaa9ed1
go test: align "no test files" message · b8f76764
Robert Griesemer authored Jan 11, 2012
```
R=rsc
CC=golang-dev
https://golang.org/cl/5533070
```
b8f76764

go/scanner: remove (exported) InsertSemis mode · 276f177b

Robert Griesemer authored Jan 11, 2012

This is a relic from the times when we switched
to automatic semicolon insertion. It's still use-
ful to have a non-exported switch for testing.

R=golang-dev, r, rsc
CC=golang-dev
https://golang.org/cl/5528077

276f177b

cmd/go: fix test documentation · c7fdbeb6
Dmitriy Vyukov authored Jan 11, 2012
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5529067
```
c7fdbeb6
go/printer: don't crash if AST contains BadXXX nodes · a30b172c
Robert Griesemer authored Jan 11, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5535048
```
a30b172c
Makefile: update openpgp/error -> openpgp/errors · b1bad553
Adam Langley authored Jan 11, 2012
```
R=golang-dev
CC=golang-dev
https://golang.org/cl/5530078
```
b1bad553

crypto/openpgp: assorted cleanups · a68494bf

Adam Langley authored Jan 11, 2012

1) Include Szabolcs Nagy's patch which adds serialisation for more
   signature subpackets.
2) Include Szabolcs Nagy's patch which adds functions for making DSA
   keys.
3) Make the random io.Reader an argument to the low-level signature
   functions rather than having them use crypto/rand.
4) Rename crypto/openpgp/error to crypto/openpgp/errors so that it
   doesn't clash with the new error type.

R=bradfitz, r
CC=golang-dev
https://golang.org/cl/5528044

a68494bf

cmd/go: kill test.out after 1 minute · 0c012af1

Russ Cox authored Jan 11, 2012

Will have to do better but this is enough to
stop the builders from hanging, I hope.

R=golang-dev, dsymonds, adg
CC=golang-dev
https://golang.org/cl/5533066

0c012af1

runtime: runtime.usleep() bugfix on darwin/amd64 and linux/arm · 1250f94f

Shenghou Ma authored Jan 11, 2012

pkg/runtime/sys_darwin_amd64.s: fixes syscall select nr
pkg/runtime/sys_linux_arm.s: uses newselect instead of the now unimplemented
        (old) select, also fixes the wrong div/mod statements in runtime.usleep.
Fixes #2633

R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/5504096

1250f94f

builder: pass through TMPDIR env var, drop DISABLE_NET_TESTS · 5cf803f4
Andrew Gerrand authored Jan 11, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5530076
```
5cf803f4
os: work around inlining bug (issue 2678) · 8fe77013
Russ Cox authored Jan 11, 2012
```
TBR=lvd
CC=golang-dev
https://golang.org/cl/5534070
```
8fe77013
go: rely on exit code to tell if test passed · 091ef25a
Russ Cox authored Jan 11, 2012
```
R=adg, dsymonds
CC=golang-dev
https://golang.org/cl/5532066
```
091ef25a
gc: enable inlining by default · 4a6b07f2
Russ Cox authored Jan 11, 2012
```
R=lvd, r
CC=golang-dev
https://golang.org/cl/5531058
```
4a6b07f2
net: fix windows build · d03bfa8e
Alex Brainman authored Jan 11, 2012
```
R=golang-dev, adg, rsc
CC=golang-dev
https://golang.org/cl/5533065
```
d03bfa8e

runtime: make garbage collector faster by deleting code · a6d8b483

Russ Cox authored Jan 11, 2012

Suggested by Sanjay Ghemawat.  5-20% faster depending
on the benchmark.

Add tree2 garbage benchmark.
Update other garbage benchmarks to build again.

R=golang-dev, r, adg
CC=golang-dev
https://golang.org/cl/5530074

a6d8b483

go/scanner: fix documentation · 2b628811
Robert Griesemer authored Jan 11, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5528070
```
2b628811

go/ast: predeclared objects have the Universe/Unsafe scope as Decl · 09004913

Robert Griesemer authored Jan 11, 2012

Makes it possible to easily detect if an Object was predeclared
(as opposed to unresolved).

R=rsc
CC=golang-dev
https://golang.org/cl/5530072

09004913

syscall: fix windows build · b06514bb
Mikio Hara authored Jan 11, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5533063
```
b06514bb

image: rename image.Tiled to image.Repeated. · 415f15b6

Nigel Tao authored Jan 11, 2012

What package image currently provides is a larger image consisting
of many copies of a smaller image.

More generally, a tiled image could be a quilt consisting of different
smaller images (like Google Maps), or a technique to view a portion of
enormous images without requiring the whole thing in memory.

This richer construct might not ever belong in the standard library (and
is definitely out of scope for Go 1), but I would like the option for
image.Tiled to be its name.

R=r, rsc
CC=golang-dev
https://golang.org/cl/5530062

415f15b6

net: add IP-level socket option helpers for Unix variants · cbdbdc4f

Mikio Hara authored Jan 11, 2012

Also reorganize socket options stuff but there are no API behavioral
changes.

R=rsc, fullung
CC=golang-dev
https://golang.org/cl/5494067

cbdbdc4f

10 Jan, 2012 16 commits

A+C: add Yoshiyuki Kanno (Individual CLA) · 6a0e6cc7
Brad Fitzpatrick authored Jan 10, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5534066
```
6a0e6cc7

html: propagate foreign namespaces only when adding foreign content. · aa033c20

Nigel Tao authored Jan 10, 2012

Pass tests10.dat, test 31:
<div><svg><path><foreignObject><p></div>a

| <html>
|   <head>
|   <body>
|     <div>
|       <svg svg>
|         <svg path>
|           <svg foreignObject>
|             <p>
|               "a"

Also pass test 32:
<!DOCTYPE html><svg><desc><div><svg><ul>a

R=andybalholm
CC=golang-dev
https://golang.org/cl/5527064

aa033c20

runtime: fix typo in comment · dcdc309c
Maxim Pimenov authored Jan 10, 2012
```
R=golang-dev
CC=golang-dev
https://golang.org/cl/5529059
```
dcdc309c
exp/sql: close Rows on EOF · 4435c8bf
Brad Fitzpatrick authored Jan 10, 2012
```
Fixes #2624

R=rsc
CC=golang-dev
https://golang.org/cl/5530068
```
4435c8bf
gc: test that asserts closures are not wrapped when they don't have closure vars. · 25cf9bde
Luuk van Dijk authored Jan 10, 2012
```
R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/5529060
```
25cf9bde

gc: inlining fixes · 97fd7d5f

Luuk van Dijk authored Jan 10, 2012

flag -l means: inlining on, -ll inline with early typecheck
-l lazily typechecks imports on use and re-export, nicer for debugging
-lm produces output suitable for errchk tests, repeated -mm... increases inl.c's verbosity
export processed constants, instead of originals
outparams get ->inlvar too, and initialized to zero
fix shared rlist bug, that lead to typecheck messing up the patched tree
properly handle non-method calls to methods T.meth(t, a...)
removed embryonic code to handle closures in inlined bodies
also inline calls inside closures (todo: move from phase 6b to 4)

Fixes #2579.

R=rsc
CC=golang-dev
https://golang.org/cl/5489106

97fd7d5f

runtime: distinct panic message for call of nil func value · 5032a7dc
Russ Cox authored Jan 10, 2012
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5531062
```
5032a7dc
A+C: add Shenghou Ma (Individual CLA) · 57f15a3d
Brad Fitzpatrick authored Jan 10, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5528065
```
57f15a3d

runtime: regenerate defs_darwin_{386,amd64}.h · bc1f4c18

Dave Cheney authored Jan 10, 2012

Regenerated under Lion 10.7.2 amd64.
Also tested on Snow Leopart 10.6.8 386.

R=golang-dev, dsymonds, minux.ma
CC=golang-dev
https://golang.org/cl/5533058

bc1f4c18

go: fix typo in comment · 800c4982
Maxim Pimenov authored Jan 10, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5531060
```
800c4982

gc: Nicer errors before miscompiling. · a6c49098

Luuk van Dijk authored Jan 10, 2012

This fixes issue 2444.

A big cleanup of all 31/32bit size boundaries i'll leave for another cl though.  (see also issue 1700).

R=rsc
CC=golang-dev
https://golang.org/cl/5484058

a6c49098

gc: disallow declaration of variables outside package. · 4bcc9c6b

Luuk van Dijk authored Jan 10, 2012

Fixes #2231.

Declaring main.i in package main in the same way already triggers syntax errors.

R=rsc
CC=golang-dev
https://golang.org/cl/5483078

4bcc9c6b

gc: fix stray %#N in error message · 556258e5
Luuk van Dijk authored Jan 10, 2012
```
Fixes #2639.

R=rsc
CC=bradfitz, golang-dev
https://golang.org/cl/5489140
```
556258e5

gc: omit runtime.closure wrap for closures without closure variables · ba25778f

Luuk van Dijk authored Jan 10, 2012

Fixes #1894.

test/closure.go's test for newfunc already covers this.

R=rsc, dsymonds, bradfitz
CC=golang-dev
https://golang.org/cl/5516051

ba25778f

undo CL 5530063 / 1d7295fdf62e · ad3e82e7

Mikio Hara authored Jan 10, 2012

runtime: enable runtime.ncpu on FreeBSD

««« original CL description
cmd/go: fix freebsd build

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5530063
»»»

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5531059

ad3e82e7

runtime: enable runtime.ncpu on FreeBSD · 12bf0005
Devon H. O'Dell authored Jan 10, 2012
```
R=adg, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/5528062
```
12bf0005