Commits · d9fd11443ca0a6e421cb8f68b533eb2af136e81f · go / golang

22 Feb, 2011 7 commits

ld: detect stack overflow due to NOSPLIT · d9fd1144

Russ Cox authored Feb 22, 2011

Fix problems found.

On amd64, various library routines had bigger
stack frames than expected, because large function
calls had been added.

runtime.assertI2T: nosplit stack overflow
        120	assumed on entry to runtime.assertI2T
        8	after runtime.assertI2T uses 112
        0	on entry to runtime.newTypeAssertionError
        -8	on entry to runtime.morestack01

runtime.assertE2E: nosplit stack overflow
        120	assumed on entry to runtime.assertE2E
        16	after runtime.assertE2E uses 104
        8	on entry to runtime.panic
        0	on entry to runtime.morestack16
        -8	after runtime.morestack16 uses 8

runtime.assertE2T: nosplit stack overflow
        120	assumed on entry to runtime.assertE2T
        16	after runtime.assertE2T uses 104
        8	on entry to runtime.panic
        0	on entry to runtime.morestack16
        -8	after runtime.morestack16 uses 8

runtime.newselect: nosplit stack overflow
        120	assumed on entry to runtime.newselect
        56	after runtime.newselect uses 64
        48	on entry to runtime.printf
        8	after runtime.printf uses 40
        0	on entry to vprintf
        -8	on entry to runtime.morestack16

runtime.selectdefault: nosplit stack overflow
        120	assumed on entry to runtime.selectdefault
        56	after runtime.selectdefault uses 64
        48	on entry to runtime.printf
        8	after runtime.printf uses 40
        0	on entry to vprintf
        -8	on entry to runtime.morestack16

runtime.selectgo: nosplit stack overflow
        120	assumed on entry to runtime.selectgo
        0	after runtime.selectgo uses 120
        -8	on entry to runtime.gosched

On arm, 5c was tagging functions NOSPLIT that should
not have been, like the recursive function printpanics:

printpanics: nosplit stack overflow
        124	assumed on entry to printpanics
        112	after printpanics uses 12
        108	on entry to printpanics
        96	after printpanics uses 12
        92	on entry to printpanics
        80	after printpanics uses 12
        76	on entry to printpanics
        64	after printpanics uses 12
        60	on entry to printpanics
        48	after printpanics uses 12
        44	on entry to printpanics
        32	after printpanics uses 12
        28	on entry to printpanics
        16	after printpanics uses 12
        12	on entry to printpanics
        0	after printpanics uses 12
        -4	on entry to printpanics

R=r, r2
CC=golang-dev
https://golang.org/cl/4188061

d9fd1144

misc/dashboard/builder: talk to hg with utf-8 encoding always. · 7f5acfb2
Andrew Gerrand authored Feb 22, 2011
```
Fixes #1465.

R=rsc
CC=golang-dev
https://golang.org/cl/4172063
```
7f5acfb2
.hgignore: add *.cgo*.{c,go} · bd44684f
Gustavo Niemeyer authored Feb 22, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4168059
```
bd44684f

gob: compute information about a user's type once. · 14b6a477

Rob Pike authored Feb 22, 2011

Other than maybe cleaning the code up a bit, this has
little practical effect for now, but lays the foundation
for remembering the method set of a type, which can
be expensive.

R=rsc
CC=golang-dev
https://golang.org/cl/4193041

14b6a477

go spec: fix local link · 556506e8
Robert Griesemer authored Feb 22, 2011
```
Fixes #1543.

R=rsc, r2
CC=golang-dev
https://golang.org/cl/4169068
```
556506e8

reflect: add a secret method to ArrayOrSliceType. · 795ff00d

Rob Pike authored Feb 22, 2011

It was observed that the interface was generic enough
that several other types implemented it too.

Fixes #1530.

R=rsc
CC=golang-dev
https://golang.org/cl/4169063

795ff00d

http: add pointer from Handle[Func] to ServeMux docs · 1e73fed8
Andrew Gerrand authored Feb 22, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4169065
```
1e73fed8

21 Feb, 2011 5 commits

http: cleaned up HEAD request method. · 1f39ed8a

Padraig Kitterick authored Feb 21, 2011

Removed a redefinition of the request URL which is never used and
redundant checking of the return value from send().

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4184061

1f39ed8a

A+C: Padraig Kitterick · c010b0e8
Andrew Gerrand authored Feb 21, 2011
```
R=dsymonds
CC=golang-dev
https://golang.org/cl/4186065
```
c010b0e8
testing: Fix typo on Logf doc comment. · 1634390f
David Symonds authored Feb 21, 2011
```
R=rsc, r2
CC=golang-dev
https://golang.org/cl/4167064
```
1634390f

image/png: support for more formats · ca0d4830

Mikael Tillenius authored Feb 21, 2011

Added support for reading images with grayscale + alpha and
for images with depth 1, 2 or 4.

R=nigeltao
CC=golang-dev
https://golang.org/cl/4174053

ca0d4830

A+C: Mikael Tillenius (individual CLA) · c015dd21
Nigel Tao authored Feb 21, 2011
```
R=dsymonds
CC=golang-dev
https://golang.org/cl/4179063
```
c015dd21

20 Feb, 2011 1 commit
- runtime-gdb.py: gdb pretty printer for go strings properly handles length. · db22e236
  Luuk van Dijk authored Feb 20, 2011
```
R=rsc, r2
CC=golang-dev
https://golang.org/cl/4183060
```
  db22e236
19 Feb, 2011 2 commits
- spec: delete incorrect obsolete mention of selector working on · e041b998
  Rob Pike authored Feb 19, 2011
```
pointer to interface type.

R=golang-dev, niemeyer, gri
CC=golang-dev
https://golang.org/cl/4173067
```
  e041b998
- crypto/openpgp/packet: comment typo fix. · 7b166cd7
  Adam Langley authored Feb 19, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4178065
```
  7b166cd7
18 Feb, 2011 13 commits

build: reduce the use of subshells in recursive make · 8a8ecda5

Dave Cheney authored Feb 18, 2011

Using make -C $* rather than (cd $* ; make) results in a small,
but measurable improvement in build times where compilation is
not the major component. eg.

before - ~/go/src/pkg$ time make
        real	0m1.176s
        user	0m0.639s
        sys	0m0.399s
after - ~/go/src/pkg$ time make
        real	0m0.916s
        user	0m0.571s
        sys	0m0.243s

There are other places in the distribution src/make.common for example
that could also benefit from this change.

R=adg
CC=golang-dev, rsc
https://golang.org/cl/4174055

8a8ecda5

misc/dashboard: tweak build fail notification email · 79ba1ce0
Andrew Gerrand authored Feb 18, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4170063
```
79ba1ce0
net: fix multicast tests · 90847a85
Dave Cheney authored Feb 18, 2011
```
R=rsc, mikioh, rsc1, dho
CC=golang-dev
https://golang.org/cl/4174056
```
90847a85
crypto/openpgp/packet: fix testing print (missing arg) · 7e6488f9
Rob Pike authored Feb 18, 2011
```
R=agl
CC=golang-dev
https://golang.org/cl/4173062
```
7e6488f9
godoc: serve robots.txt raw · 06a923ad
Andrew Gerrand authored Feb 18, 2011
```
R=gri, niemeyer, rsc, r2, r
CC=golang-dev
https://golang.org/cl/4188063
```
06a923ad
.hgignore: add doc/codelab/wiki/*.bin · 3173821a
Gustavo Niemeyer authored Feb 18, 2011
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4173063
```
3173821a
runtime: handle non-standard call sequences in arm traceback · 7081e675
Russ Cox authored Feb 18, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4191048
```
7081e675

fix build · f07a45f2

Russ Cox authored Feb 18, 2011

pieces of an upcoming CL leaked into CL 4168056

TBR=r
CC=golang-dev
https://golang.org/cl/4180057

f07a45f2

runtime: record $GOROOT_FINAL for runtime.GOROOT · d3ac545f
Russ Cox authored Feb 18, 2011
```
Update #1527.

R=adg, oerdnj
CC=golang-dev
https://golang.org/cl/4171060
```
d3ac545f

ld: drop rpath · afac1c26

Russ Cox authored Feb 18, 2011

Was required by old cgo but we don't
generate stub .so files anymore.

Update #1527.

R=iant
CC=golang-dev
https://golang.org/cl/4168056

afac1c26

crypto/rsa: left-pad OAEP results when needed. · 19370973

Adam Langley authored Feb 18, 2011

PKCS#1 v2.1 section 7.1.1 says that the result of an OAEP encryption
is "an octet string of length $k$". Since we didn't left-pad the
result it was previously possible for the result to be smaller when
the most-significant byte was zero.

Fixes #1519.

R=rsc
CC=golang-dev
https://golang.org/cl/4175059

19370973

go/scanner: update comment · 547918e3
Robert Griesemer authored Feb 18, 2011
```
R=r, r2
CC=golang-dev
https://golang.org/cl/4184053
```
547918e3

testing: rename cmdline flags to avoid conflicts · 6d9db54b

Gustavo Niemeyer authored Feb 18, 2011

Flags defined in the testing package may conflict
with real flags defined in the main package, or in
any other imported package.

This change makes them less likely to be used for
other purposes.

R=r, rsc, r2
CC=golang-dev
https://golang.org/cl/4167055

6d9db54b

17 Feb, 2011 12 commits
- 6l: pe fixes · 8ba4df2e
  Wei Guangjing authored Feb 17, 2011
```
R=rsc, brainman
CC=golang-dev
https://golang.org/cl/4182061
```
  8ba4df2e
- html: small documentation fix. · 42ed1ad4
  Nigel Tao authored Feb 17, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4169058
```
  42ed1ad4
- http: send full URL in proxy requests · 063125df
  Russ Cox authored Feb 17, 2011
```
Fixes #53.  (again)

R=agl1
CC=golang-dev
https://golang.org/cl/4167054
```
  063125df
- json: only use alphanumeric tags · f80d0024
  Russ Cox authored Feb 17, 2011
```
Almost the same definition as Go identifier names.
(Leading digits are allowed.)

Fixes #1520.

R=r, r2
CC=golang-dev
https://golang.org/cl/4173061
```
  f80d0024
- gc: interface error message fixes · 6e03ed32
  Russ Cox authored Feb 17, 2011
```
Fixes #1526.

R=ken2
CC=golang-dev
https://golang.org/cl/4190051
```
  6e03ed32
- net: remove comment fragments · dd7403b1
  Russ Cox authored Feb 17, 2011
```
I have no idea how I meant to complete that sentence.

R=r, r2
CC=golang-dev
https://golang.org/cl/4191046
```
  dd7403b1
- runtime: descriptive panics for use of nil map · f2852ba6
  Russ Cox authored Feb 17, 2011
```
R=r, r2
CC=golang-dev
https://golang.org/cl/4173060
```
  f2852ba6
- crypto/rand: Added read buffer to speed up requests for small amounts of bytes. · 71288891
  Albert Strasheim authored Feb 17, 2011
```
R=agl1, rsc
CC=golang-dev
https://golang.org/cl/4170056
```
  71288891
- misc/dashboard: notify golang-dev on build failure · 00d8d005
  Andrew Gerrand authored Feb 17, 2011
```
Fixes #1229.

R=rsc
CC=golang-dev
https://golang.org/cl/4178048
```
  00d8d005
- Effective Go: stress that comments are uninterpreted text · 6095ff38
  Rob Pike authored Feb 17, 2011
```
that should look in godoc.

R=rsc, dsymonds
CC=golang-dev
https://golang.org/cl/4192041
```
  6095ff38
- arm runtime: attempt to fix build by adding casp (same as cas) · eb868815
  Rob Pike authored Feb 17, 2011
```
untested.

Fixes #1523.

R=rsc
CC=golang-dev
https://golang.org/cl/4171057
```
  eb868815
- doc/devel/release: discuss StartProcess in release notes · 6ccc96ee
  Andrew Gerrand authored Feb 17, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4172051
```
  6ccc96ee