Commits · da5a251dde539c91c87caab4abe3d346f88e82fc · go / golang

02 Dec, 2011 12 commits

doc: do not slice array literal · da5a251d

Russ Cox authored Dec 02, 2011

The special case in the spec is that you can take the
address of a composite literal using the & operator.

A composite literal is not, however, generally addressable,
and the slice operator requires an addressable argument,
so [3]int{1,2,3}[:] is invalid.  This tutorial code and one bug
report are the only places in the tree where it appears.

R=r, gri
CC=golang-dev
https://golang.org/cl/5437120

da5a251d

spec: avoid slice of array literal · 4dfe976d
Russ Cox authored Dec 02, 2011
```
R=gri
CC=golang-dev
https://golang.org/cl/5451078
```
4dfe976d

exp/ssh: allow for msgUserAuthBanner during authentication · bd9dc3d5

Gustav Paul authored Dec 02, 2011

The SSH spec allows for the server to send a banner message to the client at any point during the authentication process. Currently the ssh client auth types all assume that the first response from the server after issuing a userAuthRequestMsg will be one of a couple of possible authentication success/failure messages. This means that client authentication breaks if the ssh server being connected to has a banner message configured.

This changeset refactors the noneAuth, passwordAuth and publickeyAuth types' auth() function and allows for msgUserAuthBanner during authentication.

R=golang-dev, rsc, dave, agl
CC=golang-dev
https://golang.org/cl/5432065

bd9dc3d5

asn1: fix incorrect prints found by govet · 6f0ef845
Robert Hencke authored Dec 02, 2011
```
R=golang-dev
CC=golang-dev
https://golang.org/cl/5449063
```
6f0ef845

net, syscall: remove BindToDevice API from UDPConn, IPConn · cf4acf80

Mikio Hara authored Dec 02, 2011

For now a pair of socket options SOL_SOCKET and SO_BINDTODEVICE
is supported on Linux only. I'd like to demote BindToDevice API
to syscall level because it's Linux dependent one.

In the near future, probably we may have a bit more portable
API that using IPROTO_IP/IPV6 level socket options to specify,
identify an inbound, outbound IP interface on incoming, outgoing
UDP and raw IP packets.

R=cw, golang-dev
CC=golang-dev
https://golang.org/cl/5447071

cf4acf80

encoding/gob: don't send type info for unexported fields · 30775f67
Rob Pike authored Dec 02, 2011
```
Fixes #2517.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5440079
```
30775f67
build: update .hgignore · 8bc64108
Andrew Gerrand authored Dec 02, 2011
```
R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/5451073
```
8bc64108
dashboard: make response format consistent, implement commit GET mode · 6c165d7a
Andrew Gerrand authored Dec 02, 2011
```
R=golang-dev, dsymonds, rsc
CC=golang-dev
https://golang.org/cl/5437113
```
6c165d7a

os/exec: make LookPath always search the current directory under Windows. · 2a876beb

Benny Siegert authored Dec 02, 2011

cmd.exe implicitly looks in "." before consulting PATH.
LookPath should match this behavior.

R=alex.brainman, rsc
CC=golang-dev
https://golang.org/cl/5434093

2a876beb

doc: correct weekly snapshot notes on hash.Hash change · 517503da
Andrew Gerrand authored Dec 02, 2011
```
I had the wrong idea when I wrote this.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5437111
```
517503da
template: move the empty check into parse, which needs it when constructing · e6b33717
Rob Pike authored Dec 02, 2011
```
tree sets.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5449062
```
e6b33717

html: allow whitespace between head and body · a5d30086

Andrew Balholm authored Dec 02, 2011

Also ignore <head> tag after </head>.

Pass tests6.dat, test 0:
<!doctype html></head> <head>

| <!DOCTYPE html>
| <html>
|   <head>
|   " "
|   <body>

Also pass tests through test 6:
<body>
<div>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5447064

a5d30086

01 Dec, 2011 25 commits

go/doc: exclude lines ending in ':' from possible headings · 6ea3a268

Robert Griesemer authored Dec 01, 2011

This is a more conservative approach to heading detection and
removes 11 headings from the current repository (several in
fmt). The current headscan output is:

/home/gri/go3/src/cmd/goinstall (package documentation)
        Remote Repositories
        The GOPATH Environment Variable
/home/gri/go3/src/pkg/exp/gotype (package documentation)
        Examples
/home/gri/go3/src/pkg/html/template (package template)
        Introduction
        Contexts
        Errors
        A fuller picture
        Contexts
        Typed Strings
        Security Model
/home/gri/go3/src/pkg/text/template (package template)
        Actions
        Arguments
        Pipelines
        Variables
        Examples
        Functions
        Associated templates
        Nested template definitions
18 headings found

R=golang-dev, adg, rsc
CC=golang-dev
https://golang.org/cl/5437105

6ea3a268

godoc: improved output of examples in html. · 1e5aecf6
Volker Dobler authored Dec 01, 2011
```
Fixes #2467.
Fixes #2464.

R=golang-dev, rsc, adg
CC=golang-dev
https://golang.org/cl/5447051
```
1e5aecf6
gofmt: applied gofmt -w -s src misc · 15a3a5cf
Robert Griesemer authored Dec 01, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5451070
```
15a3a5cf

go/doc: switch ToHTML from []byte to string argument · e281576b

Robert Griesemer authored Dec 01, 2011

- this removes extra conversions from strings to bytes and vice versa
  for each comment
- minor cleanups

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5434096

e281576b

tag weekly.2011-12-02 · 158ca3c4
Andrew Gerrand authored Dec 01, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5450062
```
158ca3c4
weekly.2011-12-02 · 7af813a7
Andrew Gerrand authored Dec 01, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5447067
```
7af813a7

go/doc: better headscan · bc9ce6a1

Robert Griesemer authored Dec 01, 2011

- scan all comments not just the package documentation
- declutter output so that false positives are more easily spotted
- count the number of headings to quickly see differences
- minor tweaks

R=golang-dev, r, r
CC=golang-dev
https://golang.org/cl/5450061

bc9ce6a1

time: update doc string for Error method · 473de603
Rob Pike authored Dec 01, 2011
```
Fixes #2512.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5449057
```
473de603

os: add ModeType constant to mask file type bits · d2b77bb1

Gustavo Niemeyer authored Dec 01, 2011

This covers the lack of IsRegular comfortably:

    if stat.Mode()&os.ModeType == 0 { ... }

R=golang-dev, r, rsc, r, gustavo
CC=golang-dev
https://golang.org/cl/5440075

d2b77bb1

os: be consistent with receiver names for godoc TOC alignment · 744fb521
Brad Fitzpatrick authored Dec 01, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5449056
```
744fb521
exp/ssh: export type signal. Renamed to Signal · fad57c0c
Gustav Paul authored Dec 01, 2011
```
R=dave, agl, rsc, golang-dev, n13m3y3r
CC=golang-dev
https://golang.org/cl/5450059
```
fad57c0c
gofix: add time+fileinfo fix · c52b7db4
Russ Cox authored Dec 01, 2011
```
R=adg, rogpeppe, r, cw
CC=golang-dev
https://golang.org/cl/5450050
```
c52b7db4

go/doc: Detect headings in comments and format them as h3 in html. · a6729b30

Volker Dobler authored Dec 01, 2011

To structure larger sections of comments in html output headings
are detected in comments and formated as h3 in the generated html.
A simple heuristic is used to detect headings in comments:
A heading is a non-blank, non-indented line preceded by a blank
line. It is followed by a blank and a non-blank, non-indented line.
A heading must start with an uppercase letter and end with a letter,
digit or a colon.  A heading may not contain punctuation characters.

R=jan.mercl, gri, adg, rsc, r
CC=golang-dev
https://golang.org/cl/5437056

a6729b30

crypto/tls: cleanup certificate load on windows · d5f37122

Alex Brainman authored Dec 01, 2011

- correct syscall.CertEnumCertificatesInStore so it returns error
- remove "reflect" dependency

R=hectorchu, agl, rsc
CC=golang-dev, krautz
https://golang.org/cl/5441052

d5f37122

Add a []byte argument to hash.Hash to allow an allocation to be saved. · bac7bc55

Adam Langley authored Dec 01, 2011

This is the result of running `gofix -r hashsum` over the tree, changing
the hash function implementations by hand and then fixing a couple of
instances where gofix didn't catch something.

The changed implementations are as simple as possible while still
working: I'm not trying to optimise in this CL.

R=rsc, cw, rogpeppe
CC=golang-dev
https://golang.org/cl/5448065

bac7bc55

gofix: add a fix for hash.Sum. · 2308aefc

Adam Langley authored Dec 01, 2011

This fix adds an output argument to hash.Sum.

Tree changes in https://golang.org/cl/5448065

R=rsc
CC=golang-dev
https://golang.org/cl/5450051

2308aefc

text/template: replace Add with AddParseTree · d38cc47c

Rob Pike authored Dec 01, 2011

Makes it clear we're adding exactly one tree and creating a
new template for it.

R=rsc
CC=golang-dev
https://golang.org/cl/5448077

d38cc47c

gc: avoid re-genning ninit in branches involving float comparison. · 6bee4e55
Luuk van Dijk authored Dec 01, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5451050
```
6bee4e55
exp/ssh: add Std{in,out,err}Pipe methods to Session · c4d0ac0e
Dave Cheney authored Dec 01, 2011
```
R=gustav.paul, cw, agl, rsc, n13m3y3r
CC=golang-dev
https://golang.org/cl/5433080
```
c4d0ac0e
dashboard: don't choke on weird builder names. · c0a53bbc
David Symonds authored Dec 01, 2011
```
R=adg
CC=golang-dev
https://golang.org/cl/5447060
```
c0a53bbc
tag weekly.2011-12-01 · cd16b4f5
Andrew Gerrand authored Dec 01, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/5448068
```
cd16b4f5
weekly.2011-12-01 · 9dd07f68
Andrew Gerrand authored Dec 01, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5448067
```
9dd07f68
time: fix windows build · 68e30a97
Alex Brainman authored Dec 01, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5440071
```
68e30a97

html/template: make execution thread-safe · 9a86e244

Rob Pike authored Dec 01, 2011

The problem is that execution can modify the template, so it needs
interlocking to have the same thread-safe guarantee as text/template.
Fixes #2439.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5450056

9a86e244

html: implement fragment parsing algorithm · ce27b00f
Andrew Balholm authored Dec 01, 2011
```
Pass the tests in tests4.dat.

R=nigeltao
CC=golang-dev
https://golang.org/cl/5447055
```
ce27b00f

30 Nov, 2011 3 commits

syscall: fix openbsd sysctl hostname/domainname workaround · 595efd0d
Joel Sing authored Nov 30, 2011
```
Fixes #2509.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5451055
```
595efd0d

html/template: update to new template API · 07ee3cc7

Rob Pike authored Nov 30, 2011

Not quite done yet but enough is here to review.

Embedding is eliminated so clients can't accidentally reach
methods of text/template.Template that would break the
invariants.

TODO later: Add and Clone are unimplemented.
TODO later: address issue 2349

R=golang-dev, r, rsc
CC=golang-dev
https://golang.org/cl/5434077

07ee3cc7

undo CL 5436056 / 03560deae933 · 0e62c75b

Dave Cheney authored Nov 30, 2011

Remove the accidentally exported net.Listener

««« original CL description
exp/ssh: remove unused forwarding methods in Server Listener

R=agl, rsc
CC=golang-dev
https://golang.org/cl/5436056

»»»

R=agl, rsc
CC=golang-dev
https://golang.org/cl/5437090

0e62c75b