Commits · dda6d6aa7087f51a59bbe60d7b73d170c715ddd0 · go / golang

20 Apr, 2012 5 commits

test: use testlib in a few more cases (part 2) · dda6d6aa

Shenghou Ma authored Apr 20, 2012

        Introduced "runoutput" cmd for running generated program

R=golang-dev, iant, bradfitz, remyoudompheng
CC=golang-dev
https://golang.org/cl/5869049

dda6d6aa

doc: don't wrap package names in directory listing · f8dde60e
Andrew Gerrand authored Apr 20, 2012
```
Fixes #3522.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6063054
```
f8dde60e

exp/html: start making inBodyIM match the spec · eea5a432

Andrew Balholm authored Apr 20, 2012

Reorder some start tags.

Improve handling of </body>.
Handle </html>.

Pass 2 additional tests (by handling </html>).

R=golang-dev, nigeltao
CC=golang-dev
https://golang.org/cl/6082043

eea5a432

exp/html: ignore null bytes in text · 67910572

Andrew Balholm authored Apr 20, 2012

pass one additional test

R=golang-dev, nigeltao
CC=golang-dev
https://golang.org/cl/6048051

67910572

exp/html: improve afterHeadIM · 7d63ff09

Andrew Balholm authored Apr 20, 2012

Clean up the flow of control.
Fix the TODO for handling <html> tags.
Add a case to ignore doctype declarations.

Pass one additional test.

R=nigeltao
CC=golang-dev
https://golang.org/cl/6072047

7d63ff09

19 Apr, 2012 7 commits

syscall: cleanly exit all Go procs on Plan 9 · 49a7da2d

Akshat Kumar authored Apr 19, 2012

syscall.Exit would originally kill only the calling
Go proc, leaving behind other procs in the
same group. This change makes syscall.Exit call
runtime·exit, which due to CL
https://golang.org/cl/5617048
will cleanly exit all the Go procs in the group.

R=golang-dev, rsc, rminnich, remyoudompheng, ality, john
CC=golang-dev, mirtchovski
https://golang.org/cl/6036051

49a7da2d

exp/html: improve InHeadIM · fca32f02

Andrew Balholm authored Apr 19, 2012

Clean up the flow of control, and add a case for doctype tokens (to
ignore them).

R=nigeltao
CC=golang-dev
https://golang.org/cl/6069045

fca32f02

net/http: add example for FileServer to mention StripPrefix · acb55050
Shenghou Ma authored Apr 19, 2012
```
        Fixes #3530.

R=golang-dev, rsc, bradfitz
CC=golang-dev
https://golang.org/cl/6032052
```
acb55050
A+C: add Bjorn Tillenius (Individual CLA) · a6825405
Brad Fitzpatrick authored Apr 19, 2012
```
R=golang-dev, kevlar
CC=golang-dev
https://golang.org/cl/6075045
```
a6825405
A+C: Add Michael Chaten (Individual CLA) · 3af088db
Brad Fitzpatrick authored Apr 19, 2012
```
R=golang-dev, kevlar
CC=golang-dev
https://golang.org/cl/6075044
```
3af088db

exp/html: add parseImpliedToken method to parser · c88ca590

Andrew Balholm authored Apr 19, 2012

This method will allow us to be explicit about what we're doing when
we insert an implied token, and avoid repeating the logic involved in
multiple places.

R=nigeltao
CC=golang-dev
https://golang.org/cl/6060048

c88ca590

doc/articles/image_draw.html: Change ColorImage to Uniform · e03dd509
Benny Siegert authored Apr 19, 2012
```
Fixes #3474.

R=nigeltao
CC=golang-dev
https://golang.org/cl/6048050
```
e03dd509

18 Apr, 2012 5 commits

net/http/httputil: Clean up ReverseProxy maxLatencyWriter goroutines. · 5694ebf0

Colby Ranger authored Apr 18, 2012

When FlushInterval is specified on ReverseProxy, the ResponseWriter is
wrapped with a maxLatencyWriter that periodically flushes in a
goroutine. That goroutine was not being cleaned up at the end of the
request. This resulted in a panic when Flush() was being called on a
ResponseWriter that was closed.

The code was updated to always send the done message to the flushLoop()
goroutine after copying the body. Futhermore, the code was refactored to
allow the test to verify the maxLatencyWriter behavior.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6033043

5694ebf0

encoding/asn1: allow lengths up to the maximum int value. · 6742d0a0

Adam Langley authored Apr 18, 2012

Previously we capped lengths at 2**24 rather than 2**31.

R=golang-dev, r, r
CC=golang-dev
https://golang.org/cl/6050050

6742d0a0

exp/html: improve beforeHeadIM · b65c9a63

Andrew Balholm authored Apr 18, 2012

Add a case to ignore doctype tokens.

Clean up the flow of control to more clearly match the spec.

Pass one more test.

R=nigeltao
CC=golang-dev
https://golang.org/cl/6062047

b65c9a63

exp/html: adjust beforeHTMLIM to match spec · b39bbf1e

Andrew Balholm authored Apr 18, 2012

Add case for doctype tokens (which are ignored).

This CL does not change the status of any tests.

R=golang-dev, nigeltao
CC=golang-dev
https://golang.org/cl/6061047

b39bbf1e

os/user: simplify test · 90aa56f2

Brad Fitzpatrick authored Apr 18, 2012

Don't require the home directory to exist. Just check
that it returns something.

Fixes #3531

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/6056045

90aa56f2

17 Apr, 2012 7 commits

lib9: fix warning under clang 3.1 · b2c61168
Dave Cheney authored Apr 17, 2012
```
Fixes #3534.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6035054
```
b2c61168

codereview: restore help messages · d3889ff3

Anthony Martin authored Apr 17, 2012

Docstrings were not being set for the wrapper
functions returned by the hgcommand decorator.

R=golang-dev, minux.ma, rsc
CC=golang-dev
https://golang.org/cl/6059043

d3889ff3

exp/html: more comprehensive tests · 9a6cef8b

Andrew Balholm authored Apr 17, 2012

Currently, the html package only runs a limited subset of the tests
in the testdata directory. This tends to limit development of the
parser to fixing the bug that causes the first failing test.

This CL gives it the ability to run all the tests and produce a
log showing the status of each test. (It does it when tests are run with
'go test --update-logs') The status is listed as PASS, FAIL, or PARSE
(PARSE means that parsing produced the correct tree, but rendering and
re-parsing does not produce the same tree).

When 'go test' is run without --update-logs, it runs the tests marked
'PASS' in the logs (and the parsing portion of the tests marked 'PARSE').
Thus it will fail if there has been a regression since the last
time the logs were updated.

My goal for this CL is to allow develoment of the html package to
be less test-driven, while still having the advantages of regression
tests. In other words, one can work on any portion of the parser
and quickly see whether he is breaking things or improving them.

Current statistics of the tests:
$ grep ^PASS *.log|wc -l
        1017
$ grep ^PARSE *.log|wc -l
          46
$ grep ^FAIL *.log|wc -l
         181

R=nigeltao
CC=golang-dev
https://golang.org/cl/6031049

9a6cef8b

flag: update style. · b20163e9
David Symonds authored Apr 17, 2012
```
R=golang-dev, r, r
CC=golang-dev
https://golang.org/cl/6051044
```
b20163e9
cmd/prof: don't build on Plan 9 for now. · 3192cac5
Anthony Martin authored Apr 17, 2012
```
R=golang-dev, bradfitz, akumar
CC=golang-dev
https://golang.org/cl/5629054
```
3192cac5
os: avoid panic when testing errors on Plan 9 · 74607d18
Anthony Martin authored Apr 17, 2012
```
R=golang-dev, bradfitz, akumar
CC=golang-dev
https://golang.org/cl/6017043
```
74607d18

syscall: fix duplicate fd bug for Plan 9 · 4cf577ed

Akshat Kumar authored Apr 17, 2012

This change comes from CL 5536043,
created by Andrey Mirtchovski. His
description follows:

"The plan9 exec child handler does not manage
dup-ed fds from the parent correctly: when a
dup-ed file descriptor appears in the child's fd
list it is closed when first encountered and then
subsequent attempt to dup it later in Pass 2 fails,
resulting in 'fork/exec: fd out of range or not
open'."

R=golang-dev, rminnich, ality
CC=golang-dev, mirtchovski, rsc
https://golang.org/cl/6009046

4cf577ed

16 Apr, 2012 4 commits

CONTRIBUTORS: add Colby Ranger (Google CLA) · bd7c4aee
Brad Fitzpatrick authored Apr 16, 2012
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/6037052
```
bd7c4aee
doc/code: mention $GOBIN · 50d5cf6b
Shenghou Ma authored Apr 16, 2012
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5989045
```
50d5cf6b

runtime: update defs for openbsd · 99fc2817

Joel Sing authored Apr 16, 2012

Update runtime defs for openbsd. Add struct __tfork, which will be
needed by an upcoming change.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/6007050

99fc2817

time: parse fractional second with single digit · c81705f1
Robert Hencke authored Apr 16, 2012
```
Fixes #3487.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6011050
```
c81705f1

15 Apr, 2012 1 commit
- text/template/parse: fix doc comment · 3180137b
  Shenghou Ma authored Apr 15, 2012
```
    Fixes #3529.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6037046
```
  3180137b
14 Apr, 2012 2 commits

strconv: make malloc tests more reliable · 84ef97b5

Dave Cheney authored Apr 14, 2012

Fixes #3495.

I adapted fmt.TestCountMallocs to fix the
existing tests. As the resulting tests did not
appear to belong to either itoa or ftoa I moved
them into their own file.

R=bradfitz, fullung
CC=golang-dev
https://golang.org/cl/5985072

84ef97b5

doc: update Mercurial installation instructions · 0e596024
Andrew Gerrand authored Apr 14, 2012
```
R=r
CC=golang-dev
https://golang.org/cl/6031046
```
0e596024

13 Apr, 2012 3 commits
- cmd/6g: restore magic multiply for /=, %=. · 061061e7
  Rémy Oudompheng authored Apr 13, 2012
```
Also enables turning /= 2 in a right shift.

Part of issue 2230.

R=rsc
CC=golang-dev, remy
https://golang.org/cl/6012049
```
  061061e7
- doc/effective_go.html: fixed the Request channel parameter · 08f919f4
  Jongmin Kim authored Apr 13, 2012
```
R=golang-dev, r
CC=golang-dev, gri
https://golang.org/cl/6010051
```
  08f919f4
- time: panic if UnixNano is out of range · e4389c1d
  Gustavo Niemeyer authored Apr 13, 2012
```
R=golang-dev, remyoudompheng, dsymonds, gustavo, dchest, r, rsc
CC=golang-dev
https://golang.org/cl/5985059
```
  e4389c1d
12 Apr, 2012 6 commits

fmt: fix crash of %b on huge negative int64 · a662d3d9

Rob Pike authored Apr 12, 2012

The buffer had 64 bytes but needs one more for the sign.

Fixes #3510.

R=golang-dev, dave, dsymonds
CC=golang-dev
https://golang.org/cl/6011057

a662d3d9

crypto/tls: don't always use the default private key. · e6e8b723

Adam Langley authored Apr 12, 2012

When SNI based certificate selection is enabled, we previously used
the default private key even if we selected a non-default certificate.

Fixes #3367.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5987058

e6e8b723

encoding/pem: ignore spaces and tabs at the end of header lines. · 55af51d5
Adam Langley authored Apr 12, 2012
```
Fixes #3502.

R=bradfitz
CC=golang-dev
https://golang.org/cl/6011046
```
55af51d5

runtime: speedup GC sweep phase (batch free) · 4945fc8e

Dmitriy Vyukov authored Apr 12, 2012

benchmark old ns/op new ns/op delta
garbage.BenchmarkParser 4370050250 3779668750 -13.51%
garbage.BenchmarkParser-2 3713087000 3628771500 -2.27%
garbage.BenchmarkParser-4 3519755250 3406349750 -3.22%
garbage.BenchmarkParser-8 3386627750 3319144000 -1.99%

garbage.BenchmarkTree 493585529 408102411 -17.32%
garbage.BenchmarkTree-2 500487176 402285176 -19.62%
garbage.BenchmarkTree-4 473238882 361484058 -23.61%
garbage.BenchmarkTree-8 486977823 368334823 -24.36%

garbage.BenchmarkTree2 31446600 31203200 -0.77%
garbage.BenchmarkTree2-2 21469000 21077900 -1.82%
garbage.BenchmarkTree2-4 11007600 10899100 -0.99%
garbage.BenchmarkTree2-8 7692400 7032600 -8.58%

garbage.BenchmarkParserPause 241863263 163249450 -32.50%
garbage.BenchmarkParserPause-2 120135418 112981575 -5.95%
garbage.BenchmarkParserPause-4 83411552 64580700 -22.58%
garbage.BenchmarkParserPause-8 51870697 42207244 -18.63%

garbage.BenchmarkTreePause 20940474 13147011 -37.22%
garbage.BenchmarkTreePause-2 20115124 11146715 -44.59%
garbage.BenchmarkTreePause-4 17217584 7486327 -56.52%
garbage.BenchmarkTreePause-8 18258845 7400871 -59.47%

garbage.BenchmarkTree2Pause 174067190 172674190 -0.80%
garbage.BenchmarkTree2Pause-2 131175809 130615761 -0.43%
garbage.BenchmarkTree2Pause-4 95406666 93972047 -1.50%
garbage.BenchmarkTree2Pause-8 86056095 85334952 -0.84%

garbage.BenchmarkParserLastPause 329932000 324790000 -1.56%
garbage.BenchmarkParserLastPause-2 209383000 210456000 +0.51%
garbage.BenchmarkParserLastPause-4 113981000 112921000 -0.93%
garbage.BenchmarkParserLastPause-8 77967000 76625000 -1.72%

garbage.BenchmarkTreeLastPause 29752000 18444000 -38.01%
garbage.BenchmarkTreeLastPause-2 24274000 14766000 -39.17%
garbage.BenchmarkTreeLastPause-4 19565000 8726000 -55.40%
garbage.BenchmarkTreeLastPause-8 21956000 10530000 -52.04%

garbage.BenchmarkTree2LastPause 314411000 311945000 -0.78%
garbage.BenchmarkTree2LastPause-2 214641000 210836000 -1.77%
garbage.BenchmarkTree2LastPause-4 110024000 108943000 -0.98%
garbage.BenchmarkTree2LastPause-8 76873000 70263000 -8.60%

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5991049

4945fc8e

runtime: add lock-free stack · a5dc7793

Dmitriy Vyukov authored Apr 12, 2012

This is factored out part of the:
https://golang.org/cl/5279048/
(parallel GC)

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5993043

a5dc7793

text/template: catch unexported fields during parse · 2d0d3d8f

Rob Pike authored Apr 12, 2012

It's a common error to reference unexported field names in templates,
especially for newcomers. This catches the error at parse time rather than
execute time so the rare few who check errors will notice right away.

These were always an error, so the net behavior is unchanged.
Should break no existing code, just identify the error earlier.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6009048

2d0d3d8f