Commits · e393efc499b17d6dd13ebf558f57c3cb6a484595 · go / golang

29 Mar, 2011 17 commits

ngotest: a new gotest command, written in Go. · e393efc4

Rob Pike authored Mar 29, 2011

It runs all tests correctly and saves significant time by avoiding the shell script.
However, this is just the code for the command, for review.
A separate CL will move this into the real gotest, which will take some dancing.

R=rsc, peterGo, bsiegert, albert.strasheim, rog, niemeyer, r2
CC=golang-dev
https://golang.org/cl/4281073

e393efc4

CL 4291070: incorporating rsc's feedback · 53653176
Robert Griesemer authored Mar 29, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4313054
```
53653176

crypto/x509: Parse Extended Key Usage extension · a7bb288f

Mikkel Krautz authored Mar 29, 2011

This changeset makes it possible for crypto/x509 to parse
certificates that include the 'Extended Key Usage' extension
with the critical bit set.

R=agl1
CC=golang-dev
https://golang.org/cl/4277075

a7bb288f

asn1: extensions needed for parsing Kerberos · 05451633

Adam Langley authored Mar 29, 2011

* Adds support for GENERAL STRING
* Adds support for APPLICATION tagged values.
* Add UnmarshalWithParams to set parameters for the top-level
  structure

R=golang-dev, rsc1, r
CC=golang-dev
https://golang.org/cl/4291075

05451633

test: adjust bugs/bug322 to match current spec. · 61c9d3f0
Ian Lance Taylor authored Mar 29, 2011
```
R=gri, rsc1
CC=golang-dev
https://golang.org/cl/4328041
```
61c9d3f0

test: avoid undefined error in syntax/if.go. · 469a747e

Ian Lance Taylor authored Mar 29, 2011

Without this the gccgo version of errchk reports an unmatched
error.

R=golang-dev, rsc1
CC=golang-dev
https://golang.org/cl/4327041

469a747e

test: match gccgo error messages for syntax/chan.go. · 0bc37a6d

Ian Lance Taylor authored Mar 29, 2011

chan.go:11:1: error: unexpected ‘}’ in channel type
chan.go:13:16: error: unexpected ‘)’ in channel type
chan.go:16:16: error: unexpected comma in channel type

R=golang-dev, rsc1
CC=golang-dev
https://golang.org/cl/4313055

0bc37a6d

bytes, strings: simplify Join · 47f4ae1a
Evan Shaw authored Mar 29, 2011
```
R=gri, rsc
CC=golang-dev
https://golang.org/cl/4300044
```
47f4ae1a
kate: reorganize, remove closed() · ac74f14b
Evan Shaw authored Mar 29, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4325041
```
ac74f14b

net: implement non-blocking connect · 2f45f72d

Alexey Borzenkov authored Mar 29, 2011

Refactored bind/connect from sock.go into netFD.connect(), as
a consequence newFD() doesn't accept laddr/raddr anymore, and
expects an (optional) call to netFD.connect() followed by a
call to netFD.setAddr().
Windows code is updated, but still uses blocking connect,
since otherwise it needs support for ConnectEx syscall.

R=brainman, rsc
CC=golang-dev
https://golang.org/cl/4303060

2f45f72d

fix build · 98828f03
Russ Cox authored Mar 29, 2011
```
TBR=adg
CC=golang-dev
https://golang.org/cl/4322041
```
98828f03
gofix: netdial · 2a1b4a83
Russ Cox authored Mar 29, 2011
```
R=adg
CC=golang-dev
https://golang.org/cl/4278053
```
2a1b4a83
update tree for package net changes · 5546cc7e
Russ Cox authored Mar 29, 2011
```
Converted with gofix.

R=adg
CC=golang-dev
https://golang.org/cl/4284049
```
5546cc7e

net: drop laddr from Dial, cname from LookupHost; new functions · 41f93a43

Russ Cox authored Mar 29, 2011

Drop laddr argument from Dial.

Drop cname return from LookupHost.

Add LookupIP, LookupCNAME, ParseCIDR, IP.Equal.
Export SplitHostPort, JoinHostPort.
Add AAAA (IPv6) support to host lookups.

Preparations for implementing some of the
lookups using cgo.

ParseCIDR and IP.Equal are logically new in this CL
but accidentally snuck into an earlier CL about unused
labels that was in the same client.

In crypto/tls, drop laddr from Dial to match net.

R=golang-dev, dsymonds, adg, rh
CC=golang-dev
https://golang.org/cl/4244055

41f93a43

tag release.2011-03-28 · 188a17db
Andrew Gerrand authored Mar 29, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4321041
```
188a17db
weekly.2011-03-28 · 33e41802
Andrew Gerrand authored Mar 29, 2011
```
R=r, rsc
CC=golang-dev
https://golang.org/cl/4272072
```
33e41802
go/printer, gofmt: rely on existing line breaks when formatting expression lists · 5a3aae4b
Robert Griesemer authored Mar 29, 2011
```
No impact on existing sources.

Fixes #1632.

R=rsc
CC=golang-dev
https://golang.org/cl/4271083
```
5a3aae4b

28 Mar, 2011 11 commits

go/scanner: return literal as string instead of []byte · b2658452

Robert Griesemer authored Mar 28, 2011

Removed many string conversions in dependent code.
Runs all tests. No change to gofmt output.

R=r
CC=golang-dev
https://golang.org/cl/4291070

b2658452

godoc: fix spelling error · c98145fb
Robert Griesemer authored Mar 28, 2011
```
R=r, r2
CC=golang-dev
https://golang.org/cl/4289079
```
c98145fb
doc: gccgo now supports method expressions and multiple init functions. · d38d66e6
Ian Lance Taylor authored Mar 28, 2011
```
R=gri
CC=golang-dev
https://golang.org/cl/4314047
```
d38d66e6
go/token: use array instead of map for token->string table · 2796ac14
Robert Griesemer authored Mar 28, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4284070
```
2796ac14

net: let OS-specific AddFD routine wake up polling thread. · 0caa0c09

Ian Lance Taylor authored Mar 28, 2011

With gccgo some operating systems require using select rather
than epoll or kevent.  Using select means that we have to wake
up the polling thread each time we add a new file descriptor.
This implements that in the generic code rather than adding
another wakeup channel, even though nothing in the current net
package uses the capability.

R=rsc, iant2
CC=golang-dev
https://golang.org/cl/4284069

0caa0c09

go/ast: implemented NewPackage · 5be77a20

Robert Griesemer authored Mar 28, 2011

NewPackage creates an ast.Package node from
a set of package files and resolves unresolved
identifiers.

Also:
- Changed semantics of Scope.Insert: If an
  object is inserted w/o errors, the result
  is nil (before it was obj).
- Fixed an identifier resolution bug in the
  parser: map keys must not be resolved.

gotype runs through several go/* packages
and successfully resolves all (non-field/method)
identifiers.

R=rog, rsc
CC=golang-dev
https://golang.org/cl/4298044

5be77a20

strings: Map: avoid allocation when string is unchanged · a7a854b8

Brad Fitzpatrick authored Mar 28, 2011

This speeds up strings.ToLower, etc.

before/after:
strings_test.BenchmarkMapNoChanges 1000000 1013 ns/op
strings_test.BenchmarkMapNoChanges 5000000  442 ns/op

R=r, rog, eh, rsc
CC=golang-dev
https://golang.org/cl/4306056

a7a854b8

runtime: fix gdb support for goroutines. · 43512e6c

Luuk van Dijk authored Mar 28, 2011

in gdb, 'info goroutines' and 'goroutine <n> <cmd> were crashing
because the 'g' and 'm' structures had changed a bit.

R=rsc
CC=golang-dev
https://golang.org/cl/4289077

43512e6c

build: add all-qemu.bash, handful of arm fixes · 6b335712
Russ Cox authored Mar 28, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4313051
```
6b335712

test: match gccgo error messages for bug323.go. · dacd1cad

Ian Lance Taylor authored Mar 28, 2011

bug323.go:18:3: error: reference to undefined field or method ‘Meth’
bug323.go:19:3: error: reference to undefined field or method ‘Meth2’

R=golang-dev, rsc1
CC=golang-dev
https://golang.org/cl/4280072

dacd1cad

http: avoid crash when asked for multiple file ranges · 732f2fa2
Russ Cox authored Mar 28, 2011
```
R=adg
CC=golang-dev
https://golang.org/cl/4289076
```
732f2fa2

27 Mar, 2011 3 commits

runtime: fix darwin/amd64 thread VM footprint · 59a89268

Alexey Borzenkov authored Mar 27, 2011

On darwin amd64 it was impossible to create more that ~132 threads. While
investigating I noticed that go consumes almost 1TB of virtual memory per
OS thread and the reason for such a small limit of OS thread was because
process was running out of virtual memory. While looking at bsdthread_create
I noticed that on amd64 it wasn't using PTHREAD_START_CUSTOM.
If you look at http://fxr.watson.org/fxr/source/bsd/kern/pthread_synch.c?v=xnu-1228
you will see that in that case darwin will use stack pointer as stack size,
allocating huge amounts of memory for stack. This change fixes the issue
and allows for creation of up to 2560 OS threads (which appears to be some
Mac OS X limit) with relatively small virtual memory consumption.

R=rsc
CC=golang-dev
https://golang.org/cl/4289075

59a89268

A+C: Alexey Borzenkov (individual CLA) · ffb0a2d4
Russ Cox authored Mar 27, 2011
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/4316042
```
ffb0a2d4

test: match gccgo error messages for bug325.go. · 4675e333

Ian Lance Taylor authored Mar 27, 2011

bug325.go:13:10: error: invalid indirect of ‘unsafe.Pointer’
bug325.go:14:31: error: reference to field ‘foo’ in object which has no fields or methods

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4313050

4675e333

26 Mar, 2011 6 commits

testing: shorten some more tests · 7f9acb53
Rob Pike authored Mar 26, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4314044
```
7f9acb53

test: match gccgo error messages for init.go · d607cb28

Ian Lance Taylor authored Mar 26, 2011

init.go:16:10: error: invalid reference to unexported identifier ‘runtime.init’
init.go:15:2: error: reference to undefined name ‘init’
init.go:17:10: error: reference to undefined name ‘init’

R=golang-dev, rsc1
CC=golang-dev
https://golang.org/cl/4289074

d607cb28

gob: trivial cleanup · a4df525a
Robert Hencke authored Mar 26, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4279074
```
a4df525a
gc: remove interim ... error which rejects valid code. · 2795b131
Ian Lance Taylor authored Mar 26, 2011
```
It's been six months.

R=rsc
CC=golang-dev
https://golang.org/cl/4289073
```
2795b131
dashboard: remove old python/bash builder, update README · c3fa7305
Andrew Gerrand authored Mar 26, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4275076
```
c3fa7305

test: match gccgo error messages for cmp6.go · 4100d1a0

Ian Lance Taylor authored Mar 26, 2011

cmp6.go:28:9: error: incompatible types in binary expression
cmp6.go:29:9: error: incompatible types in binary expression
cmp6.go:40:9: error: incompatible types in binary expression
cmp6.go:41:9: error: incompatible types in binary expression
cmp6.go:48:9: error: expected integer, floating, complex, string, pointer, boolean, interface, slice, map, channel, or function type

R=rsc, r2
CC=golang-dev
https://golang.org/cl/4281071

4100d1a0

25 Mar, 2011 3 commits

testing: shorten some tests. · f0cf7d29

Rob Pike authored Mar 25, 2011

These are the top runners.  More to come.
Also print two digits of timing info under -test.v.

R=rsc
CC=golang-dev
https://golang.org/cl/4317044

f0cf7d29

test: match gccgo error messages for bug081.go. · 4cb660aa
Ian Lance Taylor authored Mar 25, 2011
```
bug081.go:9:9: error: expected type

R=rsc
CC=golang-dev
https://golang.org/cl/4280071
```
4cb660aa
build: handle broken awk in version.bash · d165dc60
Dave Cheney authored Mar 25, 2011
```
R=adg, rsc, ality
CC=golang-dev
https://golang.org/cl/4281069
```
d165dc60