- 17 Oct, 2013 2 commits
-
-
Alberto García Hierro authored
New test added in CL 14611045 causes a deadlock when running the tests with -cpu=n,n because the fakedb driver always waits when opening a new connection after running TestConnectionLeak. Reset its state after. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/14780043
-
David Symonds authored
R=golang-dev, iant CC=golang-dev https://golang.org/cl/14765043
-
- 16 Oct, 2013 6 commits
-
-
Brad Fitzpatrick authored
Found by vet. R=golang-dev, r CC=golang-dev https://golang.org/cl/14762044
-
Robert Griesemer authored
Please note the slight rewording for append: The spec now requires that append reuses the underlying array if it is sufficiently large. Per majority sentiment. This is technically a language change but the current implementation always worked this way. Fixes #5818. Fixes #5180. R=rsc, iant, r, ken, minux.ma, dan.kortschak, rogpeppe, go.peter.90 CC=golang-dev https://golang.org/cl/14419054
-
Alberto García Hierro authored
CL 10726044 introduced a race condition which causes connections to be leaked under certain circumstances. If SetMaxOpenConns is used, the application eventually deadlocks. Otherwise, the number of open connections just keep growing indefinitely. Fixes #6593 R=golang-dev, bradfitz, tad.glines, bketelsen CC=golang-dev https://golang.org/cl/14611045
-
Alberto García Hierro authored
Add a check at the end of every test to make sure there are no leaked connections after running a test. Avoid incorrectly decrementing the number of open connections when the driver connection ends up it a bad state (numOpen was decremented twice). Prevent leaking a Rows struct (which ends up leaking a connection) in Row.Scan() when a *RawBytes destination is improperly used. Close the Rows struct in TestRowsColumns. Update #6593 R=golang-dev, bradfitz, dave CC=golang-dev https://golang.org/cl/14642044
-
Shenghou Ma authored
Replaces CL 14682044. Fixes #6506. R=rsc, iant, dave CC=golang-dev https://golang.org/cl/14717043
-
Shenghou Ma authored
Fixes #6595. R=golang-dev, adg CC=golang-dev https://golang.org/cl/14425062
-
- 15 Oct, 2013 8 commits
-
-
Russ Cox authored
The preamble may want to #define some special symbols and then #include <sys/types.h> itself. The builtin prolog also #includes <sys/types.h>, which would break such a preamble (because the second #include will be a no-op). The use of sys/types.h in the builtin prolog is new since Go 1.1, so this should preserve the semantics of more existing cgo code than we would otherwise. It also fixes src/pkg/syscall/mkall.sh's use of go tool cgo -godefs on some Linux systems. Thanks to fullung@ for identifying the problem. Fixes #6558. R=golang-dev, iant CC=golang-dev https://golang.org/cl/14684044
-
Alex Brainman authored
undone because the change slows down profile collection significantly and unpredictable at times (see comments at https://golang.org/cl/14231047 for details) ««« original CL description runtime: collect profiles even while on g0 stack Fixes #6417 R=golang-dev, rsc CC=golang-dev https://golang.org/cl/14231047 »»» R=golang-dev, rsc CC=golang-dev https://golang.org/cl/14535046
-
Russ Cox authored
Ensure that clang always exits with a non-zero status by giving it something that it always warns about (the statement "1;"). Fixes #6128. R=golang-dev, iant, minux.ma CC=golang-dev https://golang.org/cl/14702043
-
Russ Cox authored
Otherwise the link fails. Fixes build. TBR=golang-dev CC=golang-dev https://golang.org/cl/14483050
-
Russ Cox authored
TBR=golang-dev CC=golang-dev https://golang.org/cl/14454063
-
Russ Cox authored
Fixes #6506. R=golang-dev, r CC=golang-dev https://golang.org/cl/14682044
-
Oling Cat authored
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/14516057
-
Alex Brainman authored
Update #6417 R=golang-dev, rsc CC=golang-dev https://golang.org/cl/14604043
-
- 14 Oct, 2013 5 commits
-
-
Keith Randall authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/14441070
-
Michael Piatek authored
Fixes #5953 R=dsymonds, bradfitz, rsc CC=golang-dev https://golang.org/cl/14434044
-
David Symonds authored
R=golang-dev, r CC=golang-dev, piatek https://golang.org/cl/14681043
-
Ian Lance Taylor authored
R=golang-dev, r, minux.ma CC=golang-dev https://golang.org/cl/14669045
-
Shenghou Ma authored
make use of $USER or %USERNAME% to determine the current user. Fixes #6578. R=golang-dev, bradfitz, alex.brainman CC=golang-dev https://golang.org/cl/14649043
-
- 12 Oct, 2013 1 commit
-
-
Shenghou Ma authored
R=golang-dev, dave CC=golang-dev https://golang.org/cl/14629043
-
- 11 Oct, 2013 10 commits
-
-
Rob Pike authored
Why doesn't tidy complain about these? Found by manlio.perillo. Fixes #6571 R=golang-dev, adg CC=golang-dev https://golang.org/cl/14608044
-
Ian Lance Taylor authored
This matches the behaviour of builder.includeArgs in cmd/go/build.go. R=golang-dev, minux.ma CC=golang-dev https://golang.org/cl/14535048
-
Ian Lance Taylor authored
Fixes #6567. R=golang-dev, minux.ma CC=golang-dev https://golang.org/cl/14502060
-
Ian Lance Taylor authored
R=golang-dev, minux.ma CC=golang-dev https://golang.org/cl/14611043
-
Ian Lance Taylor authored
R=golang-dev, jsing, r CC=golang-dev https://golang.org/cl/14523056
-
Shenghou Ma authored
Fixes #6557. R=golang-dev, rsc, tracey.brendan CC=golang-dev https://golang.org/cl/14432053
-
Andrew Gerrand authored
This will allow "godoc godoc", "godoc vet", "godoc cover" to work. Fixes #6527. R=r, dsymonds CC=golang-dev https://golang.org/cl/14566049
-
Yasuhiro Matsumoto authored
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/14454059
-
Rob Pike authored
At the moment, godoc expands the example in the link, but in the past it has not. Add a waffle word to allow either possibility. Also change the order of cases in the switch in Compare to be consistent with the other switch in the function. R=golang-dev, iant CC=golang-dev https://golang.org/cl/14439055
-
Francesc Campoy authored
R=adg, campoy, r CC=golang-dev https://golang.org/cl/14419059
-
- 10 Oct, 2013 3 commits
-
-
Dominik Honnef authored
The regexp for closing CLs that were sent by you but committed by someone else only matched messages for the main repository, because of the added &repo=... for subrepositories. R=golang-dev, r CC=golang-dev https://golang.org/cl/14512045
-
Dominik Honnef authored
R=adonovan CC=golang-dev https://golang.org/cl/14548049
-
Dominik Honnef authored
Fixes #6531. R=adonovan CC=golang-dev https://golang.org/cl/14523043
-
- 09 Oct, 2013 5 commits
-
-
Ian Lance Taylor authored
Fixes #6553. R=golang-dev, mikioh.mikioh CC=golang-dev https://golang.org/cl/14526048
-
Keith Randall authored
R=golang-dev, iant CC=golang-dev https://golang.org/cl/14441055
-
Ian Lance Taylor authored
Also add the action's object directory to the list of directories we use to find SWIG shared libraries. Fixes #6521. R=golang-dev, minux.ma CC=golang-dev https://golang.org/cl/14369043
-
Ian Lance Taylor authored
R=golang-dev, minux.ma CC=golang-dev https://golang.org/cl/14448044
-
Russ Cox authored
Fixes a bug in cgo on OS X using clang. See golang.org/issue/6472 for details. Fixes #6472. R=golang-dev, iant CC=golang-dev https://golang.org/cl/14575043
-