Commits · e7030e7fef46244eb5e0b50a474d95fde1b2c21f · go / golang

11 Jul, 2011 1 commit

exp/template: static check for defined variables. · e7030e7f

Rob Pike authored Jul 11, 2011

Worth catching at parse time rather than execution. Plus it's really easy.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4641100

e7030e7f

10 Jul, 2011 6 commits

exp/eval: delete binary · 1fe9c9a7

Rob Pike authored Jul 10, 2011

Mistakenly checked in.
Fixes #2058.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4670057

1fe9c9a7

flag: make -help nicer. · e44853c9

Rob Pike authored Jul 10, 2011

- suppress the print that -help is not defined.
- return a special error code if -help is set
- do not change behavior if an explict "help" flag is defined.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4641099

e44853c9

exp/template: add functions print and println. · abae8471
Rob Pike authored Jul 10, 2011
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4687041
```
abae8471
exp/template: package documentation · 4acddca4
Rob Pike authored Jul 10, 2011
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4675072
```
4acddca4

image: change Pix[0] to mean top-left corner of an image's Rect instead · 87d9e7e1

Nigel Tao authored Jul 10, 2011

of the origin.

image/png and image/jpeg benchmarks show no significant changes.

The image/draw changes suggest to me that making a gofix for this is not
feasible. People are just going to have to make manual fixes.

R=r
CC=golang-dev
https://golang.org/cl/4681044

87d9e7e1

archive/zip: add Writer · 4d47600f
Andrew Gerrand authored Jul 10, 2011
```
R=bradfitz, dchest, r, rsc
CC=golang-dev
https://golang.org/cl/4523077
```
4d47600f

09 Jul, 2011 8 commits

multipart: use textproto to handle multiline header · e45b3213
Evan Martin authored Jul 09, 2011
```
R=bradfitz
CC=golang-dev
https://golang.org/cl/4686044
```
e45b3213
CONTRIBUTORS: add Evan Martin (Google CLA) · 658a02a5
Brad Fitzpatrick authored Jul 09, 2011
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/4657089
```
658a02a5

http: update triv.go with gofix · b053400e

Andrew Balholm authored Jul 09, 2011

Sample code in triv.go wouldn't compile because it didn't use the new
FileSystem interface.
This was discussed on golang-nuts on July 7.
https://groups.google.com/forum/#!topic/golang-nuts/NMhZk3Ft_Vc

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/4684044

b053400e

exp/template: better template invocation · 3987b912

Rob Pike authored Jul 09, 2011

1) Make the value optional ({{template "foo"}})
2) Allow the template identifier to be a thing of type *Template.
The second makes it easy to drop templates in to a set dynamically
during invocation.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4671056

3987b912

tutorial: remove all line numbers and references to them. · c17347ee
Rob Pike authored Jul 09, 2011
```
R=golang-dev, mikioh.mikioh, dsymonds
CC=golang-dev
https://golang.org/cl/4675070
```
c17347ee
doc/progs: gofmt -w · ab3365d3
Mikio Hara authored Jul 09, 2011
```
R=r, gri, r
CC=golang-dev
https://golang.org/cl/4662085
```
ab3365d3
exp/template: vars as arguments to functions and methods. · e86d727e
Rob Pike authored Jul 09, 2011
```
That should be it, bugs aside.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4671055
```
e86d727e

exp/template: variable evaluation. · 58baf648

Rob Pike authored Jul 09, 2011

Still need to do static checking of declarations during parse.

R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/4667070

58baf648

08 Jul, 2011 12 commits

exp/template: delete upward evaluation. · bbf5eb5b

Rob Pike authored Jul 08, 2011

It was an ill-advised carryover from the previous template package.
Also clean up function evaluation.
Also add a Name method to Template.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/4657088

bbf5eb5b

exp/template: forgot to allow . as a function argument · d3d08e1e
Rob Pike authored Jul 08, 2011
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4671053
```
d3d08e1e
exp/template: parse variables and declarations · b8c66429
Rob Pike authored Jul 08, 2011
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4631099
```
b8c66429

exp/template: lex variables · ee14989e

Rob Pike authored Jul 08, 2011

Variables start with'$' and are declared with ':='.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4662084

ee14989e

exp/template: add a tree-walking example to the test. · 02039b63

Rob Pike authored Jul 08, 2011

Also fix a comment formatting glitch.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4672054

02039b63

exp/template: the must-have MustParse functions · ad58dc9d
Andrew Gerrand authored Jul 08, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4641096
```
ad58dc9d
exp/template: allow fields and methods to be found in parent structs. · a852981d
Rob Pike authored Jul 08, 2011
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4657085
```
a852981d
tag weekly.2011-07-07 · 6f4cf399
Andrew Gerrand authored Jul 08, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4664066
```
6f4cf399

weekly.2011-07-07 · 4f03ef79

Andrew Gerrand authored Jul 08, 2011

R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/4668061

4f03ef79

sort: rename helpers: s/Sort// in sort.Sort[Float64s|Ints|Strings] · 5bcbcab3
Andrew Gerrand authored Jul 08, 2011
```
Includes 'sorthelpers' gofix and updates to tree.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/4631098
```
5bcbcab3
gob: export fields in structs in the package documentation. · e67a2504
David Symonds authored Jul 08, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4648075
```
e67a2504

cgi: don't depend on CGI.pm for tests · 3236097a

Brad Fitzpatrick authored Jul 08, 2011

CGI.pm used to be part of the Perl core,
but some distros now bundle perl-core
and perl-modules separately.

It's not worth depending on.

R=golang-dev, mattn.jp
CC=golang-dev
https://golang.org/cl/4675063

3236097a

07 Jul, 2011 11 commits

image/draw: add draw tests where the destination image doesn't start · b39afde8

Nigel Tao authored Jul 07, 2011

at (0, 0).

Also refactor the test to use the SubImage method rather than monkeying
with an image's Pix and Rect fields.

R=r
CC=golang-dev
https://golang.org/cl/4678045

b39afde8

crypto/x509: prevent chain cycles in Verify · d1d466f6

Adam Langley authored Jul 07, 2011

It's possible to include a self-signed root certificate as an
intermediate and push Verify into a loop.

I already had a test for this so I thought that it was ok, but it
turns out that the test was void because the Verisign root certificate
doesn't contain the "IsCA" flag and so it wasn't an acceptable
intermediate certificate for that reason.

R=bradfitz
CC=golang-dev
https://golang.org/cl/4657080

d1d466f6

doc: remove ed from apt-get package list · 141f676b
Brad Fitzpatrick authored Jul 07, 2011
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/4672052
```
141f676b
image: tighten Paletted.Opaque to check only those palette entries · 03f987c8
Nigel Tao authored Jul 07, 2011
```
in the image, not all palette entries.

R=r
CC=golang-dev
https://golang.org/cl/4672049
```
03f987c8

os: fix documentation for FileInfo.Name. · 07c9a925

Rob Pike authored Jul 07, 2011

It's the base name, not the full name.
Fixes #2047.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4680041

07c9a925

exp/template: handle pointers and values in empty interfaces. · 238274ed
Rob Pike authored Jul 07, 2011
```
R=golang-dev, r, mattn.jp
CC=golang-dev
https://golang.org/cl/4664064
```
238274ed

exp/template: change the name from 'metacharacter' to 'delimiter', · 8d538c6d

Rob Pike authored Jul 07, 2011

because that's what they are.
No semantic change.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4675060

8d538c6d

crypto/openpgp: fixed dangerous use of for loop variable · 582d6e58

Gideon Jan-Wessel Redelinghuys authored Jul 07, 2011

In function readSignedMessage a pointer to for loop variable 'key' was incorrectly being assigned
to md.SignedBy. Changed so that md.SignedBy is pointing to the 'more correct' memory position.

R=golang-dev, r, agl
CC=golang-dev
https://golang.org/cl/4631088

582d6e58

C+A: Gideon Jan-Wessel Redelinghuys · 7875ecb4

Rob Pike authored Jul 07, 2011

R=golang-dev, dsymonds
CC=gjredelinghuys, golang-dev
https://golang.org/cl/4675059

7875ecb4

syscall: rearrange windows code so 386 and amd64 can share files · e71fc0c1
Alex Brainman authored Jul 07, 2011
```
R=golang-dev, r
CC=golang-dev, vcc.163
https://golang.org/cl/4641093
```
e71fc0c1
CONTRIBUTORS: add Google contributor mpvl@golang.org · ae19943e
Rob Pike authored Jul 07, 2011
```
R=golang-dev, dsymonds
CC=golang-dev, mpvl
https://golang.org/cl/4643075
```
ae19943e

06 Jul, 2011 2 commits

exp/template: index: forgot the always last-to-arrive uintptr. · 46ecd6f1
Rob Pike authored Jul 06, 2011
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/4636087
```
46ecd6f1

asn1: support T61 and UTF8 string. · 1aa571d3

Adam Langley authored Jul 06, 2011

There is no end to the kitchen sink of string types in ASN.1.

Fixes #1953.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/4672045

1aa571d3