Commits · e803e1cfa61d6677025440b7336e20854f619755 · go / golang

08 Aug, 2012 5 commits

misc/dashboard/codereview: fixes for non-reviewers. · e803e1cf

David Symonds authored Aug 08, 2012

Also rename the testing CGI argument from "email" to "user".

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6454117

e803e1cf

crypto/rand: Example for Read. · 4230dd4c
Yves Junqueira authored Aug 08, 2012
```
R=adg, remyoudompheng, rsc, r
CC=golang-dev
https://golang.org/cl/6457085
```
4230dd4c
misc/dashboard/codereview: fix obo · bacccefa
Russ Cox authored Aug 08, 2012
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6443091
```
bacccefa

godoc: make id attributes unique · 3601f277

Robert Griesemer authored Aug 08, 2012

Some browsers (e.g. IE9) ignore the case of 'id' attributes
which can lead to conflicts. Prefix non-generated 'id's with
"pkg-" to make them different from any generated attribute.

Also: Added missing entry for "Other packages" to top-level
index.

Fixes #3851.

R=adg, dsymonds
CC=golang-dev
https://golang.org/cl/6449105

3601f277

exp/html: foster-parent text correctly · fca45719

Andrew Balholm authored Aug 08, 2012

If a table contained whitespace, text nodes would not get foster parented
correctly.

Pass 1 additional test.

R=nigeltao
CC=golang-dev
https://golang.org/cl/6459054

fca45719

07 Aug, 2012 12 commits

image/jpeg: send a correct Start Of Scan (SOS) header. · 5f7bec69

Nigel Tao authored Aug 07, 2012

Section B.2.3 of http://www.w3.org/Graphics/JPEG/itu-t81.pdf discusses
the End of spectral selection (Se) byte.

Apparently many JPEG decoders ignore the Se byte (or let it through
with a warning), but some configurations reject them. For example,
http://download.blender.org/source/chest/blender_2.03_tree/jpeg/jcmaster.c
has these lines:

if (Ss != 0 || Se != DCTSIZE2-1 || Ah != 0 || Al != 0)
  ERREXIT1(cinfo, JERR_BAD_PROG_SCRIPT, scanno);

Fixes #3916.

R=r
CC=golang-dev
https://golang.org/cl/6459052

5f7bec69

runtime: inline several float64 routines to speed up complex128 division · 0157c72d

Shenghou Ma authored Aug 07, 2012

Depends on CL 6197045.

Result obtained on Core i7 620M, Darwin/amd64:
benchmark                       old ns/op    new ns/op    delta
BenchmarkComplex128DivNormal           57           28  -50.78%
BenchmarkComplex128DivNisNaN           49           15  -68.90%
BenchmarkComplex128DivDisNaN           49           15  -67.88%
BenchmarkComplex128DivNisInf           40           12  -68.50%
BenchmarkComplex128DivDisInf           33           13  -61.06%

Result obtained on Core i7 620M, Darwin/386:
benchmark                       old ns/op    new ns/op    delta
BenchmarkComplex128DivNormal           89           50  -44.05%
BenchmarkComplex128DivNisNaN          307          802  +161.24%
BenchmarkComplex128DivDisNaN          309          788  +155.02%
BenchmarkComplex128DivNisInf          278          237  -14.75%
BenchmarkComplex128DivDisInf           46           22  -52.46%

Result obtained on 700MHz OMAP4460, Linux/ARM:
benchmark                       old ns/op    new ns/op    delta
BenchmarkComplex128DivNormal         1557          465  -70.13%
BenchmarkComplex128DivNisNaN         1443          220  -84.75%
BenchmarkComplex128DivDisNaN         1481          218  -85.28%
BenchmarkComplex128DivNisInf          952          216  -77.31%
BenchmarkComplex128DivDisInf          861          231  -73.17%

The 386 version has a performance regression, but as we have
decided to use SSE2 instead of x87 FPU for 386 too (issue 3912),
I won't address this issue.

R=dsymonds, mchaten, iant, dave, mtj, rsc, r
CC=golang-dev
https://golang.org/cl/6024045

0157c72d

io: document ReaderFrom and WriterTo · c8423f90
Brad Fitzpatrick authored Aug 07, 2012
```
Fixes #3711

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/6445083
```
c8423f90
text/template: fix range example. · b3caa2ba
Yves Junqueira authored Aug 07, 2012
```
R=r
CC=adg, gobot, golang-dev
https://golang.org/cl/6449096
```
b3caa2ba

exp/html: correctly handle <title> after </head> · 5530a426

Andrew Balholm authored Aug 07, 2012

The <title> element was getting removed from the stack of open elements,
when its parent, the <head> element should have been removed instead.

Pass 2 additional tests.

R=nigeltao
CC=golang-dev
https://golang.org/cl/6449101

5530a426

net/http: disable TestServeFileFromCWD test on windows · 0bfa31e9

Alex Brainman authored Aug 07, 2012

This is an attempt to fix windows build. Will restore
once we know what the problem is.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6461046

0bfa31e9

doc: fix some HTML syntax errors · edc7b473
Shenghou Ma authored Aug 07, 2012
```
R=adg
CC=golang-dev
https://golang.org/cl/6458043
```
edc7b473
cmd/5l: dwarf line number support for Linux/ARM · 0cb04168
Shenghou Ma authored Aug 07, 2012
```
   Part of issue 3747.

R=dave, lvd, rsc
CC=golang-dev
https://golang.org/cl/6084044
```
0cb04168
cmd/go: remove $WORK paths in generated binaries · df623d03
Shenghou Ma authored Aug 07, 2012
```
        Fixes #3748.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6357064
```
df623d03

math, runtime: use a NaN that matches gcc's · 6e9506a7

Shenghou Ma authored Aug 07, 2012

        our old choice is not working properly at least on VFPv2 in
ARM1136JF-S (it's not preserved across float64->float32 conversions).

        Fixes #3745.

R=dave, rsc
CC=golang-dev
https://golang.org/cl/6344078

6e9506a7

runtime: remove unnecessary ROUND in alg.c · 41645847

Shenghou Ma authored Aug 07, 2012

        Introduced in CL 6452046.

R=golang-dev, nigeltao, dave
CC=golang-dev
https://golang.org/cl/6459051

41645847

misc/cgo/{life,stdio}, test/run.go: use test/run.go to do the cgo tests · 1e95429c

Shenghou Ma authored Aug 07, 2012

   Enhances test/run.go to support testing other directories
   Will enable stdio tests on Windows in a follow-up CL.

R=golang-dev, alex.brainman, rsc
CC=golang-dev
https://golang.org/cl/6220049

1e95429c

06 Aug, 2012 5 commits

exp/html: fix foster-parenting when elements are implicitly closed · 2276ab92

Andrew Balholm authored Aug 06, 2012

When an element (like <nobr> or <p>) was implicitly closed by another
start tag, it would keep foster parenting from working because
the check for what was on top of the stack of open elements was
in the wrong place.

Move the check to addChild.

Pass 2 additional tests.

R=nigeltao
CC=golang-dev
https://golang.org/cl/6460045

2276ab92

net: fix spurious EADDRNOTAVAIL errors · e1cf7d6f
Russ Cox authored Aug 06, 2012
```
R=golang-dev, fullung
CC=golang-dev
https://golang.org/cl/6443085
```
e1cf7d6f
syscall: fix plan9 build broken by CL 6458050 · 8b5d4c3c
Alexey Borzenkov authored Aug 06, 2012
```
R=golang-dev, rsc
CC=golang-dev, r, yarikos
https://golang.org/cl/6454104
```
8b5d4c3c
test/run: ignore all but .go file during compiledir action · 1df9ee03
Alex Brainman authored Aug 06, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6454091
```
1df9ee03

net: fix TCPListener file leak to child processes · 2d2866ee

Brad Fitzpatrick authored Aug 06, 2012

Hold ForkLock during dup of fd + cloexec in the net pkg,
per the locking policy documented in syscall/exec_unix.go.

R=golang-dev, dsymonds, adg
CC=golang-dev
https://golang.org/cl/6457080

2d2866ee

05 Aug, 2012 7 commits

syscall: return EINVAL when string arguments have NUL characters · a108369c

Alexey Borzenkov authored Aug 05, 2012

Since NUL usually terminates strings in underlying syscalls, allowing
it when converting string arguments is a security risk, especially
when dealing with filenames. For example, a program might reason that
filename like "/root/..\x00/" is a subdirectory or "/root/" and allow
access to it, while underlying syscall will treat "\x00" as an end of
that string and the actual filename will be "/root/..", which might
be unexpected. Returning EINVAL when string arguments have NUL in
them makes sure this attack vector is unusable.

R=golang-dev, r, bradfitz, fullung, rsc, minux.ma
CC=golang-dev
https://golang.org/cl/6458050

a108369c

syscall: add some new syscall numbers from NetBSD-current · 8efb70f9
Benny Siegert authored Aug 05, 2012
```
R=golang-dev
CC=golang-dev
https://golang.org/cl/6454100
```
8efb70f9

runtime: faster string equality. · 77f3e189

Rémy Oudompheng authored Aug 05, 2012

benchmark                                old ns/op    new ns/op    delta
BenchmarkCompareStringEqual                     51           35  -30.20%
BenchmarkCompareStringIdentical                 51            7  -85.71%
BenchmarkCompareStringSameLength                25           18  -28.29%
BenchmarkCompareStringDifferentLength            2            2   +1.46%

R=golang-dev, rsc
CC=golang-dev, remy
https://golang.org/cl/6450092

77f3e189

misc/dashboard/codereview: show first line of last message in thread · ab058b35

Russ Cox authored Aug 05, 2012

This line helps me to tell whether the CL is waiting for me or I'm waiting for the author.

Also:
 - vertical-align table cells so buttons are always aligned with CL headers.
 - add email= to show front page for someone else.

 Demo at http://rsc.gocodereview.appspot.com/.
 Until this is deployed for real, some recently changed CLs may be
 missing the 'first line of last message' part.

R=dsymonds
CC=golang-dev
https://golang.org/cl/6446065

ab058b35

bufio: discourage use of ReadLine · ea392b88

Russ Cox authored Aug 05, 2012

Too many people use it without reading what it does.
Those people want ReadBytes or ReadString.

Fixes #3906.

R=golang-dev, iant, r
CC=golang-dev
https://golang.org/cl/6442087

ea392b88

strconv: speedup AppendFloat/FormatFloat. · ff03482f

Rémy Oudompheng authored Aug 05, 2012

The improvement is obtained by eliminating the zero
initialization of a large structure that is only
needed when the fast path fails.

Also add a missing roundtrip test for float32s.

benchmark                              old ns/op    new ns/op    delta
BenchmarkAppendFloatDecimal                  301          180  -40.20%
BenchmarkAppendFloat                         486          388  -20.16%
BenchmarkAppendFloatExp                      492          383  -22.15%
BenchmarkAppendFloatNegExp                   478          370  -22.59%
BenchmarkAppendFloatBig                      650          541  -16.77%
BenchmarkAppendFloat32Integer                308          180  -41.56%
BenchmarkAppendFloat32ExactFraction          449          333  -25.84%
BenchmarkAppendFloat32Point                  494          390  -21.05%
BenchmarkAppendFloat32Exp                    488          387  -20.70%
BenchmarkAppendFloat32NegExp                 488          378  -22.54%

R=r, rsc
CC=golang-dev, remy
https://golang.org/cl/6346081

ff03482f

exp/html: don't treat SVG <title> like HTML <title> · 74db9d29

Andrew Balholm authored Aug 05, 2012

The content of an HTML <title> element is RCDATA, but the content of an SVG
<title> element is parsed as tags. Now the parser doesn't go into RCDATA
mode in foreign content.

Pass 4 additional tests.

R=nigeltao
CC=golang-dev
https://golang.org/cl/6448111

74db9d29

04 Aug, 2012 3 commits

cmd/go: allow to use syso files with cgo · 2f2df2ac

Dmitriy Vyukov authored Aug 04, 2012

I have C functions implemented in .syso file (rather than .so or inlined in .go file).
W/o this change the gcc invocation fails with undefined symbols.

R=minux.ma, rsc
CC=golang-dev
https://golang.org/cl/6352076

2f2df2ac

cmd/cc: allow to call nested packages from within C code · 8be5e8a4

Dmitriy Vyukov authored Aug 04, 2012

E.g. sync/atomic.LoadInt32() can be called as sync»atomic·LoadInt32()

R=rsc
CC=golang-dev
https://golang.org/cl/6448057

8be5e8a4

cmd/go, go/build, misc/swig: add SWIG support to Go tool · 6fa38e5e
Ian Lance Taylor authored Aug 04, 2012
```
R=adg, rsc, franciscossouza, seb.binet, gen.battle
CC=golang-dev
https://golang.org/cl/5845071
```
6fa38e5e

03 Aug, 2012 8 commits

5a, 5l, math: Add support for ABSD, ABSF floating point instructions. · dee5adcf
Michał Derkacz authored Aug 03, 2012
```
R=golang-dev, dave, rsc, minux.ma
CC=golang-dev
https://golang.org/cl/6225051
```
dee5adcf
cmd/8g: fix miscompilation due to BADWIDTH. · 823962c5
Rémy Oudompheng authored Aug 03, 2012
```
Fixes #3899.

R=rsc
CC=golang-dev, remy
https://golang.org/cl/6453084
```
823962c5

cmd/gc: accept switches on comparable arrays. · f4f1ba2b

Rémy Oudompheng authored Aug 03, 2012

The compiler is incorrectly rejecting switches on arrays of
comparable types. It also doesn't catch incomparable structs
when typechecking the switch, leading to unreadable errors
during typechecking of the generated code.

Fixes #3894.

R=rsc
CC=gobot, golang-dev, r, remy
https://golang.org/cl/6442074

f4f1ba2b

crypto/elliptic: explicitly handle P+P, ∞+P and P+∞ · 728f1913

Adam Langley authored Aug 03, 2012

These aren't needed for scalar multiplication, but since we export a
generic Add function we should handle it.

This change also corrects two bugs in p224Contract that it turned up.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6458076

728f1913

cmd/ld: add PT_PAX_FLAGS ELF header · 3f34248a

Russ Cox authored Aug 03, 2012

PAX systems are Linux systems that are more paranoid about memory permissions.
These flags tell them to relax when running Go binaries.

Fixes #47.

R=iant
CC=golang-dev
https://golang.org/cl/6326054

3f34248a

debug/elf: Add support for getting DynTag string table values. · cf067503
Mike Rosset authored Aug 03, 2012
```
R=rsc
CC=golang-dev
https://golang.org/cl/6430064
```
cf067503
go/build: tiny cleanup · f3a45d46
Robert Griesemer authored Aug 03, 2012
```
R=rsc
CC=golang-dev
https://golang.org/cl/6453083
```
f3a45d46

crypto/tls: remove flakey tests · e1077420

Adam Langley authored Aug 03, 2012

This removes some (non-short only) tests that involved connections to
the outside world and thus were flakey. This does remove some test
coverage of the root fetchers on non-Windows platforms, but the right
place for that is crypto/x509.

R=golang-dev, krautz, rsc
CC=golang-dev
https://golang.org/cl/6455085

e1077420