Commits · ed494c6398cf5172d2af7b9839583661e0cffbc0 · go / golang

05 Nov, 2009 24 commits
- gofmt-ify sort, sync · ed494c63
  Robert Griesemer authored Nov 05, 2009
```
R=rsc
http://go/go-review/1018057
```
  ed494c63
- gofmt-ify strconv · 314b358a
  Robert Griesemer authored Nov 05, 2009
```
(and remove an empty line at the end of a file)

R=rsc
http://go/go-review/1017046
```
  314b358a
- gofmt-ify net · 5d377054
  Robert Griesemer authored Nov 05, 2009
```
R=rsc
http://go/go-review/1017045
```
  5d377054
- gofmt-ify image · 7df45566
  Robert Griesemer authored Nov 05, 2009
```
R=rsc
http://go/go-review/1017044
```
  7df45566
- gofmt-ify hash, http · ca2a69ea
  Robert Griesemer authored Nov 05, 2009
```
(gofmt will be able to re-align map entries as in http nicely,
eventually)

R=rsc
http://go/go-review/1018055
```
  ca2a69ea
- gofmt-ify tabwriter · b16e6ab1
  Robert Griesemer authored Nov 05, 2009
```
R=rsc
http://go/go-review/1017042
```
  b16e6ab1
- more comment formatting: · 1fede304
  Robert Griesemer authored Nov 05, 2009
```
- preserve (some) indentation of comment text for /*-style comments
  even if the first comment line does not contain any text that might
  suggest the "correct" indentation
- enabled because otherwise existing larger comments get re-formatted
  (this will not introduce a lot of changes since comments of this
  kind - until now - were not changed with respect to indentation)

R=rsc
http://go/go-review/1016047
```
  1fede304
- bumper for video · 7f534246
  Rob Pike authored Nov 05, 2009
```
R=rsc
http://go/go-review/1017038
```
  7f534246
- gofmt-ify unicode · 841c18a9
  Robert Griesemer authored Nov 05, 2009
```
R=r
http://go/go-review/1018051
```
  841c18a9
- fixing (badly) linux_arm syscall. · 55ba9d6a
  Kai Backman authored Nov 05, 2009
```
R=rsc
http://go/go-review/1017037
```
  55ba9d6a
- - add a blank before the opening { for multi-line composites · 601ee480
  Robert Griesemer authored Nov 05, 2009
```
(request by r)
- feature temporarily disabled

R=rsc
CC=r
http://go/go-review/1018052
```
  601ee480
- gofmt-ify os · 398f220d
  Robert Griesemer authored Nov 05, 2009
```
R=r
http://go/go-review/1017034
```
  398f220d
- speed up 6l · 9c753543
  Ken Thompson authored Nov 05, 2009
```
hopefully no change

R=rsc
http://go/go-review/1017035
```
  9c753543
- package patch · cc1a9792
  Russ Cox authored Nov 05, 2009
```
R=r
http://go/go-review/1018043
```
  cc1a9792
- add a final section with a complete example · 31053d4e
  Rob Pike authored Nov 05, 2009
```
R=rsc
CC=go-dev
http://go/go-review/1017033
```
  31053d4e
- gofmt-ify compress · 5fca0bca
  Robert Griesemer authored Nov 05, 2009
```
R=rsc
http://go/go-review/1016045
```
  5fca0bca
- gofmt-ify ebnf · b6d0a22d
  Robert Griesemer authored Nov 05, 2009
```
R=r
http://go/go-review/1018050
```
  b6d0a22d
- gofmt-ify bufio · 646a2c5a
  Robert Griesemer authored Nov 05, 2009
```
R=rsc
http://go/go-review/1018049
```
  646a2c5a
- gofmt-ify asn1 · 03678f74
  Robert Griesemer authored Nov 05, 2009
```
R=rsc
http://go/go-review/1018047
```
  03678f74
- gofmt-ify src/pkg/archive · 517ebbb2
  Robert Griesemer authored Nov 05, 2009
```
R=rsc
http://go/go-review/1018046
```
  517ebbb2
- gofmt-ify crypto · eabcc981
  Robert Griesemer authored Nov 05, 2009
```
R=agl
CC=rsc
http://go/go-review/1017032
```
  eabcc981
- gofmt-ify src/pkg/go (excluding printer directory due to pending CL, · 2ce57ec1
  Robert Griesemer authored Nov 05, 2009
```
and parser.go and scanner_test.go which have minor formatting issues)

R=rsc
http://go/go-review/1016042
```
  2ce57ec1
- rename testfiles from .go -> .orig so that they won't be · 26c3f6c1
  Robert Griesemer authored Nov 05, 2009
```
picked up by gofmt (they should not be modified) or godoc
(testdata should not be considered a potential package
directory)

R=rsc
http://go/go-review/1018045
```
  26c3f6c1
- gofmt-ify bytes · 688a6ff7
  Robert Griesemer authored Nov 05, 2009
```
R=r
http://go/go-review/1016044
```
  688a6ff7
04 Nov, 2009 16 commits
- better placement of /*-style comments interspersed with code on one line · 789b31a4
  Robert Griesemer authored Nov 04, 2009
```
R=rsc
http://go/go-review/1017030
```
  789b31a4
- bytes.SplitAfter and strings.SplitAfter · 5d436b9d
  Russ Cox authored Nov 04, 2009
```
most common usage is:

	lines := strings.SplitAfter(text, "\n", 0)

R=r
http://go/go-review/1018042
```
  5d436b9d
- doc doc doc · 3de3af51
  Russ Cox authored Nov 04, 2009
```
R=r
http://go/go-review/1016039
```
  3de3af51
- avoid infinite recursion in matcher. · e414fda6
  Russ Cox authored Nov 04, 2009
```
after sync (or sync --local), clean up repository:
	* look for and close CLs submitted on our behalf
	* remove unmodified files from CLs
	* warn about empty CLs

R=r
http://go/go-review/1017029
```
  e414fda6
- panic can't print interfaces well so use err.String() · 56cba885
  Rob Pike authored Nov 04, 2009
```
R=rsc
http://go/go-review/1016041
```
  56cba885
- - always format blocks with closing } on a new line, even if empty · 2f792d32
  Robert Griesemer authored Nov 04, 2009
```
- at the moment this also affects single-line function declarations
  because we have disabled them at the moment (but not single-line
  function literals)

R=rsc
http://go/go-review/1016040
```
  2f792d32
- stylistic issues in a couple of cmd docs · 98ac4c6e
  Rob Pike authored Nov 04, 2009
```
R=rsc
http://go/go-review/1017028
```
  98ac4c6e
- document godoc and gofmt · 0d3dd3c9
  Rob Pike authored Nov 04, 2009
```
R=rsc
http://go/go-review/1018036
```
  0d3dd3c9
- remove reference to /home/r · 4bb0271a
  Robert Griesemer authored Nov 04, 2009
```
R=rsc
http://go/go-review/1018039
```
  4bb0271a
- - complete html-escaping also in printer.go · 6dbf7aa1
  Robert Griesemer authored Nov 04, 2009
```
R=rsc
http://go/go-review/1017027
```
  6dbf7aa1
- - respect source line breaks in grouped declarations · c8c3f1d5
  Robert Griesemer authored Nov 04, 2009
```
- made ast.Spec nodes implement Node interface
- added extra test cases

R=rsc
http://go/go-review/1016038
```
  c8c3f1d5
- fix bufio test case · 524ade9a
  Robert Griesemer authored Nov 04, 2009
```
R=rsc
http://go/go-review/1018038
```
  524ade9a
- remove "em" unit from td width specification · d06dc14a
  Robert Griesemer authored Nov 04, 2009
```
R=rsc
http://go/go-review/1018037
```
  d06dc14a
- two more regexp tweaks · d441d545
  Russ Cox authored Nov 04, 2009
```
TBR=r
http://go/go-review/1016037
```
  d441d545
- allow "no such host" and also "no answer from server"; · af2bc8f9
  Russ Cox authored Nov 04, 2009
```
seems to help on snow leopard.

TBR=r
http://go/go-review/1018035
```
  af2bc8f9
- various tweaks to code review. · 506ce11f
  Russ Cox authored Nov 04, 2009
```
main one is to check at submit time that
user name being used in checkin message
is listed in the CONTRIBUTORS file.
this should catch misconfigurations.

another is to cut the @domain part
from the R= and CC= lines on checkin
messages, so that cc'ing someone on
a change does not mean their email
address is recorded for all time.

R=r
CC=go-dev
http://go/go-review/1016036
```
  506ce11f