- 07 Aug, 2012 6 commits
-
-
Shenghou Ma authored
R=adg CC=golang-dev https://golang.org/cl/6458043
-
Shenghou Ma authored
Part of issue 3747. R=dave, lvd, rsc CC=golang-dev https://golang.org/cl/6084044
-
Shenghou Ma authored
Fixes #3748. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6357064
-
Shenghou Ma authored
our old choice is not working properly at least on VFPv2 in ARM1136JF-S (it's not preserved across float64->float32 conversions). Fixes #3745. R=dave, rsc CC=golang-dev https://golang.org/cl/6344078
-
Shenghou Ma authored
Introduced in CL 6452046. R=golang-dev, nigeltao, dave CC=golang-dev https://golang.org/cl/6459051
-
Shenghou Ma authored
Enhances test/run.go to support testing other directories Will enable stdio tests on Windows in a follow-up CL. R=golang-dev, alex.brainman, rsc CC=golang-dev https://golang.org/cl/6220049
-
- 06 Aug, 2012 5 commits
-
-
Andrew Balholm authored
When an element (like <nobr> or <p>) was implicitly closed by another start tag, it would keep foster parenting from working because the check for what was on top of the stack of open elements was in the wrong place. Move the check to addChild. Pass 2 additional tests. R=nigeltao CC=golang-dev https://golang.org/cl/6460045
-
Russ Cox authored
R=golang-dev, fullung CC=golang-dev https://golang.org/cl/6443085
-
Alexey Borzenkov authored
R=golang-dev, rsc CC=golang-dev, r, yarikos https://golang.org/cl/6454104
-
Alex Brainman authored
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6454091
-
Brad Fitzpatrick authored
Hold ForkLock during dup of fd + cloexec in the net pkg, per the locking policy documented in syscall/exec_unix.go. R=golang-dev, dsymonds, adg CC=golang-dev https://golang.org/cl/6457080
-
- 05 Aug, 2012 7 commits
-
-
Alexey Borzenkov authored
Since NUL usually terminates strings in underlying syscalls, allowing it when converting string arguments is a security risk, especially when dealing with filenames. For example, a program might reason that filename like "/root/..\x00/" is a subdirectory or "/root/" and allow access to it, while underlying syscall will treat "\x00" as an end of that string and the actual filename will be "/root/..", which might be unexpected. Returning EINVAL when string arguments have NUL in them makes sure this attack vector is unusable. R=golang-dev, r, bradfitz, fullung, rsc, minux.ma CC=golang-dev https://golang.org/cl/6458050
-
Benny Siegert authored
R=golang-dev CC=golang-dev https://golang.org/cl/6454100
-
Rémy Oudompheng authored
benchmark old ns/op new ns/op delta BenchmarkCompareStringEqual 51 35 -30.20% BenchmarkCompareStringIdentical 51 7 -85.71% BenchmarkCompareStringSameLength 25 18 -28.29% BenchmarkCompareStringDifferentLength 2 2 +1.46% R=golang-dev, rsc CC=golang-dev, remy https://golang.org/cl/6450092
-
Russ Cox authored
This line helps me to tell whether the CL is waiting for me or I'm waiting for the author. Also: - vertical-align table cells so buttons are always aligned with CL headers. - add email= to show front page for someone else. Demo at http://rsc.gocodereview.appspot.com/. Until this is deployed for real, some recently changed CLs may be missing the 'first line of last message' part. R=dsymonds CC=golang-dev https://golang.org/cl/6446065
-
Russ Cox authored
Too many people use it without reading what it does. Those people want ReadBytes or ReadString. Fixes #3906. R=golang-dev, iant, r CC=golang-dev https://golang.org/cl/6442087
-
Rémy Oudompheng authored
The improvement is obtained by eliminating the zero initialization of a large structure that is only needed when the fast path fails. Also add a missing roundtrip test for float32s. benchmark old ns/op new ns/op delta BenchmarkAppendFloatDecimal 301 180 -40.20% BenchmarkAppendFloat 486 388 -20.16% BenchmarkAppendFloatExp 492 383 -22.15% BenchmarkAppendFloatNegExp 478 370 -22.59% BenchmarkAppendFloatBig 650 541 -16.77% BenchmarkAppendFloat32Integer 308 180 -41.56% BenchmarkAppendFloat32ExactFraction 449 333 -25.84% BenchmarkAppendFloat32Point 494 390 -21.05% BenchmarkAppendFloat32Exp 488 387 -20.70% BenchmarkAppendFloat32NegExp 488 378 -22.54% R=r, rsc CC=golang-dev, remy https://golang.org/cl/6346081
-
Andrew Balholm authored
The content of an HTML <title> element is RCDATA, but the content of an SVG <title> element is parsed as tags. Now the parser doesn't go into RCDATA mode in foreign content. Pass 4 additional tests. R=nigeltao CC=golang-dev https://golang.org/cl/6448111
-
- 04 Aug, 2012 3 commits
-
-
Dmitriy Vyukov authored
I have C functions implemented in .syso file (rather than .so or inlined in .go file). W/o this change the gcc invocation fails with undefined symbols. R=minux.ma, rsc CC=golang-dev https://golang.org/cl/6352076
-
Dmitriy Vyukov authored
E.g. sync/atomic.LoadInt32() can be called as sync»atomic·LoadInt32() R=rsc CC=golang-dev https://golang.org/cl/6448057
-
Ian Lance Taylor authored
R=adg, rsc, franciscossouza, seb.binet, gen.battle CC=golang-dev https://golang.org/cl/5845071
-
- 03 Aug, 2012 13 commits
-
-
Michał Derkacz authored
R=golang-dev, dave, rsc, minux.ma CC=golang-dev https://golang.org/cl/6225051
-
Rémy Oudompheng authored
Fixes #3899. R=rsc CC=golang-dev, remy https://golang.org/cl/6453084
-
Rémy Oudompheng authored
The compiler is incorrectly rejecting switches on arrays of comparable types. It also doesn't catch incomparable structs when typechecking the switch, leading to unreadable errors during typechecking of the generated code. Fixes #3894. R=rsc CC=gobot, golang-dev, r, remy https://golang.org/cl/6442074
-
Adam Langley authored
These aren't needed for scalar multiplication, but since we export a generic Add function we should handle it. This change also corrects two bugs in p224Contract that it turned up. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6458076
-
Russ Cox authored
PAX systems are Linux systems that are more paranoid about memory permissions. These flags tell them to relax when running Go binaries. Fixes #47. R=iant CC=golang-dev https://golang.org/cl/6326054
-
Mike Rosset authored
R=rsc CC=golang-dev https://golang.org/cl/6430064
-
Robert Griesemer authored
R=rsc CC=golang-dev https://golang.org/cl/6453083
-
Adam Langley authored
This removes some (non-short only) tests that involved connections to the outside world and thus were flakey. This does remove some test coverage of the root fetchers on non-Windows platforms, but the right place for that is crypto/x509. R=golang-dev, krautz, rsc CC=golang-dev https://golang.org/cl/6455085
-
Adam Langley authored
We already support reading ECDSA certificates and this change adds write support. R=golang-dev, bradfitz, rsc CC=golang-dev https://golang.org/cl/6422046
-
Marcel van Lohuizen authored
for dealing with CLDR files: - Add now taxes a list of indexes of colelems that are variables. Checking and handling is now done by the Builder. VariableTop is now also properly generated using the Build method. - Introduced separate Builder, called Tailoring, for creating tailorings of root table. This clearly separates the functionality for building a table based on weights (the allkeys* files) versus tables based on LDML XML files. - Tailorings are now added by two calls instead of one: SetAnchor and Insert. This more closely reflects the structure of LDML side and simplifies the implementation of both the client and library side. It also preserves some information that is otherwise hard to recover for the Builder. - Allow the LDML XML element extend to be passed to Insert. This simplifies both client and library implementation. R=r CC=golang-dev https://golang.org/cl/6454061
-
Alex Brainman authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/6442080
-
Robert Griesemer authored
R=r CC=golang-dev https://golang.org/cl/6442076
-
Robert Griesemer authored
Don't print unexported struct fields; their values are not accessible via reflection. Fixes #3898. Also: - added support for arrays - print empty maps, arrays, slices, structs on one line for a denser output - added respective test cases R=r CC=golang-dev https://golang.org/cl/6454089
-
- 02 Aug, 2012 3 commits
-
-
Andrew Balholm authored
Pass 2 additional tests. R=nigeltao CC=golang-dev https://golang.org/cl/6454090
-
Nigel Tao authored
R=andybalholm CC=golang-dev https://golang.org/cl/6453071
-
Rémy Oudompheng authored
R=golang-dev, gri CC=golang-dev https://golang.org/cl/6445068
-
- 01 Aug, 2012 3 commits
-
-
Robert Griesemer authored
Process a package's object in a reproducible order (rather then in map order) so that we get error messages in reproducible order. R=r CC=golang-dev https://golang.org/cl/6449076
-
Andrew Balholm authored
The text inside <script> tags is not ordinary raw text; there are all sorts of other complications. This CL implements those complications. Pass 76 additional tests. R=nigeltao CC=golang-dev https://golang.org/cl/6443070
-
Shenghou Ma authored
we can't import "./bug0" on windows, as it will trigger "import path contains invalid character ':'" error. instead, we pass "-D." and "-I." to gc to override this behavior. this idea is due to remyoudompheng. R=golang-dev, r, alex.brainman, remyoudompheng CC=golang-dev https://golang.org/cl/6441074
-