Skip to content

G
golang
Switch branch/tag
  1. 20 Apr, 2012 3 commits
  3. 19 Apr, 2012 7 commits
  5. 18 Apr, 2012 5 commits
  7. 17 Apr, 2012 7 commits
    • Dave Cheney's avatar
      lib9: fix warning under clang 3.1 · b2c61168
      Dave Cheney authored 
      Fixes #3534.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6035054
      b2c61168
    • Anthony Martin's avatar
      codereview: restore help messages · d3889ff3
      Anthony Martin authored 
      Docstrings were not being set for the wrapper
functions returned by the hgcommand decorator.

R=golang-dev, minux.ma, rsc
CC=golang-dev
https://golang.org/cl/6059043
      d3889ff3
    • Andrew Balholm's avatar
      exp/html: more comprehensive tests · 9a6cef8b
      Andrew Balholm authored 
      Currently, the html package only runs a limited subset of the tests
in the testdata directory. This tends to limit development of the
parser to fixing the bug that causes the first failing test.

This CL gives it the ability to run all the tests and produce a
log showing the status of each test. (It does it when tests are run with
'go test --update-logs') The status is listed as PASS, FAIL, or PARSE
(PARSE means that parsing produced the correct tree, but rendering and
re-parsing does not produce the same tree).

When 'go test' is run without --update-logs, it runs the tests marked
'PASS' in the logs (and the parsing portion of the tests marked 'PARSE').
Thus it will fail if there has been a regression since the last
time the logs were updated.

My goal for this CL is to allow develoment of the html package to
be less test-driven, while still having the advantages of regression
tests. In other words, one can work on any portion of the parser
and quickly see whether he is breaking things or improving them.

Current statistics of the tests:
$ grep ^PASS *.log|wc -l
        1017
$ grep ^PARSE *.log|wc -l
          46
$ grep ^FAIL *.log|wc -l
         181

R=nigeltao
CC=golang-dev
https://golang.org/cl/6031049
      9a6cef8b
    • David Symonds's avatar
      flag: update style. · b20163e9
      David Symonds authored 
      R=golang-dev, r, r
CC=golang-dev
https://golang.org/cl/6051044
      b20163e9
    • Anthony Martin's avatar
      cmd/prof: don't build on Plan 9 for now. · 3192cac5
      Anthony Martin authored 
      R=golang-dev, bradfitz, akumar
CC=golang-dev
https://golang.org/cl/5629054
      3192cac5
    • Anthony Martin's avatar
      os: avoid panic when testing errors on Plan 9 · 74607d18
      Anthony Martin authored 
      R=golang-dev, bradfitz, akumar
CC=golang-dev
https://golang.org/cl/6017043
      74607d18
    • Akshat Kumar's avatar
      syscall: fix duplicate fd bug for Plan 9 · 4cf577ed
      Akshat Kumar authored 
      This change comes from CL 5536043,
created by Andrey Mirtchovski. His
description follows:

"The plan9 exec child handler does not manage
dup-ed fds from the parent correctly: when a
dup-ed file descriptor appears in the child's fd
list it is closed when first encountered and then
subsequent attempt to dup it later in Pass 2 fails,
resulting in 'fork/exec: fd out of range or not
open'."

R=golang-dev, rminnich, ality
CC=golang-dev, mirtchovski, rsc
https://golang.org/cl/6009046
      4cf577ed
  9. 16 Apr, 2012 4 commits
  11. 15 Apr, 2012 1 commit
  13. 14 Apr, 2012 2 commits
  15. 13 Apr, 2012 3 commits
  17. 12 Apr, 2012 6 commits
    • Rob Pike's avatar
      fmt: fix crash of %b on huge negative int64 · a662d3d9
      Rob Pike authored 
      The buffer had 64 bytes but needs one more for the sign.

Fixes #3510.

R=golang-dev, dave, dsymonds
CC=golang-dev
https://golang.org/cl/6011057
      a662d3d9
    • Adam Langley's avatar
      crypto/tls: don't always use the default private key. · e6e8b723
      Adam Langley authored 
      When SNI based certificate selection is enabled, we previously used
the default private key even if we selected a non-default certificate.

Fixes #3367.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5987058
      e6e8b723
    • Adam Langley's avatar
      encoding/pem: ignore spaces and tabs at the end of header lines. · 55af51d5
      Adam Langley authored 
      Fixes #3502.

R=bradfitz
CC=golang-dev
https://golang.org/cl/6011046
      55af51d5
    • Dmitriy Vyukov's avatar
      runtime: speedup GC sweep phase (batch free) · 4945fc8e
      Dmitriy Vyukov authored 
      benchmark                             old ns/op    new ns/op    delta
garbage.BenchmarkParser              4370050250   3779668750  -13.51%
garbage.BenchmarkParser-2            3713087000   3628771500   -2.27%
garbage.BenchmarkParser-4            3519755250   3406349750   -3.22%
garbage.BenchmarkParser-8            3386627750   3319144000   -1.99%

garbage.BenchmarkTree                 493585529    408102411  -17.32%
garbage.BenchmarkTree-2               500487176    402285176  -19.62%
garbage.BenchmarkTree-4               473238882    361484058  -23.61%
garbage.BenchmarkTree-8               486977823    368334823  -24.36%

garbage.BenchmarkTree2                 31446600     31203200   -0.77%
garbage.BenchmarkTree2-2               21469000     21077900   -1.82%
garbage.BenchmarkTree2-4               11007600     10899100   -0.99%
garbage.BenchmarkTree2-8                7692400      7032600   -8.58%

garbage.BenchmarkParserPause          241863263    163249450  -32.50%
garbage.BenchmarkParserPause-2        120135418    112981575   -5.95%
garbage.BenchmarkParserPause-4         83411552     64580700  -22.58%
garbage.BenchmarkParserPause-8         51870697     42207244  -18.63%

garbage.BenchmarkTreePause             20940474     13147011  -37.22%
garbage.BenchmarkTreePause-2           20115124     11146715  -44.59%
garbage.BenchmarkTreePause-4           17217584      7486327  -56.52%
garbage.BenchmarkTreePause-8           18258845      7400871  -59.47%

garbage.BenchmarkTree2Pause           174067190    172674190   -0.80%
garbage.BenchmarkTree2Pause-2         131175809    130615761   -0.43%
garbage.BenchmarkTree2Pause-4          95406666     93972047   -1.50%
garbage.BenchmarkTree2Pause-8          86056095     85334952   -0.84%

garbage.BenchmarkParserLastPause      329932000    324790000   -1.56%
garbage.BenchmarkParserLastPause-2    209383000    210456000   +0.51%
garbage.BenchmarkParserLastPause-4    113981000    112921000   -0.93%
garbage.BenchmarkParserLastPause-8     77967000     76625000   -1.72%

garbage.BenchmarkTreeLastPause         29752000     18444000  -38.01%
garbage.BenchmarkTreeLastPause-2       24274000     14766000  -39.17%
garbage.BenchmarkTreeLastPause-4       19565000      8726000  -55.40%
garbage.BenchmarkTreeLastPause-8       21956000     10530000  -52.04%

garbage.BenchmarkTree2LastPause       314411000    311945000   -0.78%
garbage.BenchmarkTree2LastPause-2     214641000    210836000   -1.77%
garbage.BenchmarkTree2LastPause-4     110024000    108943000   -0.98%
garbage.BenchmarkTree2LastPause-8      76873000     70263000   -8.60%

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5991049
      4945fc8e
    • Dmitriy Vyukov's avatar
      runtime: add lock-free stack · a5dc7793
      Dmitriy Vyukov authored 
      This is factored out part of the:
https://golang.org/cl/5279048/
(parallel GC)

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5993043
      a5dc7793
    • Rob Pike's avatar
      text/template: catch unexported fields during parse · 2d0d3d8f
      Rob Pike authored 
      It's a common error to reference unexported field names in templates,
especially for newcomers. This catches the error at parse time rather than
execute time so the rare few who check errors will notice right away.

These were always an error, so the net behavior is unchanged.
Should break no existing code, just identify the error earlier.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6009048
      2d0d3d8f
  19. 11 Apr, 2012 2 commits