- 04 May, 2018 16 commits
-
-
Brad Fitzpatrick authored
RFC 2617, Section 1.2: "It uses an extensible, case-insensitive token to identify the authentication scheme" RFC 7617, Section 2: "Note that both scheme and parameter names are matched case-insensitively." Fixes #22736 Change-Id: I825d6dbd4fef0f1c6add89f0cbdb56a03eae9443 Reviewed-on: https://go-review.googlesource.com/111516Reviewed-by:
Dmitri Shuralyov <dmitri@shuralyov.com> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Dmitri Shuralyov authored
This is a followup to CL 110296. That change added a new behavior to Redirect, where the short HTML body is not written if the Content-Type header is already set. It was implemented by doing an early return. That unintentionally prevented the correct status code from being written, so it would always default to 200. Existing tests didn't catch this because they don't check status code. This change fixes that issue by removing the early return and moving the code to write a short HTML body behind an if statement. It adds written status code checks to Redirect tests. It also tries to improve the documentation wording and code style in TestRedirect_contentTypeAndBody. Updates #25166. Change-Id: Idce004baa88e278d098661c03c9523426c5eb898 Reviewed-on: https://go-review.googlesource.com/111517Reviewed-by:
-
Richard Musiol authored
This commit adds the wasm architecture to the compile command. A later commit will contain the corresponding linker changes. Design doc: https://docs.google.com/document/d/131vjr4DH6JFnb-blm_uRdaC0_Nv3OUwjEY5qVCxCup4 The following files are generated: - src/cmd/compile/internal/ssa/opGen.go - src/cmd/compile/internal/ssa/rewriteWasm.go - src/cmd/internal/obj/wasm/anames.go Updates #18892 Change-Id: Ifb4a96a3e427aac2362a1c97967d5667450fba3b Reviewed-on: https://go-review.googlesource.com/103295 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Cherry Zhang <cherryyz@google.com>
-
Yuval Pavel Zholkover authored
CL 108095 goes to some length inorder to keep the stack usage of getHPETTimecounter code paths bellow a limit being checked by the linker analysis. That limit is spurious, when running on the system or signal stack. In a similar scenario, cgocallback_gofunc performs an indirect call through AX to hide the call from the linker analysis. Here instead, mark getHPETTimecounter //go:systemstack and call it appropriately. Change-Id: I80bec5e4974eee3c564d94f6e1142f322df88b2f Reviewed-on: https://go-review.googlesource.com/111495 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Richard Musiol authored
Updates to x/net git rev 640f462 for CL 109995. Change-Id: I081d4c2265c576d61833bdf31ef8e388588053d3 Reviewed-on: https://go-review.googlesource.com/111555Reviewed-by:
-
Brad Fitzpatrick authored
When dist test was updated to run "go test" with multiple package arguments at once, merging the logical test units into one execution, the hack to give cmd/go twice as much time wasn't updated. What was happening (even in the all.bash case) was that we were merging together, say, "cmd/go" and "bytes", and because bar was lexically earlier, the timeout calculation was based on package "byte", even though we were actually running, say: "go test bytes cmd/go". This explains why x/build/cmd/release was often flaky with its all.bash, since cmd/go can't really finish in 3 minutes reliably unless it's running by itself. If it has any competition, it runs over. Change-Id: I875c8c9e65940ce0ceff48215740dfadfaa89d3f Reviewed-on: https://go-review.googlesource.com/111395 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Andrew Bonventre <andybons@golang.org>
-
Elias Naur authored
The macOS and iOS external linker strips DWARF information from binaries because it assumes the information will go into separate DWARF information .dSYM files. To preserve the embedded debugging information, the Go linker re-combines the separate DWARF information into the unmapped __DWARF segment of the final executable. However, the iOS dyld linker does not allow unmapped segments, so use the presence of the LC_VERSION_MIN_IPHONEOS linker command to skip DWARF combining. Note that we can't use GOARCH for detection since the iOS emulator runs on GOARCH=386 and GOARCH=amd64 and we will run into https://golang.org/issues/25148. Updates #25148. Change-Id: I29a1bc468fdee74ab3b27c46931501a0a8120c66 Reviewed-on: https://go-review.googlesource.com/111275 Run-TryBot: Elias Naur <elias.naur@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Lynn Boger authored
linux/ppc64 uses the ppc64 v1 ABI which was never fully supported by Go. (linux/ppc64le uses the ppc64 v2 ABI and that is fully supported). As a result if the external linker is used to build a program on ppc64, there is a either a warning or error message that doesn't clearly describe the problem. In the case of a warning, a program is created that will most likely not execute since it is not built as expected for the ppc64 dynamic linker (ld64.so.1). To avoid confusion in these cases, error messages are now issued if external linker is explicitly used to build the program. Note that most buildmodes that require external linking were already flagging linux/ppc64 as unsupported except for c-archive, which has been added here. This problem does not occur with gccgo since the ppc64 v1 ABI is supported there. Fixes #25079 Change-Id: I44d77a1eb9df750d499cd432b0ca4a97f0be88b2 Reviewed-on: https://go-review.googlesource.com/109915Reviewed-by:
-
Zhou Peng authored
Change-Id: I11793daafdb69156b1dafaa80fe501fcaeeff202 Reviewed-on: https://go-review.googlesource.com/111435Reviewed-by:
-
Elias Naur authored
The new iOS test harness forwards environment variables to the test program, which means that it runs builder-only tests that were previously skipped because GO_BUILDER_NAME was missing. Skip one such unblocked test, TestGZIPFilesHaveZeroMTimes, which assumes a valid GOROOT. Change-Id: I5daf0f4c1897afbeb8b1a380669a1d2aa47e764a Reviewed-on: https://go-review.googlesource.com/111475 Run-TryBot: Elias Naur <elias.naur@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Elias Naur authored
The new iOS test harness forwards environment variables, such that tests that skipped on non-builders now run because GO_BUILDER_NAME is set. Skip the net tests that rely on resolv.conf being present. Change-Id: I7875dc4252b2ab696c9aae13a9106ddf296ee8ec Reviewed-on: https://go-review.googlesource.com/111476 Run-TryBot: Elias Naur <elias.naur@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Elias Naur authored
It turns out that a non-empty result from ideviceimagemounter does not mean an image is mounted. Use ideviceimagemounter's xml output mode to improve the check. Also, iOS versions are reported as major.minor or major.minor.patch. Developer images are only specific to major.minor version, so cut off the patch number in the search, if present. Change-Id: Ia182e6f4655b7e6aa6feb8005cd3b533535b73cd Reviewed-on: https://go-review.googlesource.com/111235 Run-TryBot: Elias Naur <elias.naur@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Hyang-Ah Hana Kim <hyangah@gmail.com>
-
Martin Möhrmann authored
Fix encoding of PAD (U+0080) which has the same value as utf8.RuneSelf being incorrectly encoded as \x80 in strings.Map due to using <= instead of a < comparison operator to check one byte encodings for utf8. Fixes #25242 Change-Id: Ib6c7d1f425a7ba81e431b6d64009e713d94ea3bc Reviewed-on: https://go-review.googlesource.com/111286 Run-TryBot: Martin Möhrmann <moehrmann@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Daniel Martí authored
fmt's %d, %x, and %X all accept pointer arguments. However, in cmd/vet's printVerbs table, they were defined as if they did not accept pointer arguments. This inconsistency with fmt did not manifest to users since the vet codebase worked around it. In particular, pointer arguments were usually allowed for verbs that accepted integers, as the *types.Pointer argument type case read the following: t&(argInt|argPointer) != 0 As a result, using the %q verb with a pointer resulted in a bug in cmd/vet: $ go run f.go %!q(*int=0xc000014140) $ go vet f.go [no warning] As documented, fmt's %q verb only accepts runes (integers), strings, and byte slices. It should not accept pointers, and it does not. But since vet mixed integers and pointers, it wasn't properly warning about the misuse of fmt. This patch surfaced another bug with fmt.Printf("%p", nil): $ go run f.go %!p(<nil>) $ go vet f.go [no warning] As documented, fmt's %p verb only accepts pointers, and untyped nil is not a valid pointer. But vet did not warn about it, which is another inconsistency with fmt's documented rules. Fix that too, with a test, also getting rid of the TODO associated with the code. As a result of those changes, fix a wrong use of the fmt format verbs in the standard library, now correctly spotted by vet. Fixes #25233. Change-Id: Id0ad31fbc25adfe1c46c6b6879b8d02b23633b3a Reviewed-on: https://go-review.googlesource.com/111284 Run-TryBot: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:Alan Donovan <adonovan@google.com>
-
Brad Fitzpatrick authored
Fixes #18468 Change-Id: Ic88a8daf67db949e5b59f9aa466b37e7f7890713 Reviewed-on: https://go-review.googlesource.com/110395Reviewed-by:
-
Ian Lance Taylor authored
The gccgo toolchain does not put tools (cgo, vet, etc.) in $GOROOT/pkg/tool, but instead in a directory available at runtime.GCCGOTOOLDIR. Update the go/build package and the cmd/go tool to use this tool directory when using gccgo. Change-Id: Ib827336ff53601208300aceb77f76c2e1b069859 Reviewed-on: https://go-review.googlesource.com/111097 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
- 03 May, 2018 18 commits
-
-
Marvin Stenger authored
Ran go generate in order to update docs. Change-Id: Ideb903427d153d0ff35e5164b7e79426b83b1afb Reviewed-on: https://go-review.googlesource.com/111336Reviewed-by:
-
Sam Whited authored
Fixes #25166 Change-Id: Id1fe18899579365519ac08ebedf74cd23c0fbd9f Reviewed-on: https://go-review.googlesource.com/110296 Run-TryBot: Sam Whited <sam@samwhited.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Matthew Dempsky authored
SDWARFMISC was added in golang.org/cl/93664. Change-Id: Ifab0a5effd8e64a2b7916004aa35d51030f23d15 Reviewed-on: https://go-review.googlesource.com/111261 Run-TryBot: Matthew Dempsky <mdempsky@google.com> Reviewed-by:
Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Josh Bleecher Snyder authored
Must have been missed in a previous CL. Change-Id: I303736e82585be8d58b330235c76ed4b24a92952 Reviewed-on: https://go-review.googlesource.com/111259 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Cherry Zhang authored
This is a follow-up of CL 93637. There, when we redirect sync/atomic to runtime/internal/atomic, a few good implementations of ARM atomics were lost. This CL brings most of them back, with some improvements. - Change atomic Store to a plain store with memory barrier, as we already changed atomic Load to plain load with memory barrier. - Use native 64-bit atomics on ARMv7, jump to Go implementations on older machines. But drop the kernel helper. In particular, for Load64, just do loads, not using Cas on the address being load from, so it works also for read-only memory (since we have already fixed 32-bit Load). Change-Id: I725cd65cf945ae5200db81a35be3f251c9f7af14 Reviewed-on: https://go-review.googlesource.com/111315 Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Austin Clements <austin@google.com>
-
Cherry Zhang authored
This gets us around the kernel helpers on ARMv7. It is slightly faster than using the kernel helper. name old time/op new time/op delta AtomicLoad-4 72.5ns ± 0% 69.5ns ± 0% -4.08% (p=0.000 n=9+9) AtomicStore-4 57.6ns ± 1% 54.4ns ± 0% -5.58% (p=0.000 n=10+9) [Geo mean] 64.6ns 61.5ns -4.83% If performance is really critical, we can even do compiler intrinsics on GOARM=7. Fixes #23792. Change-Id: I36497d880890b26bdf01e048b542bd5fd7b17d23 Reviewed-on: https://go-review.googlesource.com/94076 Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Cherry Zhang authored
The implementation of atomics are inherently tricky. It would be good to have them implemented in a single place, instead of multiple copies. Mostly a simple redirect. On 386, some functions in sync/atomic have better implementations, which are moved to runtime/internal/atomic. On ARM, some functions in sync/atomic have better implementations. They are dropped by this CL, but restored with an improved version in a follow-up CL. On linux/arm, 64-bit CAS kernel helper is dropped, as we're trying to move away from kernel helpers. Fixes #23778. Change-Id: Icb9e1039acc92adbb2a371c34baaf0b79551c3ea Reviewed-on: https://go-review.googlesource.com/93637Reviewed-by:
-
Josh Bleecher Snyder authored
These rules trigger 1141 times during make.bash. Shrinks a few object files a tiny bit: name old object-bytes new object-bytes delta Template 476kB ± 0% 476kB ± 0% +0.00% (p=0.008 n=5+5) Unicode 218kB ± 0% 218kB ± 0% ~ (all equal) GoTypes 1.58MB ± 0% 1.58MB ± 0% ~ (all equal) Compiler 6.25MB ± 0% 6.25MB ± 0% -0.00% (p=0.008 n=5+5) Flate 304kB ± 0% 304kB ± 0% -0.01% (p=0.008 n=5+5) GoParser 370kB ± 0% 370kB ± 0% ~ (all equal) Reflect 1.27MB ± 0% 1.27MB ± 0% ~ (all equal) Tar 421kB ± 0% 421kB ± 0% -0.05% (p=0.008 n=5+5) XML 518kB ± 0% 518kB ± 0% ~ (all equal) archive/tar benchmarks: name old time/op new time/op delta /Writer/USTAR-8 3.97µs ± 1% 3.88µs ± 0% -2.26% (p=0.000 n=26+26) /Writer/GNU-8 4.67µs ± 0% 4.54µs ± 1% -2.72% (p=0.000 n=28+27) /Writer/PAX-8 8.20µs ± 0% 8.01µs ± 0% -2.32% (p=0.000 n=29+29) /Reader/USTAR-8 3.61µs ± 0% 3.54µs ± 1% -2.04% (p=0.000 n=25+28) /Reader/GNU-8 2.27µs ± 2% 2.17µs ± 0% -4.08% (p=0.000 n=30+28) /Reader/PAX-8 7.75µs ± 0% 7.63µs ± 0% -1.60% (p=0.000 n=28+28) [Geo mean] 4.61µs 4.50µs -2.51% Change-Id: Ib4dfade5069a7463ccaba073ea91c8213e9714a0 Reviewed-on: https://go-review.googlesource.com/110235 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Ilya Tocar <ilya.tocar@intel.com> Reviewed-by:
Keith Randall <khr@golang.org>
-
Ben Shi authored
More atomic instructions were introduced in ARMv8.1. And this CL adds support for them and corresponding test cases. LDADD Rs, (Rb), Rt: (Rb) -> Rt, Rs+(Rb) -> (Rb) LDAND Rs, (Rb), Rt: (Rb) -> Rt, Rs&(Rb) -> (Rb) LDEOR Rs, (Rb), Rt: (Rb) -> Rt, Rs^(Rb) -> (Rb) LDOR Rs, (Rb), Rt: (Rb) -> Rt, Rs|(Rb) -> (Rb) Change-Id: Ifb9df86583c4dc54fb96274852c3b93a197045e4 Reviewed-on: https://go-review.googlesource.com/110535Reviewed-by:
-
Marvin Stenger authored
Use substring of digits for values < 10. name old time/op new time/op delta FormatIntSmall/7-4 4.54ns ± 1% 3.70ns ± 1% -18.41% (p=0.000 n=18+17) FormatIntSmall/42-4 4.54ns ± 1% 4.13ns ± 1% -9.02% (p=0.000 n=16+18) Change-Id: I0b521b563c13ef88aa2701049fa4a43760e884af Reviewed-on: https://go-review.googlesource.com/111285Reviewed-by:
-
Richard Musiol authored
This commit adds the js/wasm architecture to the crypto packages. Updates #18892 Change-Id: Id41a9d54920746d5019cbeedcff1b83874f2ef73 Reviewed-on: https://go-review.googlesource.com/110095Reviewed-by:
-
Richard Musiol authored
This commit adds the syscall/js package, which is used by the wasm architecture to access the WebAssembly host environment (and the operating system through it). Currently, web browsers and Node.js are supported hosts, which is why the API is based on JavaScript APIs. There is no common API standardized in the WebAssembly ecosystem yet. This package is experimental. Its current scope is only to allow tests to run, but not yet to provide a comprehensive API for users. Updates #18892 Change-Id: I236ea10a70d95cdd50562212f2c18c3db5009230 Reviewed-on: https://go-review.googlesource.com/109195Reviewed-by:
-
Josh Bleecher Snyder authored
The GC maps don't care about trailing non-pointers in args. Work harder to eliminate them. This should provide a slight speedup to everything that reads these maps, mainly GC and stack copying. The non-ptr-y runtime benchmarks happen to go from having a non-empty args map to an empty args map, so they have a significant speedup. name old time/op new time/op delta StackCopyPtr-8 80.2ms ± 4% 79.7ms ± 2% -0.63% (p=0.001 n=94+91) StackCopy-8 63.3ms ± 3% 59.2ms ± 3% -6.45% (p=0.000 n=98+97) StackCopyNoCache-8 107ms ± 3% 98ms ± 3% -8.00% (p=0.000 n=95+88) It also shrinks object files a tiny bit: name old object-bytes new object-bytes delta Template 476kB ± 0% 476kB ± 0% -0.03% (p=0.008 n=5+5) Unicode 218kB ± 0% 218kB ± 0% -0.09% (p=0.008 n=5+5) GoTypes 1.58MB ± 0% 1.58MB ± 0% -0.03% (p=0.008 n=5+5) Compiler 6.25MB ± 0% 6.24MB ± 0% -0.06% (p=0.008 n=5+5) SSA 15.9MB ± 0% 15.9MB ± 0% -0.06% (p=0.008 n=5+5) Flate 304kB ± 0% 303kB ± 0% -0.29% (p=0.008 n=5+5) GoParser 370kB ± 0% 370kB ± 0% +0.02% (p=0.008 n=5+5) Reflect 1.27MB ± 0% 1.27MB ± 0% -0.07% (p=0.008 n=5+5) Tar 421kB ± 0% 421kB ± 0% -0.05% (p=0.008 n=5+5) XML 518kB ± 0% 517kB ± 0% -0.06% (p=0.008 n=5+5) [Geo mean] 934kB 933kB -0.07% Note that some object files do grow; this can happen because some maps that were duplicates of each others must be stored separately. Change-Id: Ie076891bd8e9d269ff2ff5435d5d25c721e0e31d Reviewed-on: https://go-review.googlesource.com/104175 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Josh Bleecher Snyder authored
Every time I poke at #14921, the g.waitreason string pointer writes show up. They're not particularly important performance-wise, but it'd be nice to clear the noise away. And it does open up a few extra bytes in the g struct for some future use. This is a re-roll of CL 99078, which was rolled back because of failures on s390x. Those failures were apparently due to an old version of gdb. Change-Id: Icc2c12f449b2934063fd61e272e06237625ed589 Reviewed-on: https://go-review.googlesource.com/111256 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Michael Munday <mike.munday@ibm.com>
-
Elias Naur authored
Sometimes, a newly installed the test app is not ready to launch or the reported app path is stale. Pause and retry the launch if the lldb script did not run the program. Change-Id: Ic7745d4b5a02f2e3cb8134341859039812f65a65 Reviewed-on: https://go-review.googlesource.com/111216 Run-TryBot: Elias Naur <elias.naur@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Elias Naur authored
Also replace repeated `or` clauses with the Python idiomatic list operator `in`. Change-Id: I4b178f93eb92996d8b5449ee5d252543624aed9e Reviewed-on: https://go-review.googlesource.com/111215 Run-TryBot: Elias Naur <elias.naur@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Elias Naur authored
log.Fatal exits the process and doesn't allow deferred functions to run. Extract log.Fatal calls to main where all deferred functions have completed. For the iOS builder. Change-Id: Id1ef9955bed19944a819d6137a611d6ecbe624a6 Reviewed-on: https://go-review.googlesource.com/110955 Run-TryBot: Elias Naur <elias.naur@gmail.com> Reviewed-by:
-
Elias Naur authored
Sometimes ideviceinstaller fails to install the app. Retry a few times before giving up. For the iOS builder. Change-Id: Ib066ffd4f97ae8d22c0fa9a78ea4d04f67c17410 Reviewed-on: https://go-review.googlesource.com/111055 Run-TryBot: Elias Naur <elias.naur@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
- 02 May, 2018 6 commits
-
-
Antonin Amand authored
Java fails to unzip archives created by archive/zip because directories are written with the "data descriptor" flag (bit 3) set, but emits no such descriptor. To fix this, we explicitly clear the flag. Fixes #25215 Change-Id: Id3af4c7f863758197063df879717c1710f86c0e5 Reviewed-on: https://go-review.googlesource.com/110795Reviewed-by:
Joe Tsai <thebrokentoaster@gmail.com> Run-TryBot: Joe Tsai <thebrokentoaster@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Elias Naur authored
If TMPDIR is not set, the iOS runtime will automatically set TMPDIR to a valid app temporary path. For the iOS builders. Change-Id: Ia82404059dcb10678f0a6e0c96d5efc79a5485fd Reviewed-on: https://go-review.googlesource.com/110956 Run-TryBot: Elias Naur <elias.naur@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Robert Griesemer authored
Fixes #22747. Change-Id: I498cb29f18bd9b59b13dc2ddc3a613cc12ac2a14 Reviewed-on: https://go-review.googlesource.com/110975Reviewed-by:
Matthew Dempsky <mdempsky@google.com>
-
Fangming.Fang authored
Changes include: 1. open compilation option -msan for arm64 2. modify doc to explain -msan is also supported on linux/arm64 3. wrap msan lib API in msan_arm64.s 4. use libc for sigaction syscalls when cgo is enabled 5. use libc for mmap syscalls when cgo is enabled Change-Id: I26ebe61ff7ce1906125f54a0182a720f9d58ec11 Reviewed-on: https://go-review.googlesource.com/109255 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Anmol Sethi authored
We need to grab the mutex before we can access it. Fixes #24438 Change-Id: Idd6130036691acec5bc5f8b40d6884f8db1d9d3c Reviewed-on: https://go-review.googlesource.com/101283 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Robert Griesemer authored
Imported (incl. dot-imported) objects are always in file scope, never in package scope. Fix misleading comment. Package-scope declared objects must have objMap entry by construction (of that map). Remove unnecessary check and corresponding misleading comment. Found while investigating solutions for @23203. Change-Id: Idadfdd1576681ae56e11daa27bdcee2c73733c41 Reviewed-on: https://go-review.googlesource.com/110916 Run-TryBot: Robert Griesemer <gri@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
