Commits · f0bcb6dd249721592d3db1ee6f9ea5f4e47af0a9 · go / golang

04 May, 2011 4 commits
- doc: document r57.1 · f0bcb6dd
  Russ Cox authored May 04, 2011
```
R=adg
CC=golang-dev
https://golang.org/cl/4471041
```
  f0bcb6dd
- http: fix FormFile nil pointer dereference on missing multipart form · 73f4b847
  Andrew Gerrand authored May 04, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4463042
```
  73f4b847
- net: disable dnsmsg_test on windows · 684e065d
  Alex Brainman authored May 04, 2011
```
R=golang-dev, bradfitzwork
CC=golang-dev
https://golang.org/cl/4466041
```
  684e065d
- make.bash: remove old bash version of gotest on Windows · 37dca9d4
  Alex Brainman authored May 04, 2011
```
The file is called gotest.exe now.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4444090
```
  37dca9d4
03 May, 2011 14 commits

Brad Fitzpatrick authored May 03, 2011

Should prevent failures on slow machines, such as:
http://godashboard.appspot.com/log/47b5cae591b7ad8908704e327f3b9b41945d7d5fecfc0c8c945d5545ece1a813

Verified the change (on a fast machine) by removing the
existing sleep, in which case the race happens ~50% of the
time with GOMAXPROCS > 1, but recovers gracefully with
retries.

R=rsc
CC=golang-dev
https://golang.org/cl/4441089

4b30d7ce

tag release.r57 step 2 · 54422c77
Russ Cox authored May 03, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4431088
```
54422c77
tag release.r57 · 8ace46c6
Russ Cox authored May 03, 2011
```
R=r, r2
CC=golang-dev
https://golang.org/cl/4435083
```
8ace46c6

doc: release.r57 · d6dd80b6

Russ Cox authored May 03, 2011

R=golang-dev, r, adg, r2
CC=golang-dev
https://golang.org/cl/4457049

d6dd80b6

gofmt: update test.sh (exclude a file w/ incorrect syntax) · e49d50e2
Robert Griesemer authored May 03, 2011
```
R=iant, iant2
CC=golang-dev
https://golang.org/cl/4453058
```
e49d50e2

codereview: add release branch support · 35a37f17

Russ Cox authored May 03, 2011

Note that if you are working on the upcoming release
branch you have to point your extension path to a
copy of lib/codereview/codereview.py that won't change
as the repository flips between release-branch and default branch.
This warning should only apply to this one branch and only to rsc,
but you never know.

R=adg
CC=golang-dev
https://golang.org/cl/4446076

35a37f17

reflect: allow unexported key in Value.MapIndex · 86e6a441
Russ Cox authored May 03, 2011
```
Fixes #1748.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4444087
```
86e6a441
net: don't crash on unexpected DNS SRV responses · 8ef56f7e
Brad Fitzpatrick authored May 03, 2011
```
Fixes #1350

R=rsc, bradfitzwork
CC=golang-dev
https://golang.org/cl/4432089
```
8ef56f7e
Make.cmd: create TARGDIR if necessary · 2c92fe0b
Gustavo Niemeyer authored May 03, 2011
```
Fixes #1771.

R=adg, rsc1
CC=golang-dev
https://golang.org/cl/4437089
```
2c92fe0b

ld: make ELF binaries with no shared library dependencies static binaries · 296d6871

Russ Cox authored May 03, 2011

$ file $GOROOT/bin/{godoc,goyacc}
/home/rsc/g/go/bin/godoc:  ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked (uses shared libs), not strpped
/home/rsc/g/go/bin/goyacc: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, not stripped
$

Fixes #1758.

R=iant
CC=golang-dev
https://golang.org/cl/4428079

296d6871

doc/install: specify clone -u instead of -r · a3baf7f9
Andrew Gerrand authored May 03, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4435081
```
a3baf7f9
os: remove race paranoia from Environ(); it's guarded now · ec1ee024
Brad Fitzpatrick authored May 03, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4426077
```
ec1ee024

godoc: if there is no search box, don't run the respective JS code · 8e340695

Robert Griesemer authored May 03, 2011

Fixes a JS crash which prevented the automatically generated
table of contents to not appear.

R=adg, bradfitz
CC=golang-dev
https://golang.org/cl/4460041

8e340695

go spec: clarify semantics of integer division · bb7eb400
Robert Griesemer authored May 03, 2011
```
Fixes #1764.

R=rsc, r, iant, ken2
CC=golang-dev
https://golang.org/cl/4431082
```
bb7eb400

02 May, 2011 20 commits

image: fix build · a2354cd4

Rob Pike authored May 02, 2011

accidentally deleted one method
TBR=rsc

R=rsc
CC=golang-dev
https://golang.org/cl/4438090

a2354cd4

image: add type-specific Set methods and use them when decoding PNG. · 2398a74b

Rob Pike authored May 02, 2011

This speeds up PNG decode about 20% by avoiding per-pixel interface conversions.

R=nigeltao, rsc
CC=golang-dev
https://golang.org/cl/4428080

2398a74b

http/pprof: fix POST reading bug · 4002014c
Russ Cox authored May 02, 2011
```
R=bradfitz
CC=golang-dev
https://golang.org/cl/4430075
```
4002014c

net: default to 127.0.0.1, not localhost, in TestICMP · 12cf1699

Brad Fitzpatrick authored May 02, 2011

If localhost resolves to ::1, the IPv4-only test fails.

R=rsc, r2
CC=golang-dev
https://golang.org/cl/4444084

12cf1699

runtime: maybe fix Windows build broken by cgo setenv CL · 6876ad37
Brad Fitzpatrick authored May 02, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4428078
```
6876ad37
godoc: added -index flag to enable/disable search index · c783e68f
Robert Griesemer authored May 02, 2011
```
Fixes #1647.

R=adg, rsc1, r2, rsc, r
CC=golang-dev
https://golang.org/cl/4444083
```
c783e68f

http: fix racy test with a simpler version · f279a939

Brad Fitzpatrick authored May 02, 2011

This was seen breaking the slow arm5 builder:
http://godashboard.appspot.com/log/ec54ee302a70c07093e8f5c47454b3eb48768b77e1d8cc7943d8951f8b6696be

The test was unnecessarily complex and didn't benefit from
using httptest.Server. That just got in the way.

R=rsc
CC=golang-dev
https://golang.org/cl/4439088

f279a939

os: make Setenv update C environment variables · 623e7de1
Brad Fitzpatrick authored May 02, 2011
```
Fixes #1569

R=rsc, bradfitzwork
CC=golang-dev
https://golang.org/cl/4456045
```
623e7de1

misc/cgo/test: run tests · f985638b

Russ Cox authored May 02, 2011

The new gotest ignores Test functions outside *_test.go files
(the old shell script allowed them), so replace one clumsy hack
with another.

The root problem is that the package makefiles only know
how to run cgo for source files in the package proper, not
for test files.  Making it work for test files is probably more
trouble than it's worth.

R=bradfitz
CC=golang-dev
https://golang.org/cl/4452060

f985638b

go/printer: make tests follow syntactic restrictions · 3599e3fc
Robert Griesemer authored May 02, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4439087
```
3599e3fc

go/token: faster FileSet.Position implementation · 16381b14

Robert Griesemer authored May 02, 2011

- added a cache for last file looked up: avoids binary
  search if the file matches

- don't look up extra line info if not present
  (it is almost never present)

- inline one critical binary search call (inlining
  provides almost 30% improvement in this case)

Together, these changes make the go/printer benchmark
more than twice as fast (53% improvement). gofmt also
sped up by about the same amount.

Also: removed an unused internal field from FileSet.

Measurements (always best of 5 runs):

* original:
  printer.BenchmarkPrint     5    238354200 ns/op (100%)

* using last file cache:
  printer.BenchmarkPrint    10    201796600 ns/op (85%)

* avoiding lookup of extra line info:
  printer.BenchmarkPrint    10    157072700 ns/op (66%)

* inlining a critical binary search call:
  printer.BenchmarkPrint    10    111523500 ns/op (47%)

gofmt (always best of 3 runs):

* before:
  time gofmt -l src misc
  real	0m33.316s
  user	0m31.298s
  sys	0m0.319s

* after:
  time gofmt -l src misc
  real	0m15.889s
  user	0m14.596s
  sys	0m0.224s

R=r, dfc, bradfitz, rsc1
CC=golang-dev
https://golang.org/cl/4433086

16381b14

go spec: restricted expressions may still be parenthesized · 6af887ec

Robert Griesemer authored May 02, 2011

No language change.

- added a few examples with parentheses
- added a corresponding sentence to assignments
  (this explicitly permits: (_) = 0, currently allowed by 6g,
  gofmt, but marked as an error by gccgo).

R=rsc, r, iant
CC=golang-dev
https://golang.org/cl/4446071

6af887ec

5a, 6a, 8a, cc: remove old environment variables · a46a311d

Russ Cox authored May 02, 2011

Uses of $INCLUDE and $NPROC are left over from Plan 9.
Remove them to avoid causing confusion.

R=golang-dev, r2
CC=golang-dev
https://golang.org/cl/4445079

a46a311d

multipart: add FileName accessor on Part · ef945203
Brad Fitzpatrick authored May 02, 2011
```
R=rsc, adg
CC=golang-dev
https://golang.org/cl/4426074
```
ef945203
net: enable SO_REUSEPORT on BSD variants · bc926713
Mikio Hara authored May 02, 2011
```
Fixes #1694.

R=golang-dev, rsc1, rsc
CC=golang-dev
https://golang.org/cl/4445067
```
bc926713
net: fix ipv6 test · 756df8e0
Mikio Hara authored May 02, 2011
```
Fixes #1767.

R=rsc
CC=golang-dev
https://golang.org/cl/4436073
```
756df8e0

runtime, sync/atomic: fix arm cas · 540feaae

Russ Cox authored May 02, 2011

Works around bug in kernel implementation on old ARM5 kernels.
Bug was fixed on 26 Nov 2007 (between 2.6.23 and 2.6.24) but
old kernels persist.

Fixes #1750.

R=dfc, golang-dev
CC=golang-dev
https://golang.org/cl/4436072

540feaae

jpeg: speed up RGBA encoding ~%50 · 807ce271

Brad Fitzpatrick authored May 02, 2011

Avoids image.At(), color.RGBA(), opposing 8 bit shifts,
and min function calls in a loop.  Not as pretty as before,
but the pure version is still there to revert back to
later if/when the compiler gets better.

before (best of 5)
jpeg.BenchmarkEncodeRGBOpaque   50   64781360 ns/op   18.97 MB/s

after (best of 5)
jpeg.BenchmarkEncodeRGBOpaque   50   42044300 ns/op   29.23 MB/s

(benchmarked on an HP z600; 16 core Xeon E5520 @ 2.27Ghz)

R=r, r2, nigeltao
CC=golang-dev
https://golang.org/cl/4433088

807ce271

png: speed up opaque RGBA encoding · 437015bb

Brad Fitzpatrick authored May 02, 2011

With Linux/8g on a 2006 Mac Mini (1.66 GHz Intel Core Duo,
2KB L1, 2MB L2, 2G main memory), GOMAXPROCS unset:

start:
png.BenchmarkEncodePaletted	      50	  44772820 ns/op
png.BenchmarkEncodeRGBOpaque	      10	 208395900 ns/op
png.BenchmarkEncodeRGBA		       5	 331088000 ns/op

remove interface method calls:
png.BenchmarkEncodePaletted	      50	  44722880 ns/op
png.BenchmarkEncodeRGBOpaque	      10	 139042600 ns/op
png.BenchmarkEncodeRGBA		       5	 334033600 ns/op

flate inline min/max():
png.BenchmarkEncodePaletted	      50	  40631180 ns/op
png.BenchmarkEncodeRGBOpaque	      10	 124894900 ns/op
png.BenchmarkEncodeRGBA		       5	 312099000 ns/op

after adler change:
png.BenchmarkEncodePaletted	      50	  40181760 ns/op
png.BenchmarkEncodeRGBOpaque	      20	 121781950 ns/op
png.BenchmarkEncodeRGBA		       5	 313890800 ns/op

In comparison to 121 ms on this 2006 machine, on my
Core2 Duo 2.66 GHz laptop, the final BenchmarkEncodeRGBOpaque
runs in 27 ms. (these are all for 640x480 images)

R=nigeltao, rsc, r
CC=golang-dev
https://golang.org/cl/4432077

437015bb

multipart: return an error on Reader EOF, not (nil, nil) · db16bca1
Brad Fitzpatrick authored May 02, 2011
```
R=rsc, adg
CC=golang-dev
https://golang.org/cl/4430074
```
db16bca1

01 May, 2011 2 commits
- syscall: add Windows file mapping functions and constants · 366986a3
  Evan Shaw authored May 01, 2011
```
R=brainman, rsc1, rsc
CC=golang-dev
https://golang.org/cl/4375046
```
  366986a3
- http: rename ErrBodyReadAferClose to ErrBodyReadAfterClose · 89adf5dc
  Andrew Gerrand authored May 01, 2011
```
R=bradfitz, dsymonds
CC=golang-dev
https://golang.org/cl/4432085
```
  89adf5dc