- 08 May, 2013 3 commits
-
-
Andrew Gerrand authored
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/9288045
-
Ian Lance Taylor authored
This works around a bug in GCC 4.8.0. Fixes #5118. R=golang-dev, r, minux.ma CC=golang-dev https://golang.org/cl/9120045
-
Alex Brainman authored
Fixes #5349. R=golang-dev, lucio.dere, dsymonds, bradfitz, iant, adg, dave, r CC=golang-dev https://golang.org/cl/9159043
-
- 07 May, 2013 3 commits
-
-
Rob Pike authored
Fixes #5421. R=golang-dev, bradfitz, adg CC=golang-dev https://golang.org/cl/9274043
-
Andrew Gerrand authored
-
Brad Fitzpatrick authored
R=golang-dev, adg, r CC=golang-dev https://golang.org/cl/9250043
-
- 06 May, 2013 8 commits
-
-
Dmitriy Vyukov authored
The linker can generate split stack prolog when a textflag 7 function makes an indirect function call. If it happens, badsignal() crashes trying to dereference g. Fixes #5337. R=bradfitz, dave, adg, iant, r, minux.ma CC=adonovan, golang-dev https://golang.org/cl/9226043
-
Shenghou Ma authored
Update #5236 Update #5402 This CL reduces gofmt's committed memory from 545864 KiB to 139568 KiB. Note: Go 1.0.3 uses about 70MiB. R=golang-dev, r, iant, nightlyone CC=golang-dev https://golang.org/cl/9245043
-
Brad Fitzpatrick authored
Found while debugging memory usage. Nobody accesses this field anymore. R=golang-dev, i.caught.air, adg, r CC=golang-dev https://golang.org/cl/9108043
-
Andrew Gerrand authored
R=golang-dev, dsymonds, r CC=golang-dev https://golang.org/cl/9244043
-
Shenghou Ma authored
API change, but the old API is obviously wrong. R=golang-dev, iant, r, rsc CC=golang-dev https://golang.org/cl/9157044
-
Jeremiah Harmsen authored
Allows Examples with KeyValue expressions to be playable in godoc. During the traversal of the abstract syntax tree any KeyValueExpr Key.Name was incorrectly being added as an unresolved identifier. Since this identifier could not be provided the Example was marked as unplayable. This updates the AST traversal to skip Keys (but continue traversing the Values). Example of problematic AST now fixed (see L99 where "UpperBound" was being added as a missing identifier): 81 . . . . . . . . . Values: []ast.Expr (len = 1) { 82 . . . . . . . . . . 0: *ast.UnaryExpr { 83 . . . . . . . . . . . OpPos: 12:19 84 . . . . . . . . . . . Op: & 85 . . . . . . . . . . . X: *ast.CompositeLit { 86 . . . . . . . . . . . . Type: *ast.SelectorExpr { 87 . . . . . . . . . . . . . X: *ast.Ident { 88 . . . . . . . . . . . . . . NamePos: 12:20 89 . . . . . . . . . . . . . . Name: "t_proto" 90 . . . . . . . . . . . . . } 91 . . . . . . . . . . . . . Sel: *ast.Ident { 92 . . . . . . . . . . . . . . NamePos: 12:41 93 . . . . . . . . . . . . . . Name: "BConfig" 94 . . . . . . . . . . . . . } 95 . . . . . . . . . . . . } 96 . . . . . . . . . . . . Lbrace: 12:79 97 . . . . . . . . . . . . Elts: []ast.Expr (len = 2) { 98 . . . . . . . . . . . . . 0: *ast.KeyValueExpr { 99 . . . . . . . . . . . . . . Key: *ast.Ident { 100 . . . . . . . . . . . . . . . NamePos: 13:3 101 . . . . . . . . . . . . . . . Name: "UpperBound" 102 . . . . . . . . . . . . . . } 103 . . . . . . . . . . . . . . Colon: 13:13 104 . . . . . . . . . . . . . . Value: *ast.CallExpr { 105 . . . . . . . . . . . . . . . Fun: *ast.SelectorExpr { 106 . . . . . . . . . . . . . . . . X: *ast.Ident { 107 . . . . . . . . . . . . . . . . . NamePos: 13:15 108 . . . . . . . . . . . . . . . . . Name: "proto" 109 . . . . . . . . . . . . . . . . } 110 . . . . . . . . . . . . . . . . Sel: *ast.Ident { 111 . . . . . . . . . . . . . . . . . NamePos: 13:21 112 . . . . . . . . . . . . . . . . . Name: "Float32" 113 . . . . . . . . . . . . . . . . } R=adg CC=gobot, golang-dev, gri https://golang.org/cl/8569045
-
Andrew Gerrand authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/9229043
-
Brad Fitzpatrick authored
Fixes #5413 R=golang-dev, dave, adg CC=golang-dev https://golang.org/cl/9153045
-
- 04 May, 2013 1 commit
-
-
Shenghou Ma authored
R=golang-dev, i.caught.air, alexb, r CC=golang-dev https://golang.org/cl/9064044
-
- 03 May, 2013 5 commits
-
-
Keith Randall authored
R=golang-dev, minux.ma, r CC=golang-dev https://golang.org/cl/9086043
-
Andrew Gerrand authored
Fixes #5403. R=golang-dev, minux.ma CC=golang-dev https://golang.org/cl/9100046
-
Shenghou Ma authored
TBR=iant CC=golang-dev https://golang.org/cl/9048048
-
Shenghou Ma authored
Fixes #5392. R=iant, r CC=golang-dev https://golang.org/cl/9119043
-
Brad Fitzpatrick authored
This must have been from when "error" was a good variable name for an "os.Error". But we use "err" these days. R=golang-dev, dsymonds, r CC=golang-dev https://golang.org/cl/9132045
-
- 02 May, 2013 3 commits
-
-
Russ Cox authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/9103046
-
Alex Brainman authored
As advised by iant. Fixes windows build. R=golang-dev, r CC=golang-dev, iant https://golang.org/cl/9110044
-
Rob Pike authored
"The usual conversions" bite again. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/9103044
-
- 01 May, 2013 6 commits
-
-
David du Colombier authored
Include libc.h before bio.h in 8.c, because bio.h uses the UTFmax enum, which is declared in libc.h, since the recent switch to 21-bit runes in Plan 9. The 5.c and 6.c files already includes libc.h. R=golang-dev, r CC=golang-dev https://golang.org/cl/9040047
-
Ian Lance Taylor authored
R=rsc, alexb, minux.ma, bradfitz, i.caught.air CC=golang-dev https://golang.org/cl/9082043
-
Ian Lance Taylor authored
R=rsc, r CC=golang-dev https://golang.org/cl/9060045
-
Ian Lance Taylor authored
This is needed for SWIG when linking in internal mode. In internal mode if a symbol was cgo_import_static we used to forget that it was also cgo_import_dynamic. R=rsc, r CC=golang-dev https://golang.org/cl/9080043
-
Andrew Gerrand authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/9047045
-
Alex Brainman authored
Fixes #5355. R=golang-dev, mikioh.mikioh, bradfitz, r CC=golang-dev https://golang.org/cl/8966046
-
- 30 Apr, 2013 11 commits
-
-
Rob Pike authored
R=golang-dev, iant CC=golang-dev https://golang.org/cl/9025047
-
Russ Cox authored
Manual undo due to later changes in doc/go1.1.html; cmd/go/test.bash still passes. Rationale, from CL 8119049 review log: This makes the 'go run' command different from every other command. For example, 'go test' does not mean 'go test *.go'. If we were going to handle the no arguments case in 'go run', I would hope that it would scan the current directory to find a package just like 'go build' or 'go test' would, and then it would require that package to be 'package main', and then it would run that package. This would make it match 'go test' and 'go build' and 'go install' and so on. It would mean that if you are working on a command in a directory that is 'go install'able, then 'go run' will run the binary for you. The current CL does not accomplish that when build constraints or file name constraints are involved. For example, if I am working on a program like: $ ls main.go main_386.s main_arm.s main_amd64.s $ Then 'go run' will fail here because the .s files are ignored. If instead I am working on a program like: $ ls main.go main_386.go main_arm.go main_amd64.go $ then 'go run' will fail because too many files are included. I would like to see this command implemented so that it is compatible with the other go subcommands. Since it is too late to do that for Go 1.1, I would like to see this CL reverted, to preserve the option to do it better later. R=golang-dev, iant, r CC=golang-dev https://golang.org/cl/8797049
-
Ian Lance Taylor authored
I would like opinions on whether this is a good idea for 1.1. On the one hand it's a moderately important issue. On the other hand this introduces at least the possibility of external linker errors due to the additional relocations and it may be better to wait. I'm fairly confident that the behaviour is unchanged when not using an external linker. Update #5221 This CL is tested lightly on 386 and amd64 and fixes the cases I tested. I have not tested it on Darwin or Windows. R=golang-dev, dave, daniel.morsing, rsc CC=golang-dev https://golang.org/cl/8858047
-
Rob Pike authored
It's too hard to make portable just now. R=golang-dev, iant CC=golang-dev https://golang.org/cl/9057043
-
Cosmos Nicolaou authored
R=iant, iant, r, bradfitz CC=golang-dev https://golang.org/cl/8334044
-
Rob Pike authored
exec_plan9.go too. Those are in CL 8334044 R=golang-dev, iant CC=golang-dev https://golang.org/cl/9055043
-
Rob Pike authored
R=golang-dev, iant CC=golang-dev https://golang.org/cl/9036046
-
Rob Pike authored
PC-relative needs a signed offset; others need unsigned. Also fix signedness of 32-bit relocation on Windows. R=golang-dev, iant CC=golang-dev https://golang.org/cl/9039045
-
Andrew Gerrand authored
Update #5164 R=golang-dev, dave CC=golang-dev https://golang.org/cl/9049043
-
Rob Pike authored
R=golang-dev, dsymonds, dave CC=golang-dev https://golang.org/cl/9038043
-
Rob Pike authored
Some 64-bit fields were run through 32-bit words, some counts were not checked for overflow, and relocations must fit in 32 bits. Tests to follow. R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/9033043
-