- 30 Nov, 2017 10 commits
-
-
Brad Fitzpatrick authored
I've been doing these tweaks by hand. I was going to write a tool in Go for it, but it's not much additional shell here. Fixes #22912 Updates #9797 (already closed) Change-Id: Ia15bd9b6876e6f6a76aa9ca86b10f113095e96a3 Reviewed-on: https://go-review.googlesource.com/80895Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Vladimir Stefanovic authored
Updates #18162 Change-Id: I591fcf71a02678a99a56a6487da9689d3c9b1bb6 Reviewed-on: https://go-review.googlesource.com/37955 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>
-
Vladimir Stefanovic authored
Updates #18162 Change-Id: Iee854f48b2d1432955fdb462f2073ebbe76c34f8 Reviewed-on: https://go-review.googlesource.com/37957 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>
-
Vladimir Stefanovic authored
GOMIPS is a GOARCH=mips{,le} specific option, for a choice between hard-float and soft-float. Valid values are 'hardfloat' (default) and 'softfloat'. It is passed to the assembler as 'GOMIPS_{hardfloat,softfloat}'. Note: GOMIPS will later also be used for a choice of MIPS instruction set (mips32/mips32r2). Updates #18162 Change-Id: I35417db8625695f09d6ccc3042431dd2eaa756a6 Reviewed-on: https://go-review.googlesource.com/37954 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>
-
Tobias Klauser authored
Fix a typo of "packageshlib" used for generating the link action ID. Change-Id: Id6d39830908b03de658a58661030c32c592a1da9 Reviewed-on: https://go-review.googlesource.com/80935 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Alberto Donizetti <alb.donizetti@gmail.com>
-
Than McIntosh authored
Compiler and linker changes to support DWARF inlined instances, see https://go.googlesource.com/proposal/+/HEAD/design/22080-dwarf-inlining.md for design details. This functionality is gated via the cmd/compile option -gendwarfinl=N, where N={0,1,2}, where a value of 0 disables dwarf inline generation, a value of 1 turns on dwarf generation without tracking of formal/local vars from inlined routines, and a value of 2 enables inlines with variable tracking. Updates #22080 Change-Id: I69309b3b815d9fed04aebddc0b8d33d0dbbfad6e Reviewed-on: https://go-review.googlesource.com/75550 Run-TryBot: Than McIntosh <thanm@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: David Chase <drchase@google.com>
-
Cherry Zhang authored
ORANGE node's Right node is the expression it is ranging over, which is evaluated before the loop. In the escape analysis, we should walk this node without loop depth incremented. Fixes #21709. Change-Id: Idc1e4c76e39afb5a344d85f6b497930a488ce5cf Reviewed-on: https://go-review.googlesource.com/80740 Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: David Chase <drchase@google.com>
-
Brad Fitzpatrick authored
This reverts commit a631daba. Reason for revert: I was wrong. It still fails on the builders. I don't know what's different about my VMWare VM, but on GCE it fails. Change-Id: Ic6bee494b69235768bf08ba0bf59026bca41ad12 Reviewed-on: https://go-review.googlesource.com/80915Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Brad Fitzpatrick authored
Fixes #22778 Change-Id: I37f7a59c15828aa720fe787fff42fb3ef17729c7 Reviewed-on: https://go-review.googlesource.com/80815Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Brad Fitzpatrick authored
It must've been fixed since NetBSD 7.0. I can no longer reproduce it with NetBSD 8-BETA (our new minimum NetBSD requirement). Fixes #19293 Change-Id: I28f970ca41a53a037e1c6cddf1b7f286bda2d725 Reviewed-on: https://go-review.googlesource.com/80875 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
- 29 Nov, 2017 22 commits
-
-
Robert Griesemer authored
The fix (CL 79575) for #18395 is too risky at this stage of the Go 1.10 release process. Since issue #18395 is easily recognized (but not easily fixed), report an error instead of silently continuing. This avoids inscrutable follow on errors. Also, make sure all empty interfaces are "completed", and adjust printing code to report incomplete interfaces. For #18395. Change-Id: I7fa5f97ff31ac9775c9a6d318fce9f526b0350cd Reviewed-on: https://go-review.googlesource.com/80455Reviewed-by: Alan Donovan <adonovan@google.com>
-
Robert Griesemer authored
Fixes #22815. Change-Id: Iaa54fa311bf2c0549a6316a0d51cc92425f5ba94 Reviewed-on: https://go-review.googlesource.com/80855Reviewed-by: Daniel Martí <mvdan@mvdan.cc> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Cherry Zhang authored
Updates #20650 (CL 45099 introduced the feature to x86). Change-Id: If40cc9d87417a05281d8633f05cd91f6f434b136 Reviewed-on: https://go-review.googlesource.com/80843 Run-TryBot: Cherry Zhang <cherryyz@google.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Cherry Zhang authored
In the x/arch repo, CL 45098 introduced SymLookup type, replacing the unnamed function type for lookup functions. This affects the signature of x86asm.GoSyntax. In particular, it cannot convert one named type, namely lookupFunc, to the other without an explicit cast. Make lookupFunc unnamed to fix. Change-Id: I973300d29ef1dbfdbd7fc2429e89c5849e6a7329 Reviewed-on: https://go-review.googlesource.com/80842 Run-TryBot: Cherry Zhang <cherryyz@google.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Matthew Dempsky authored
For "type T = U" we were accidentally emitting a #define for "U__size" instead of "T__size". Fixes #22877. Change-Id: I5ed6757d697753ed6d944077c16150759f6e1285 Reviewed-on: https://go-review.googlesource.com/80759 Run-TryBot: Matthew Dempsky <mdempsky@google.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Leigh McCulloch authored
The note about the single change workflow is included in the git-codereview installation instructions, but it has nothing to do with installing git-codereview. This note is more relevant for when a change is actually being made. Change-Id: Iccb90f3b7da87fab863fa4808438cd69a21a2fce Reviewed-on: https://go-review.googlesource.com/76317Reviewed-by: Steve Francia <spf@golang.org>
-
Brad Fitzpatrick authored
Updates to x/net git rev a8b92947779 for CL 80755 Updates #22927 Change-Id: I84aad75afd954c9a6c57ad9a76328b99f1dc74a1 Reviewed-on: https://go-review.googlesource.com/80758 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Benny Siegert <bsiegert@gmail.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Brad Fitzpatrick authored
Updates #22927 Updates #20852 Change-Id: I3ac0f8d38375d58a77781ab0e4f78ca57b258de0 Reviewed-on: https://go-review.googlesource.com/80756Reviewed-by: Benny Siegert <bsiegert@gmail.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Joe Tsai authored
Several usages of tar (reasonably) just use the Header.FileInfo to determine the type of the header. However, the os.FileMode type is not expressive enough to represent "files" that are not files at all, but some form of metadata. Thus, Header{Typeflag: TypeXGlobalHeader}.FileInfo().Mode().IsRegular() reports true, even though the expected result may have been false. To reduce (not eliminate) the possibility of failure for such usages, use the placeholder filename from the global PAX headers. Thus, in the event the user did not handle special "meta" headers specifically, they will just be written to disk as a regular file. As an example use case, the "git archive --format=tgz" command produces an archive where the first "file" is a global PAX header with the name "global_pax_header". For users that do not explicitly check the Header.Typeflag field to ignore such headers, they may end up extracting a file named "global_pax_header". While it is a bogus file, it at least does not stop the extraction process. Updates #22748 Change-Id: I28448b528dcfacb4e92311824c33c71b482f49c9 Reviewed-on: https://go-review.googlesource.com/78355Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Robert Griesemer authored
For #22695. Change-Id: Idcda3294070aeaeaf940aaf2014b573732fd60a4 Reviewed-on: https://go-review.googlesource.com/80696Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Dmitri Shuralyov <shurcool@gmail.com>
-
Sebastien Binet authored
This CL is a simple doc typo fix, uncovered while reviewing the go-wasm port. Change-Id: I0fce915c341aaaea3a7cc365819abbc5f2c468c3 Reviewed-on: https://go-review.googlesource.com/80715Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Jess Frazelle authored
Return an error when a user passes -o and -buildmode=exe to build a package without a main. Fixes #20017. Change-Id: I07d49c75e7088a96f00afe18c9faa842c5d71afb Reviewed-on: https://go-review.googlesource.com/49371 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>
-
Joe Tsai authored
In order to avoid a regression where the date of the ModTime method changed behavior, simply preserve the old behavior of determining the date based on the legacy fields. This ensures that anyone relying on ModTime before Go1.10 will have the exact same behavior as before. New users should use FileHeader.Modified instead. We keep the UTC coersion logic in SetModTime since some users manually compute timezone offsets in order to have precise control over the MS-DOS time field. Fixes #22738 Change-Id: Ib18b6ebd863bcf645748e083357dce9bc788cdba Reviewed-on: https://go-review.googlesource.com/78031Reviewed-by: Russ Cox <rsc@golang.org> Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Russ Cox authored
A method is more in keeping with the rest of the Writer API and incidentally allows the comment error to be reported earlier. Fixes #22737. Change-Id: I1eee2103a0720c76d0c394ccd6541e6219996dc0 Reviewed-on: https://go-review.googlesource.com/79415 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
-
Russ Cox authored
If there are no more requests being made, wait to shut down the response-writing codec until the pending requests are all answered. Fixes #17239. Change-Id: Ie62c63ada536171df4e70b73c95f98f778069972 Reviewed-on: https://go-review.googlesource.com/79515 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rob Pike <r@golang.org>
-
Brad Fitzpatrick authored
Thanks to coypoop for noticing at: https://github.com/golang/go/issues/22914#issuecomment-347761838 FreeBSD/386 and NetBSD/386 diverged between Go 1.4 and Go 1.5 when Russ sent https://golang.org/cl/135830043 (git rev 25f6b02a) to change the calling convention of the C compilers to match Go. But netbsd wasn't updated. Tested on a NetBSD/386 VM, since the builders aren't back up yet (due to this bug) Fixes #22914 Updates #19339 Updates #20852 Updates #16511 Change-Id: Id76ebe8f29bcc85e39b1c11090639d906cd6cf04 Reviewed-on: https://go-review.googlesource.com/80515 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Benny Siegert <bsiegert@gmail.com> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Inanc Gumus authored
When -test.failfast flag is provided to go test, no new tests get started after the first failure. Fixes #21700 Change-Id: I0092e72f25847af05e7c8e1b811dcbb65a00cbe7 Reviewed-on: https://go-review.googlesource.com/74450 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>
-
Jess Frazelle authored
Fixes #19832 Change-Id: I7ce39c2c435d4716d8a42ac6784b4c87874c0e13 Reviewed-on: https://go-review.googlesource.com/49490 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>
-
Tobias Klauser authored
Due to err being shadowed in the else brach, the actual err return of fd1.Chdir() is never checked. Fix it by not shadowing err anymore. Change-Id: I9f1d52e88d8bc9a1c035960aa7af9f5224a63ab0 Reviewed-on: https://go-review.googlesource.com/80556 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Tobias Klauser authored
Follow CL 75810 which did the same for x/sys/unix. Change-Id: I6314a97989631d589369c7b6001d1523ec2cc242 Reviewed-on: https://go-review.googlesource.com/80555 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Rob Pike authored
There were too many changes of direction. Tidy up the intro a little for better flow, and delete some unnecessary comments. Change-Id: Ib5d85c0992626bd3152f86a51585884d3e0cab72 Reviewed-on: https://go-review.googlesource.com/80495Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Rob Pike authored
Fixes #22770. Change-Id: Ief62043fb6895e215d2530d2a3bf88f7ea58c875 Reviewed-on: https://go-review.googlesource.com/80195Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
- 28 Nov, 2017 8 commits
-
-
David Chase authored
Binary import sometimes constructs nodes using functions that use the global lineno for the Position. This causes spurious numbers to appear in the assembly and the debugging output. Fix (targeted, because late in the cycle): save and restore lineno around bimport calls known to use lineno-sensitive functions. Updates #22600. (Comment: "This is a weird line to step through") Change-Id: I9c4094670380609fe4b6696443fb02579521c596 Reviewed-on: https://go-review.googlesource.com/80115 Run-TryBot: David Chase <drchase@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
-
Matthew Dempsky authored
Fixes #22904. Change-Id: Id504504eda7275c10d3c665add8b7ccd23f65820 Reviewed-on: https://go-review.googlesource.com/80301 Run-TryBot: Matthew Dempsky <mdempsky@google.com> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Matthew Dempsky authored
typenod is only used for anonymous types, which don't logically have position information. Passes toolstash-check. Updates #19683. Change-Id: I505424ae980b88c7deed5f23502c3cecb3dc0702 Reviewed-on: https://go-review.googlesource.com/80298 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: David Chase <drchase@google.com>
-
Mikio Hara authored
This change drops the support for FreeBSD 9 or below and simplifies platform-dependent code for the sake of maintenance. Updates #7187. Fixes #11412. Updates #16064. Updates #18854. Fixes #19072. Change-Id: I9129130aafbfc7d0d7e9b674b6fc6cb31b7381be Reviewed-on: https://go-review.googlesource.com/64910Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Brad Fitzpatrick authored
Fixes #18122 Change-Id: Ib4067422c0c447ddb2c3068dc6217393abc4eed0 Reviewed-on: https://go-review.googlesource.com/80175 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Brad Fitzpatrick authored
Fixes #22873 Change-Id: Ib2b7ee42a23b84db21cdfa693b62d5e6fbfdb54e Reviewed-on: https://go-review.googlesource.com/80075Reviewed-by: Tom Bergan <tombergan@google.com>
-
Russ Cox authored
Apparently 4 kB is not enough for some people. Fixes #21674. Change-Id: If39eeb225d548b578560939f6ce51e31060f5aff Reviewed-on: https://go-review.googlesource.com/79516 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Brad Fitzpatrick authored
Update http2 to x/net git rev db473f6b23. (And un-skip TestWriteHeader0_h2 added in CL 80077, now fixed.) Includes: http2: remove afterReqBodyWriteError wrapper https://golang.org/cl/75252 http2: fix transport data race on reused *http.Request objects https://golang.org/cl/75530 http2: require either ECDSA or RSA ciphersuite https://golang.org/cl/30721 http2: don't log about timeouts reading client preface on new connections https://golang.org/cl/79498 http2: don't crash in Transport on server's DATA following bogus HEADERS https://golang.org/cl/80056 http2: panic on invalid WriteHeader status code https://golang.org/cl/80076 http2: fix race on ClientConn.maxFrameSize https://golang.org/cl/79238 http2: don't autodetect Content-Type when the response has an empty body https://golang.org/cl/80135 Fixes golang/go#18776 Updates golang/go#20784 Fixes golang/go#21316 Fixes golang/go#22721 Fixes golang/go#22880 Change-Id: Ie86e24e0ee2582a5a82afe5de3c7c801528be069 Reviewed-on: https://go-review.googlesource.com/80078 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Tom Bergan <tombergan@google.com>
-