Commits · f11f032486ada2ee8e3ae9ee8860acdeb2e8db00 · go / golang

15 Mar, 2011 11 commits

Rob Pike authored Mar 15, 2011

On my mac:
mallocs per rpc round trip: 144
rpc.BenchmarkEndToEnd	   10000	    228244 ns/op

Room for improvement.

R=rsc
CC=golang-dev
https://golang.org/cl/4274058

f11f0324

lib9, libmach: Change GOOS references to GOHOSTOS · c3254bbe

Evan Shaw authored Mar 15, 2011

This makes it possible to build Windows binaries on non-Windows OSes.

R=golang-dev, rsc1, rsc
CC=golang-dev
https://golang.org/cl/4271046

c3254bbe

os, syscall: add ProcAttr type. Change StartProcess etc. to use it. · aa55c052
Roger Peppe authored Mar 15, 2011
```
The Windows code is untested.

R=rsc, gri, brainman, rsc1
CC=golang-dev
https://golang.org/cl/4253052
```
aa55c052
gofix: new command for updating code to new release · a34f1bbb
Russ Cox authored Mar 15, 2011
```
R=bradfitzgo, dsymonds, r, gri, adg
CC=golang-dev
https://golang.org/cl/4282044
```
a34f1bbb
gc: diagnose unused labels · 66f09fd4
Russ Cox authored Mar 15, 2011
```
R=ken2
CC=golang-dev
https://golang.org/cl/4287047
```
66f09fd4
remove unused labels · e72156b3
Russ Cox authored Mar 15, 2011
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/4274052
```
e72156b3

gofmt: simpler walkDir · 35cee9f5

Russ Cox authored Mar 15, 2011

Swapping the goroutines lets them reuse the
communication completion on v instead of
needing a second channel (done).

R=gri
CC=golang-dev
https://golang.org/cl/4287045

35cee9f5

spec: disallow unused labels · 108564da

Russ Cox authored Mar 15, 2011

Also change labelled examples to use gofmt formatting.

R=gri, r, jnml
CC=golang-dev
https://golang.org/cl/4287046

108564da

httptest: default the Recorder status code to 200 on a Write · f1928917
Brad Fitzpatrick authored Mar 15, 2011
```
This matches the real ResponseWriter behavior.

R=rsc
CC=golang-dev
https://golang.org/cl/4291048
```
f1928917
openpgp: add PublicKey KeyId string accessors · 5245b27e
Brad Fitzpatrick authored Mar 15, 2011
```
R=agl, agl1
CC=golang-dev
https://golang.org/cl/4297041
```
5245b27e

rpc: add buffering to the encode path. · a5697251

Rob Pike authored Mar 15, 2011

This reduces the number of writes by 2 (1 client, 1 server) on each round trip.
A simple test shows 24% higher throughput.

R=rsc
CC=golang-dev
https://golang.org/cl/4279057

a5697251

14 Mar, 2011 4 commits

libmach: correct string comparison to revive 6cov on darwin · 31a72d1a
Dave Cheney authored Mar 14, 2011
```
R=golang-dev, r, dsymonds, rsc1
CC=golang-dev
https://golang.org/cl/4277046
```
31a72d1a
5l: fix build · c5e474dd
Russ Cox authored Mar 14, 2011
```
R=ken2
CC=golang-dev
https://golang.org/cl/4279053
```
c5e474dd

gc: include all dependencies in export metadata · e6f3aa6c

Russ Cox authored Mar 14, 2011

This change records more metadata about what
influenced the creation of the object file.
Specifically, if a package imports, say, "fmt" but does not
need to describe any fmt types in its own export data,
that package's object file did not mention the dependency
on "fmt" before.  Now it does.

Listing the import is purely informational.
It has no effect on which files are opened or consulted
when importing a package.

Import lines are marked indirect when they are needed
to explain the API but were not imported directly.
For example http imports crypto/tls and exports
a struct with a field of type tls.ConnectionState,
which contains an x509.Certificate.  Since http does
not import x509 but needs to explain the x509.Certificate
type in its export data, the import of x509 is marked
as indirect.  These import lines were always present;
marking them with the indirect comment makes clear
which were imported directly and which are incidental.

R=ken2
CC=golang-dev
https://golang.org/cl/4295048

e6f3aa6c

build: remove duplicate dependency in Make.cmd · 67077cc1
Robert Hencke authored Mar 14, 2011
```
R=golang-dev, dfc, rsc1, rsc
CC=golang-dev
https://golang.org/cl/4274048
```
67077cc1

13 Mar, 2011 2 commits
- crypto/tls: fix compile error · 43ae7da1
  Dave Cheney authored Mar 13, 2011
```
Fixes #1555.

R=rsc, bradfitzgo
CC=golang-dev
https://golang.org/cl/4284047
```
  43ae7da1
- ioutil: add NopCloser · 3479bb6c
  Brad Fitzpatrick authored Mar 13, 2011
```
R=rsc, dsymonds
CC=golang-dev
https://golang.org/cl/4278044
```
  3479bb6c
12 Mar, 2011 6 commits

http: use Header.Del not empty Set(k, "") · 1c96562f

Brad Fitzpatrick authored Mar 12, 2011

Also don't serialize empty headers.

R=dsymonds, rsc
CC=golang-dev
https://golang.org/cl/4275045

1c96562f

runtime/proc.c: which to that · a7528f1b
Rob Pike authored Mar 12, 2011
```
R=iant, dho
CC=golang-dev
https://golang.org/cl/4286044
```
a7528f1b
runtime: reduce lock contention via wakeup on scheduler unlock. · 5e963a82
Ian Lance Taylor authored Mar 12, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4275043
```
5e963a82

net: don't loop to drain wakeup pipe. · c01238a5

Ian Lance Taylor authored Mar 12, 2011

The loop always makes an extra system call.  It only makes a
difference if more than 100 goroutines started waiting for
something to happen on a network file descriptor since the
last time the pipe was drained, which is unlikely since we
will be woken up the first time a goroutine starts waiting.
If we don't drain the pipe this time, we'll be woken up again
right away and can drain again.

R=rsc
CC=golang-dev
https://golang.org/cl/4275042

c01238a5

gob: use bufio on the decode to avoid a system call on each read. · 5df1cf04

Rob Pike authored Mar 12, 2011

Add a benchmark.
BenchmarkEndToEndPipe gives 14.3microseconds/op before,
13.1microseconds/op after, or about 76e3 round trips per second
through the kernel.
With a bytes buffer, and therefore no system calls for I/O, the
numbers go to 7.3microseconds/op, or about 137e3 round trips
per second.

R=rsc
CC=golang-dev
https://golang.org/cl/4279045

5df1cf04

gotype: clean handling of stdin, added tests · c734b50b

Robert Griesemer authored Mar 12, 2011

- removed uses of global variables
- minor cleanups

R=r
CC=golang-dev
https://golang.org/cl/4277044

c734b50b

11 Mar, 2011 14 commits
- go/typechecker: fix build · 86e35a96
  Robert Griesemer authored Mar 11, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4278043
```
  86e35a96
- go/parser: first constant in a constant declaration must have a value · 7664ec39
  Robert Griesemer authored Mar 11, 2011
```
R=r, rsc1
CC=golang-dev
https://golang.org/cl/4291042
```
  7664ec39
- build: run gotest in misc/cgo/test · ec713d68
  Russ Cox authored Mar 11, 2011
```
R=golang-dev, iant, r
CC=golang-dev
https://golang.org/cl/4239079
```
  ec713d68
- runtime: split non-debugging malloc interface out of debug.go into mem.go · 591c74ad
  Russ Cox authored Mar 11, 2011
```
R=r, dsymonds
CC=golang-dev
https://golang.org/cl/4273045
```
  591c74ad
- go code: replace closed(c) with x, ok := <-c · 3f915f51
  Russ Cox authored Mar 11, 2011
```
R=golang-dev, rog, bradfitzwork, r
CC=golang-dev
https://golang.org/cl/4243072
```
  3f915f51
- gc, runtime: replace closed(c) with x, ok := <-c · 8bf34e33
  Russ Cox authored Mar 11, 2011
```
R=ken2, ken3
CC=golang-dev
https://golang.org/cl/4259064
```
  8bf34e33
- spec: remove closed from language, replaced by x, ok = <-c · 9f2cb86f
  Russ Cox authored Mar 11, 2011
```
R=gri, r, r2
CC=golang-dev
https://golang.org/cl/4249065
```
  9f2cb86f
- http: rename interface Transport to RoundTripper · d3d67299
  Brad Fitzpatrick authored Mar 11, 2011
```
Transport.Do -> RoundTripper.RoundTrip

This makes way for a subsequent CL to export the
currently private RoundTripper implementation
as struct Transport.

R=rsc, r
CC=golang-dev
https://golang.org/cl/4286043
```
  d3d67299
- gotype: commandline tool to typecheck go programs · dbff0ada
  Robert Griesemer authored Mar 11, 2011
```
First version. Handles scope analysis only at the
moment.

R=rsc, r, eds
CC=golang-dev
https://golang.org/cl/4259065
```
  dbff0ada
- http: fix transport crash when request URL is nil · 9554e671
  Brad Fitzpatrick authored Mar 11, 2011
```
Fixes #1602

R=rsc, petar-m
CC=golang-dev
https://golang.org/cl/4284043
```
  9554e671
- gopack: omit time stamps · e6c9bccd
  Russ Cox authored Mar 11, 2011
```
This makes it possible to build a package twice
and get the same bytes both times.

R=r, dsymonds, r2
CC=golang-dev
https://golang.org/cl/4248077
```
  e6c9bccd
- .hgtags: s/release/weekly/ · 08ceb870
  Andrew Gerrand authored Mar 11, 2011
```
.hgtags, release.html: tag current weekly as release.r56

R=r, rsc
CC=golang-dev
https://golang.org/cl/4281041
```
  08ceb870
- io/ioutil: clean-up of ReadAll and ReadFile · 478f08a5
  Robert Griesemer authored Mar 11, 2011
```
Make ReadAll use the same mechanism as ReadFile.

R=r
CC=golang-dev
https://golang.org/cl/4279041
```
  478f08a5
- go/ast: fix printing of maps · 2e8b375e
  Robert Griesemer authored Mar 11, 2011
```
Print a newline after each map entry;
similar to the style used for slices
and structs.

R=r, r2
CC=golang-dev
https://golang.org/cl/4274042
```
  2e8b375e
10 Mar, 2011 3 commits

go/ast: ast.Print needs a file set to print position values nicely · f1fee448
Robert Griesemer authored Mar 10, 2011
```
Also removed a TODO (AST nodes have been restructured a while ago).

R=r
CC=golang-dev
https://golang.org/cl/4245077
```
f1fee448

gofmt: remove -trace and -ast flags · 2099e9fd

Robert Griesemer authored Mar 10, 2011

Functionality was only present for
debuggging and now is available in
gocheck where is makes more sense.

R=rsc
CC=golang-dev
https://golang.org/cl/4239078

2099e9fd

flag: visit the flags in sorted order, for better messages. · 034ca39e
Rob Pike authored Mar 10, 2011
```
Fixes #1601.

R=rsc
CC=golang-dev
https://golang.org/cl/4249070
```
034ca39e