Commits · f2dc50b48d011d4d585d09d5e6bed350894add3d · go / golang

04 Nov, 2011 13 commits

html,bzip2,sql: rename Error methods that return error to Err · f2dc50b4

Gustavo Niemeyer authored Nov 04, 2011

There are three classes of methods/functions called Error:

a) The Error method in the just introduced error interface
b) Error methods that create or report errors (http.Error, etc)
c) Error methods that return errors previously associated with
   the receiver (Tokenizer.Error, rows.Error, etc).

This CL introduces the convention that methods in case (c)
should be named Err.

The reasoning for the change is:

- The change differentiates the two kinds of APIs based on
  names rather than just on signature, unloading Error a bit
- Err is closer to the err variable name that is so commonly
  used with the intent of verifying an error
- Err is shorter and thus more convenient to be used often
  on error verifications, such as in iterators following the
  convention of the sql package.

R=bradfitz, rsc
CC=golang-dev
https://golang.org/cl/5327064

f2dc50b4

template: format error with pointer receiver. · 39fcca60

David Symonds authored Nov 04, 2011

This is a continuation of 982d70c6d5d6.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5348042

39fcca60

runtime: fix linux/arm nanotime? · 7f5ae484
Russ Cox authored Nov 04, 2011
```
TBR=r
CC=golang-dev
https://golang.org/cl/5354041
```
7f5ae484
template: format errors · e73680ae
Russ Cox authored Nov 04, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5340043
```
e73680ae
runtime: fix openbsd nanotime? · cb2040b2
Russ Cox authored Nov 04, 2011
```
TBR=r
CC=golang-dev
https://golang.org/cl/5353041
```
cb2040b2
bytes: fix typo and resolve to be less idiotic next time · ed925490
Andrew Gerrand authored Nov 04, 2011
```
R=bradfitz
CC=golang-dev
https://golang.org/cl/5340044
```
ed925490
bytes: add Contains function · 1a4402a1
Andrew Gerrand authored Nov 04, 2011
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5349041
```
1a4402a1

html: properly close <tr> element when an new <tr> starts. · 632a2c59

Andrew Balholm authored Nov 04, 2011

Pass tests1.dat, test 87:
<table><tr><tr><td><td><span><th><span>X</table>

| <html>
|   <head>
|   <body>
|     <table>
|       <tbody>
|         <tr>
|         <tr>
|           <td>
|           <td>
|             <span>
|           <th>
|             <span>
|               "X"

R=nigeltao
CC=golang-dev
https://golang.org/cl/5343041

632a2c59

http: doc nits · 0865c57f

Brad Fitzpatrick authored Nov 04, 2011

Remove the last two "convenience" mentions.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5344041

0865c57f

http: clarify Request docs · 3b901f45
Brad Fitzpatrick authored Nov 04, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5342041
```
3b901f45

httputil: move dump and chunking functions out of http · 28564d60

Brad Fitzpatrick authored Nov 04, 2011

This moves DumpRequest, DumpResponse, NewChunkedReader,
and NewChunkedWriter out of http, as part of the continued
http diet plan.

Also, adds DumpRequestOut (for dumping outbound requests),
since DumpRequest's ambiguity (the "wire representation" in
what direction?) was often a source of confusion and bug
reports.

R=rsc, adg
CC=golang-dev
https://golang.org/cl/5339041

28564d60

gob: fix bug when registering the same type multiple times · 88cf76a9

Rob Pike authored Nov 04, 2011

Need to compare user type, not base type.

R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/5340041

88cf76a9

http: only recognize application/x-www-form-urlencoded in ParseForm · a494c200
Brad Fitzpatrick authored Nov 04, 2011
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5322070
```
a494c200

03 Nov, 2011 23 commits

httputil: move ReverseProxy out of http · 54049767
Brad Fitzpatrick authored Nov 03, 2011
```
http diet plan, continued.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5305090
```
54049767

html: move <link> element from after <head> into <head> · 46308d7d

Andrew Balholm authored Nov 03, 2011

Pass tests1.dat, test 85:
<head><meta></head><link>

| <html>
|   <head>
|     <meta>
|     <link>
|   <body>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5297079

46308d7d

net/http/httputil: new package; move ClientConn and ServerConn · a7f1141d

Brad Fitzpatrick authored Nov 03, 2011

Part of http diet plan.

More of the lesser-used and newcomer-misleading parts of http will
move here.

R=r, rsc
CC=golang-dev
https://golang.org/cl/5336049

a7f1141d

time: faster Nanoseconds call · f437331f

Russ Cox authored Nov 03, 2011

runtime knows how to get the time of day
without allocating memory.

R=golang-dev, dsymonds, dave, hectorchu, r, cw
CC=golang-dev
https://golang.org/cl/5297078

f437331f

runtime: fix set and not used · 31452a36
Russ Cox authored Nov 03, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5305087
```
31452a36

gofix: make fix order implicit by date. · d26144be

David Symonds authored Nov 03, 2011

This partially undoes 8fd7e6d070c8, but preserves its semantics.
More importantly, it results in the data about each fix being
decentralised, which makes it easier for new fixes to be added,
and other gofix users to slot new fixes in.

It also adds some useful metadata that could be used in the future.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5306092

d26144be

os,text,unicode: renamings · 37d82c85

Rob Pike authored Nov 03, 2011

This is Go 1 package renaming CL #4.
This one merely moves the source; the import strings will be
changed after the next weekly release.
This one moves pieces into os, text, and unicode.

exec -> os/exec
scanner -> text/scanner
tabwriter -> text/tabwriter
template -> text/template
template/parse -> text/template/parse
utf16 -> unicode/utf16
utf8 -> unicode/utf8

This should be the last of the source-rearranging CLs.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5331066

37d82c85

all: rename os.EOF to io.EOF in various non-code contexts · eb1717e0
Vincent Vanackere authored Nov 03, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5334050
```
eb1717e0

net: renamings · de03d502

Rob Pike authored Nov 03, 2011

This is Go 1 package renaming CL #3.
This one merely moves the source; the import strings will be
changed after the next weekly release.
This one moves pieces into net.

http -> net/http
http/cgi -> net/http/cgi
http/fcgi -> net/http/fcgi
http/pprof -> net/http/pprof
http/httptest -> net/http/httptest
mail -> net/mail
rpc -> net/rpc
rpc/jsonrpc -> net/rpc/jsonrpc
smtp -> net/smtp
url -> net/url

Also remove rand (now math/rand) from NOTEST - it has a test.

The only edits are in Makefiles and deps.bash.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5335048

de03d502

html,log,math: renamings · 5cb4a153

Rob Pike authored Nov 03, 2011

This is Go 1 package renaming CL #2.
This one merely moves the source; the import strings will be
changed after the next weekly release.

exp/template/html -> html/template
big -> math/big
cmath -> math/cmplx
rand -> math/rand
syslog -> log/syslog

The only edits are in Makefiles and deps.bash.

Note that this CL moves exp/template/html out of exp. I decided
to do that so all the renamings can be done together, even though
the API (and that of template, for that matter) is still fluid.

R=r, rsc
CC=golang-dev
https://golang.org/cl/5332053

5cb4a153

http: don't use ClientConn in Transport · 53493a22

Brad Fitzpatrick authored Nov 03, 2011

ClientConn's main feature (pipelining support)
wasn't being used anyway.  Ends up simpler to
just not use it.

This is prep for the http diet, moving ClientConn,
ServerConn, etc into http/httputil.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5305088

53493a22

container/heap: document what Push and Pop do · 41dc7d3a

Russ Cox authored Nov 03, 2011

Now that vector is gone, there is no precedent to refer to.
This is a confusing point for people looking to use the
package.

R=golang-dev, r, cw
CC=golang-dev
https://golang.org/cl/5322069

41dc7d3a

deps.bash: attempt to fix the windows build · d615a525
Rob Pike authored Nov 03, 2011
```
Use simpler shell constructs.

R=golang-dev
CC=golang-dev
https://golang.org/cl/5297080
```
d615a525

encoding: move asn1, csv, gob, json, xml into encoding · f4cd8022

Rob Pike authored Nov 03, 2011

This is Go 1 package renaming CL #1.
This one merely moves the source; the import strings will be
changed after the next weekly release.

The only edits are in Makefiles.

R=r, rsc
CC=golang-dev
https://golang.org/cl/5331060

f4cd8022

gc: Don't pollute the xmethod list with non-methods. · 11075ed8

Luuk van Dijk authored Nov 03, 2011

Fixes #2355.

I have a test, but not sure if it's worth adding.  Instead i've made
the patching-over in reflect.c methods more fatal and more descriptive.

R=rsc
CC=golang-dev
https://golang.org/cl/5302082

11075ed8

gc, ld: sync pathtoprefix + add comments · 80bce97e
Russ Cox authored Nov 03, 2011
```
R=lvd, lvd
CC=golang-dev
https://golang.org/cl/5332051
```
80bce97e
gopack: do not look for Go metadata in non-Go objects · d6ff3c11
Russ Cox authored Nov 03, 2011
```
Fixes #2333.

R=r
CC=golang-dev
https://golang.org/cl/5316075
```
d6ff3c11
8a: fix IMULL grammar · 1738dc0e
Russ Cox authored Nov 03, 2011
```
R=ken2
CC=golang-dev
https://golang.org/cl/5298091
```
1738dc0e

html: parse <link> elements in <head> · 77aabbf2

Andrew Balholm authored Nov 03, 2011

Pass tests1.dat, test 83:
<title><meta></title><link><title><meta></title>

| <html>
|   <head>
|     <title>
|       "<meta>"
|     <link>
|     <title>
|       "<meta>"
|   <body>

Also pass test 84:
<style><!--</style><meta><script>--><link></script>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5331061

77aabbf2

builtin: remove errant spaces · 1c530d5d
Andrew Gerrand authored Nov 03, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5337041
```
1c530d5d
http: update mime sniffing doc reference. · e4b46424
David Symonds authored Nov 03, 2011
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5303095
```
e4b46424

websocket: return an error HTTP response for bad websocket request. · de3d6472

Fumitoshi Ukai authored Nov 03, 2011

websocket spec had changed server-side requiements to return
an HTTP response with an appropriate error code (such as 400 Bad
Request) when it finds client did not send a handshake that matches
websocket protocol, rather than just closing connection.
It needs to flush out response before closing connection.
Fixes issues 2396.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5318072

de3d6472

test: clear execute bit from source file · bc440f1b
Mikio Hara authored Nov 03, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5330068
```
bc440f1b

02 Nov, 2011 4 commits

html: properly close <marquee> elements. · cf6a7121

Andrew Balholm authored Nov 02, 2011

Pass tests1.dat, test 80:
<a href=a>aa<marquee>aa<a href=b>bb</marquee>aa

| <html>
|   <head>
|   <body>
|     <a>
|       href="a"
|       "aa"
|       <marquee>
|         "aa"
|         <a>
|           href="b"
|           "bb"
|       "aa"

Also pass tests through test 82:
<!DOCTYPE html><spacer>foo

R=nigeltao
CC=golang-dev
https://golang.org/cl/5319071

cf6a7121

gc: package paths in symbol names: don't escape periods before last slash, always escape >=0x7f. · 33f1d47b
Luuk van Dijk authored Nov 02, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5323071
```
33f1d47b
all: sort imports · 965845a8
Russ Cox authored Nov 02, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5319072
```
965845a8

gofmt, gofix: sort imports · 4a9ebb18

Russ Cox authored Nov 02, 2011

Add ast.SortImports(fset, file) to go/ast, for use by both programs.

Fixes #346.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5330069

4a9ebb18