- 11 Feb, 2015 2 commits
-
-
Austin Clements authored
Currently, if there is a VERSION.cache, running make.bash will set runtime.theVersion to the revision as of the *last* make.bash run instead of the current make.bash run. For example, $ git rev-parse --short HEAD 5c4a86d0 $ ./make.bash ... $ cat ../VERSION.cache devel +5c4a86d0 Tue Feb 10 01:46:30 2015 +0000 $ git checkout a1dbb920 $ ./make.bash ... $ go version go version devel +5c4a86d0 Tue Feb 10 01:46:30 2015 +0000 linux/amd64 $ ./make.bash ... $ go version go version devel +a1dbb920 Tue Feb 10 02:31:27 2015 +0000 linux/amd64 This happens because go tool dist reads the potentially stale VERSION.cache into goversion during early initialization; then cleans, which deletes VERSION.cache; then builds the runtime using the stale revision read in to goversion. It isn't until make later in the build process, when make.bash invokes go tool dist again, that VERSION.cache gets updated with the current revision. To address this, simply don't bother fetching the version until go tool dist needs it and don't bother caching the value in memory. This is more robust since it interacts with cleaning in the expected ways. Futhermore, there's no downside to eliminating the in-memory cache; the file system cache is perfectly reasonable for the whole three times make.bash consults it. Change-Id: I8c480100e56bb2db0816e8a088177004d9e87973 Reviewed-on: https://go-review.googlesource.com/4540Reviewed-by: Russ Cox <rsc@golang.org>
-
rubyist authored
If an absolute domain name (i.e. ends in a '.' like "example.com.") is used with ssl/tls, the certificate will be reported as invalid. In matchHostnames, the host and patterns are split on '.' and if the lengths of the resulting slices do not match, the function returns false. When splitting an absolute domain name on '.', the slice will have an extra empty string at the end. This empty string should be discarded before comparison, if present. Fixes #9828 Change-Id: I0e39674b44a6f93b5024497e76cf1b550832a61d Reviewed-on: https://go-review.googlesource.com/4380Reviewed-by: Adam Langley <agl@golang.org> TryBot: Adam Langley <agl@golang.org>
-
- 10 Feb, 2015 13 commits
-
-
Keith Randall authored
Container symbols shouldn't be considered as functions in the functab. Having them present probably messes up function lookup, as you might get the descriptor of the container instead of the descriptor of the actual function on the stack. It also messed up the findfunctab because these entries caused off-by-one errors in how functab entries were counted. Normal code is not affected - it only changes (& hopefully fixes) the behavior for libraries linked as a unit, like: net runtime/cgo runtime/race Fixes #9804 Change-Id: I81e036e897571ac96567d59e1f1d7f058ca75e85 Reviewed-on: https://go-review.googlesource.com/4290Reviewed-by: Russ Cox <rsc@golang.org>
-
Mikio Hara authored
Change-Id: I695b89ec2b63233d94c49c4a40a57b50350ec67c Reviewed-on: https://go-review.googlesource.com/4350 TryBot: Mikio Hara <mikioh.mikioh@gmail.com> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Mikio Hara authored
Change-Id: I69f24887601e491d6d722bfeb2952d927df8ad80 Reviewed-on: https://go-review.googlesource.com/4351Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Ian Lance Taylor authored
Fixes #9814. Change-Id: I1be49efae0648038f590eeca1262037bf1af3df5 Reviewed-on: https://go-review.googlesource.com/4240Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>
-
Robert Griesemer authored
- Frexp, Ldexp are equivalents to the corresponding math functions. - Set now has the same prec behavior as the other functions - Copy is a true assignment (replaces old version of Set) - Cmp now handles infinities - more tests Change-Id: I0d33980c08be3095b25d7b3d16bcad1aa7abbd0f Reviewed-on: https://go-review.googlesource.com/4292Reviewed-by: Alan Donovan <adonovan@google.com>
-
Nicolas S. Dade authored
The sanity checks at the beginning of WriteMsgUDP were too strict, and did not allow a case sendmsg(2) suppports: sending to a connected UDP socket. This fixes the sanity checks. Either the socket is unconnected, and a destination addresses is required (what all existing callers must have been doing), or the socket is connected and an explicit destination address must not be used. Fixes #9807 Change-Id: I08d4ec3c2bf830335c402acfc0680c841cfcec71 Reviewed-on: https://go-review.googlesource.com/3951Reviewed-by: Mikio Hara <mikioh.mikioh@gmail.com>
-
Alex Brainman authored
Change-Id: I5cedd9e53f4e020aea74d498d0db88d79a95260c Reviewed-on: https://go-review.googlesource.com/2718Reviewed-by: Minux Ma <minux@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Rajat Goel authored
I think the test was meant to test requests to 'localhost:80' instead of 'localhost:80:80'. It passes even with 'localhost:80:80' because net.SplitHostPort fails inside useProxy. Please comment if you want to leave old 'localhost:80' is the list too to check old code path. Change-Id: Ic4cd21901563449e3d4e2f4c8caf723f4ca15bac u Reviewed-on: https://go-review.googlesource.com/4293Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Andrew Gerrand authored
Change-Id: Iad1764707d173a09467fd36e8c49a58147f12219 Reviewed-on: https://go-review.googlesource.com/4320Reviewed-by: Minux Ma <minux@golang.org>
-
Alex Brainman authored
This CL introduces new methods for 'context' type, so we can manipulate its values in an architecture independent way. Use new methods to replace both 386 and amd64 versions of dosigprof with single piece of code. There is more similar code to be converted in the following CLs. Also remove os_windows_386.go and os_windows_amd64.go. These contain unused functions. Change-Id: I28f76aeb97f6e4249843d30d3d0c33fb233d3f7f Reviewed-on: https://go-review.googlesource.com/2790Reviewed-by: Minux Ma <minux@golang.org>
-
Rob Pike authored
I am an idiot but the failure to implement this means we can decide exactly what its design should be for 1.5 Change-Id: Ie2b025fcd899d306ddeddd09d1d0e8f9a99ab7a8 Reviewed-on: https://go-review.googlesource.com/4291Reviewed-by: Minux Ma <minux@golang.org>
-
mattn authored
Fixes #5395 Change-Id: I4322bc8a974d04d9bae6b48c71c5d32d9252973c Reviewed-on: https://go-review.googlesource.com/3024Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
-
Dave Cheney authored
Fixes #9732 Fixes #9819 Rather than detecting vfp support via catching SIGILL signals, parse the contents of /proc/cpuinfo. As the GOARM values for NaCl and freebsd are hard coded, this parsing logic only needs to support linux/arm. This change also fixes the nacl/arm build which is broken because the first stage of nacltest.bash is executed with GOARM=5, embedding that into 5g. The second stage of nacltest.bash correctly detects GOARM=7, but this is ignored as we pass --no-clean at that point, and thus do not replace the compiler. Lastyly, include a fix to error message in nacltest.bash Change-Id: I13f306ff07a99b44b493fade72ac00d0d5097e1c Reviewed-on: https://go-review.googlesource.com/3981Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
- 09 Feb, 2015 9 commits
-
-
Shenghou Ma authored
CL 2118 makes the assumption that all references to runtime.tlsg should be accompanied by a declaration of runtime.tlsg if its type should be a normal variable, instead of a placeholder for TLS relocation. Because if runtime.tlsg is not declared by the runtime package, the type of runtime.tlsg will be zero, so fix the check in liblink to look for 0 instead of STLSBSS (the type will be initialized by cmd/ld, but cmd/ld doesn't run during assembly). Change-Id: I691ac5c3faea902f8b9a0b963e781b22e7b269a7 Reviewed-on: https://go-review.googlesource.com/4030Reviewed-by: David Crawshaw <crawshaw@golang.org>
-
Robert Griesemer authored
Change-Id: I208c8ac44d1a8882d8fdeb18347dc20941e20374 Reviewed-on: https://go-review.googlesource.com/4250Reviewed-by: Alan Donovan <adonovan@google.com>
-
Rahul Chaudhry authored
"go test -v" buffers output if more than one package is being tested to avoid mixing the outputs from multiple tests running in parallel. It currently enables streaming if there's only a single package under test. It is ok to stream output from multiple tests if we know that they're not going to be running in parallel. To see the difference: go test -v -p=1 runtime fmt -short Change-Id: Idc24575c899eac30d553e0bf52b86f90e189392d Reviewed-on: https://go-review.googlesource.com/4153Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Robert Griesemer authored
- better and more consistent documentation - more functions implemented - more tests Change-Id: If4c591e7af4ec5434fbb411a48dd0f8add993720 Reviewed-on: https://go-review.googlesource.com/4140Reviewed-by: Alan Donovan <adonovan@google.com>
-
Rahul Chaudhry authored
This is an alternative to http://golang.org/cl/4150, and is motivated by a review comment on that CL. testKillProcess() tries to build and run the Go equivalent for "sleep 1". This doesn't work for testing cross compilers since the Go compiler is not available on the targets. This change embeds the "sleep 1" functionality within the "os.test" binary itself. Change-Id: I6bad513deaa6c9e2704e70319098eb4983f1bb23 Reviewed-on: https://go-review.googlesource.com/4190Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Dmitry Vyukov authored
When we use dialMulti we also allocate dialSingle closure for no reason. Change-Id: I074282a9d6e2c2a1063ab311a1b95e10fe65219f Reviewed-on: https://go-review.googlesource.com/4119Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Dmitry Vyukov authored
Change-Id: Ib46a42fc873066b1cc00368fe43648f08dce48bd Reviewed-on: https://go-review.googlesource.com/4200Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Nigel Tao authored
There are no behavior changes in this CL, only specifying the status quo. A follow-up CL, https://go-review.googlesource.com/#/c/2660/, will change the EncodeToken behavior. Change-Id: I6ecbcfb05ae681de71fa1099d054df2826ed4acb Reviewed-on: https://go-review.googlesource.com/4167Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Shenghou Ma authored
The Addr might be a stack variable with uninitialized fields. Fixes #9777. Change-Id: I799786e3d8b2e17e069725bc66a076cf9ca11f93 Signed-off-by: Shenghou Ma <minux@golang.org> Reviewed-on: https://go-review.googlesource.com/3932Reviewed-by: Dave Cheney <dave@cheney.net> Reviewed-by: Keith Randall <khr@golang.org>
-
- 08 Feb, 2015 7 commits
-
-
Florin Patan authored
There was a small typo in the comment before the Stable function. Change-Id: Ia6fa5272aa7869124a637d2eeda81c4f35ef46c8 Reviewed-on: https://go-review.googlesource.com/4201Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
David Symonds authored
Change-Id: I66d923abbef13ba35c76c6f6da5b14c6d534127c Reviewed-on: https://go-review.googlesource.com/4165Reviewed-by: Alex Brainman <alex.brainman@gmail.com> Reviewed-by: David du Colombier <0intro@gmail.com>
-
David Symonds authored
If we cannot load timezone information for a reason other than the zoneinfo file not existing, return it since that will be much more useful in debugging failures than "unknown time zone XYZ". Fixes #9723. Change-Id: I3aa5774859cec28e584d16bcc1fef0705d95288c Reviewed-on: https://go-review.googlesource.com/3984Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Brad Fitzpatrick authored
Reverts https://golang.org/cl/119530044 (OS X 10.10 Yosemite beta 14A299l workaround), since it was fixed in the final Yosemite release. I verified that the C program http://swtch.com/~rsc/readdirbug.c passes on Yosemite. Adds a new test to the os package too, to verify that reading a regular file as a directory fails. Fixes #9789 (ReadDir: no error if dirname is a file) Change-Id: I75286cef88fbb2ebccf045b479e33c810749dcbc Reviewed-on: https://go-review.googlesource.com/4164Reviewed-by: Dave Cheney <dave@cheney.net>
-
David Symonds authored
This reverts commit 11d1c05f. See #9296 for details. Change-Id: I89a36351cb007836662f28a611af5616818b95fe Reviewed-on: https://go-review.googlesource.com/1536Reviewed-by: Minux Ma <minux@golang.org> Reviewed-by: Russ Cox <rsc@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
mattyw authored
Change-Id: If697ab554e6cb5545d99c6b103ed8bc54f69ed48 Reviewed-on: https://go-review.googlesource.com/4161Reviewed-by: Andrew Gerrand <adg@golang.org>
-
Shenghou Ma authored
Fixes build for solaris. Change-Id: Ic6ffab36df9bd68fc38b258f1484a29fa2a0cd39 Reviewed-on: https://go-review.googlesource.com/4180Reviewed-by: Aram Hăvărneanu <aram@mgk.ro>
-
- 07 Feb, 2015 5 commits
-
-
Brad Fitzpatrick authored
Fixes #9776 Change-Id: I53741fd970244bbfa6874adcb4f1e3d0e7de386b Reviewed-on: https://go-review.googlesource.com/4162Reviewed-by: Andrew Gerrand <adg@golang.org>
-
Brian Smith authored
Before, an array of size 4 would always be allocated even if a tag doesn't have any attributes. Now that array is allocated only if needed. benchmark old allocs new allocs delta BenchmarkUnmarshal 191 176 -8.5% Change-Id: I4d214b228883d0a6e892c0d6eb00dfe2da84c116 Reviewed-on: https://go-review.googlesource.com/4160Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Håvard Haugen authored
Fixes #8780 Change-Id: I09cf01ff9722eed49086992a12774f2de81d16f2 Reviewed-on: https://go-review.googlesource.com/2840Reviewed-by: Andrew Gerrand <adg@golang.org>
-
David du Colombier authored
warning: src/liblink/list5.c:171 format mismatch lld INT, arg 4 warning: src/liblink/list9.c:175 format mismatch lld INT, arg 4 warning: src/liblink/list6.c:211 format mismatch lld INT, arg 4 warning: src/liblink/list8.c:205 format mismatch lld INT, arg 4 Change-Id: I745ea852d8b58ecbbd32723e2a67aa784a729ff8 Reviewed-on: https://go-review.googlesource.com/4112Reviewed-by: Minux Ma <minux@golang.org>
-
Brad Fitzpatrick authored
The old C-based dist accepted merged flags (-wp) but the Go-based dist requires -w -p This should get the Windows race builder running properly, along with https://go-review.googlesource.com/#/c/4132/ Update #8640 Change-Id: Ic17bbe9ea6c8b3d3e9b29f94e234d014f2926439 Reviewed-on: https://go-review.googlesource.com/4133Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
- 06 Feb, 2015 4 commits
-
-
David du Colombier authored
This change is an implementation of the signal runtime and os/signal package on Plan 9. Contrary to Unix, on Plan 9 a signal is called a note and is represented by a string. For this reason, the sigsend and signal_recv functions had to be reimplemented specifically for Plan 9. In order to reuse most of the code and internal interface of the os/signal package, the note strings are mapped to integers. Thanks to Russ Cox for the early review. Change-Id: I95836645efe21942bb1939f43f87fb3c0eaaef1a Reviewed-on: https://go-review.googlesource.com/2164Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Rob Pike <r@golang.org>
-
Shenghou Ma authored
It turns out -iex argument is not supported by all gdb versions, but as we need to add the auto-load safe path before loading the inferior, test -iex support first and skip the test if it's not available. We should still update our builders though. Change-Id: I355697de51baf12162ba6cb82f389dad93f93dc5 Reviewed-on: https://go-review.googlesource.com/4070Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Shenghou Ma authored
On some systems, gdb refuses to load Python plugin from arbitrary paths, so we have to add $GOROOT/src/runtime to auto-load-safe-path in the gdb script test. Change-Id: Icc44baab8d04a65bd21ceac2ab8ddb13c8d083e8 Reviewed-on: https://go-review.googlesource.com/2905Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
-
Shenghou Ma authored
Ideally, those methods should return a copy of the Addr, but due to the Go 1 API guarantee, we cannot make that change now: there might exist client code that uses the returned Addr as map index and thus relies on the fact that different invocation of the method returns the same pointer. Changing this behavior will lead to hidden behaviour change in those programs. Update #9654. Change-Id: Iad4235f2ed7789b3a3c8e0993b9718cf0534ea2b Reviewed-on: https://go-review.googlesource.com/3851Reviewed-by: Mikio Hara <mikioh.mikioh@gmail.com> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-