Commits · f492bd7012a6cb2af2f91d82400e6c8df141c127 · go / golang

22 Mar, 2011 7 commits
- gob: fix up ugly formatting introduced by buggy (now fixed) gofmt. · f492bd70
  Rob Pike authored Mar 22, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4281065
```
  f492bd70
- gob: use pointers in bootstrapType so interfaces behave properly · 544cf759
  Rob Pike authored Mar 22, 2011
```
and don't lead to a nil reflect.Type.
Fixes #1626.

R=rsc
CC=golang-dev
https://golang.org/cl/4289062
```
  544cf759
- go/printer, gofmt: simplify struct formatting and respect line breaks · 6684d550
  Robert Griesemer authored Mar 22, 2011
```
Also: gofmt src misc

Fixes #1627.

R=rsc
CC=golang-dev
https://golang.org/cl/4303042
```
  6684d550
- test: enable tests using v, ok := <-ch syntax · 169e6d40
  Robert Hencke authored Mar 22, 2011
```
R=rsc, r
CC=golang-dev
https://golang.org/cl/4290059
```
  169e6d40
- gopprof: fix bug: do not rotate 180 degrees for large scrolls · 1da382c8
  Russ Cox authored Mar 22, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4273088
```
  1da382c8
- ld: return > 0 exit code on unsafe import · d4b19bdb
  Andrew Gerrand authored Mar 22, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4273092
```
  d4b19bdb
- go/printer, gofmt: avoid exponential layout algorithm · 4a33d440
  Robert Griesemer authored Mar 22, 2011
```
Use memoization to avoid repeated recomputation of nested
node sizes. Speeds up testdata/slow.input by several orders
of magnitude.

- added respective test case
- added timeout to test code
- deleted some unrelated unused code

Fixes #1628.

R=rsc, r
CC=golang-dev
https://golang.org/cl/4274075
```
  4a33d440
21 Mar, 2011 8 commits

cgi: extra failure debugging in host_test · 70801306

Brad Fitzpatrick authored Mar 21, 2011

Trying to track down why this fails on some
people's machines.

R=rsc, adg, dsymonds
CC=golang-dev
https://golang.org/cl/4304041

70801306

time: give a helpful message when we can't set the time zone for testing. · 45aeca47
Rob Pike authored Mar 21, 2011
```
Fixes #1625.

R=bradfitzgo, bradfitzwork, r2
CC=golang-dev
https://golang.org/cl/4295060
```
45aeca47
syscall: rename from .sh to .pl, because these files are in Perl. · 319a8c45
Rob Pike authored Mar 21, 2011
```
Also delete references to nacl.

R=rsc, r2
CC=golang-dev
https://golang.org/cl/4275060
```
319a8c45
exec: document dir option for Run · 2187f43e
Gustavo Niemeyer authored Mar 21, 2011
```
R=golang-dev, bradfitzwork, rsc1, peterGo
CC=golang-dev
https://golang.org/cl/4271056
```
2187f43e

build: reenable clean.bash without gomake · b889a9f9

Gustavo Niemeyer authored Mar 21, 2011

This change had already been made in revision 7371, but
was then undone with changes in revision 7606.

R=golang-dev, rsc1
CC=golang-dev
https://golang.org/cl/4239064

b889a9f9

goinstall: add -clean flag to docs · f91e677e
Andrew Gerrand authored Mar 21, 2011
```
Fixes #1629.

R=rsc
CC=golang-dev
https://golang.org/cl/4291057
```
f91e677e

rpc: increase server_test timeout · 126911dc

Gustavo Niemeyer authored Mar 21, 2011

These timeouts are breaking tests in very slow
systems every once in a while.  I've noticed
problems when compiling the Ubuntu packages for
arm, specifically.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4291058

126911dc

path/filepath: fix TestEvalSymlinks when run under symlinked GOROOT · 338185da
Andrew Gerrand authored Mar 21, 2011
```
Fixes #1622.

R=rsc, bradfitzgo
CC=golang-dev
https://golang.org/cl/4287063
```
338185da

20 Mar, 2011 1 commit
- flag: document Nflag function · 19aecba1
  Fazlul Shahriar authored Mar 20, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4279065
```
  19aecba1
19 Mar, 2011 1 commit
- gopprof: update list of memory allocation functions · 893e02ab
  Russ Cox authored Mar 19, 2011
```
R=r, r2
CC=golang-dev
https://golang.org/cl/4275057
```
  893e02ab
18 Mar, 2011 7 commits

build: diagnose Ubuntu's buggy copy of gold · eedfc445
Russ Cox authored Mar 18, 2011
```
R=iant, dsymonds
CC=golang-dev
https://golang.org/cl/4300041
```
eedfc445
net: Use preallocated buffer for kqueue/kevent. · 000d60ac
Ian Lance Taylor authored Mar 18, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4293056
```
000d60ac
cgo: fix index-out-of-bounds bug · 3be0921e
Robert Griesemer authored Mar 18, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/4284057
```
3be0921e

rpc: keep free lists of Request and Response structures. · 3a6c0990

Rob Pike authored Mar 18, 2011

Also in the common case avoid unnecessary buffering in
the channel.
Removes 13 allocations per round trip. Now at 86, down from
144 a week ago.

R=rsc, bradfitzgo, r2, rsc1
CC=golang-dev
https://golang.org/cl/4277060

3a6c0990

net: Use preallocated buffer for epoll. · add8c8db

Ian Lance Taylor authored Mar 18, 2011

Reduces rpc test "mallocs per rpc round trip" by 4.

Gains ~8% on a localhost client/server RPC test.

R=rsc
CC=golang-dev
https://golang.org/cl/4284056

add8c8db

godoc: No need to use filepath.IsAbs() · 8c4a2ae6
Yasuhiro Matsumoto authored Mar 18, 2011
```
R=golang-dev, brainman, gri
CC=golang-dev
https://golang.org/cl/4277062
```
8c4a2ae6
godoc: fix path problem for windows. · b22e29d9
Yasuhiro Matsumoto authored Mar 18, 2011
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/4299044
```
b22e29d9

17 Mar, 2011 16 commits

sinit.c: recursion in sinit · 61c83b64
Ken Thompson authored Mar 17, 2011
```
fixes #1617

R=rsc
CC=golang-dev
https://golang.org/cl/4277059
```
61c83b64
filepath: do not run TestEvalSymlinks on Windows · bf91e827
Alex Brainman authored Mar 17, 2011
```
R=golang-dev, rsc1
CC=adg, golang-dev
https://golang.org/cl/4274069
```
bf91e827

go/parser: fix memory leak by making a copy of token literals · 39a1465d

Robert Griesemer authored Mar 17, 2011

The scanner returns slices into the original source
for token values. If those slices are making it into
the AST and from there into other long-living data
structures (e.g. godoc search), references to the
original source are kept around involuntarily.

For the current godoc and source tree, this change reduces
memory consumption after indexing and before GC by ~92MB
or almost 30%, and by ~10MB after GC (or about 6%).

R=rsc
CC=golang-dev
https://golang.org/cl/4273072

39a1465d

flag: fix example in doc comment. · 52b95970
Rob Pike authored Mar 17, 2011
```
Fixes #1615.

R=dsymonds
CC=golang-dev
https://golang.org/cl/4277058
```
52b95970

net: Don't force epoll/kqueue to wake up in order to add new events. · 42bc7fc8

Ian Lance Taylor authored Mar 17, 2011

In conjunction with the non-blocking system call CL, this
gives about an 8% performance improvement on a client/server
test running on my local machine.

R=rsc, iant2
CC=golang-dev
https://golang.org/cl/4272057

42bc7fc8

go/scanner: to interpret line comments with Windows filenames · c0f3b6c8
Alex Brainman authored Mar 17, 2011
```
Fixes #1614.

R=gri
CC=golang-dev
https://golang.org/cl/4290054
```
c0f3b6c8
os: remove fstat TODO · b3166bcb
Caine Tighe authored Mar 17, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/3559041
```
b3166bcb

gob: eliminate two more allocations in decode. · 9ad091e1

Rob Pike authored Mar 17, 2011

- just an oversight; we were reallocating a buffer.
- use unsafe to avoid allocating storage for a string twice.

R=rsc
CC=golang-dev
https://golang.org/cl/4290056

9ad091e1

time: isolate syscall reference in sys.go · 2ca46a78
Russ Cox authored Mar 17, 2011
```
R=dsymonds
CC=golang-dev
https://golang.org/cl/4291052
```
2ca46a78
.hgignore: Ignore all goinstalled packages · bc353797
Evan Shaw authored Mar 17, 2011
```
R=golang-dev, niemeyer, rsc1, rog, rsc
CC=golang-dev
https://golang.org/cl/4285047
```
bc353797
doc: mention godoc in "implements" FAQ · 393ea2df
Andrew Gerrand authored Mar 17, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4248066
```
393ea2df
path/filepath: add EvalSymlinks function · 75d4cb6a
Andrew Gerrand authored Mar 17, 2011
```
R=rsc, niemeyer, r2, rog, iant2, r
CC=golang-dev
https://golang.org/cl/4235060
```
75d4cb6a
doc: explain release and weekly tags in install.html · 929449dd
Andrew Gerrand authored Mar 17, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4272058
```
929449dd

syscall: Permit non-blocking syscalls. · 4fd41e49

Ian Lance Taylor authored Mar 17, 2011

Permit system calls to be designated as non-blocking, meaning
that we simply call them without involving the scheduler.

This change by itself is mostly performance neutral.  In
combination with a following change to the net package there
is a performance advantage.

R=rsc, dfc, r2, iant2, rsc1
CC=golang-dev
https://golang.org/cl/4278055

4fd41e49

gc: fix crash when using -u · e39dc768
Russ Cox authored Mar 17, 2011
```
R=ken2
CC=golang-dev
https://golang.org/cl/4278056
```
e39dc768

gob: remove a few more allocations. · 90f3f917

Rob Pike authored Mar 17, 2011

- use enc.err and dec.err instead of return values in deferred error catcher
- replace io.WriteString with buffer.WriteString

now at:
mallocs per encode of type Bench: 7
mallocs per decode of type Bench: 8

R=rsc
CC=golang-dev
https://golang.org/cl/4277057

90f3f917