- 03 Mar, 2014 5 commits
-
-
David du Colombier authored
warning: src/cmd/ld/pcln.c:184 more arguments than format INT LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/69870047
-
Brad Fitzpatrick authored
Fixes #3362 LGTM=josharian R=golang-codereviews, josharian CC=adg, dsymonds, golang-codereviews, n13m3y3r https://golang.org/cl/70120045
-
Andrew Gerrand authored
LGTM=r R=minux.ma, r CC=golang-codereviews https://golang.org/cl/70660043
-
Andrew Gerrand authored
This broke when we renamed the tool, and I missed this fix when I fixed darwin last week. LGTM=minux.ma, bradfitz R=golang-codereviews, minux.ma, bradfitz CC=golang-codereviews https://golang.org/cl/70670043
-
Andrew Gerrand authored
LGTM=minux.ma R=golang-codereviews, minux.ma CC=golang-codereviews https://golang.org/cl/69970047
-
- 02 Mar, 2014 4 commits
-
-
Mikio Hara authored
Also enables netgo test on solaris. LGTM=aram, jsing R=golang-codereviews, dave, aram, jsing CC=golang-codereviews https://golang.org/cl/70300043
-
Mikio Hara authored
Update #7186 LGTM=iant R=iant CC=golang-codereviews https://golang.org/cl/70490043
-
Richard Crowley authored
The addition of Server.ConnState provides all the necessary hooks to stop a Server gracefully, but StateNew previously could fire concurrently with Serve exiting (as it does when its net.Listener is closed). This previously meant one couldn't use a WaitGroup incremented in the StateNew hook along with calling Wait after Serve. Now you can. Update #4674 LGTM=bradfitz R=bradfitz CC=golang-codereviews https://golang.org/cl/70410044
-
Brad Fitzpatrick authored
Generated by addca. R=gobot CC=golang-codereviews https://golang.org/cl/70470043
-
- 01 Mar, 2014 3 commits
-
-
Shenghou Ma authored
See also CL 4259056 for FreeBSD. Test program: // exec.go package main import ( "log" "os" "os/exec" "runtime" ) func main() { path := runtime.GOROOT() + "/src/pkg/net/http/cgi/testdata" cmd := &exec.Cmd{ Path: "test.cgi", Args: []string{path + "/test.cgi"}, Dir: path Stdout: os.Stdout} if err := cmd.Start(); err != nil { log.Fatal(err) } if err := cmd.Wait(); err != nil { log.Fatal(err) } } $ go run exec.go 2014/03/01 15:52:41 fork/exec test.cgi: argument list too long LGTM=iant R=rsc, iant CC=golang-codereviews https://golang.org/cl/69970044
-
Dave Cheney authored
Update #7338 The nil deref tests are currently failing on the *bsd/arm platforms. In an effort to avoid the build deteriorating further I would like to skip these tests on freebsd/arm and netbsd/arm. LGTM=bradfitz, minux.ma R=golang-codereviews, bradfitz, minux.ma CC=golang-codereviews https://golang.org/cl/69870045
-
Dave Cheney authored
cgocall.c: define the CBARGS macro for GOARCH_amd64p32. I don't think the value of this macro will ever be used under nacl/amd64p32 but it is required to compile even if cgo is not used. hashmap.goc: amd64p32 uses 32bit words. LGTM=iant R=rsc, iant CC=golang-codereviews https://golang.org/cl/69960044
-
- 28 Feb, 2014 13 commits
-
-
Brad Fitzpatrick authored
LGTM=r R=r CC=golang-codereviews https://golang.org/cl/70120044
-
Brad Fitzpatrick authored
LGTM=josharian R=golang-codereviews, josharian CC=golang-codereviews https://golang.org/cl/70270043
-
Brad Fitzpatrick authored
Fixes #7291 LGTM=agl R=golang-codereviews, agl CC=agl, golang-codereviews https://golang.org/cl/70250044
-
Josh Bleecher Snyder authored
The pcln file number was being encoded incorrectly. The recorded delta was always against -1, not against the previous value. Update #7369 This CL fixes the bad DWARF file numbers. It does not, however, fix the gdb continue-to-end bug. LGTM=iant R=rsc, minux.ma, iant CC=golang-codereviews, graham https://golang.org/cl/68960046
-
Brad Fitzpatrick authored
This is a user error, but killing -1 kills everything, which is a pretty bad failure mode. Fixes #7434 LGTM=iant R=iant CC=golang-codereviews https://golang.org/cl/70140043
-
Brad Fitzpatrick authored
Part of graceful shutdown. Update #4674 LGTM=adg, josharian R=adg, josharian, r CC=golang-codereviews https://golang.org/cl/69670043
-
Adam Langley authored
While reviewing uses of the lower-level Client API in code, I found that in many cases, code was using Client only because it needed a timeout on the connection. DialWithDialer allows a timeout (and other values) to be specified without resorting to the low-level API. LGTM=r R=golang-codereviews, r, bradfitz CC=golang-codereviews https://golang.org/cl/68920045
-
Dave Cheney authored
Some parts of CL 15400047 didn't survive the merge. LGTM=rsc R=rsc, iant CC=golang-codereviews https://golang.org/cl/69870044
-
Nigel Tao authored
inside Huffman-encoded data. Fixes #6450. LGTM=r R=r CC=golang-codereviews https://golang.org/cl/69830043
-
Robert Sesek authored
LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/69100045
-
Brad Fitzpatrick authored
Update #4674 This allows for all sorts of graceful shutdown policies, without picking a policy (e.g. lameduck period) and without adding lots of locking to the server core. That policy and locking can be implemented outside of net/http now. LGTM=adg R=golang-codereviews, josharian, r, adg, dvyukov CC=golang-codereviews https://golang.org/cl/69260044
-
Russ Cox authored
This CL replays the following one CL from the rsc-go13nacl repo. This is the last replay CL: after this CL the main repo will have everything the rsc-go13nacl repo did. Changes made to the main repo after the rsc-go13nacl repo branched off probably mean that NaCl doesn't actually work after this CL, but all the code is now moved over and just needs to be redebugged. --- cmd/6l, cmd/8l, cmd/ld: support for Native Client See golang.org/s/go13nacl for design overview. This CL is publicly visible but not CC'ed to golang-dev, to avoid distracting from the preparation of the Go 1.2 release. This CL and the others will be checked into my rsc-go13nacl clone repo for now, and I will send CLs against the main repo early in the Go 1.3 development. R≡khr https://golang.org/cl/15750044 --- LGTM=bradfitz, dave, iant R=dave, bradfitz, iant CC=golang-codereviews https://golang.org/cl/69040044
-
Andrew Gerrand authored
We're about to commit some wide-sweeping changes to the go-tour and I would rather not include them in Go 1.2.1, which is due in the next week or so. Also fix the makerelease tool; it has been broken since it was renamed from bindist. LGTM=campoy R=campoy CC=golang-codereviews https://golang.org/cl/68780043
-
- 27 Feb, 2014 15 commits
-
-
Nigel Tao authored
over multiple scans. Previously, the Go code assumed that DC was synonymous with interleaved and AC with non-interleaved. Fixes #6767. The test files were generated with libjpeg's cjpeg program, version 9a, with the following patch, since cjpeg is hard-coded to output interleaved DC. $ diff -u jpeg-9a*/jcparam.c --- jpeg-9a-clean/jcparam.c 2013-07-01 21:13:28.000000000 +1000 +++ jpeg-9a/jcparam.c 2014-02-27 11:40:41.236889852 +1100 @@ -572,7 +572,7 @@ { int ci; - if (ncomps <= MAX_COMPS_IN_SCAN) { + if (0) { /* Single interleaved DC scan */ scanptr->comps_in_scan = ncomps; for (ci = 0; ci < ncomps; ci++) @@ -610,7 +610,7 @@ (cinfo->jpeg_color_space == JCS_YCbCr || cinfo->jpeg_color_space == JCS_BG_YCC)) { /* Custom script for YCC color images. */ - nscans = 10; + nscans = 14; } else { /* All-purpose script for other color spaces. */ if (ncomps > MAX_COMPS_IN_SCAN) LGTM=r R=r CC=golang-codereviews https://golang.org/cl/69000046
-
Keith Randall authored
Before GC, we flush all the per-P allocation caches. Doing stack shrinking mid-GC causes these caches to fill up. At the end of gc, the sweepgen is incremented which causes all of the data in these caches to be in a bad state (cached but not yet swept). Move the stack shrinking until after sweepgen is incremented, so any caching that happens as part of shrinking is done with already-swept data. Reenable stack copying. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/69620043
-
Brad Fitzpatrick authored
Fixes #7428 LGTM=r R=r CC=golang-codereviews https://golang.org/cl/69530044
-
Brad Fitzpatrick authored
Fixes #6951 LGTM=josharian R=golang-codereviews, josharian CC=golang-codereviews https://golang.org/cl/69280043
-
Robert Griesemer authored
No change to $GOROOT/src, misc formatting. Nice side-effect: almost 3% faster runs because it's much faster to compute line number differences in the generated output than the incoming source. Benchmark run, best of 5 runs, before and after: BenchmarkPrint 200 12347587 ns/op BenchmarkPrint 200 11999061 ns/op Fixes #4504. LGTM=adonovan R=golang-codereviews, adonovan CC=golang-codereviews https://golang.org/cl/69260045
-
Brad Fitzpatrick authored
This is the simple half of https://golang.org/cl/53560043/ with a new benchmark. pongad is in the C+A files already. benchmark old ns/op new ns/op delta BenchmarkReaderWriteToOptimal 2054 825 -59.83% Update #6373 LGTM=iant, gri R=golang-codereviews, iant, gri CC=golang-codereviews https://golang.org/cl/69220046
-
William Orr authored
Fixes #7415 LGTM=bradfitz R=bradfitz, iant CC=golang-codereviews https://golang.org/cl/68980043
-
Brad Fitzpatrick authored
Generated by addca. R=gobot CC=golang-codereviews https://golang.org/cl/68930047
-
Robert Griesemer authored
Reflect changes of reflect API. LGTM=r R=golang-codereviews, r CC=golang-codereviews https://golang.org/cl/69240044
-
Robert Griesemer authored
Fixes #4482. LGTM=r R=r, iant, rsc, ken CC=golang-codereviews https://golang.org/cl/69020045
-
Dmitriy Vyukov authored
LGTM=r R=golang-codereviews, r CC=golang-codereviews, iant, khr, rsc https://golang.org/cl/67460043
-
Joel Sing authored
This test currently deadlocks on dragonfly/386. Update #7421 LGTM=minux.ma R=golang-codereviews, minux.ma CC=golang-codereviews https://golang.org/cl/69380043
-
Keith Randall authored
TBR=dvyukov TBR=dvyukov CC=golang-codereviews https://golang.org/cl/69080045
-
David du Colombier authored
warning: src/pkg/runtime/mem_plan9.c:72 param declared and not used: n src/pkg/runtime/mem_plan9.c:73 name not declared: nbytes src/pkg/runtime/mem_plan9.c:73 bad in naddr: NAME nbytes<>+0(SB) LGTM=minux.ma, bradfitz R=khr, minux.ma, bradfitz CC=golang-codereviews https://golang.org/cl/69360043
-
Keith Randall authored
On stack overflow, if all frames on the stack are copyable, we copy the frames to a new stack twice as large as the old one. During GC, if a G is using less than 1/4 of its stack, copy the stack to a stack half its size. TODO - Do something about C frames. When a C frame is in the stack segment, it isn't copyable. We allocate a new segment in this case. - For idempotent C code, we can abort it, copy the stack, then retry. I'm working on a separate CL for this. - For other C code, we can raise the stackguard to the lowest Go frame so the next call that Go frame makes triggers a copy, which will then succeed. - Pick a starting stack size? The plan is that eventually we reach a point where the stack contains only copyable frames. LGTM=rsc R=dvyukov, rsc CC=golang-codereviews https://golang.org/cl/54650044
-