- 17 Sep, 2016 1 commit
-
-
Suyash authored
Change-Id: I27b82d8c63a06ddf7e148b15853aba24a22a6282 Reviewed-on: https://go-review.googlesource.com/29336Reviewed-by:
Joe Tsai <thebrokentoaster@gmail.com> Run-TryBot: Joe Tsai <thebrokentoaster@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 16 Sep, 2016 32 commits
-
-
David Crawshaw authored
Mysterious error and no time or easy machine access to investigate now, so disabling the -buildmode=plugin test on arm64. (The arm version is working as expected.) Updates #17138 Change-Id: I4cc56ddf47e7597213462e48d4934a765168bd07 Reviewed-on: https://go-review.googlesource.com/29363Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
David Crawshaw authored
I missed one in CL 29360. Change-Id: I29fc6dcd920829a918c70734d646119133a0a9df Reviewed-on: https://go-review.googlesource.com/29361Reviewed-by:
Keith Randall <khr@golang.org>
-
David Crawshaw authored
This test was always being run with external linking on these platforms because the linker was silently forcing external linking until CL 28971. Now it produces an error instead. Change-Id: I794e0812711e05b150daf805dc3451507bb4cae8 Reviewed-on: https://go-review.googlesource.com/29360 Run-TryBot: David Crawshaw <crawshaw@golang.org> Reviewed-by:
-
David Crawshaw authored
These are close to working, but untested and failing on build.golang.org. So disable for now. Change-Id: I330b8d1a91f0bf5139c894913868f01ec87e986d Reviewed-on: https://go-review.googlesource.com/29359Reviewed-by:
-
Matthew Dempsky authored
Update #16357. Change-Id: I507676212d7137a62c76de7bfa0ba8dbd68e840f Reviewed-on: https://go-review.googlesource.com/29358 Run-TryBot: Matthew Dempsky <mdempsky@google.com> Reviewed-by:
Dave Cheney <dave@cheney.net>
-
David Crawshaw authored
Change-Id: I3d64549b85b71bb63bcc815ce2276af6ca2eb215 Reviewed-on: https://go-review.googlesource.com/29354Reviewed-by:
-
Matthew Dempsky authored
Similar idea to golang.org/cl/28970. Change-Id: I9d2feb1a669d71ffda1d612cf39ee0d3c08d22d2 Reviewed-on: https://go-review.googlesource.com/29357 Run-TryBot: Matthew Dempsky <mdempsky@google.com> Reviewed-by:
David Crawshaw <crawshaw@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Robert Griesemer authored
Permits parsing of alias declarations with -newparser const/type/var/func T => p.T but the compiler will reject it with an error. For now this also accepts type T = p.T so we can experiment with a type-alias only scenario. - renamed _Arrow token to _Larrow (<-) - introduced _Rarrow token (=>) - introduced AliasDecl node - extended scanner to accept _Rarrow - extended parser and printer to handle alias declarations Change-Id: I0170d10a87df8255db9186d466b6fd405228c38e Reviewed-on: https://go-review.googlesource.com/29355 Run-TryBot: Robert Griesemer <gri@golang.org> Reviewed-by:
Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
David Crawshaw authored
Add some notes to main.go on what happens where. Change-Id: I4fb0b6c280e5f990ddc5d749267372b86870af6d Reviewed-on: https://go-review.googlesource.com/28970 TryBot-Result: Gobot Gobot <gobot@golang.org> Run-TryBot: David Crawshaw <crawshaw@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Keith Randall authored
ppc64 has an extraneous variable live in some situations. We need a better tighten pass to get rid of this extra variable. I'm working on it, but fix the test in the meantime. Fixes build for ppc64. Change-Id: I1efb9ccb234a64f2a1c228abd2b3195f67fbeb41 Reviewed-on: https://go-review.googlesource.com/29353Reviewed-by:
David Chase <drchase@google.com>
-
Matthew Dempsky authored
Updates #16357. Change-Id: I37f04d83134b5e1e7f6ba44eb9a566758ef594d3 Reviewed-on: https://go-review.googlesource.com/29350 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Keith Randall authored
Teach SSA about the cmd/internal/obj/$ARCH register numbering. It can then return that numbering when requested. Each architecture now does not need to know anything about the internal SSA numbering of registers. Change-Id: I34472a2736227c15482e60994eebcdd2723fa52d Reviewed-on: https://go-review.googlesource.com/29249Reviewed-by:
-
David Crawshaw authored
Change-Id: Ib20263405a08674b5e160295fc965da4c8b54b34 Reviewed-on: https://go-review.googlesource.com/29248Reviewed-by:
-
David Crawshaw authored
This CL gives Linkmode a type, switches it to the standard flag handling mechanism, and deduplicates some logic. There is a semantic change in this CL. Previously if a link was invoked explicitly with -linkmode=internal, any condition that forced external linking would silently override this and use external linking. Instead it now fails with a reason why. I believe this is an improvement, but will change it back if there's disagreement. Fixes #12848 Change-Id: Ic80e341fff65ecfdd2b6fdd6079674cc7210fc5f Reviewed-on: https://go-review.googlesource.com/28971 Run-TryBot: David Crawshaw <crawshaw@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
David Crawshaw authored
Change-Id: Ie9fea9814c850b084562ab2349b54d9ad9fa1f4a Reviewed-on: https://go-review.googlesource.com/27825 Run-TryBot: David Crawshaw <crawshaw@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
David Crawshaw authored
Change-Id: I0c8a04457db28c55c35c9a186b63c40f40730e39 Reviewed-on: https://go-review.googlesource.com/27824Reviewed-by:
-
David Crawshaw authored
Includes a linux implementation. Change-Id: Iacc2ed7da760ae9deebc928adf2b334b043b07ec Reviewed-on: https://go-review.googlesource.com/27823 Run-TryBot: David Crawshaw <crawshaw@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
David Chase authored
Bias {Eq,Neq}{8,16} to prefer the extension likely to match their operand's load (if loaded), and elide sign and zero extending MOV{B,W}, MOV{B,W}Z when their operands are already appropriately extended. Change-Id: Ic01b9cab55e170f68fc2369688b50ce78a818608 Reviewed-on: https://go-review.googlesource.com/29236 Run-TryBot: David Chase <drchase@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:Cherry Zhang <cherryyz@google.com>
-
Cherry Zhang authored
A tentative fix of #16380. It adds "line" everywhere... This also reduces binary size slightly (cmd/go on ARM as an example): before after total binary size 8068097 8018945 (-0.6%) .gopclntab 1195341 1179929 (-1.3%) .debug_line 689692 652017 (-5.5%) Change-Id: Ibda657c6999783c5bac180cbbba487006dbf0ed7 Reviewed-on: https://go-review.googlesource.com/25082Reviewed-by:
-
Cherry Zhang authored
Old backends did not implement them, but SSA do. Change-Id: I543b2281dcf4bab0da37c9b1f26a5ef55a0ea11b Reviewed-on: https://go-review.googlesource.com/29278 Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
David Crawshaw authored
For -buildmode=plugin, this lets the linker drop the main.main symbol out of the binary while including most of the runtime. (In the future it should be possible to drop the entire runtime package from plugins.) Change-Id: I3e7a024ddf5cc945e3d8b84bf37a0b7cb2a00eb6 Reviewed-on: https://go-review.googlesource.com/27821 Run-TryBot: David Crawshaw <crawshaw@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
David Crawshaw authored
This CL contains several linker changes to support creating plugins. It collects the exported plugin symbols provided by the compiler and includes them in the moduledata. It treats a binary as being dynamically linked if it imports the plugin package. This lets the dynamic linker de-duplicate symbols. Change-Id: I099b6f38dda26306eba5c41dbe7862f5a5918d95 Reviewed-on: https://go-review.googlesource.com/27820 Run-TryBot: David Crawshaw <crawshaw@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Suyash authored
This adds examples showing the different ways of using sort.Search. Change-Id: Iaa08b4501691f37908317fdcf2e618fbe9f99ade Reviewed-on: https://go-review.googlesource.com/29131Reviewed-by:
Andrew Gerrand <adg@golang.org> Run-TryBot: Andrew Gerrand <adg@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Matthew Dempsky authored
Gins, and in turn Naddr, is only used with ONAME and OLITERAL Nodes, so we can drastically simplify Naddr. Passes toolstash/buildall. Change-Id: I2deb7eb771fd55e7c7f00040a9aee54588fcac11 Reviewed-on: https://go-review.googlesource.com/29247 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Emmanuel Odeke authored
Updates #16360. Adds examples for: + CombinedOutput + StdinPipe + StderrPipe Change-Id: I19293e64b34ed9268da00e0519173a73bfbc2c10 Reviewed-on: https://go-review.googlesource.com/29150 Run-TryBot: Andrew Gerrand <adg@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Matthew Dempsky authored
Since the legacy backends were removed, these fields are write-only. Change-Id: I4816c39267b7c10a4da2a6d22cd367dc475e564d Reviewed-on: https://go-review.googlesource.com/29246 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Michael Hudson-Doyle <michael.hudson@canonical.com> Reviewed-by:
-
Dave Cheney authored
Follow up to CL 29134. Generated with gofmt -r 'Nod -> nod', plus three manual adjustments to the comments in syntax/parser.go Change-Id: I02920f7ab10c70b6e850457b42d5fe35f1f3821a Reviewed-on: https://go-review.googlesource.com/29136Reviewed-by:
-
Cherry Zhang authored
According to golang.org/s/go12symtab, for N files, it should put N+1 there. Fixes #17132. Change-Id: I0c84136855c6436be72b9d3c407bf10d4c81a099 Reviewed-on: https://go-review.googlesource.com/29275 Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Matthew Dempsky authored
Change-Id: I5c2fd0ff1b49f3826f2b9869b0b11329804b0e2a Reviewed-on: https://go-review.googlesource.com/29244 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Matthew Dempsky authored
Only added lines are moving amd64 and x86's ginsnop functions from gsubr.go to ggen.go to match other architectures, so all of the gsubr.go files can go away. Change-Id: Ib2292460c155ae6d9dcf5c9801f178031d8eea7a Reviewed-on: https://go-review.googlesource.com/29240 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Matthew Dempsky authored
Change-Id: I0131b0d7421ff1397f16a08eff758250abbdf8e2 Reviewed-on: https://go-review.googlesource.com/29239Reviewed-by:
-
Vitor De Mario authored
Effective Go has references to a function call f(c, req) made by ServeHTTP mixed with f(w, req). c is dropped in favor of w to maintain consistency Fixes #17128 Change-Id: I6746fd115ed5a58971fd24e54024d29d18ead1fa Reviewed-on: https://go-review.googlesource.com/29311Reviewed-by:
Rob Pike <r@golang.org>
-
- 15 Sep, 2016 7 commits
-
-
Alberto Bertogli authored
ReadMsgUnix and WriteMsgUnix both will read/write 1 byte from/to the socket if they were given no buffer to read/write, to avoid a common pitfall in out of band operations (they will usually block indefinitely if there's no actual data to read). This patch adds a note about this behaviour in their documentation, so users can be aware of it. Change-Id: I751f0e12bb4d80311e94ea8de023595c5d40ec3e Reviewed-on: https://go-review.googlesource.com/29180 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
David Chase authored
Binary search remains our friend. Suppose you add an ought-to-be-benign pattern to PPC64.rules, and make.bash starts crashing. You can guard the pattern(s) with config.DebugTest: (Eq8 x y) && config.DebugTest && isSigned(x.Type) && isSigned(y.Type) -> (Equal (CMPW (SignExt8to32 x) (SignExt8to32 y))) and then gossahash -s ./make.bash ... (go drink beer while silicon minions toil) ... Trying ./make.bash args=[], env=[GOSSAHASH=100110010111110] ./make.bash failed (1 distinct triggers): exit status 1 Trigger string is 'GOSSAHASH triggered (*importReader).readByte', repeated 1 times Review GSHS_LAST_FAIL.0.log for failing run Finished with GOSSAHASH=100110010111110 Change-Id: I4eff46ebaf496baa2acedd32e217005cb3ac1c62 Reviewed-on: https://go-review.googlesource.com/29273 Run-TryBot: David Chase <drchase@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: -
Keith Randall authored
Everything is SSA now. Update #16357 Change-Id: I436dbe367b863ee81a3695a7d653ba4bfc5b0f6c Reviewed-on: https://go-review.googlesource.com/29232Reviewed-by:
-
Keith Randall authored
Delete legacy backend tests, make SSA tests unconditional. Next CL will remove _ssa from the file names. Update #16357 Change-Id: I2a7f5dcbc69455f63b5e6e6b2725df26ab86c8dd Reviewed-on: https://go-review.googlesource.com/29231 Run-TryBot: Keith Randall <khr@golang.org> Reviewed-by:
-
Sam Whited authored
Fixes #17040 Change-Id: I3682cc0367b919084c280d7dc64746495c1d4aaa Reviewed-on: https://go-review.googlesource.com/28872Reviewed-by:
-
Mohit Agarwal authored
Also remove the hard-coded path for getting glibc information. As an example, the following is the diff for `go bug` on Ubuntu before and after the change: >>> --- /tmp/01 2016-09-13 15:08:53.202758043 +0530 +++ /tmp/02 2016-09-13 21:38:17.485039867 +0530 @@ -1,7 +1,7 @@ Please check whether the issue also reproduces on the latest release, go1.7.1. ``` -go version devel +bdb3b790 Wed Sep 7 03:23:44 2016 +0000 linux/amd64 +go version devel +cb13150 Wed Sep 7 09:46:58 2016 +0530 linux/amd64 GOARCH="amd64" GOBIN="" GOEXE="" @@ -18,5 +18,23 @@ CXX="g++" CGO_ENABLED="1" uname -sr: Linux 4.4.0-36-generic +Distributor ID: Ubuntu +Description: Ubuntu 16.04.1 LTS +Release: 16.04 +Codename: xenial +/lib/x86_64-linux-gnu/libc.so.6: GNU C Library (Ubuntu GLIBC 2.23-0ubuntu3) stable release version 2.23, by Roland McGrath et al. gdb --version: GNU gdb (Ubuntu 7.11.1-0ubuntu1~16.04) 7.11.1 ``` <<< Change-Id: I7e3730a797af0f94d6e43fe4743ab48bc0f11f1b Reviewed-on: https://go-review.googlesource.com/28581 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
David Chase authored
GOSSAFUNC=foo had previously only done printing for the single function foo, and didn't quite clean up after itself properly. Changes ensures that Config.HTML != nil iff GOSSAFUNC==name-of-current-function. Change-Id: I255e2902dfc64f715d93225f0d29d9525c06f764 Reviewed-on: https://go-review.googlesource.com/29250 Run-TryBot: David Chase <drchase@google.com> Reviewed-by:
-
