Commits · fdb69cb0a32c6eb0a2ff8f4fdce170b982faf26e · go / golang

29 Jul, 2013 19 commits

Russ Cox authored Jul 29, 2013

As promised.

TBR=dvyukov
CC=golang-dev
https://golang.org/cl/12063043

fdb69cb0

go/parser: selectors may be method expressions · 340918a8
Robert Griesemer authored Jul 29, 2013
```
R=adonovan
CC=golang-dev
https://golang.org/cl/12062043
```
340918a8

build: break builds · 46437f00

Russ Cox authored Jul 29, 2013

I want to see the timing information in build logs,
and we can't see the logs for "ok" builds.
So make the build fail everywhere.

Will roll back immediately.

TBR=dvyukov
CC=golang-dev
https://golang.org/cl/12058046

46437f00

runtime: adjust timediv to avoid _vasop; mark _subv okay · c7d5c438
Russ Cox authored Jul 29, 2013
```
R=dvyukov
CC=golang-dev
https://golang.org/cl/12028046
```
c7d5c438
runtime: fix timediv calls on NetBSD, OpenBSD · 98cc58e2
Russ Cox authored Jul 29, 2013
```
Document endian-ness assumption.

R=dvyukov
CC=golang-dev
https://golang.org/cl/12056044
```
98cc58e2

runtime: fix arm build · 14e35404

Dmitriy Vyukov authored Jul 29, 2013

The current failure is:
fatal error: runtime: stack split during syscall
goroutine 2 [stack split]:
_si2v(0xb6ebaebc, 0x3b9aca00)
        /usr/local/go/src/pkg/runtime/vlrt_arm.c:628 fp=0xb6ebae9c
runtime.timediv(0xf8475800, 0xd, 0x3b9aca00, 0xb6ebaef4)
        /usr/local/go/src/pkg/runtime/runtime.c:424 +0x1c fp=0xb6ebaed4

Just adding textflag 7 causes the following error:
notetsleep: nosplit stack overflow
        128	assumed on entry to notetsleep
        96	after notetsleep uses 32
        60	after runtime.futexsleep uses 36
        4	after runtime.timediv uses 56
        -4	after _si2v uses 8

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/12001045

14e35404

math/big: better documentation for Rat.Float64 · 5bd61e06
Robert Griesemer authored Jul 29, 2013
```
R=adonovan, r
CC=golang-dev
https://golang.org/cl/11961043
```
5bd61e06

runtime: fix arm build · 64db2ec9

Dmitriy Vyukov authored Jul 29, 2013

The current failure is:
fatal error: runtime: stack split during syscall
goroutine 2 [stack split]:
_addv(0xb6fa0f28, 0xd0a5112e, 0x13156d6e, 0xf8475800, 0xd)
        /usr/local/go/src/pkg/runtime/vlrt_arm.c:66 fp=0xb6fa0ef8
notetsleep(0xb6fa0f9c, 0xf8475800, 0xd, 0x0, 0x0, ...)
        /usr/local/go/src/pkg/runtime/lock_futex.c:156 +0xd0 fp=0xb6fa0f18
runtime.notetsleepg(0xb6fa0f9c, 0xf8475800, 0xd)
        /usr/local/go/src/pkg/runtime/lock_futex.c:197 +0x74 fp=0xb6fa0f3c

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/12052043

64db2ec9

runtime: fix linux/arm build · d91219e4

Dmitriy Vyukov authored Jul 29, 2013

notetsleep: nosplit stack overflow
        128	assumed on entry to notetsleep
        80	after notetsleep uses 48
        44	after runtime.futexsleep uses 36
        -12	after runtime.timediv uses 56

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/12049043

d91219e4

runtime: fix openbsd build · ddc01d5b

Dmitriy Vyukov authored Jul 29, 2013

notetsleep: nosplit stack overflow
        120	assumed on entry to notetsleep
        96	after notetsleep uses 24
        88	on entry to runtime.semasleep
        32	after runtime.semasleep uses 56
        24	on entry to runtime.nanotime
        -8	after runtime.nanotime uses 32

Nanotime seems to be using only 24 bytes of stack space.
Unless I am missing something.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/12041044

ddc01d5b

runtime: fix freebsd build · d8368816

Dmitriy Vyukov authored Jul 29, 2013

notetsleep: nosplit stack overflow
        120	assumed on entry to notetsleep
        80	after notetsleep uses 40
        72	on entry to runtime.futexsleep
        16	after runtime.futexsleep uses 56
        8	on entry to runtime.printf
        -16	after runtime.printf uses 24

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/12047043

d8368816

runtime: do not split stacks in syscall status · e84d9e1f

Dmitriy Vyukov authored Jul 29, 2013

Split stack checks (morestack) corrupt g->sched,
but g->sched must be preserved consistent for GC/traceback.
The change implements runtime.notetsleepg function,
which does entersyscall/exitsyscall and is carefully arranged
to not call any split functions in between.

R=rsc
CC=golang-dev
https://golang.org/cl/11575044

e84d9e1f

net: fix memory leaks on windows · b8734748

Dmitriy Vyukov authored Jul 29, 2013

Close netpoll descriptor along with socket.
Ensure that error paths close the descriptor as well.

R=golang-dev, mikioh.mikioh, alex.brainman
CC=golang-dev
https://golang.org/cl/11987043

b8734748

runtime: allow SetFinalizer with a func(interface{}) · 6350e458
Pieter Droogendijk authored Jul 29, 2013
```
Fixes #5368.

R=golang-dev, dvyukov
CC=golang-dev, rsc
https://golang.org/cl/11858043
```
6350e458
net: remove redundant comment on isWildcard · 3398322d
Mikio Hara authored Jul 29, 2013
```
R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/11985043
```
3398322d

net: document sockaddr interface · 442e614c

Mikio Hara authored Jul 29, 2013

This is in preparation for runtime-integrated network pollster for BSD
variants.

Update #5199

R=golang-dev, fvbommel, dave
CC=golang-dev
https://golang.org/cl/11984043

442e614c

doc/articles: state that slices/arrays start at the 0th element · f6dd45bf
Andrew Gerrand authored Jul 29, 2013
```
Fixes #5881.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/11892043
```
f6dd45bf

misc/dashboard/builder: increase cmdTimeout to 10 minutes · 6db195ca

Alex Brainman authored Jul 29, 2013

It takes more then 5 minutes to clone go repo
on windows-386 builder now.

R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/12007043

6db195ca

misc/dashboard: don't update tip tag for release branch commits. · e87af8c4

David Symonds authored Jul 29, 2013

This will mean that sub-repositories won't get built against the
release branch. They are often not compatible because the subrepos
often run ahead of the current release (e.g. go.tools is using
new additions to go/ast, and go.net is using new things in syscall)
so there's little point in checking them against cherrypick commits
when they'll be tested against those commits on tip anyway.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/12001043

e87af8c4

28 Jul, 2013 6 commits

all: move examples into package *_test. · b7c3d06a
Rémy Oudompheng authored Jul 28, 2013
```
Fixes #5677.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/11992043
```
b7c3d06a
effective_go.html: make snippets look formatted. · d26d5e64
Rémy Oudompheng authored Jul 28, 2013
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/11991043
```
d26d5e64

compress/flate: reduce tiny allocs done by encoder. · 05026c4e

Rémy Oudompheng authored Jul 28, 2013

benchmark old allocs new allocs delta
BenchmarkEncodeDigitsSpeed1e4 942 91 -90.34%
BenchmarkEncodeDigitsSpeed1e5 1919 178 -90.72%
BenchmarkEncodeDigitsSpeed1e6 18539 1517 -91.82%
BenchmarkEncodeDigitsDefault1e4 734 100 -86.38%
BenchmarkEncodeDigitsDefault1e5 1958 193 -90.14%
BenchmarkEncodeDigitsDefault1e6 17338 1426 -91.78%
BenchmarkEncodeDigitsCompress1e4 734 100 -86.38%
BenchmarkEncodeDigitsCompress1e5 1958 193 -90.14%
BenchmarkEncodeDigitsCompress1e6 17338 1426 -91.78%
BenchmarkEncodeTwainSpeed1e4 1865 109 -94.16%
BenchmarkEncodeTwainSpeed1e5 3943 211 -94.65%
BenchmarkEncodeTwainSpeed1e6 31279 1595 -94.90%
BenchmarkEncodeTwainDefault1e4 1811 103 -94.31%
BenchmarkEncodeTwainDefault1e5 3708 199 -94.63%
BenchmarkEncodeTwainDefault1e6 26738 1330 -95.03%
BenchmarkEncodeTwainCompress1e4 1811 103 -94.31%
BenchmarkEncodeTwainCompress1e5 3693 190 -94.86%
BenchmarkEncodeTwainCompress1e6 26902 1333 -95.04%

benchmark old bytes new bytes delta
BenchmarkEncodeDigitsSpeed1e4 1469438 1453920 -1.06%
BenchmarkEncodeDigitsSpeed1e5 1490898 1458961 -2.14%
BenchmarkEncodeDigitsSpeed1e6 1858819 1542407 -17.02%
BenchmarkEncodeDigitsDefault1e4 1465903 1454160 -0.80%
BenchmarkEncodeDigitsDefault1e5 1491841 1459361 -2.18%
BenchmarkEncodeDigitsDefault1e6 1825424 1531545 -16.10%
BenchmarkEncodeDigitsCompress1e4 1465903 1454160 -0.80%
BenchmarkEncodeDigitsCompress1e5 1491681 1459361 -2.17%
BenchmarkEncodeDigitsCompress1e6 1825424 1531545 -16.10%
BenchmarkEncodeTwainSpeed1e4 1485308 1454400 -2.08%
BenchmarkEncodeTwainSpeed1e5 1526065 1459878 -4.34%
BenchmarkEncodeTwainSpeed1e6 2066627 1536296 -25.66%
BenchmarkEncodeTwainDefault1e4 1484380 1454240 -2.03%
BenchmarkEncodeTwainDefault1e5 1521793 1459558 -4.09%
BenchmarkEncodeTwainDefault1e6 1977504 1523388 -22.96%
BenchmarkEncodeTwainCompress1e4 1484380 1454240 -2.03%
BenchmarkEncodeTwainCompress1e5 1521457 1459318 -4.08%
BenchmarkEncodeTwainCompress1e6 1980000 1523609 -23.05%

benchmark old ns/op new ns/op delta
BenchmarkEncodeDigitsSpeed1e4 1472128 1384343 -5.96%
BenchmarkEncodeDigitsSpeed1e5 8283663 8112304 -2.07%
BenchmarkEncodeDigitsSpeed1e6 77459311 76364216 -1.41%
BenchmarkEncodeDigitsDefault1e4 1813090 1746552 -3.67%
BenchmarkEncodeDigitsDefault1e5 26221292 26052516 -0.64%
BenchmarkEncodeDigitsDefault1e6 286512472 286099039 -0.14%
BenchmarkEncodeDigitsCompress1e4 1809373 1747230 -3.43%
BenchmarkEncodeDigitsCompress1e5 26231580 26038456 -0.74%
BenchmarkEncodeDigitsCompress1e6 286140002 286025372 -0.04%
BenchmarkEncodeTwainSpeed1e4 1594094 1438600 -9.75%
BenchmarkEncodeTwainSpeed1e5 7669724 7316288 -4.61%
BenchmarkEncodeTwainSpeed1e6 68731353 65938994 -4.06%
BenchmarkEncodeTwainDefault1e4 2063497 1866488 -9.55%
BenchmarkEncodeTwainDefault1e5 22602689 22221377 -1.69%
BenchmarkEncodeTwainDefault1e6 233376842 232114297 -0.54%
BenchmarkEncodeTwainCompress1e4 2062441 1949676 -5.47%
BenchmarkEncodeTwainCompress1e5 28264344 27930627 -1.18%
BenchmarkEncodeTwainCompress1e6 304369641 303704330 -0.22%

benchmark old MB/s new MB/s speedup
BenchmarkEncodeDigitsSpeed1e4 6.79 7.22 1.06x
BenchmarkEncodeDigitsSpeed1e5 12.07 12.33 1.02x
BenchmarkEncodeDigitsSpeed1e6 12.91 13.10 1.01x
BenchmarkEncodeDigitsDefault1e4 5.52 5.73 1.04x
BenchmarkEncodeDigitsDefault1e5 3.81 3.84 1.01x
BenchmarkEncodeDigitsDefault1e6 3.49 3.50 1.00x
BenchmarkEncodeDigitsCompress1e4 5.53 5.72 1.03x
BenchmarkEncodeDigitsCompress1e5 3.81 3.84 1.01x
BenchmarkEncodeDigitsCompress1e6 3.49 3.50 1.00x
BenchmarkEncodeTwainSpeed1e4 6.27 6.95 1.11x
BenchmarkEncodeTwainSpeed1e5 13.04 13.67 1.05x
BenchmarkEncodeTwainSpeed1e6 14.55 15.17 1.04x
BenchmarkEncodeTwainDefault1e4 4.85 5.36 1.11x
BenchmarkEncodeTwainDefault1e5 4.42 4.50 1.02x
BenchmarkEncodeTwainDefault1e6 4.28 4.31 1.01x
BenchmarkEncodeTwainCompress1e4 4.85 5.13 1.06x
BenchmarkEncodeTwainCompress1e5 3.54 3.58 1.01x
BenchmarkEncodeTwainCompress1e6 3.29 3.29 1.00x

R=imkrasin, golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/10006043

05026c4e

net: make UnixAddr implement sockaddr interface · a64bea5c

Mikio Hara authored Jul 28, 2013

This is in preparation for runtime-integrated network pollster for BSD
variants.

Update #5199

R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/11932044

a64bea5c

net: extend sockaddr interface to the all address families · e257cd8a

Mikio Hara authored Jul 28, 2013

This CL extends existing sockaddr interface to accommodate not only
internet protocol family endpoint addressess but unix network family
endpoint addresses.

This is in preparation for runtime-integrated network pollster for BSD
variants.

Update #5199

R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/11979043

e257cd8a

net: simplify socket option helpers · bf61a97f

Mikio Hara authored Jul 28, 2013

Also consolidates syscall.IPPROTO_TCP level option helper files.

R=golang-dev, dave, alex.brainman
CC=golang-dev
https://golang.org/cl/8637049

bf61a97f

27 Jul, 2013 4 commits

misc/dashboard: fix typo in comment · 7da7d71c
Dmitriy Vyukov authored Jul 27, 2013
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/11936045
```
7da7d71c

cmd/dist: fix crash on windows · d5c7ef62

Dmitriy Vyukov authored Jul 27, 2013

currently 'dist install' always crashes on windows

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/11919043

d5c7ef62

runtime: fix potential deadlock in netpoll on windows · 91d35ad1

Dmitriy Vyukov authored Jul 27, 2013

If netpoll has been told to block, it must not return with nil,
otherwise scheduler assumes that netpoll is disabled.

R=golang-dev, alex.brainman
CC=golang-dev
https://golang.org/cl/11920044

91d35ad1

net: temporary skip hanging test on windows · 29f17fb0
Dmitriy Vyukov authored Jul 27, 2013
```
Update #5971.

R=alex.brainman
CC=golang-dev
https://golang.org/cl/11938046
```
29f17fb0

26 Jul, 2013 8 commits

misc/notepadplus: use new User Defined Language system (UDL2) · c44e4835

ChaiShushan authored Jul 26, 2013

Add missing single quotation and backslash marks.

Change dot and underscore character keyword type.
"_" is a predeclared identifier, not a operator.
"." is a selector, x.f should be one identifier highlight.
So the fix is to change it.

Fixes #5775.
Fixes #5788.
Fixes #5798.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/10480044

c44e4835

runtime: handle runtime.Goexit during init · 14062efb

Russ Cox authored Jul 26, 2013

Fixes #5963.

R=golang-dev, dsymonds, dvyukov
CC=golang-dev
https://golang.org/cl/11879045

14062efb

runtime: refactor mallocgc · f8a850b2

Dmitriy Vyukov authored Jul 26, 2013

Make it accept type, combine flags.
Several reasons for the change:
1. mallocgc and settype must be atomic wrt GC
2. settype is called from only one place now
3. it will help performance (eventually settype
functionality must be combined with markallocated)
4. flags are easier to read now (no mallocgc(sz, 0, 1, 0) anymore)

R=golang-dev, iant, nightlyone, rsc, dave, khr, bradfitz, r
CC=golang-dev
https://golang.org/cl/10136043

f8a850b2

crypto/des: faster block expansion. · a0f74093

Rémy Oudompheng authored Jul 26, 2013

On amd64:

benchmark           old ns/op    new ns/op    delta
BenchmarkEncrypt         6170         3593  -41.77%
BenchmarkDecrypt         6209         3564  -42.60%

benchmark            old MB/s     new MB/s  speedup
BenchmarkEncrypt         1.30         2.23    1.72x
BenchmarkDecrypt         1.29         2.24    1.74x

Update #4299.

R=golang-dev, agl, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/11874043

a0f74093

cmd/pack: support removing of leading file prefix on windows · a79e125b
Alex Brainman authored Jul 26, 2013
```
Fixes #5550

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/11904043
```
a79e125b

gc: fix line directive processing on windows · 32a3ce67

Alex Brainman authored Jul 26, 2013

This change should have been part of 5671737303a0.

Fixes #5904

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/11894043

32a3ce67

undo CL 11788043 / 62d06cccc261 · ad5cd931

Keith Randall authored Jul 26, 2013

Reason for breakage fixed with CL 11888043.

««« original CL description
undo CL 11683043 / bb75d03e6ccb

Broke arm build.
R=dave

««« original CL description
cc: generate argument pointer maps for C functions.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/11683043
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/11788043
»»»

TBR=dave
CC=golang-dev
https://golang.org/cl/11789043

ad5cd931

5c: fix pc recalculation in the presence of AFUNCDATA · de6da4a8

Keith Randall authored Jul 26, 2013

This makes CL 11683043 not break arm anymore.

R=golang-dev, bradfitz, dave
CC=golang-dev
https://golang.org/cl/11888043

de6da4a8

25 Jul, 2013 3 commits
- go/parser: restrict ParseDir to files with suffix ".go" · 4a695d2c
  Robert Griesemer authored Jul 25, 2013
```
Fixes #5956.

R=rsc, r
CC=golang-dev
https://golang.org/cl/11813043
```
  4a695d2c
- spec: update prose in Constants section · f3310124
  Robert Griesemer authored Jul 25, 2013
```
Fixes #5952.

R=r, rsc
CC=golang-dev
https://golang.org/cl/11812043
```
  f3310124
- net: give more detail when test panics · cdd35983
  Mikio Hara authored Jul 25, 2013
```
R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/11811043
```
  cdd35983