Commits · feb509c794584d634ad1a51d88c0f6d109bf42d8 · go / golang

13 Dec, 2012 7 commits

net: make TestDialTimeoutFDLeak a bit robust · feb509c7

Mikio Hara authored Dec 13, 2012

TestDialTimeoutFDLeak will fail when system state somaxconn is
greater than expected fixed value.

Fixes #4384 (again).

R=fullung, dave, rsc
CC=golang-dev
https://golang.org/cl/6873069

feb509c7

runtime/race: fix test for GOMAXPROCS>1 · b978995f
Albert Strasheim authored Dec 13, 2012
```
Fixes #4530.

R=dvyukov, dave
CC=golang-dev
https://golang.org/cl/6933052
```
b978995f

database/sql: Alter *DB.begin to return driver.ErrBadConn when… · 309eae19

James David Chalfant authored Dec 13, 2012

    database/sql: Alter *DB.begin to return driver.ErrBadConn when driver.Conn.Begin returns driver.ErrBadConn
Fixes #4433

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6845094

309eae19

A+C: James David Chalfant (individual CLA) · 7571d23c
Brad Fitzpatrick authored Dec 13, 2012
```
Generated by addca.

R=gobot
CC=golang-dev
https://golang.org/cl/6939043
```
7571d23c

log/syslog: fix flakey test on slow hosts · ae12e963

Dave Cheney authored Dec 13, 2012

Fixes #4467.

The syslog tests can fail if the timeout fires before the data arrives at the mock server. Moving the timeout onto the goroutine that is calling ReadFrom() and always processing the data returned before handling the error should improve the reliability of the test.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6920047

ae12e963

go/doc: hide "Program exited." message from front page playground output · 641d1529
Andrew Gerrand authored Dec 13, 2012
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6934049
```
641d1529

doc/play: sync playground.js with go-playground repo · c8ce844d

Andrew Gerrand authored Dec 13, 2012

Also add style for "Program exited." message.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6934047

c8ce844d

12 Dec, 2012 13 commits

spec: more explicit comments for constant expression examples · 462860bd
Robert Griesemer authored Dec 12, 2012
```
Fixes #3814.

R=rsc, iant
CC=golang-dev
https://golang.org/cl/6920057
```
462860bd

spec: calling delete on a nil map is a no-op · a9a49fe9

Robert Griesemer authored Dec 12, 2012

This is language change. It is a backward-compatible
change but for code that relies on a run-time panic
when calling delete on a nil map (unlikely).

Fixes #4253.

R=rsc, r, iant, ken, bradfitz, rogpeppe
CC=golang-dev
https://golang.org/cl/6909060

a9a49fe9

net/http: return nicer error when Client request Host is blank · f85b94aa
Brad Fitzpatrick authored Dec 12, 2012
```
Update #4271

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6931052
```
f85b94aa
net/http: remove a stale cookie TODO comment, add a test · be5ce4e0
Brad Fitzpatrick authored Dec 12, 2012
```
Fixes #4528

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6922054
```
be5ce4e0
misc/dashboard: don't email about netbsd failures · a257c753
Brad Fitzpatrick authored Dec 12, 2012
```
Too flaky.

R=iant, rsc
CC=golang-dev
https://golang.org/cl/6925056
```
a257c753
net/http: follow certain redirects after POST requests · 08ce7f1d
Brad Fitzpatrick authored Dec 12, 2012
```
Fixes #4145

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6923055
```
08ce7f1d
spec: index and array/slice size constants must fit into an int · 39067062
Robert Griesemer authored Dec 12, 2012
```
R=r, rsc, iant, ken
CC=golang-dev
https://golang.org/cl/6903048
```
39067062

doc/gopher: add high-resolution pencil sketches · 17b3766d

Rob Pike authored Dec 12, 2012

These are higher-resolution scans of the little
drawings used as clip art on golang.org

R=bradfitz, rsc
CC=golang-dev
https://golang.org/cl/6929058

17b3766d

cmd/gc: Give better line numbers for errors in composite literals. · bf59aafd

Daniel Morsing authored Dec 12, 2012

Credit to Russ for suggesting this fix.

Fixes #3925.

R=golang-dev, franciscossouza, rsc
CC=golang-dev
https://golang.org/cl/6920051

bf59aafd

go/build: give better explanation for "cannot find package" · 11d96dd7

Dave Cheney authored Dec 12, 2012

Fixes #4079.

Some example output:

% go install foo/bar
can't load package: package foo/bar: cannot find package "foo/bar" in any of:
        /home/dfc/go/src/pkg/foo/bar (from $GOROOT)
        /home/dfc/src/foo/bar (from $GOPATH)
        /home/dfc/src2/src/foo/bar

% GOPATH= go install foo/bar
can't load package: package foo/bar: cannot find package "foo/bar" in any of:
	/home/dfc/go/src/pkg/foo/bar (from $GOROOT)
	($GOPATH not set)

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6899057

11d96dd7

cmd/5g: avoid temporary during OMINUS · 5bdf40dc

Dave Cheney authored Dec 12, 2012

Saves one MOVW and one register during the fast div/mod introduced in CL 6819123.

linux/arm (armv5)

benchmark               old ns/op    new ns/op    delta
BenchmarkInt64Mod1             12           12   +7.50%
BenchmarkUint16Mod2             7            7   +0.28%
BenchmarkUint16Mod4             7            7   -0.28%
BenchmarkUint64Mod1            15           11  -23.72%
BenchmarkInt8Neg                8            7  -17.66%
BenchmarkInt16Neg               8            7  -17.66%
BenchmarkInt32Neg               5            5   -9.04%
BenchmarkUint8Neg               7            6  -14.35%
BenchmarkUint16Neg              8            7  -17.66%
BenchmarkUint32Neg              5            5   -9.04%

R=rsc
CC=golang-dev
https://golang.org/cl/6842045

5bdf40dc

cmd/gc: don't import the same package multiple times. · 11999306

Rémy Oudompheng authored Dec 12, 2012

Implementation suggested by DMorsing.

R=golang-dev, dave, daniel.morsing, rsc
CC=golang-dev
https://golang.org/cl/6903059

11999306

cmd/6g, cmd/8g: simplify integer division code. · a617d062

Rémy Oudompheng authored Dec 12, 2012

Change suggested by iant. The compiler generates
special code for a/b when a is -0x80...0 and b = -1.
A single instruction can cover the case where b is -1,
so only one comparison is needed.

Fixes #3551.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6922049

a617d062

11 Dec, 2012 19 commits

net: TestDialTimeoutFDLeak failure · 4766a35e

Dave Cheney authored Dec 11, 2012

Fixes #4384.

Implments the suggestion by rsc in comment 15, http://code.google.com/p/go/issues/detail?id=4384#c15

An alternate suggestion would be to temporarily set GOMAXPROCS to 1 during this test.

R=fullung, rsc
CC=golang-dev
https://golang.org/cl/6923046

4766a35e

lib/codereview: suggest argument to hg mail / hg submit · c3d881b3
Russ Cox authored Dec 11, 2012
```
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/6924050
```
c3d881b3
doc/contribute: mention 'hg help codereview' · 111fcf15
Russ Cox authored Dec 11, 2012
```
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/6932053
```
111fcf15
encoding/csv: add Error method to Writer · 9a12a9c5
Ryan Slade authored Dec 11, 2012
```
Fixed issue 3931

R=bradfitz, rsc
CC=golang-dev
https://golang.org/cl/6923049
```
9a12a9c5
A+C: Ryan Slade (individual CLA) · c6944573
Russ Cox authored Dec 11, 2012
```
Generated by addca.

R=gobot
CC=golang-dev
https://golang.org/cl/6924049
```
c6944573

exp/types: filling in more blanks · 1a6f8dcb

Robert Griesemer authored Dec 11, 2012

- implemented built-in complex()
- implemented missing expression switch checks

R=rsc
CC=golang-dev
https://golang.org/cl/6920046

1a6f8dcb

cmd/gc: merge casep and casee labels · 0dd0e1ad

Miquel Sabaté Solà authored Dec 11, 2012

The code inside the casee and casep labels can perfectly be merged since
they essentially do the same. The character to be stored where cp points is
just the character contained by the c variable.

R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/6845112

0dd0e1ad

regexp: re-enable TestBadCompile · 3c6c8831

Russ Cox authored Dec 11, 2012

The code that was commented out was for the old regexp package.
In the new one the errors and the space of valid regexps are different.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6873063

3c6c8831

math/big: add SetUint64 and Uint64 functions to *Int · f4fc163d

Luit van Drongelen authored Dec 11, 2012

Implementation is mostly identical to passing a non-negative int64 to
SetInt64, and calling Int64 with a non-negative value in the *Int.
Fixes #4389.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6929048

f4fc163d

spec: Correct typo in method expressions example. · 1d46fc44

Robin Eklind authored Dec 11, 2012

Also, remove unnecessary whitespace.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6928045

1d46fc44

net/http, net/url: permit Request-URI "*" · a6701f26

Brad Fitzpatrick authored Dec 11, 2012

Also, implement a global OPTIONS * handler, like Apache.

Permit sending "*" requests to handlers, but not path-based
(ServeMux) handlers.  That means people can go out of their
way to support SSDP or SIP or whatever, but most users will be
unaffected.

See RFC 2616 Section 5.1.2 (Request-URI)
See RFC 2616 Section 9.2 (OPTIONS)

Fixes #3692

R=rsc
CC=golang-dev
https://golang.org/cl/6868095

a6701f26

syscall: let mkall.sh work on multiarch systems (like Precise) · fc393638
Brad Fitzpatrick authored Dec 11, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6912063
```
fc393638
regexp/syntax: export ErrUnexpectedParen · 1b46e4cd
Brian Ketelsen authored Dec 11, 2012
```
Fixes #3712

R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/6902069
```
1b46e4cd
A+C: Brian Ketelsen and Miquel Sabaté Solà (individual CLA × 2) · b979b192
Russ Cox authored Dec 11, 2012
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6923051
```
b979b192

fmt: fix %v of complex slice · 07cc0586

Russ Cox authored Dec 11, 2012

Fixes #4525.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6929049

07cc0586

encoding/base64: new example for NewEncoder with emphasis on Close · 15353d21
Shenghou Ma authored Dec 11, 2012
```
Fixes #4394.

R=iant, bradfitz, rsc, remigius.gieben
CC=golang-dev
https://golang.org/cl/6847125
```
15353d21

cmd/gc: remove bad check for BADWIDTH · 0d22573f

Daniel Morsing authored Dec 11, 2012

This check for BADWIDTH might happen while in defercheckwidth, making it raise errors for non-erroneous situations.

Fixes #4495.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6927043

0d22573f

net/url: fix handling of relative paths in ResolveReference. · 2f45f280
Rick Arnold authored Dec 11, 2012
```
Fixes #3560.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6886047
```
2f45f280

godoc: move example list into index section · dffdece8

Russ Cox authored Dec 11, 2012

Putting it before the Index (where it is now) is wrong:
we don't even know what's in the package yet.

Fixes #4484.

R=adg, dsymonds
CC=golang-dev
https://golang.org/cl/6868071

dffdece8

10 Dec, 2012 1 commit
- doc/go1.1.html: add warning about net.ResolveTCPAddr error checking · 014137c8
  Russ Cox authored Dec 10, 2012
```
Suggested by Paul Borman.

R=golang-dev, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/6930043
```
  014137c8