- 31 Dec, 2013 1 commit
-
-
Josh Bleecher Snyder authored
Fixes #7032. R=golang-codereviews, r CC=golang-codereviews https://golang.org/cl/43960045
-
- 30 Dec, 2013 6 commits
-
-
Mihai Borobocea authored
Looks like a typo. Fixes #7011. R=golang-codereviews, r, bradfitz CC=golang-codereviews https://golang.org/cl/45350043
-
Brad Fitzpatrick authored
Generated by addca. R=gobot CC=golang-codereviews https://golang.org/cl/46540044
-
Keith Randall authored
This change fixes a serious performance regression with reflect.Value growing to 4 words instead of 3. The json benchmark was ~50% slower, with this change it is ~5% slower (and the binary is 0.5% larger). Longer term, we probably need to rethink our copy generation. Using REP is really expensive time-wise. But inlining the copy grows the binary. R=golang-codereviews, r CC=golang-codereviews https://golang.org/cl/44990043
-
Keith Randall authored
on map keys and values which are now passed by reference. R=dvyukov, khr CC=golang-codereviews https://golang.org/cl/43490044
-
Richard Musiol authored
R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/46500043
-
Shawn Smith authored
R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/46510043
-
- 29 Dec, 2013 5 commits
-
-
Shawn Smith authored
R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/46320043
-
Shawn Smith authored
R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/39910044
-
Shawn Smith authored
R=golang-codereviews, dave CC=golang-codereviews https://golang.org/cl/39200045
-
Shawn Smith authored
R=golang-codereviews, dave CC=golang-codereviews https://golang.org/cl/41320044
-
Dave Cheney authored
Fixes #6952. runtime.asminit was incorrectly loading runtime.goarm as a word, not a uint8 which made it subject to alignment issues on arm5 platforms. Alignment aside, this also meant that the top 3 bytes in R11 would have been garbage and could not be assumed to be setting up the FPU reliably. R=iant, minux.ma CC=golang-codereviews https://golang.org/cl/46240043
-
- 28 Dec, 2013 3 commits
-
-
Ian Lance Taylor authored
On Solaris, if you do a in-progress connect, and then the server accepts and closes the socket, the client's later attempt to complete the connect will fail with EINVAL. Handle this case by assuming that the connect succeeded. This code is weird enough that it is implemented as Solaris-only so that it doesn't hide a real error on a different OS. Update #6828 R=golang-codereviews, bradfitz, dave CC=golang-codereviews https://golang.org/cl/46160043
-
Shawn Smith authored
R=golang-codereviews, dave CC=golang-codereviews https://golang.org/cl/46140043
-
Shawn Smith authored
R=golang-codereviews, dave CC=golang-codereviews https://golang.org/cl/44710044
-
- 27 Dec, 2013 6 commits
-
-
Martin Olsson authored
R=golang-codereviews, dave, iant CC=golang-codereviews https://golang.org/cl/45750044
-
Ian Lance Taylor authored
Generated by addca. R=gobot CC=golang-codereviews https://golang.org/cl/46040043
-
Ian Lance Taylor authored
This avoids problems with systems that take a long time to find out nothing is listening, while still testing for the self-connect misfeature since a self-connect should be fast. With this we may be able to remove the test for non-Linux systems. Tested (on GNU/Linux) by editing selfConnect in tcpsock_posix.go to always return false and verifying that TestSelfConnect then fails with and without this change. Idea from Uros Bizjak. R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/39200044
-
Shawn Smith authored
R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/42480043
-
Shawn Smith authored
R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/44200044
-
Shawn Smith authored
R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/38990045
-
- 26 Dec, 2013 5 commits
-
-
Brad Fitzpatrick authored
Capture log output (and test it while at it), and quiet unnecessary t.Logf. R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/45850043
-
Brad Fitzpatrick authored
Fixes #7006 R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/44940044
-
John Newlin authored
When a connection is hijacked, release the reference to the bufio.Writer that is used with the chunkWriter. The chunkWriter is not used after the connection is hijacked. Also add a test to check that double Hijack calls do something sensible. benchmark old ns/op new ns/op delta BenchmarkServerHijack 24137 20629 -14.53% benchmark old allocs new allocs delta BenchmarkServerHijack 21 19 -9.52% benchmark old bytes new bytes delta BenchmarkServerHijack 11774 9667 -17.90% R=bradfitz, dave, chris.cahoon CC=golang-codereviews https://golang.org/cl/39440044
-
Brad Fitzpatrick authored
R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/45830043
-
Marko Tiikkaja authored
The last connection in the pool was not being handed out correctly. R=golang-codereviews, gobot, bradfitz CC=golang-codereviews https://golang.org/cl/40410043
-
- 24 Dec, 2013 2 commits
-
-
Ian Lance Taylor authored
R=golang-codereviews TBR=dfc CC=golang-codereviews https://golang.org/cl/43120044
-
Ian Lance Taylor authored
This was done correctly for most targets but was missing from FreeBSD/ARM and Linux/ARM. R=golang-codereviews, dave CC=golang-codereviews https://golang.org/cl/45180043
-
- 23 Dec, 2013 1 commit
-
-
Yasuhiro Matsumoto authored
R=golang-codereviews, gobot, dsymonds CC=golang-codereviews https://golang.org/cl/44960043
-
- 22 Dec, 2013 2 commits
-
-
S.Çağlar Onur authored
sigprocmask use in a multithreaded environment is undefined so replace it with pthread_sigmask. Fixes #6811. R=jsing, iant CC=golang-codereviews, golang-dev https://golang.org/cl/30460043
-
Ian Lance Taylor authored
Generated by addca. R=gobot CC=golang-codereviews https://golang.org/cl/42800045
-
- 21 Dec, 2013 4 commits
-
-
Shawn Smith authored
bytes, strings: improve Title test coverage by adding cases with underscore and unicode line separator R=golang-codereviews, gobot, r CC=golang-codereviews https://golang.org/cl/42310045
-
Alex Brainman authored
R=golang-codereviews, r CC=golang-codereviews https://golang.org/cl/44160044
-
David du Colombier authored
R=golang-codereviews, rsc CC=golang-codereviews, jas https://golang.org/cl/44790043
-
Russ Cox authored
Reduces 6g big.go memory usage from 251 MB to 242 MB. Reduces 6g slow.go memory usage from 529 MB to 453 MB. Mostly a memory savings; 6g slow.go is only about 5% faster. The test programs are at https://rsc.googlecode.com/hg/testdata/big.go (36k lines, 276kB) https://rsc.googlecode.com/hg/testdata/slow.go (7k lines, 352kB) R=golang-codereviews, bradfitz, iant CC=golang-codereviews https://golang.org/cl/42280045
-
- 20 Dec, 2013 5 commits
-
-
Jakub Ryszard Czarnowicz authored
RFC 2616, section 7.2.1 - empty type SHOULD be treated as application/octet-stream. Fixes #6616. R=golang-codereviews, gobot, bradfitz, josharian CC=golang-codereviews https://golang.org/cl/31810043
-
Russ Cox authored
As much as 7x speedup on some programs, cuts all.bash time by 20%. Change splicebefore function from O(n) to O(1). The approach was suggested by Carl during the code's review but apparently did not make it into the tree. It makes a huge difference on huge programs. Make twobitwalktype1 slightly faster by using & instead of %. Really it needs to be cached; left a note to that effect. (Not a complete fix, hence the ½.) big.go (output of test/chan/select5.go) 47.53u 0.50s 48.14r before this CL 7.09u 0.47s 7.59r with splicebefore change (6.7x speedup) 6.15u 0.42s 6.59r with twobitwalktype1 change (1.15x speedup; total 7.7x) slow.go (variant of program in go.text, by mpvl) 77.75u 2.11s 80.03r before this CL 24.40u 1.97s 26.44r with splicebefore change (3.2x speedup) 18.12u 2.19s 20.38r with twobitwalktype1 change (1.35x speedup; total 4.3x) test/run 150.63u 49.57s 81.08r before this CL 88.01u 45.60s 46.65r after this CL (1.7x speedup) all.bash 369.70u 115.64s 256.21r before this CL 298.52u 110.35s 214.67r after this CL (1.24x speedup) The test programs are at https://rsc.googlecode.com/hg/testdata/big.go (36k lines, 276kB) https://rsc.googlecode.com/hg/testdata/slow.go (7k lines, 352kB) R=golang-codereviews, gobot, r CC=cshapiro, golang-codereviews https://golang.org/cl/43210045
-
Russ Cox authored
Eventually we will want to bypass DATA for everything, but the relocations are not standardized well enough across architectures to make that possible. This did not help as much as I expected, but it is definitely better. It shaves maybe 1-2% off all.bash depending on how much you trust the timings of a single run: Before: 241.139r 362.702u 112.967s After: 234.339r 359.623u 111.045s R=golang-codereviews, gobot, r, iant CC=golang-codereviews https://golang.org/cl/44650043
-
Rob Pike authored
Expand the type's doc comment to make its purpose clear and discourage misuse. R=golang-codereviews, gobot, rsc CC=golang-codereviews https://golang.org/cl/44680043
-
Brad Fitzpatrick authored
Generated by addca. R=gobot CC=golang-codereviews https://golang.org/cl/44690043
-