- 14 Mar, 2013 2 commits
-
-
Russ Cox authored
An earlier CL disallowed ~ anywhere in GOPATH, to avoid problems with GOPATH='~/home' instead of GOPATH=~/home. But ~ is only special in the shell at the beginning of each of the paths in the list, and some paths do have ~ in the middle. So relax the requirement slightly. Fixes #4140. R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/7799045
-
Olivier Saingre authored
Fixes #4235. R=rsc, dave, r, dr.volker.dobler CC=golang-dev https://golang.org/cl/7438051
-
- 13 Mar, 2013 14 commits
-
-
Russ Cox authored
The new build tag "go1.1" will be satisfied by any Go 1.z release >= 1.1. In general, the build tag "go1.x" will be satisfied by any Go 1.z release >= 1.x. What happens when we reach Go 2 is yet to be decided. The tags "go1" or "go1.0" are missing, because +build tags did not exist before then, and also because the Go 1.0 releases do not recognize them. The new -installsuffix flag gives access to the build context's InstallSuffix (formerly named InstallTag, but not part of Go 1.0), for use in isolating builds to custom directories. For example -race implies -installsuffix race, and an AppEngine-specific build might use -tags appengine -installsuffix appengine. Fixes #4116. Fixes #4443. R=golang-dev, bradfitz, r CC=golang-dev https://golang.org/cl/7794043
-
Russ Cox authored
Eliminate false positives when you can tell even without type information that the literal does not need field tags. Far too noisy otherwise. R=golang-dev, r CC=golang-dev https://golang.org/cl/7797043
-
Rob Pike authored
Point the user to "go tool pprof" and mention some important flags. Fixes #4990. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/7657045
-
Dave Cheney authored
valgrind complained that under some circumstances, *nr = *nc was being called when nr and nc were the same *Node. The suggestion my Rémy was to introduce a tmp node to avoid the potential for aliasing in subnode. R=remyoudompheng, minux.ma, rsc CC=golang-dev https://golang.org/cl/7780044
-
Russ Cox authored
All the headings are CAPS not Title. Fixes #4843. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/7792043
-
Rick Arnold authored
If a fixed size array is passed in as the decode target and the JSON to decode has extra array elements that are objects, then previously the decoder would return a "data changing underfoot" error. Fixes #3717. R=golang-dev, adg, rsc CC=golang-dev https://golang.org/cl/7490046
-
Tyler Bunnell authored
Fixes #3838. R=dave, mikioh.mikioh, rsc CC=golang-dev https://golang.org/cl/7511043
-
Russ Cox authored
Also change prefix generation to use more human-friendly prefixes. Fixes #5040. R=golang-dev, r, bradfitz CC=golang-dev https://golang.org/cl/7777047
-
Jeff R. Allen authored
Just use "go tool addr2line" no matter what, since we know it works for all OSs. Fixes #4818. R=rsc, r CC=golang-dev https://golang.org/cl/7526047
-
Jeff R. Allen authored
Fixes #4972. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/7649044
-
Brad Fitzpatrick authored
Don't call unix-only function in test init. R=golang-dev, alex.brainman CC=golang-dev https://golang.org/cl/7778043
-
Dominik Honnef authored
Correctly indent the body of functions that have been declared over multiple lines. See http://play.golang.org/p/MHMwNDbFyf for an example. Previously, the body of the function would be indented as deep as the continuation line of the function declaration. Now it gets indented as deep as the func keyword. R=adonovan, cw, patrick.allen.higgins CC=golang-dev https://golang.org/cl/7628043
-
Mike Rosset authored
R=golang-dev, r, iant, iant CC=golang-dev https://golang.org/cl/6454072
-
Mikio Hara authored
On BSD variants, the tests need surely constructed IPv6 routing table. R=golang-dev, dave CC=golang-dev https://golang.org/cl/7776043
-
- 12 Mar, 2013 24 commits
-
-
Rob Pike authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/7480047
-
Brad Fitzpatrick authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/7529048
-
Nigel Tao authored
Fixes #4705. Note that libjpeg will print a warning to stderr if there are many extraneous bytes, but can be silent if the extraneous bytes can fit into its int32 bit-buffer for Huffman decoding. I'm guessing that this is why whatever encoder that produced the image filed for issue 4705 did not realize that they are, strictly speaking, generating an invalid JPEG. That issue's attached image has two extraneous bytes. For example, piping the program below into libjpeg's djpeg program will print an "18 extraneous bytes" warning, even though N == 20. $ cat main.go package main import ( "bytes" "image" "image/color" "image/jpeg" "os" ) const N = 20 func main() { // Encode a 1x1 red image. m := image.NewRGBA(image.Rect(0, 0, 1, 1)) m.Set(0, 0, color.RGBA{255, 0, 0, 255}) buf := new(bytes.Buffer) jpeg.Encode(buf, m, nil) b := buf.Bytes() // Strip the final "\xff\xd9" EOI marker. b = b[:len(b)-2] // Append N dummy 0x80 bytes to the SOS data. for i := 0; i < N; i++ { b = append(b, 0x80) } // Put back the "\xff\xd9" EOI marker. b = append(b, 0xff, 0xd9) os.Stdout.Write(b) } $ go run main.go | djpeg /dev/stdin > /tmp/foo.pnm Corrupt JPEG data: 18 extraneous bytes before marker 0xd9 The resultant /tmp/foo.pnm is a perfectly good 1x1 red image. R=r CC=golang-dev https://golang.org/cl/7750043
-
Mikio Hara authored
R=golang-dev, bradfitz, dave, rsc CC=golang-dev https://golang.org/cl/7547044
-
Akshat Kumar authored
With the global redefinition of runtime·open by CL 7543043, we need to provide a third argument and remove the cast to the string. Fixes build on 386 version of Plan 9. R=khr, rsc, rminnich, ality CC=golang-dev https://golang.org/cl/7644047
-
Akshat Kumar authored
Needed by TestResolveIPAddr. This makes us pass tests again. R=rsc, rminnich, ality, bradfitz CC=golang-dev https://golang.org/cl/7737043
-
Russ Cox authored
Many thanks to Elias Naur for finding this with Valgrind on Linux. Perhaps this is what is breaking the windows/amd64 builder. R=golang-dev, r CC=golang-dev https://golang.org/cl/7595044
-
Rob Pike authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/7663045
-
Robert Figueiredo authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/6727046
-
Benny Siegert authored
R=golang-dev, dave, iant CC=golang-dev https://golang.org/cl/7765043
-
Rob Pike authored
The old description was misleading and inaccurate. Fixes #4774. R=iant, rsc, gri CC=golang-dev https://golang.org/cl/7761044
-
Jan Ziak authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/7762046
-
Rob Pike authored
See also https://golang.org/cl/7656044 R=golang-dev, gri, rsc CC=golang-dev https://golang.org/cl/7625048
-
Russ Cox authored
Fixes #5033. R=golang-dev, r CC=golang-dev https://golang.org/cl/7764044
-
Robert Griesemer authored
The parameter list layout function was incorrectly computing the end of the previous line in cases where a parameter type spanned multiple lines. As a result, an extra (valid, but not needed) comma was introduced before the paremeter list's closing parenthesis. Fixes #4533. R=rsc CC=golang-dev https://golang.org/cl/7674044
-
Robert Griesemer authored
This was a bug that didn't manifest itself before CL 7674044; but with that CL and without this fix, the go/doc tests fail. (The bug fixed by 7674044 and the bug fixed here cancelled each other out w/ respect to the go/doc tests). R=rsc CC=golang-dev https://golang.org/cl/7628045
-
Dmitriy Vyukov authored
Introduce pollDesc struct, to split netFD struct into fd-related and poller-related parts. R=golang-dev, bradfitz, iant CC=golang-dev https://golang.org/cl/7762044
-
Shenghou Ma authored
Fixes #5035. R=golang-dev, r CC=golang-dev https://golang.org/cl/7519045
-
Keith Randall authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/7593045
-
Rob Pike authored
It didn't work properly according to the Go memory model. Fixes #5023. R=golang-dev, dvyukov, adg CC=golang-dev https://golang.org/cl/7698045
-
Keith Randall authored
Uses AES hardware instructions on 386/amd64 to implement a fast hash function. Incorporates a random key to thwart hash collision DOS attacks. Depends on CL#7548043 for new assembly instructions. Update #3885 Helps some by making hashing faster. Go time drops from 0.65s to 0.51s. R=rsc, r, bradfitz, remyoudompheng, khr, dsymonds, minux.ma, elias.naur CC=golang-dev https://golang.org/cl/7543043
-
Dmitriy Vyukov authored
R=golang-dev CC=golang-dev https://golang.org/cl/7760043
-
Dmitriy Vyukov authored
This is a part of the bigger change that moves network poller into runtime: https://golang.org/cl/7326051/ R=golang-dev, bradfitz, mikioh.mikioh, rsc CC=golang-dev https://golang.org/cl/7448048
-
Russ Cox authored
If two fields have the same name but different explicit name spaces, treat as non-conflicting. This allows parsing common XML formats that have ns1:tag and ns2:tag in the same XML element. Fixes #4691. Allow setting the default name space for unadorned tags, by writing to Decoder.DefaultSpace. This allows turned the job of parsing common XML formats that have tag and ns2:tag in the same XML element into the first case by setting DefaultSpace="ns1". Fixes #3703. Use name space attributes when decoding. Attach name space to attributes when encoding. Could be done with fewer annotations, but semantically correct as is. Fixes #3526. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/7227056
-