• Keith Randall's avatar
    cmd/compile: don't combine load+op if the op has SymAddr arguments · 05bbec73
    Keith Randall authored
    By combining the load+op, we may force the op to happen earlier in
    the store chain. That might force the SymAddr operation earlier, and
    in particular earlier than its corresponding VarDef. That leads to
    an invalid schedule, so avoid that.
    
    This is kind of a hack to work around the issue presented. I think
    the underlying problem, that LEAQ is not directly ordered with respect
    to its vardef, is the real problem. The benefit of this CL is that
    it fixes the immediate issue, is small, and obviously won't break
    anything. A real fix for this issue is much more invasive.
    
    The go binary is unchanged in size.
    This situation just doesn't occur very often.
    
    Fixes #28445
    
    Change-Id: I13a765e13f075d5b6808a355ef3c43cdd7cd47b6
    Reviewed-on: https://go-review.googlesource.com/c/153641
    Run-TryBot: Keith Randall <khr@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarCherry Zhang <cherryyz@google.com>
    05bbec73
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testdata Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...