• Alberto Donizetti's avatar
    cmd/compile: fix OTYPESW Op comment · 07f7db3e
    Alberto Donizetti authored
    OTYPESW Op comment says
    
      // List = Left.(type)
    
    this seems to be wrong. Adding
    
      fmt.Printf("n: %v\n", cond)
      fmt.Printf("  n.List: %v\n", cond.List)
      fmt.Printf("  n.Left: %v\n", cond.Left)
      fmt.Printf("  n.Right: %v\n", cond.Right)
    
    to (s *typeSwitch) walk(sw *Node), and compiling the following code
    snippet
    
      var y interface{}
      switch x := y.(type) {
      default:
        println(x)
      }
    
    prints
    
      n: <node TYPESW>
        n.List:
        n.Left: x
        n.Right: y
    
    The correct OTYPESW Node field positions are
    
      // Left = Right.(type)
    
    This is confirmed by the fact that, further in the code,
    typeSwitch.walk() checks that Right (and not Left) is of type
    interface:
    
      cond.Right = walkexpr(cond.Right, &sw.Ninit)
      if !cond.Right.Type.IsInterface() {
        yyerror("type switch must be on an interface")
        return
      }
    
    This patch fixes the OTYPESW comment.
    
    Change-Id: Ief1e409cfabb7640d7f7b0d4faabbcffaf605450
    Reviewed-on: https://go-review.googlesource.com/69112Reviewed-by: 's avatarMatthew Dempsky <mdempsky@google.com>
    07f7db3e
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...