• Russ Cox's avatar
    cmd/vet: report uncalled functions in Printf %v · 0f89efa2
    Russ Cox authored
    Given, say, var f *os.File, a new vet check in CL 14122 diagnoses:
    
    	fmt.Printf("%s\n", f.Name)
    	fmt.Println(f.Name)
    
    but not
    
    	fmt.Printf("%v\n", f.Name)
    
    In all three cases the error is that the argument should be f.Name().
    
    Diagnosing Println but not Printf %v seems oddly inconsistent,
    so I changed %v to have the check too. In fact, all verbs now have
    the check except %p and %T.
    
    Fixes Dave Cheney's confusion when trying to write an example
    of the new vet check advertised in the Go 1.6 release notes.
    
    Change-Id: I92fa6a7a1d5d9339a6a59ae4e587a254e633f500
    Reviewed-on: https://go-review.googlesource.com/19101
    Run-TryBot: Russ Cox <rsc@golang.org>
    Reviewed-by: 's avatarRob Pike <r@golang.org>
    0f89efa2
Name
Last commit
Last update
..
internal/whitelist Loading commit data...
testdata Loading commit data...
asmdecl.go Loading commit data...
assign.go Loading commit data...
atomic.go Loading commit data...
bool.go Loading commit data...
buildtag.go Loading commit data...
cgo.go Loading commit data...
composite.go Loading commit data...
copylock.go Loading commit data...
deadcode.go Loading commit data...
doc.go Loading commit data...
example.go Loading commit data...
main.go Loading commit data...
method.go Loading commit data...
nilfunc.go Loading commit data...
print.go Loading commit data...
rangeloop.go Loading commit data...
shadow.go Loading commit data...
shift.go Loading commit data...
structtag.go Loading commit data...
types.go Loading commit data...
unsafeptr.go Loading commit data...
unused.go Loading commit data...
vet_test.go Loading commit data...