• Matthew Dempsky's avatar
    cmd/compile: allocate Nodes together with Name/Param/Func · 166b1219
    Matthew Dempsky authored
    After allocating a Node that needs a Name, Param, and/or Func field,
    we never clear that field, so we can reduce GC overhead slightly by
    allocating them together with the owner Node.
    
    name       old time/op     new time/op     delta
    Template       325ms ± 7%      325ms ± 7%    ~           (p=0.910 n=29+30)
    Unicode        177ms ±12%      173ms ±11%    ~           (p=0.110 n=29+30)
    GoTypes        1.06s ± 7%      1.05s ± 5%  -1.22%        (p=0.027 n=30+30)
    Compiler       4.48s ± 3%      4.47s ± 3%    ~           (p=0.423 n=30+30)
    
    name       old user-ns/op  new user-ns/op  delta
    Template        476M ±22%       467M ±14%    ~           (p=0.310 n=29+30)
    Unicode         298M ±22%       294M ±25%    ~           (p=0.335 n=30+30)
    GoTypes        1.54G ± 9%      1.48G ± 9%  -4.06%        (p=0.000 n=30+30)
    Compiler       6.26G ± 6%      6.14G ± 6%  -1.90%        (p=0.004 n=30+30)
    
    name       old alloc/op    new alloc/op    delta
    Template      40.9MB ± 0%     41.1MB ± 0%  +0.53%        (p=0.000 n=30+30)
    Unicode       30.9MB ± 0%     31.0MB ± 0%  +0.16%        (p=0.000 n=30+30)
    GoTypes        122MB ± 0%      123MB ± 0%  +0.37%        (p=0.000 n=30+30)
    Compiler       477MB ± 0%      479MB ± 0%  +0.37%        (p=0.000 n=30+29)
    
    name       old allocs/op   new allocs/op   delta
    Template        400k ± 1%       376k ± 1%  -5.96%        (p=0.000 n=30+30)
    Unicode         330k ± 1%       325k ± 1%  -1.48%        (p=0.000 n=30+30)
    GoTypes        1.22M ± 0%      1.16M ± 0%  -4.38%        (p=0.000 n=30+30)
    Compiler       4.35M ± 0%      4.13M ± 0%  -5.08%        (p=0.000 n=30+29)
    
    Change-Id: I9bdc7d9223bb32f785df71810564e82d9a76d109
    Reviewed-on: https://go-review.googlesource.com/36022Reviewed-by: 's avatarRobert Griesemer <gri@golang.org>
    Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
    166b1219
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...