• David Chase's avatar
    cmd/compile: change phi location to be optimistic at backedges · 846bc6c5
    David Chase authored
    This is:
    
    (1) a simple trick that cuts the number of phi-nodes
    (temporarily) inserted into the ssa representation by a factor
    of 10, and can cut the user time to compile tricky inputs like
    gogo/protobuf tests from 13 user minutes to 9.5, and memory
    allocation from 3.4GB to 2.4GB.
    
    (2) a fix to sparse lookup, that does not rely on
    an assumption proven false by at least one pathological
    input "etldlen".
    
    These two changes fix unrelated compiler performance bugs,
    both necessary to obtain good performance compiling etldlen.
    Without them it takes 20 minutes or longer, with them it
    completes in 2 minutes, without a gigantic memory footprint.
    
    Updates #16407
    
    Change-Id: Iaa8aaa8c706858b3d49de1c4865a7fd79e6f4ff7
    Reviewed-on: https://go-review.googlesource.com/23136Reviewed-by: 's avatarKeith Randall <khr@golang.org>
    Run-TryBot: David Chase <drchase@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    846bc6c5
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x/net Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...