• Austin Clements's avatar
    cmd/link: fix confusing error on unresolved symbol · 66065c31
    Austin Clements authored
    Currently, if an assembly file includes a static reference to an
    undefined symbol, and another package also has an undefined reference
    to that symbol, the linker can report an error like:
    
      x: relocation target zero not defined for ABI0 (but is defined for ABI0)
    
    Since the symbol is referenced in another package, the code in
    ErrorUnresolved that looks for alternative ABI symbols finds that
    symbol in the symbol table, but doesn't check that it's actually
    defined, which is where the "but is defined for ABI0" comes from. The
    "not defined for ABI0" is because ErrorUnresolved failed to turn the
    static symbol's version back into an ABI, and it happened to print the
    zero value for an ABI.
    
    This CL fixes both of these problems. It explicitly maps the
    relocation version back to an ABI and detects if it can't be mapped
    back (e.g., because it's a static reference). Then, if it finds a
    symbol with a different ABI in the symbol table, it checks to make
    sure it's a definition, and not simply an unresolved reference.
    
    Fixes #29852.
    
    Change-Id: Ice45cc41c1907919ce5750f74588e8047eaa888c
    Reviewed-on: https://go-review.googlesource.com/c/159518
    Run-TryBot: Austin Clements <austin@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
    66065c31
Name
Last commit
Last update
..
internal Loading commit data...
doc.go Loading commit data...
dwarf_test.go Loading commit data...
link_test.go Loading commit data...
linkbig_test.go Loading commit data...
main.go Loading commit data...